Back to Home / #openttd / 2018 / 01 / Prev Day | Next Day
#openttd IRC Logs for 2018-01-25

---Logopened Thu Jan 25 00:00:03 2018
01:19-!-Thedarkb [] has quit [Ping timeout: 480 seconds]
01:28-!-sim-al2 is now known as Guest2663
01:28-!-sim-al2 [] has joined #openttd
01:28-!-sim-al2 is "sim-al2" on #openttd @#/r/openttd
01:32-!-Guest2663 [] has quit [Ping timeout: 480 seconds]
01:46-!-Thedarkb [] has joined #openttd
01:46-!-Thedarkb is "realname" on #oolite #openttd #/r/openttd
01:48-!-sla_ro|master [] has joined #openttd
01:48-!-sla_ro|master is "slamaster" on @#sla #openttd #love
01:53-!-Breckett [~DDD@] has joined #openttd
01:53-!-Breckett is "Breckett" on #openttd
02:18-!-Biolunar [] has joined #openttd
02:18-!-Biolunar is "Biolunar" on #openttd #suckless
02:21-!-sla_ro|master [] has quit []
02:33-!-sim-al2 [] has quit [Ping timeout: 480 seconds]
03:29-!-Supercheese [] has quit [Read error: Connection reset by peer]
03:33-!-Supercheese [] has joined #openttd
03:33-!-Supercheese is "Supercheese" on #openttd
03:38<debdog>is there a way to view game settings for the scenario used in OpenTTD's splash screens? in this case the physics settings of the 1.7.x versions
03:38<debdog>or, ideally, a .sav file of that scenario.
03:39<LordAro>debdog: openttd.dat(?) is just a renamed .sav file
03:40<LordAro>rename it, open it, look at it
03:42<debdog>ahh, neat
03:44<debdog>hum where would I find this file on linux?
03:44<debdog>find /usr -iname openttd.dat returned nothing
03:45<debdog>some for ~/.openttd
03:46<debdog>no hit either:
03:46<LordAro>that is a good question
03:48<debdog>mayhap the fille's name changed over time
03:48<LordAro>nah, openttd hasn't changed significantly in years :p
03:49<LordAro>ah, opntitle.dat
03:49<LordAro>my bad, misremembered
03:51<debdog>cool, that worked. thanks!
03:55-!-Breckett [~DDD@] has quit [Quit: Verlassend]
03:55-!-Breckett [~DDD@] has joined #openttd
03:55-!-Breckett is "Breckett" on #openttd
04:14-!-rellig [] has joined #openttd
04:14-!-rellig is "rellig" on #openttd
04:40-!-Biolunar [] has quit [Ping timeout: 480 seconds]
04:53-!-FLHerne [] has joined #openttd
04:53-!-FLHerne is "Francis Herne" on #openttd
05:07-!-tokai|noir [] has joined #openttd
05:07-!-tokai|noir is "Christian Rosentreter" on #openttd
05:07-!-mode/#openttd [+v tokai|noir] by ChanServ
05:13<Cadmus>Hello, I've started a server for some friends, but haven't played in a very long time. Could someone recommend some GRFs for road, rail, and sea that go to the near future? AV8 (or its successor) already has me covered for air.
05:14-!-tokai [] has quit [Ping timeout: 480 seconds]
05:16-!-Samu [] has joined #openttd
05:16-!-Samu is "OFTC WebIRC Client" on #openttd
05:16-!-john-aj [] has joined #openttd
05:16-!-john-aj is "John" on #openttd
05:19<Alkel_U3>I'd still recommend eGRVTS for road. SQUID for waterways and either Pineapple / Iron horse for rail if you want something "like original but different/better" or NUTS if you want... to go nuts with it :-)
05:21-!-funnel [] has quit [Ping timeout: 480 seconds]
05:22-!-FLHerne [] has quit [Ping timeout: 480 seconds]
05:24<debdog>haha "Features lickable pixels..."
05:25<debdog>FISH ship set 0.9.2 Description
05:25-!-funnel [] has joined #openttd
05:25-!-funnel is "funnel" on #logcheck #xen #vserver #virt #uml #tor #suckless #smuxi #sd #qemu #pwmt #powerdns #perl #pentadactyl #ovirt #openttd #openbox #oftc #munin #moocows #monkeysphere #mm @#mci #linuxfs #linode #kvm #kernelnewbies #igloo #gcc #gc-linux #freedombox @#exvm #ext4 #dzen #debian #debian-mentors #debian-it #debian-ipv6 #debian-hurd #debian-glibc #debian-boot #debian-arm #davical @#cursive #ck #ceph #bitlbee #awesome #apparmor @#antlr #acal
05:26<debdog>prolly keep some glass cleaner handy
05:27<debdog>*at hand
05:29-!-Supercheese [] has quit [Quit: Valete omnes]
05:34-!-iSoSyS [] has joined #openttd
05:34-!-iSoSyS is "realname" on #/r/openttd #openttd
05:39-!-Breckett [~DDD@] has quit [Ping timeout: 480 seconds]
05:44<Cadmus>Thanks folks. I'll take a look at them, I guess with a lot of these sets you have a much earlier start (1899?), so a longer game even if you stop at 2020 or 2030
05:50-!-Mike [~oftc-webi@] has joined #openttd
05:50-!-Mike is "OFTC WebIRC Client" on #openttd
05:51<Cadmus>I thought SQUID supersed FISH now?
05:51-!-Mike [~oftc-webi@] has quit []
05:51<Samu>i fail at understanding what a repository is for
05:52-!-Flygon_ [] has joined #openttd
05:52-!-Flygon_ is "Flygon" on #openttd
05:52<LordAro>Samu: so you get how all the "commits" that are stored on the svn server? with hg/git (and other "distributed" version control systems (DVCS)), this copy of the commits is stored on your computer, as opposed to just a central server
05:53<LordAro>this allows you to make a separate set of commits/changes
05:53<LordAro>which i think was your original goal
05:55-!-Flygon [] has quit [Ping timeout: 480 seconds]
05:57<Samu>what i'm trying to do is, create multiple patches in a sequence. First patch is against last trunk revision, currently r27967
05:57<Samu>Second patch is against my own patch
05:57<Samu>but i only able to patch against r27967
05:58<LordAro>with svn, yes
05:58-!-crem2 [~crem@2a02:168:520c:0:201:c0ff:fe08:8328] has joined #openttd
05:58-!-crem2 is "crem" on #openttd
05:58<LordAro>but with hg, you can create your own commit "r27968" (hg doesn't use revision numbers, but it's effectively the same thing)
05:58<LordAro>and then apply another commit to that
06:00-!-crem1 [~crem@2a02:168:520c:0:201:c0ff:fe08:8328] has quit [Ping timeout: 480 seconds]
06:00<Samu>kdiff3 looks so ugly in comparison with tortoise diff
06:01<Samu>what happens when the real central openttd updates to r27968? how am i update my own stuff to the new revision?
06:06<LordAro>that's where it gets a bit tricky
06:06<LordAro>but let's cross that bridge when we get to it :)
06:11<Samu>Commit failed (details follow): Authorization failed
06:11<Samu>i fail
06:11-!-FLHerne [] has joined #openttd
06:11-!-FLHerne is "Francis Herne" on #openttd
06:12<Samu>commit to: svn://
06:12<Samu>hmm this is not where I want to send my commits, or is it?
06:16<LordAro>not that it'll work either way
06:16<LordAro>but you don't want to send your commits anywhere
06:18<LordAro>as in, don't "push"
06:23<Samu>this is my repository, it's emtpy :(
06:25<Samu>all empty
06:25<Cadmus>SVN *feels nauseous*
06:25<Samu>no idea what I'm doing, really :( t.t
06:28<Samu>"Subversion Repository" is what it says here
06:28<Samu>wasn't is supposed to be mercurial?
06:30<Samu>so confusing, it's "importing" to something that is local
06:39<LordAro>i'm not sure why you're doing any importing
06:59-!-Breckett [~DDD@pool8021x160-112.RZ.HS-Augsburg.DE] has joined #openttd
06:59-!-Breckett is "Breckett" on #openttd
07:05-!-Breckett [~DDD@pool8021x160-112.RZ.HS-Augsburg.DE] has quit [Quit: Verlassend]
07:07<Samu>Commit failed (details follow): Authorization failed
07:07<Samu>i fail... i fail... i fail!
07:07<Samu>kill me!
07:09<Samu>when i press OK, i get commit failed
07:09<Samu>what am i doing wrong :|
07:15<LordAro>Samu: ...that is svn
07:15<LordAro>you can't commit with svn
07:15<Samu>if i can't use svn, then how am I gonna create patches
07:16<Samu>can i create patches with hg?
07:17<LordAro>it's an alternative, not in addition to
07:17<Samu>kdiff3 is an ugly mofo, btw :(
07:17<Samu>that's what's included with hg
07:17<LordAro>it's a diffing tool
07:17<LordAro>what does it matter?
07:18<Samu>doesn't seem to let me edit
07:18<Samu>but ok, i will retry with hg
07:18<Samu>nevermind, i can't use the apply patch approach
07:19<Samu>seems i gotta manually move 'aircraft_cmd.cpp' into the folder
07:21<LordAro>well, it'll work
07:21<Samu>sorry, i'll be lack later, when i'm more calm
07:22-!-Samu [] has quit [Remote host closed the connection]
07:43-!-Gustavo6046 [] has joined #openttd
07:43-!-Gustavo6046 is "If you look at real names all day, your life sucks" on #openttd
08:07-!-Gja [] has joined #openttd
08:07-!-Gja is "Martin" on #ceph #bcache #openttd
08:13-!-Samu [] has joined #openttd
08:13-!-Samu is "OFTC WebIRC Client" on #openttd
08:16-!-iSoSyS [] has quit [Ping timeout: 480 seconds]
08:37-!-Gustavo6046 [] has quit [Ping timeout: 480 seconds]
08:37-!-Gustavo6046 [] has joined #openttd
08:37-!-Gustavo6046 is "If you look at real names all day, your life sucks" on #openttd
08:37<Samu>question, is it ok to ignore the .hgignore file?
08:38<LordAro>for what you're doing, yes
08:39<LordAro>(.hgignore is how the repo knows which files in the directories to not add to the repo)
08:39<LordAro>(svn does it with file metadata instead)
08:40<Samu>i've added a directory to the ignorelist, but then that made .hgignore to be modified
08:41<Samu>ignoring the ignore sounds ... weird
08:41<LordAro>oh, i see
08:41<LordAro>which directory did you add?
08:41<Samu>projects - Cópia
08:41<Samu>a copy of projects, so i can open it on visual studio freely
08:42<Samu>without bothering with changes in the real projects folder
08:42<LordAro>oh, and that's inside your ottd checkout?
08:42<john-aj>well, .hgignore is the file that holds the ignorelist, unless i misunderstand? so it should be modified
08:42-!-sim-al2 [] has joined #openttd
08:42-!-sim-al2 is "sim-al2" on #openttd @#/r/openttd
08:42<LordAro>i'd probably want to move it outside the ottd checkout
08:42<LordAro>you shouldn't add IDE/editor related files to ignorelists
08:43<LordAro>they should be added to global/user specific ignore files
08:43<Samu>okay.. wondering how i'm doing that without visual studio complaining
08:45<Samu>global/user specific ignore files... hmmm ahem.. where is that
08:52-!-iSoSyS [] has joined #openttd
08:52-!-iSoSyS is "realname" on #openttd #/r/openttd
08:55<Samu>oh wow, visual studio did not complain
08:55<Samu>it only closed all my open tabs, but that's not much of a problem
08:56<Samu>i wonder where it's dumping all those obs files now
08:56<Samu>nevermind, it cannot build :)
08:57<Samu>cannot open source file because... FU
08:57-!-Flygon_ [] has quit [Remote host closed the connection]
08:57<Samu>so, let me see that username thing
09:00<Samu>rebuilding solution, let's see if it can still do it
09:06<Samu>Rebuild All succeeded
09:18<supermop_work>good morniing
09:35-!-Breckett [~DDD@pool8021x160-112.RZ.HS-Augsburg.DE] has joined #openttd
09:35-!-Breckett is "Breckett" on #openttd
09:46-!-sim-al2 [] has quit [Ping timeout: 480 seconds]
09:50-!-Mavy [] has quit [Remote host closed the connection]
10:12<Samu>i can't work this out LordAro :(
10:13<LordAro>anything in particular, or just generally?
10:13<LordAro>i can't really help you in the general case
10:13<LordAro>you need to learn what you're doing for yourself
10:13<Samu>i have this patch here
10:14<Samu>apparently i need to split it into 3 commits or so I think
10:15<Samu>this would be the first commit
10:16<Samu>in essence, it changes nothing, but it prepares the code for what's to come
10:16<LordAro>i'd question whether such a change should be split further, but do go on
10:17<Samu>the 2nd would be this, but i can't manage to create a patch for it
10:17<Samu>i get rejected hunks
10:18<Samu>only 1 hunk rejected, which is exactly what I want to patch
10:19<LordAro>well, that'd be because it's not a patch file :p
10:19<LordAro>can you create an hg commit with that first patch, on top of a "clean" trunk repo?
10:19<Samu>yes, I mean, i think I did that
10:20<Samu>yup, it commited on its own, but yes, it did ithat
10:20<LordAro>excellent :)
10:20<LordAro>now, you can make the second modification
10:20<LordAro>it'll be easier for you to do this manually, since your patch isn't valid
10:21<Samu>hold on, let me show u
10:22<LordAro>aye, that looks like commit 1 ( you can see the Rev value on the left)
10:22<Samu>manually, that means type it in visual studio?
10:22<LordAro>(it's offset from the svn revision number in the commit message for svn related shenanigans)
10:22<LordAro>Samu: yeah
10:29<Samu>ok, visual studio built it
10:29<Samu>on workbench hg
10:29<Samu>i do commit ?
10:30<Samu>uhm,, no,
10:30<Samu>diff to parent?
10:32-!-sla_ro|master [] has joined #openttd
10:32-!-sla_ro|master is "slamaster" on @#sla #openttd #love
10:33<Samu>ah, i got something
10:34<Samu>that 3rd part shouldn' be there, but at least the first part isn't rejected anymore
10:35<Samu>however, i got this in clipboard, not a patch file, doesn't it create patch files on its own?
10:36<Samu>this feels so archaic, not intuitive at all
10:41<Samu>KDiff3 - i fail to understand this program. It points out the differences between two files, but then doesn't let me save... what's wrong
10:42<LordAro>it's different, not necessarily unintuitive
10:43<LordAro>you should be able to commit again
10:43<LordAro>once you've made the 2nd change
10:49<Samu>ok i edited out the 3rd change from within visual studio, only kept the 2nd change, i clicked commit on workbench hg
10:49<Samu>it forced me to enter a commit message
10:50<Samu>i get that diff at the bottom right, but I don't have a patch file of it :( it's just there in this workbench
10:51<LordAro>i don't know tortoisehg, but there will be a way to pull a patch file out of it
10:52<LordAro>have an explore, or a google
10:52<LordAro>and yes, commits usually need commit messages
10:52<LordAro>if you look, your first patch has the commit message "Index: src/...." - which it took from the top of the svn-style patch
10:54<Samu>when i do Diff to Parent
10:54<Samu>it brings up KDiff3
10:55<Samu>i see the differences side by side
10:55<LordAro>right, there'll likely be some sort of export from there
10:55<Samu>with tortoise i could just save the left part of the right part, or both, or even edit the left part or the right part
10:56<Samu>with kdiff3... i can only look, like it's read only mode... can't save
10:56<Samu>can't edit
10:56-!-Mavy [~Mavy@2a01:4f8:1c0c:414e::1] has joined #openttd
10:56-!-Mavy is "Mavy" on #openttd
10:56<Samu>can't do squat
10:56-!-Mavy [~Mavy@2a01:4f8:1c0c:414e::1] has quit [Remote host closed the connection]
10:56<LordAro>it'll be somewhere
10:56<LordAro>keep looking
10:56-!-Mavy is "Mavy" on #openttd
10:56-!-Mavy [~Mavy@2a01:4f8:1c0c:414e::1] has joined #openttd
10:59<Samu>ah, i have to click "merge"
10:59<Samu>i think
10:59<Samu>let's see what it did
11:01<LordAro>merge? within kdiff3?
11:02<Samu>merge allows me to save, but what it saves is the entire aircraft_cmd.cpp file... not a patch, grrr i fail
11:03-!-Mazur [] has quit [Ping timeout: 480 seconds]
11:03<Samu>"Merge Current File"
11:03<Samu>opens a 3rd panel at the bottom, where I decide which of the sides I want
11:04<Samu>and allows me to save... (the file apparently), not a patch~
11:04<LordAro>ok, i've done some searching
11:04<LordAro>turns out kdiff3 is useless :p
11:05<Samu>very well
11:05<LordAro> 6.1.1
11:07<Samu>let me look
11:07-!-john-aj [] has quit [Quit: john-aj]
11:08<LordAro>Samu: oh hey, this is perfect for you :)
11:08<LordAro>for some reason tortoisehg doesn't come with tortoisemerge, whereas the svn & git variants do
11:10<Samu>oh, nice, nice tortoisemerge was listed
11:10<Samu>along with kdiff3 and other stuff
11:10<Samu>i didn't know this
11:12-!-Mazur [] has joined #openttd
11:12-!-Mazur is "Stefan Linnemann" on #oolite #openttd #openttdcoop.stable #openttdcoop
11:12<Samu>yeah, "create patch file"... exactly what I needed
11:13<Samu>eww, this doesn't look right though
11:14<Samu>does it look right?
11:14<LordAro>doesn't look right, does it?
11:15<LordAro>see if there are some settings
11:16<Samu>Context lines for patches
11:16<Samu>how many lines should go here? 3, 4? moar?
11:17<Samu>gonna try 3
11:18<Samu>better, but still, that header, it's comparing temporary files
11:18<Samu>full pathnames
11:18<Samu>something's not quite right
11:27-!-roidal [] has joined #openttd
11:27-!-roidal is "roland" on #openttd
11:28-!-Breckett [~DDD@pool8021x160-112.RZ.HS-Augsburg.DE] has quit [Ping timeout: 480 seconds]
11:38-!-alluke [] has joined #openttd
11:38-!-alluke is "" on #openttd
11:51-!-Cubey [] has joined #openttd
11:51-!-Cubey is "Jaybar" on #openttd
11:53<Samu>oh, export patch
11:53<Samu>oh wow... it's dumping too much information though
11:54<Samu>it's using my email address, i do not like this
11:56<Samu> halp
11:56<Samu>too much details...
11:59-!-Alberth [] has joined #openttd
11:59-!-Alberth is "purple" on #openttd
11:59-!-mode/#openttd [+o Alberth] by ChanServ
12:04<Samu>LordAro: why does it dump my email and that crap into the patch file?
12:05<Samu>other than that, it's almost there!
12:05<LordAro>because that's how it works
12:05<LordAro>you can remove it if you like
12:05<LordAro>hgrc file
12:08<Samu>my hgrc file looks like that
12:08<LordAro>Samu: well look at it
12:08<LordAro>what do you think you want to change?
12:08<Samu>i don't want my email to be displayed
12:08<Samu>at least that
12:11<Samu>ah, it's on mercurial.ini
12:13<Samu>nope, my email is still displayed
12:13<Samu>to hell with this program
12:14<LordAro>well it's not going to regenerate it
12:14<Samu>but mercurial.ini no longer has my email
12:14<LordAro>it's embedded into the commit
12:14<Samu>oh, is that it?
12:15<Samu>seriously, these kind of programs are spam magnets
12:16<LordAro>get a better email (host) if spam's an issue
12:16<LordAro>these days
12:16<Samu>if i knew i didn't have to provide an email, i wouldn't even type it in
12:17<LordAro>well don't put it anywhere then
12:17<LordAro>modify the patch file before you publish it
12:17<Samu>time to recycle bin
12:17<LordAro>it's just a text file
12:17-!-FLHerne [] has quit [Ping timeout: 480 seconds]
12:17<LordAro>and the commits themselves aren't going to see the light of day
12:22-!-Thedarkb [] has quit [Ping timeout: 480 seconds]
12:25-!-Thedarkb [] has joined #openttd
12:25-!-Thedarkb is "realname" on #oolite #openttd #/r/openttd
12:31<Samu>[tortoisehg] ciexclude = projects - Cópia/*
12:31<Samu>i still see it listed... :( i fail, i don't get it, i hate myself...
12:35<Samu>oh ... oh wow.. list options -> ? uknownk
12:35<Samu>was it that simple? ...
12:35<Samu>i really need to calm down
12:36-!-Breckett [] has joined #openttd
12:36-!-Breckett is "Breckett" on #openttd
12:37<Samu>does this mean i don't need a ciexclude = projects - Cópia/* for anything?
12:38<Samu>yep... it wasn't needed
12:38<Samu>damn thing made me look so stupid
12:41-!-Progman [] has joined #openttd
12:41-!-Progman is "Peter Henschel" on #openttdcoop #openttd
12:41<Samu>You must identify yourself to Mercurial
12:42<@Alberth>of course, how else would you get authorship of a patch
12:42<Samu>why would I want to?
12:43<@Alberth>nobody forces you to use a real email address
12:43<@Alberth>although a random new email address is easily made
12:43<@Alberth>no need to actually read that email either, in general
12:44<Samu>why do these programs force so many pointless steps to work...
12:44<@Alberth>1. enter credentials; 2. work
12:44<@Alberth>how is that many steps?
12:45<@Alberth>but version control in general does require a bit of setup, which you do one time at the start of a project
12:45<@Alberth>takes less than a minute
12:45<@Alberth>gives you years of reliable history
12:46<@Alberth>and undo and co-operation with others
12:46<@Alberth>seems like a fair deal to me
12:51-!-john-aj [] has joined #openttd
12:51-!-john-aj is "John" on #openttd
12:54<Samu>before commit:
12:56<Samu>after commit:
12:56<Samu>program is stupid and makes it look like I'm the stupid
12:57<@Alberth>how is that wrong?
12:58<Samu>it doesn't need my username to create a patch
12:58<@Alberth>ie the output is what I expect, a diff with commit message and the timestamp and author
12:58<Samu>suddenly it needs!
12:58<@Alberth>huh, it always needed it
12:59<@Alberth>I have been using hg for many years, and supplying a name and email address was the first thing I needed to do
13:00-!-glx [] has joined #openttd
13:00-!-glx is "Loïc GUILLOUX" on #openttd
13:00-!-mode/#openttd [+v glx] by ChanServ
13:01<@Alberth>the program is designed to be used in a shared repository, so you can make a program together with others
13:01<@Alberth>then things need to be labeled properly to avoid confusion
13:02<@Alberth>you can also use it all by yourself in a repository that only you can access
13:02<@Alberth>in that case supplying a name and email address is a bit useless
13:03<@Alberth>but you never know if in the future that code might be useful in a project with others
13:08<Samu>my problem is that I'm using it to create patch sequences, patch chains
13:08<Samu>patch queues
13:09<@Alberth>mq ! :)
13:09<Samu>to be able to patch a second time, i need to submit, which then creates an ugly stupid pointless header to the patch file
13:09<Samu>to commit*
13:10-!-Wolf01 [] has joined #openttd
13:10-!-Wolf01 is "Wolf01" on #openttd
13:10<@Alberth>so? let it add headers, they are harmless
13:10<@Alberth>o/ Wolf01
13:11<Wolf01>Yeah soon or later headers will be added anyway (no clue on the current discussion)
13:12<supermop_work>speaking of which, i still need to draw some door header details
13:15<@Alberth>start with the front door?
13:17<supermop_work>that door is actually remaining as is
13:17-!-Biolunar [] has joined #openttd
13:17-!-Biolunar is "Biolunar" on #openttd #suckless
13:21-!-sla_ro|master [] has quit []
13:22-!-andythenorth [~andytheno@] has joined #openttd
13:22-!-andythenorth is "andythenorth" on #openttd
13:22-!-andythenorth [~andytheno@] has left #openttd []
13:23-!-Wormnest [] has joined #openttd
13:23-!-Wormnest is "Wormnest" on #openttd
13:23<Wolf01>Also old as the game XD
13:37-!-HerzogDeXtEr [] has joined #openttd
13:37-!-HerzogDeXtEr is "purple" on #openttd
13:38-!-Thedarkb [] has quit [Remote host closed the connection]
13:42-!-Thedarkb [] has joined #openttd
13:42-!-Thedarkb is "realname" on #/r/openttd #openttd #oolite
13:43-!-smoke_fumus [~smoke_fum@] has joined #openttd
13:43-!-smoke_fumus is "Crapping wizard" on #qemu #oolite #openttd
13:49-!-iSoSySt [] has joined #openttd
13:49-!-iSoSySt is "realname" on #openttd #/r/openttd
13:51-!-frosch123 [] has joined #openttd
13:51-!-frosch123 is "frosch" on #openttdcoop.devzone #openttd
13:55-!-iSoSyS [] has quit [Ping timeout: 480 seconds]
14:03<Samu>Not a head revision! in red
14:03<Samu>should i be scared
14:06-!-andythenorth [] has joined #openttd
14:06-!-andythenorth is "andythenorth" on #openttd
14:06<Samu>question, this one is a bit more complicated
14:06<Samu> how many commits should this be sliced into?
14:08<Samu>in my poor understanding, all of it makes sense together, but when trying to slice it, i can't think of it working without the rest
14:12-!-Breckett [] has quit [Ping timeout: 480 seconds]
14:13<john-aj>Samu: by the way, i'm curious as to what patches are you trying to apply?
14:14<Wolf01>o/, quak
14:14<Samu>i'm slicing my work into small patches
14:14<andythenorth>Wolf01: lo
14:14<Samu>i have the whole thing in 1 single patch :(
14:15<@Alberth>"hangar" sounds like the wrong name for the parameter
14:15<john-aj>ah, it's a patch of your own
14:15<@Alberth>lines 10 to 17 look independent?
14:15<Samu>i posted it here
14:16<@Alberth>cancel order is not remove order, is it?
14:17<Samu>make dummy will cancel the current order if it's heading to hangar (manually sent if I remember)
14:17<john-aj>Samu: nice idea
14:17<Samu>that's code is part of "what to do with aircraft going to an airport i just upgraded"
14:18<Samu>upgrading from a small airport to a heliport while the aircraft is heading to hangar
14:19<Samu>it doesn't remove order
14:19<@Alberth>yeah, so it's different, and can be split
14:20<@Alberth>you try to do a single small thing each commit
14:21<@Alberth>one commit add function, next commit use the new function for its purpose
14:22<LordAro>Alberth: i'd probably argue that adding & using should be one commit
14:23<LordAro>since otherwise you have a commit with dead code
14:24<andythenorth>Wolf01: so what's next?
14:24<@Alberth>fair enough
14:24<Wolf01>Sleep, I think
14:25<andythenorth>ok I refactor some work code :P
14:25<andythenorth>no NRT for me :)
14:26<supermop_work>push the work code to nrt
14:26<Wolf01>Push NRT to the work code
14:27<supermop_work>refactor tanks code
14:27-!-Gustavo6046 [] has quit [Quit: They make sleep time such a rigid and often unexpected for time it is a nuisance! Bah!]
14:30-!-Stimrol [] has joined #openttd
14:30-!-Stimrol is "Stimrol" on #openttd
14:33-!-Breckett [] has joined #openttd
14:33-!-Breckett is "Breckett" on #openttd
14:33-!-Stimrol [] has quit []
14:35-!-iSoSySt [] has quit [Remote host closed the connection]
14:36-!-Gustavo6046 [] has joined #openttd
14:36-!-Gustavo6046 is "If you look at real names all day, your life sucks" on #openttd
14:38-!-Thedarkb [] has quit [Ping timeout: 480 seconds]
14:42-!-Chrill [] has joined #openttd
14:42-!-Chrill is "Christopher" on #openttd #tycoon
14:48-!-Chrill [] has quit []
14:50-!-Stimrol [] has joined #openttd
14:50-!-Stimrol is "Stimrol" on #openttd
14:54<andythenorth>refactor all things
14:57-!-som89 [] has joined #openttd
14:57-!-som89 is "Som" on #openttd #josm #osm-ru #osm
15:02<Eddi|zuHause>refactor 2^77232917-1?
15:06<Eddi|zuHause>"This bug has existed since before curl 6.0. It existed in the first commit we have recorded in the project."
15:09-!-oof [~oftc-webi@2604:2000:414a:a200:3087:cf96:f7ef:5583] has joined #openttd
15:09-!-oof is "OFTC WebIRC Client" on #openttd
15:11<peter1138>Not just us then.
15:15-!-Stimrol [] has quit [Quit: ZNC -]
15:16<Wolf01> that's what you get with "building while paused"
15:17<@Alberth>building with daylength, as it took 9 hours :)
15:17<@Alberth>but still a masterpiece in organizing it
15:18<Wolf01>IIRC they have supercomputers to organize working shifts on subway too
15:26<peter1138>Health and safety would have fun with that.
15:30-!-Stimrol [] has joined #openttd
15:30-!-Stimrol is "Stimrol" on #openttd
15:37-!-Stimrol [] has quit [Quit: ZNC -]
15:38-!-oof [~oftc-webi@2604:2000:414a:a200:3087:cf96:f7ef:5583] has quit [Quit: Page closed]
15:40-!-Stimrol [] has joined #openttd
15:40-!-Stimrol is "Stimrol" on #openttd
15:51-!-Supercheese [~Superchee@] has joined #openttd
15:51-!-Supercheese is "Supercheese" on #openttd
15:55-!-Alberth [] has left #openttd []
15:56-!-roidal [] has quit [Quit: WeeChat 1.9.1]
16:02-!-frosch123 [] has quit [Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn]
16:29-!-Stimrol [] has quit [Quit: ZNC -]
16:32-!-Wolf01 [] has quit [Quit: Once again the world is quick to bury me.]
16:42<Samu>this is seriously scary, if I mess up one commit, I can't undo it
16:43<john-aj>there are ways to undo it
16:43<john-aj>it's fine
16:43<Samu>would have to re-do from scratch
16:43-!-sim-al2 [] has joined #openttd
16:43-!-sim-al2 is "sim-al2" on #openttd @#/r/openttd
16:44<Samu>they're unelegant from what i've seen
16:45<john-aj>surely more elegant than redoing from scratch ;-)
16:48<Samu>ok, i reached another delicate part... helicopter and service at helipad setting mayhem
16:51<Samu>and moving PendingReplace outside of NeedsAutomaticService
16:52<Samu>they're all related to service at helipad
16:52-!-chomwitt [~chomwitt@2a02:587:dc08:a00:c854:3cb6:f417:7dd1] has joined #openttd
16:52-!-chomwitt is "chomwitt" on #debian-mentors #oolite #openttd #qemu #debian #debian-games
16:53-!-FLHerne [] has joined #openttd
16:53-!-FLHerne is "Francis Herne" on #openttd
16:55<Samu>i'm not really sure what needs to be done first
16:56<Samu>the comment in aircraft_cmd.cpp that says - /* Send the helicopter to a hangar if needed for replacement */
16:56<Samu>doesn't work
16:56<Samu>i trashed that code part
16:57<Samu>now there's automatic service at helipad without the need for a replace, and a non-need to automatic service, but a replace is pending
16:57<Samu>what do i need to do first :(
16:58<LordAro>Samu: you can check compiling and what not before commiting
17:01<Samu>there's also the case there's a need for both automatic service and a pending replace
17:01<Samu>the automatic service at helipad is done first before doing the pending replace check
17:02<Samu>i think i'm gonna deal with service at helipad first, pending replace can wait
17:05<Samu>there's also the case of heliport (no hangar) vs any other airport (hangar)
17:06<Samu>everything needs to be connected with need automatic servicing and service at helipad to make sense
17:07<Samu>hmm, ok, i got a vague idea of the order this has to be done
17:18-!-Progman [] has quit [Remote host closed the connection]
17:18-!-sim-al2 is now known as Guest2728
17:18-!-sim-al2 [] has joined #openttd
17:18-!-sim-al2 is "sim-al2" on #openttd @#/r/openttd
17:22-!-Guest2728 [] has quit [Ping timeout: 480 seconds]
17:30-!-andythenorth [] has quit [Quit: andythenorth]
17:36-!-Breckett [] has quit [Quit: Verlassend]
17:36-!-Thedarkb [] has joined #openttd
17:36-!-Thedarkb is "realname" on #oolite #openttd #/r/openttd
17:38-!-john-aj [] has quit [Remote host closed the connection]
17:52-!-Gja [] has quit [Quit: Going offline, see ya! (]
18:01-!-HerzogDeXtEr [] has quit [Read error: Connection reset by peer]
18:16-!-Wormnest [] has quit [Quit: Leaving]
18:23-!-smoke_fumus [~smoke_fum@] has quit [Quit: KVIrc 4.2.0 Equilibrium]
18:26<Samu>another dilema to solve
18:27<Samu> /* check if the aircraft needs to be replaced or renewed and send it to a hangar if needed */
18:27<Samu>this code is removed
18:27<Samu> /* Send the helicopter to a hangar if needed for replacement */
18:27<Samu>along with this
18:28<Samu>now I add code somewhere else that will do what these two were intending to do
18:29<Samu>it deals with airplanes and helicopters, with the exception of heliport (no hangar)
18:29<Samu>heliport... hmm heliport hmm
18:30<Samu>how many commits do I need for this
18:31<Samu>check if the aircraft needs bla bla is removed, helicopter to a hangar is removed. code is added inside aircraft leaving terminal
18:32<Samu>with the exception of heliport
18:32<Samu>bah, i hate commits
18:41<Samu>LordAro: halp me slice this
18:42<Samu>lines 23-27 and 46-52 are replaced with the code at lines 8-15
18:42<Samu>deals with both
18:42<Samu>the exception is the heliport
18:43<Samu>which is what lines 28-38 are for
18:44<Samu>my commenting doesn't make it obvious :(
18:45<LordAro>so, what's the end result of this patch?
18:46<Samu>at lines 8-15 it checks if the aircraft needs servicing and if the current airport the aircraft is at got an hangar, it sends it to hangar
18:46<Samu>it won't check on landing
18:46<Samu>for airplanes
18:47<Samu>and won't check on takeoff for heli
18:47<Samu>the take off part is a bit hard to explain
18:47<Samu>so aircraft reaches a terminal, does the loading/unloading stuff
18:48<ST2>sidenote: a good tool for slicing
18:48<Samu>when he's done, it decides where to go next, i made the checking of servicing right there
18:48<LordAro>i get the bits and pieces, what's the point of the patch
18:49<LordAro>although the removal of the DoCommand is a bit suspicious
18:49<Samu>i removed it because it was cancelling send to hangar automatic services
18:51<Samu>it is more fitting to check for servicing right after the loading/unloading at a terminal, before the aircraft goes to the runway or the helicopter goes into the air
18:52<Samu>the exception to this is the helidepot which has no hangar, so it had to be done at some time after he's in the air
18:52<Samu>and i had to make it deal with serviceathelipad
18:53<Samu>it has just departed from a helipad, which means the automatic servicing interval is reset
18:54<Samu>NeedsAutomaticServicing will fail there
18:54<Samu>if there is an autoreplace set, HasPendingReplace would kick in, and order the helicopter to a hangar
18:55<LordAro>i'm not sure i would split it any further
18:55<LordAro>maybe ask a dev next time they're online what they think
18:55<Samu>there's some other split before this, which is the creation of HasPendingReplace, separate from NeedsServicing
18:56<Samu>let me copy paste brb
18:57<Samu> separation of HasPendingReplace and NeedsServicing
18:57-!-DDR [] has quit [Ping timeout: 480 seconds]
18:58<Samu>it's the only way I could think of to make it work in tandem with serviceathelipad setting
19:01<Samu>and there's yet another lonely change, sec
19:03<Samu>looks minor, but helps a lot with pending replace
19:03<Samu>everything together, makes sense
19:03<Samu>everthing on its own... meh...
19:04-!-Biolunar [] has quit [Ping timeout: 480 seconds]
19:08-!-Flygon [] has joined #openttd
19:08-!-Flygon is "Flygon" on #openttd
19:23<Samu>well, i gotta go, cyas and thx for the help
19:24-!-Samu [] has quit [Quit: Page closed]
19:27-!-FLHerne [] has quit [Ping timeout: 480 seconds]
19:36-!-chomwitt [~chomwitt@2a02:587:dc08:a00:c854:3cb6:f417:7dd1] has quit [Ping timeout: 480 seconds]
20:31-!-Mahjong [~qq@2a00:23c5:6507:1a00:a873:be1:384d:7b9f] has quit [Remote host closed the connection]
20:32-!-Mahjong [~qq@2a00:23c5:6507:1a00:a873:be1:384d:7b9f] has joined #openttd
20:32-!-Mahjong is "realname" on #ohnx #openttd
20:56-!-som89 [] has quit [Ping timeout: 480 seconds]
21:08-!-Gustavo6046 [] has quit [Quit: They make sleep time such a rigid and often unexpected for time it is a nuisance! Bah!]
21:32-!-Supercheese [~Superchee@] has quit [Quit: Valete omnes]
22:30-!-Cubey [] has quit [Ping timeout: 480 seconds]
22:41-!-Chrill [] has joined #openttd
22:41-!-Chrill is "Christopher" on #openttd #tycoon
22:43-!-Chrill [] has quit []
23:03-!-Thedarkb1 [] has joined #openttd
23:03-!-Thedarkb1 is "realname" on #oolite #openttd #/r/openttd
23:07-!-glx [] has quit [Quit: Bye]
23:09-!-Thedarkb [] has quit [Ping timeout: 480 seconds]
---Logclosed Fri Jan 26 00:00:05 2018