Back to Home / #openttd / 2018 / 07 / Prev Day | Next Day
#openttd IRC Logs for 2018-07-19

---Logopened Thu Jul 19 00:00:33 2018
---Daychanged Thu Jul 19 2018
00:00-!-imdak [~sprta@217.16.190.198] has joined #openttd
00:00-!-imdak is "Radek Sprta" on #openttd
00:06-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has quit [Quit: snail_UES_]
01:12-!-nielsm [~nielsm@62-243-118-198-cable.dk.customer.tdc.net] has joined #openttd
01:12-!-nielsm is "Niels Martin Hansen" on #openttd #tycoon
01:56-!-nielsm [~nielsm@62-243-118-198-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
02:23-!-Supercheese [~Superchee@cpe-98-146-230-183.natnow.res.rr.com] has quit [Remote host closed the connection]
02:23-!-Supercheese [~Superchee@cpe-98-146-230-183.natnow.res.rr.com] has joined #openttd
02:23-!-Supercheese is "Supercheese" on #openttd
03:14-!-Mahjong1 [~qq@host5-81-231-202.range5-81.btcentralplus.com] has quit [Ping timeout: 480 seconds]
04:48-!-Supercheese [~Superchee@cpe-98-146-230-183.natnow.res.rr.com] has quit [Quit: Valete omnes]
05:28<TrueBrain>meh; bit stuck ... when I install Debian Stretch on OpenTTD, it simple doesn't want to boot correctly ..
05:28<TrueBrain>ugh
05:32<peter1138>Debian... on OpenTTD...?
05:36<TrueBrain>on the OpenTTD infrastructure
05:38<TrueBrain>tomorrow a call with Google Cloud Platform ... lets hope they can offer something
05:38<TrueBrain>as I simply don't have time anymore to do it myself, all this infrastructure blabla ..
05:41<SpComb>it's fun to write a custom CI/CD system, though? :P
05:41<TrueBrain>meh; I tried really hard to avoid that too
05:41<TrueBrain>but given the constraints ...
05:41<SpComb>what does GCP offer... GCE or even GKE?
05:41<TrueBrain>nothing yet
05:41<TrueBrain>I asked them what they could offer
05:41<TrueBrain>but I want GKE
05:42<SpComb>you'd expect that having kube would make e.g. CI/CD easier to implement
05:42<TrueBrain>as that would mean a lot more people can help out, without understanding most part of it
05:42<TrueBrain>the CI/CD is done up till the part it needs to deploy something to somewhere
05:42<TrueBrain>and yeah, kubernetes would make that near-trivial
05:42<TrueBrain>(as the configuration is already in there)
05:43<TrueBrain>I was looking if I could do it in docker, which means I have to write my own configuration layer ... which really sucks balls
05:43<TrueBrain>setting up your own kubernetes is .. euh ... yeah, lets not go there
05:49<SpComb>my day job is automating kube setup and maintenance :)
05:49<SpComb>https://kontena.io/pharos/ insert employer sponsored open-source content
05:50<TrueBrain>so set it up for OpenTTD already :P
05:50<SpComb>no, we offer the tooling that lets you do it yourself :P
05:50<TrueBrain>I am really annoyed CoreOS is no longer really "stable" .. bit uncertain in which state it is ..
05:50<TrueBrain>I looking into kubespray ... I slowly walked away
05:50<SpComb>pharos would be somewhat similar
05:51<SpComb>what was wrong with kubespray?
05:51<SpComb>but yeah, if you can get free GKE resources from google, then it's certainly a good option
05:51<TrueBrain>the complexity .. and the amount of required maintainance
05:51<TrueBrain>mainly, we would need to set it up on-premise
05:51<TrueBrain>we have a single machine
05:51<SpComb>doable
05:51<TrueBrain>all stuff kinda demands you have at least 3 nodes in kubernetes
05:51<TrueBrain>so ... I have to spin up 3 VMs? And another for ansible?
05:52<TrueBrain>I dont have that memory available
05:52<SpComb>https://pharos.sh/docs/usage/#using-node-taints
05:52<SpComb>you can have a single master host without the NoSchedule taint
05:52<TrueBrain>yeah, I saw you can do that too with kubespray, but than people claim that is not "production ready"
05:53<TrueBrain>and I got just really annoyed of me not having enough domain knowledge :D
05:53<SpComb>dunno why it wouldn't be production-ready assuming you have enough resources to cover the kube overhead, and don't consider the lack of HA to be a problem
05:53<TrueBrain>I guess it is mainly that ... I know shit about this stuff .. and it is a pretty steep learning curve
05:53<TrueBrain>lack of HA is never been an issue :D
05:53<TrueBrain>but okay .. so now I run into the next issue .. that I would need to upgrade the dom0
05:54<SpComb>physical host running some ancient xen?
05:54<TrueBrain>which means renting a second machine, linking them together (with a GRE and some black magic on network level), migrating to one machine, upgrading, migrating back ..
05:54<TrueBrain>it runs XenServer .. upgrading a single-host XenServer is a real pita
05:54<TrueBrain>I regret ever making that choice
05:55<SpComb>I've used ganeti for kvm with drbd and live-migration, but it lacks support for a lot of kvm knobs and it's not really maintained anymore, which is a pity
05:55<TrueBrain>and when you look what it costs to get a kube in cloud and kube on permise ...... cloud is so expensive
05:56<SpComb>does the old version of xen prevent you from running newer domU kernels/distros?
05:56<TrueBrain>so yeah .. what I am trying to create is an infrastructure that is as simple as possible, so more people can support it
05:56<TrueBrain>yeah, latest kernel just flat-out crashes
05:56<TrueBrain>(4.9)
05:56<TrueBrain>"latest"
05:56<TrueBrain>latest Debian Stretch kernel flat-out crashes
05:57<SpComb>is it still some xen-PV mode without any bootloader support?
05:57<TrueBrain>its PV, with pygrub bootloader
05:57<TrueBrain>I can put it in HVM .. but .. I care about my performance
05:57<SpComb>kvm with virtio...
05:58<TrueBrain>the migration is the issue, to any other technoligy
05:58<TrueBrain>so that is why I have the plan to migrate everything inside Dockers
05:58<TrueBrain>which is a lot easier
05:58<SpComb>but yeah, maintaining a single physical machine like that is a challenge once you get to the point where you have to start doing a major upgrade on it... tends to turn into a full rebuild
05:58<TrueBrain>and run Dockers "somewhere"
05:58<TrueBrain>I upgraded the machine twice now .. both times took a month, including planning and execution
05:59<TrueBrain>OVH is a good provider to have in these cases
05:59<TrueBrain>maybe we should rent a second machine, make that a kube-cluster, and move everything in dockers to there or something
05:59<TrueBrain>best thing about Docker, we can just migrate even the shitty-old-stuff we have
06:00<TrueBrain>(some parts still run in Django 1.2)
06:00<SpComb>btw if a single machine is enough, then `kubeadm init` is pretty trivial, all you really need is an appropriate kubeadm yaml
06:00<TrueBrain>people kept telling me I should never do that?
06:00<SpComb>why not?
06:00<TrueBrain>(again, I know very little about kube, so I just go with what people tell me)
06:00<TrueBrain>long long rants
06:01<TrueBrain>something about hard to maintain, no upgrade path, etc
06:01<SpComb>`kubeadm upgrade` has worked fine so far for 1.9 -> 1.10 -> 1.11
06:01<TrueBrain>good to know :)
06:01<SpComb>given, the systemd units changed in 1.11, and there were some things like `kubelet --cluster-dns` that you had to tweakin the 1.10 systemd units, and those tweaks no longer work in 1.11... but they're no longer necessary either
06:02<TrueBrain>hmm .. so I guess I could give that a try ..
06:02<SpComb>okay, and you also need to do a two-step dance where you first download the raw kubeadm binary and use that to run the upgrade before upgrading the kubeadm package, or it breaks
06:03<SpComb>but those are documented clearly enough in https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade-1-11/#upgrade-the-control-plane
06:03<TrueBrain>so ideal I have the kube cluster hosted externally, as that would mean no support from our side ..
06:03<TrueBrain>but for now I can spin one up and see if that works
06:03<TrueBrain>I guess
06:04<TrueBrain>just installing a new debian stretch fails horribly .. hmm ... lets clone an existing :D
06:04<TrueBrain>btw, random question, do you happen to know: can you in a kube cluster have persistant storage?
06:04<TrueBrain>for example, what if I want to run mediawiki in it?
06:05<TrueBrain>(uploads etc ar enot in a database, but on a filesystem)
06:05<SpComb>it took me a couple years, but I finally managed to upgrade our puppet infra from 3.x -> 4.x/5.x this month... means we can finally start migrating from squeeze/wheezy/jessie -> stretch now, because puppet 3.x is no longer available/supported :)
06:06<TrueBrain>ugh, puppet .... I started to really hate puppet :D
06:06<TrueBrain>but gratz :)
06:06<SpComb>there's various approaches to it... trivial approach is to bind the pod to a specific node and use a hostPath volume, of course
06:06<TrueBrain>sneaky :D
06:07<SpComb>after that it starts getting more complicated with persistentVolumes... you can use local storage if you create local persistentVolumes and bind them to specific nodes, but the approches to that which I've seen barely make any sense, it's just more complex than the hostPath approach and I'm not aware of any automagic sync/replication functionality
06:08<SpComb>and then there's all kinds of custom storage providers like OpenEBS, buuuuut I'm not exactly convinced that they would be production-ready yet either
06:08<SpComb>it's a solved problem if you have some external storage like EBS, though
06:08<TrueBrain>do cloud providers solve this?
06:08<SpComb>yeah, then you just use the integrated kube support for those cloud provider volumes
06:09<TrueBrain>more reason to use that :D
06:10<TrueBrain>so you say, just download kubeadm, and run kubeadm init :)
06:10<SpComb>sure, it's the easiest way to get started, and it *does* have an upgrade path
06:11<SpComb>main limitation with kubeadm is that it doesn't really do multi-master/HA at all, at least not yet
06:11<TrueBrain>when we run kube on premise, that is also never going to happen
06:11<TrueBrain>so that is fine
06:11<TrueBrain>first, let me see what happens if I upgrade this clone .. see if it does want to boot ..
06:13<TrueBrain>the page on kubernetes.io that tells how to install kubeadm is a 404 :D
06:13<TrueBrain>lovely
06:14<SpComb>so it is
06:15<TrueBrain>owh right .. and than you get to "picking a network plugin" .. yeah .... eeuuuuhuhhhhh ... *closes eyes*
06:15<TrueBrain>:D
06:15<TrueBrain>you happen to have a suggestion?
06:16<SpComb>you can try https://kontena.io/pharos/#get-started with the download from https://github.com/kontena/pharos-cluster/releases
06:17<TrueBrain>okay, 4.9.0-r6 works, 4.9.0-r7 crashes
06:17<SpComb>but we only support Ubuntu... not Debian
06:17<TrueBrain>revert to snapshot
06:17<TrueBrain>is there really a difference, in terms of support?
06:19<TrueBrain>holy crap at these prices .. people pay that? Big business .... :D
06:20-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
06:20-!-mode/#openttd [+v tokai] by ChanServ
06:20-!-tokai is "Christian Rosentreter" on +#openttd
06:20<SpComb>yes :)
06:20<TrueBrain>kubernetes 1.10? What about 1.11!
06:21<SpComb>https://github.com/kontena/pharos-cluster/pull/473
06:21<SpComb>answer: it's july, everybody except me is on holidays :P
06:21<TrueBrain>:D
06:21<TrueBrain>and it is warmmmmm
06:23<TrueBrain>okay, now first upgrading while holding the kernel back ..
06:23<TrueBrain>SpComb: why do I read a lot that they want kubernetes to run on Docker 17.03? 18.N has been out for months now?
06:25<SpComb>partly political, kube does not use any of the newer Docker features past 1.11 or so, so the newer Docker releases really only bring more bugs
06:25<TrueBrain>lolz
06:25<SpComb>long-term plan is to replace Docker with some other CRI like containerd or cri-o, but it hasn't happened yet
06:26<SpComb>I mean, it's an option, but not the default
06:27-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
06:28<TrueBrain>can a host be: this current host?
06:28<TrueBrain>without ssh :D
06:30<TrueBrain>seems it always goes over ssh
06:30<TrueBrain>pfft
06:31<TrueBrain>awh, it really refuses the host because it is not ubuntu :D
06:32<TrueBrain>Ubuntu is not a server distribution ffs :P
06:32<SpComb>I'd guess that Ubuntu server is more commol than Debian, tbh
06:32<TrueBrain>it still makes me puke everytime I notice that
06:33<TrueBrain>somewhere something went terribly wrong :D
06:34<SpComb>I'm pretty sure that canonical makes more money from Ubuntu server/cloud than desktop
06:35<TrueBrain>hmm .. kubeadm is not in the google repo, what documentation suggests
06:35<TrueBrain>grrrr
06:37<TrueBrain>they too, only added it for Ubuntu
06:37<TrueBrain>lolz
06:38<SpComb>you can probably install the ubuntu dist on debian just fine
06:38<TrueBrain>just did :)
06:38<SpComb>the kube packages only contain a sinhle static binary + systemd units
06:39<TrueBrain>so many preflight errors :D
06:39<TrueBrain>it even refuses newer Dockers
06:39<TrueBrain>lol
06:41-!-RafiX [~rafix@public-gprs352496.centertel.pl] has joined #openttd
06:41-!-RafiX is "rafix" on #C #openttd
06:43<TrueBrain>I love the: swap is not allowed, part
06:46<TrueBrain>well, that seems to run..ish
06:52<TrueBrain>tnx SpComb, kubeadm seems to work .. now I need to figure out how it all works, but I had to do that anyway :D
06:54<SpComb>yeah, and if nothing else a single-node kubeadm setup is a good step towards something like GKE
06:54<TrueBrain>this is a bit weird ... I told it to use 10.100.0.0/16 .. but the sock-shop now has 10.104.N.N
06:54<SpComb>I wouldn't be surprised if GCP were willing to offer the OpenTTD project free GKE
06:55<SpComb>are you sure it osn't 10.100.0.0/12?
06:56<SpComb>the service cidr is also separate
06:56<TrueBrain>I wrote /16 .. but what-ever ... as long as it stays away from the lower-end of that range, we will be fine
06:57<TrueBrain>OpenTTD infra runs very isolated in terms of networks .. so it cannot do much harm
06:57<TrueBrain>and I hope GCP can do something for OpenTTD .. not having to maintain this ... pfftt .. that would be very nice :)
06:57<TrueBrain>and having everything run in pods ..... even nicer
06:57<SpComb>the default service cidr is 10.96.0.0/12 and that covers 10.104.x.x
06:58<TrueBrain>funny .. I really use another address :P Owh well, that range is fine
06:58<TrueBrain>tnx :)
06:58<SpComb>odd if kubeadm allows the two to overlap
06:58<TrueBrain>sock-shop works!
06:58<TrueBrain>and I can even reach it from our web-proxy :P
06:58<SpComb>having the pod cidr within the service cidr sounds like a bad idea
06:59<SpComb>nodePort service?
06:59<TrueBrain>no clue ..
06:59<TrueBrain>I just loaded the sock-shop demo
06:59<TrueBrain>it gave me a service on a port
06:59<TrueBrain>which worked
06:59<TrueBrain>:P
07:00<TrueBrain>so now all I have to find out is how to start my test image
07:00<TrueBrain>and a deployment is than as simple as settng a new image for it
07:00<TrueBrain>images are like: truebrain/testing:sha-of-commit
07:00<TrueBrain>first lunch!
07:01<TrueBrain>tnx a bunch SpComb :)
07:01<SpComb>using nodeport services with an externally configured frontend proxy is probably the common initial setup, but there's also native kube ingress-nginx and letsencrypt stuff
07:01<SpComb>np... where do I have sales send the consulting bill to? :P
07:14<TrueBrain>try /dev/null :D
08:42-!-imdak [~sprta@217.16.190.198] has quit [Remote host closed the connection]
08:48-!-sim-al2 [~sim-al2@c-75-65-196-171.hsd1.tn.comcast.net] has quit [Ping timeout: 480 seconds]
08:56-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has joined #openttd
08:56-!-snail_UES_ is "Jacopo Coletto" on #openttd
09:06-!-Erato [~oftc-webi@541B45BC.cm-5-4b.dynamic.ziggo.nl] has joined #openttd
09:06-!-Erato is "OFTC WebIRC Client" on #openttd
09:06<Erato>o/
09:07<Erato>I had a question about BaNaNaS and was told that the people here could help.
09:08-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has quit [Quit: snail_UES_]
09:09<Erato>I would like to change the name of one of my newgrfs, because I incorrectly entered it and it seems like I can't change it without reuploading under a different GRF-ID.
09:22-!-Wacko1976 [~IceChat9@027-161-128-083.dynamic.caiway.nl] has joined #openttd
09:22-!-Wacko1976 is "The Chat Cool People Use" on #openttd #/r/openttd
09:45<FLHerne>TrueBrain: ^ (?)
09:51<TrueBrain>renaming is a bit of a pita indeed :D
09:55<TrueBrain>Erato: what is the grfid?
09:55<Erato>454E2001
09:55<TrueBrain>it already has 4 versions?
09:56<Erato>yes
09:56<TrueBrain>that makes it even harder :D
09:56<TrueBrain>what would you like changed?
09:56<Erato>"RIMS" should be "Real International Maglev Set"
09:56-!-Mahjong [~qq@2a00:23c5:6507:1a00:4564:7b61:bf2c:f363] has joined #openttd
09:56-!-Mahjong is "realname" on #openttd #ohnx
09:57<TrueBrain>the main issue with renames is that it takes a lot of time and effort
09:57<TrueBrain>the name is part of the filename as it ends up on the mirrors
09:57<TrueBrain>it is also how the files end up at the user on his disk
09:58<TrueBrain>so I am wondering what the easiest approach is .. as renaming 4 versions will take way too much time to make it reasonable
09:58<@planetmaker>dumdidei... it would at worst mean users download it again... but grfid is checked before, IIRC?
09:58<TrueBrain>Erato: do you have a new version ready to upload?
09:58<Erato>I'm going to be updating it relatively soon
09:58<Erato>It's not ready yet, unfortunately
09:59<@planetmaker>couldn't you make an intermediate update to upload today?
09:59-!-nielsm [~nielsm@62-243-118-198-cable.dk.customer.tdc.net] has joined #openttd
09:59-!-nielsm is "Niels Martin Hansen" on #openttd #tycoon
09:59<TrueBrain>planetmaker: I am not sure; last time some custom stuff got a bit confused :D
09:59<TrueBrain>but mostly, it is expensive mirror-wise
10:00<TrueBrain>I have to manually login on them and remove the unwanted files, before they pick up the new name
10:00<TrueBrain>which .. takes a lot of time
10:00<TrueBrain>last we did a rename, we did it in bulk
10:00<TrueBrain>making it somewhat more bareble :)
10:01<TrueBrain>but I cannot remember if we ever did that, and what the after-effects were
10:01<TrueBrain>Toying with a 8 year old system is never fun :D
10:03<TrueBrain>screw it
10:04<TrueBrain>if it breaks, it breaks
10:04<TrueBrain>Erato: if you now upload a new version, it should be named as you asked
10:04<TrueBrain>old files remain RIMS
10:04<Erato>That's fine.
10:04<TrueBrain>please let me know if you uploaded 1.4 (even if it is a dummy)
10:04<TrueBrain>than I can make sure everything went as it should :D
10:04<TrueBrain>a 1.4 as soon as possible would be appreciated :)
10:07<Erato>I think I can get something acceptable out the door in 5-10 minutes
10:07<TrueBrain>perfect :)
10:07<TrueBrain>can even be the same content as 1.3 btw, just named 1.4 :)
10:07<TrueBrain>(as long as the md5 isnt identical)
10:13<Erato>Alright I uploaded it
10:13<Erato>I saw in the Bananas manager that the name of 1.3 had already been changed
10:14<Erato>Alright it shows up as "Real International Maglev Set" in the in-game content downloader.
10:14<Erato>TrueBrain: It seems to work.
10:14<Erato>Thank you so much.
10:17<TrueBrain>that was the trick I tried; I renamed 1.3 (the name, not the filename), which is not okay, but fakes the system in thinking on next upload what the name should be :D
10:17<TrueBrain>so now you uploaded 1.4, I renamed 1.3 back to RIMS :P
10:17<TrueBrain>and it seems the system accepted that ;)
10:17<TrueBrain>enjoy :D
10:17<Erato>Thanks again!
10:18<TrueBrain>its on the list of BaNaNaS2 that you as user can just rename it btw :)
10:18<LordAro>inb4 OTTD makes some assumption about names are GRFIDs and now crashes
10:18<LordAro>names and*
10:19<TrueBrain>the whole system uses GRFids and MD5s to find GRFs :)
10:19<TrueBrain>names are just what end up on mirrors, and only used when you initiate a http download .. or so it should :P
10:24-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has joined #openttd
10:24-!-andythenorth is "andythenorth" on #openttd
10:25-!-Alberth [~alberth@00015f9e.user.oftc.net] has joined #openttd
10:25-!-Alberth is "purple" on #openttd
10:25-!-mode/#openttd [+o Alberth] by ChanServ
10:25<@Alberth>o/
10:25<andythenorth>hi
10:27-!-Erato [~oftc-webi@541B45BC.cm-5-4b.dynamic.ziggo.nl] has quit [Quit: Page closed]
10:33<andythenorth>glass + plastic -> window factory -> building materials
10:34<andythenorth>http://www.loadlifter-solutions.com/floatlinerglasslinersm.jpg
10:34<@Alberth>no metal in windows? :)
10:34<@Alberth>or wood, for that matter
10:35<andythenorth>considered that
10:35<nielsm>modern windows are all about the plastic
10:35<andythenorth>one of the weaknesses in FIRS is that too many cargos could be used ~everywhere
10:35<@Alberth>that sounds fair
10:36<Eddi|zuHause>gives a challenge for cargodist
10:36<andythenorth>also I worked in a upvc window factory
10:36<@Alberth>so you were looking for a use of plastic :)
10:37<nielsm>make an entirely opaque economy where the cargoes are just named A, B, C and industries are "type 1, 2, 3"
10:38<nielsm>and be released from the constraints of having to seems based on a reality
10:38<andythenorth>that's the 'stuff' economy
10:38<andythenorth>reality is quite easy to circumvent
10:38<andythenorth>apply the toy train 'prototype for everything' rule
10:47<@Alberth>nielsm: and then you get the problem of assigning cargoes and industry types, not sure how much better that gets
10:51<nielsm>Alberth but you can do that in a completely arbitrary manner
10:52<@Alberth>yes, the problem is too much choice indeed
10:53<@Alberth>in particular too many boring options
11:00<peter1138>hi
11:03<andythenorth>lo peter1138
11:03<andythenorth>shall I approve your PRs? :P
11:03-!-Wormnest [~Wormnest@s5596abd2.adsl.online.nl] has joined #openttd
11:03-!-Wormnest is "Wormnest" on #openttd
11:08<LordAro>andythenorth: yes
11:14<andythenorth>I don't think I'm allowed :P
11:15<andythenorth>we're just in a weird situation now
11:15<andythenorth>where peter1138 used to be allowed to just commit
11:15<andythenorth>but now can't
11:15<andythenorth>we're getting non-core commits through faster (win)
11:15<andythenorth>but core developers are blocked (ooof)
11:31<SpComb>blocked? You mean they have to go through the same PR review as any other plebs?
11:31<andythenorth>yes
11:31<andythenorth>previously, often, they kind of didn't
11:36<@Alberth>not really, anything non-trivial was reviewed too
11:37<@Alberth>ie technically being able to bypass doesn't mean it's a good idea to do so :P
11:38<@Alberth>and in my experience, a review does improve a solution, it's beneficial too thus
11:39<andythenorth>I am more laissez faire :P
11:39<andythenorth>experience people usually want to avoid being the one wearing clown shoes
11:39<andythenorth>experienced *
11:40<@Alberth>it's also a form of learning
11:40<@Alberth>you get new insights in how to solve things beyond what you know or considered
11:57-!-HerzogDeXtEr [~farci@dslb-178-012-125-143.178.012.pools.vodafone-ip.de] has joined #openttd
11:57-!-HerzogDeXtEr is "purple" on #openttd
11:58<SpComb>it's also possible to do really bad reviews and get stuck on some inconsequential opinionated aspects
11:58<SpComb>reviewing it also a skill that you need to learn
12:00-!-cHawk [~chawk@p4FDBFA61.dip0.t-ipconnect.de] has quit [Quit: Leaving]
12:02<andythenorth>we are figuring out reviews at work
12:02<andythenorth>reviews seem like they should be about risk
12:02<andythenorth>not taste
12:03<nielsm>yeah
12:03<andythenorth>taste is *really* important when coding
12:03<andythenorth>but if I'm coding it, and I've complied with all/any rules
12:03<andythenorth>then *your* taste shouldn't creep into the review
12:04<andythenorth>just wastes everyone's time
12:04<@Alberth>work is simple, as the boss decides the direction
12:04<andythenorth>I should have used Bob and Alice in my example :P
12:04<andythenorth>Alberth: in my case, why would I decide the direction?
12:04<andythenorth>I pay other people to do that
12:04<andythenorth>my job is mostly spreadsheets and signing stuff
12:05<@Alberth>open source has the additional problem of holder of the direction of development
12:05<andythenorth>Guido is having an interesting moment with that
12:05<@Alberth>in that case, the people that you pay decide the direction :)
12:05<andythenorth>so we look at risks
12:05<nielsm>IMO reviews should also look at the context of the changes and consider if all relevant documentation/comments are being updated to match the new state
12:06<andythenorth>- infosec risk (confidentiality, availability, integrity)
12:06<andythenorth>- and stasis risk: does this tie our hands in future
12:06<@Alberth>suppose I submit a patch to remove some in my view obsolete part
12:06<nielsm>I had a bit of an argument on a review a while ago on a pull request here, about whether/how much comments should be changed
12:06<@Alberth>even if I follow all rules, there has to be agreement that the part is indeed obsolete
12:07<andythenorth>well yes
12:07<andythenorth>I'm not disputing that :)
12:08<andythenorth>the map array PR is a good case for that
12:08<andythenorth>it's a fundamental change, even if it's not dramatic
12:09<@Alberth>map array is not a real change, it's just an expansion of possibilities, we can disagree on how much cpu time it may cost, but that's about it
12:09<@Alberth>shunting would be bigger in my view
12:10<andythenorth>consent and consensus are always interesting
12:10<@Alberth>but people just submit patches, without making sure it's acceptable, so that comes with the review
12:10<andythenorth>I tend to apply consensus as 'people have stopped disagreeing with me'
12:10<@Alberth>while work has already set that direction
12:10<andythenorth>this is kind of interesting http://www.sociocracy.info/consent-versus-consensus/
12:11<andythenorth>"Consent means that one has an opportunity to present a “reasoned no.” It does not require “a yes,” an affirmation, nor does it imply unanimity or full agreement. It is also not a veto; it must be explained."
12:12<@Alberth>oh, there are many level of agreement I agree :p
12:12<andythenorth>the upside of my projects is instant 100% consent :P
12:13<andythenorth>the downside is, I have to do nearly everything :P
12:13<@Alberth>but at some point it's about direction, and if some guy doesn't want, it's not going to happen with that guy
12:14<andythenorth>+1
12:14-!-Progman [~progman@p548D9AB5.dip0.t-ipconnect.de] has joined #openttd
12:14-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttdcoop #openttd
12:17<@Alberth>but we may be deviating from not getting code reviewed :p
12:18<andythenorth>it's all related :P
12:18<@Alberth>I am sure FIRS is the center of it :p
12:20<SpComb>how common is it to review your own code with `git diff` before each `git commit`?
12:20<@Alberth>99.5% of the time for me
12:20<SpComb>yeah
12:21<@Alberth>but that's just technical correctness, is it all there, nothing weird?
12:22<SpComb>I wouldn't necessarily assume that to always be the case
12:22<@Alberth>not "he, if you take this and this approach, it's much simpler, and you can do that and that too"
12:23<@Alberth>nope, I usually find 1 or 2 things every 3 commits or so
12:23<@Alberth>just an additional empty line usually
12:24<@Alberth>on the other hand, when I revisit code, I do sometimes think "oh man this is all wrong" :p
12:24<@Alberth>broken in some obscure way :)
12:27<peter1138>Well
12:27<Eddi|zuHause>the "which idiot coded THAT?!?" problem :p
12:27<peter1138>With reviews, you now have "which idiot approved THAT?!?"
12:28<Eddi|zuHause>i meant, the "idiot" is you from 6 months/5 years/whatever ago
12:28<andythenorth>'former us'
12:28<andythenorth>'former us' were stupid
12:29<Eddi|zuHause>s/you/yourself/
12:31<@Alberth>everything is broken, for most parts we're still working out how :)
12:32<peter1138>So maybe I should make maintain a branch with everything merged in my forked.
12:32<peter1138>-ed
12:32<peter1138>But maybe I won't bother, because that way lies madness.
12:32<peter1138>As it is, I've effectively given up coding anything because of the review system.
12:33<SpComb>:(
12:33<peter1138>Great principle, it's just not working in practice.
12:33<peter1138>Map array changes. No comment. Nothing. Not even a "holy shit you shouldn't do this"
12:33<SpComb>the worst part of review systems is when you have open PRs that never get reviews, either negative or positive
12:33<SpComb>yeah
12:34<@Alberth>number of people that can give meaning full comments on that is close to 0
12:34<peter1138>GUI timing changes. Reviewed briefly, changed made, not looked at again. Stagnant.
12:34<SpComb>because reviewing also takes effort, maybe more effort than writing the code itself sometimes
12:35<peter1138>NRT, I may just merge this later, becuase it's had zero objections.
12:35<Eddi|zuHause>understanding other people's code is a pain
12:36<peter1138>However, I wouldn't be able to fix any issues myself, because it'd just get stuck.
12:36<andythenorth>NRT, we already had TB review
12:36<andythenorth>all the issues TB found were fixed afaik
12:36<SpComb>well, the motivation for reviewing has to also come from somewhere
12:36<andythenorth>then you reviewed it peter1138
12:37<andythenorth>I am +1 to reviews, but I like to know what risk they're preventing them
12:37<andythenorth>shitloads of things are done in software because 'someone said it's correct'
12:37<andythenorth>that's not engineering
12:37<SpComb>I personally appreciate having someone else review my code and give comments
12:38<SpComb>doesn't answer your question, though
12:40<nielsm>map array changes is the nuclear plant the famous bike shed belongs to
12:40<Eddi|zuHause>maybe for "trusted devs" the review should be more optional? like you make a pull request, and if no other dev has said "hold on, i want to review that first" within a certain time, then you get to just commit it?
12:41<andythenorth>yes. the argument isn't "are reviews good or bad"
12:41<andythenorth>it's about gates to progress
12:42<SpComb>it certainly requires someone to also commit to reviewing stuff
12:44*nielsm is downloading an actual linux iso via bittorrent
12:44<Eddi|zuHause>how edgy
12:45<nielsm>huh apparently I've had a linux vm running in HyperV for possibly years here and totally forgotten about it
12:46<nielsm>and I mean actually running
12:46<peter1138>:D
12:46<nielsm>VM created april 2016
12:47-!-frosch123 [~frosch@00013ce7.user.oftc.net] has joined #openttd
12:47-!-frosch123 is "frosch" on #openttdcoop.devzone #openttd.dev #openttd
12:48<nielsm>sudo dhutdown
12:48<nielsm>without typos
12:48<peter1138>Bit out of date then?
12:48<nielsm>-h now too
13:02-!-Flygon [~Flygon@124-148-170-189.dyn.iinet.net.au] has quit [Read error: Connection reset by peer]
13:04-!-debdog [~debdog@2a02:8070:41a6:3700:7a24:afff:fe8a:d04d] has quit [Quit: Initiating getting-the-hell-out-of-here maneuver!]
13:06-!-debdog [~debdog@2a02:8070:41a6:3700:7a24:afff:fe8a:d04d] has joined #openttd
13:06-!-debdog is "Wowbagger" on #openttd
13:09<@Alberth>safe to say it works :p
13:09<peter1138>Not for very long.
13:25<peter1138>Current Game Speed Factor: 1.02x
13:25<peter1138>Ooer
13:26<LordAro>peter1138: what's the future like?
13:26<peter1138>Orange? :S
13:29-!-Wacko1976_ [~IceChat9@027-161-128-083.dynamic.caiway.nl] has joined #openttd
13:29-!-Wacko1976_ is "The Chat Cool People Use" on #openttd #/r/openttd
13:30-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has joined #openttd
13:30-!-Wolf01 is "Wolf01" on #openttd
13:30<Wolf01>o/
13:35-!-Wacko1976 [~IceChat9@027-161-128-083.dynamic.caiway.nl] has quit [Ping timeout: 480 seconds]
13:38<peter1138>\o
13:44<TrueBrain>peter1138: you always "had a patch for that", even when there was no review system; are you sure the review system is to blame? :)
13:44<andythenorth>30 days, no objections, clear to merge?
13:44<andythenorth>^ prone to being gamed
13:44<andythenorth>oh it's TrueBrain :)
13:45<TrueBrain>I always wonder why, especially full-fletched-devs, can be so pessistic yet action-less
13:45<TrueBrain>if you don't like something, change it
13:45<TrueBrain>don't sit on the side of the road like a grumpy old man holding your stick up high
13:45<TrueBrain>do something about it!
13:45<TrueBrain>don't expect someone else to do it or something
13:45<TrueBrain>this community has the huge tentency to go back to his hibernation when someone is not yelling loud enough to move forward
13:46-!-gelignite [~gelignite@55d4e5dc.access.ecotel.net] has joined #openttd
13:46-!-gelignite is "gelignite" on #openttd #openttdcoop.devzone
13:46<TrueBrain>is your PR not getting a review? Tell people and "force" them to review, how-ever nice you can do that (not by passive-aggresively making statements in this channel btw; that is not a good option :D)
13:46<Wolf01>Is game dead yet?
13:46<TrueBrain>is your PR not being merged? Ask yourself why not! Talk about it! Come up with ideas to solve it!
13:46<TrueBrain>fix your own problem! This is Open Source!
13:47<TrueBrain>be active! Even better: be PROACTIVE!
13:47<TrueBrain>but most of all: grow some balls and take action
13:47<TrueBrain>if you consider NRT good enough: fucking merge it
13:47<TrueBrain>if it blows up, it blows up
13:47<TrueBrain>boo-fucking-hoo
13:47<TrueBrain>OpenTTD has a history of shit being blown up
13:47<andythenorth>there's always revert
13:47<andythenorth>no kittens die
13:48<TrueBrain>no movement is always worse than any movement, in which ever direction
13:48<TrueBrain>but worse than no movement, complaining about the lack of moment
13:48<TrueBrain>moment = movement
13:48<TrueBrain>the only (!!) thing that is currently enforced, is that the CI approves a PR, and that a dev merges the PR
13:48<TrueBrain>there is no restriction on WHO reviewed it
13:49<TrueBrain>and if you think that system sucks: come with a suggestion!
13:49<TrueBrain>(am I rattling this cage hard enough? Or should I continue?)
13:50<TrueBrain>Take PR 6828
13:50<TrueBrain>why isn't this accepted yet?
13:50<peter1138>I'm not complaining about the system!
13:51<TrueBrain>[18:32] <peter1138> As it is, I've effectively given up coding anything because of the review system.
13:51<TrueBrain>sorry, you could have fooled me :D How should I have read it? :)
13:53<TrueBrain>(and just to be clear, the above was aimed at any person in this channel; get active! Stop being so passive!)
13:56<TrueBrain>peter1138: PR#6780 -> there are some comments that are not addressed yet; if they are fixed, that seems mergable?
13:59<nielsm>lol, just discovered that the configure script doesn't actually check the user has make installed
13:59<TrueBrain>:D
14:09<TrueBrain>no comments about the content of PR#6821 .. that is a bit sad
14:09<TrueBrain>who to slap for that .... hmmmmmmmmmm
14:10<TrueBrain>frosch123: does it make sense to, on load of a savegame in Single Player, convert all other companies to AIs?
14:11<frosch123>i somewhat doubt that
14:11<frosch123>likely ais won't make sense of the already built stuff
14:11<TrueBrain>it feels a bit weird, but I dont know why
14:12<frosch123>and some people like to play multiplayer with themself
14:12<frosch123>by switching companies
14:12<frosch123>or playing a bit on their own and then continue in multiplayer or whatnot
14:12<nielsm>is there an (easy) way to convert an existing player company to an AI if you ever want to?
14:13<frosch123>so. in essence, i can imagine more people complaining about conversion than prasiing :p
14:13<frosch123>nielsm: i don't think so
14:13<frosch123>but maybe adding a console command makes sense
14:13<frosch123>force ai onto existing company, and remove an ai without klling the company
14:13<TrueBrain>so we are going to reject the PR than :)
14:13<@Alberth>simplest option for the ai is to sell everything and start anew
14:14<frosch123>currently we have "startai" and "stopai". maybe people want "attachai" and "detachai"
14:18<nielsm>https://0x0.st/sODf.jpg well there's some sort of test environment at least
14:19<TrueBrain>frosch123: tnx; updated tickets, closed PRs
14:19<nielsm>also looks fine https://0x0.st/sODV.png
14:20<nielsm>interesting it runs at slightly faster than 33.33 here
14:22<TrueBrain>lol
14:23<TrueBrain>nielsm: yeah, tri-state is the bare minimum; it could be a lot better. But I am already happy if someone adds tri-state tbh :D
14:26<TrueBrain>frosch123: tldr, #6846, did he fix all your mentioned points?
14:26<frosch123>i'll check on the weekend
14:26<frosch123>did not manage last weekend
14:27<TrueBrain>no worries
14:27<TrueBrain>was mostly wondering, and didnt feel like reading :D
14:28<TrueBrain>and ugh, I did so little of what I planned .. the stupid weather is really draining me :(
14:28<TrueBrain>I like the forest PR :)
14:30<TrueBrain>tempted to merge it, but I should validate it first ..
14:30<TrueBrain>wish I had a bot I could tell to make me a binary
14:30<TrueBrain>owh wait, that was what I was building
14:32<TrueBrain>I wonder about 6784 .. feels like someone needs to say "left" or "right" on it ..
14:33<Wolf01>Go ahead?
14:33<nielsm>unless anyone has objections for fps-meter I think it's also ready to merge now?
14:33<nielsm>or someone thinks it needs re-testing on mac
14:33<Wolf01>Ships need to be fixed in many ways
14:34<nielsm>bbl food
14:35<TrueBrain>Wolf01: there is a bit of politics involved; if we can make J0anJosep happy by adding a simple statement, it makes his work in his patchpack easier
14:35<Wolf01>So?
14:36<TrueBrain>something about an upwards spiral of hapiness
14:36<TrueBrain>if you help someone else, he is more likely to help you :)
14:36<Wolf01>Fine
14:37<TrueBrain>so what I wonder, how much code is it
14:37<TrueBrain>one line?
14:37<TrueBrain>20?
14:41<andythenorth>TrueBrain: I am -1 to the forest patch
14:41<andythenorth>I would rather tree algorithm was newgrf content
14:41<Wolf01>^
14:42<LordAro>perhaps, but if "tree placement as newgrf" is going to take years and years, why not add this now?
14:42<TrueBrain>which is unlikely to happen ... that is a thoughy!
14:42<LordAro>it can always be taken out later
14:42<TrueBrain>it depends .. do we want "master" to be as close to original as reasonable, and extend by addons (read: newgrfs)
14:42<TrueBrain>or do we extend in "master" too
14:43<TrueBrain>as if we add forest, having tree placement in newgrf is even more unlikely
14:43<Wolf01>I'm for extending with newgrfs
14:43<andythenorth>content all the way
14:43<TrueBrain>(lets put away if newgrfs are the correct solution for this btw)
14:43<andythenorth>just content
14:43<TrueBrain>currently there are two ways to extend OpenTTD: NewGRFs and Squirrel
14:43<andythenorth>extensible, smaller core
14:43<andythenorth>more patchpacks
14:43<TrueBrain>rest of the world uses lua :D
14:43<andythenorth>fewer conflicts, fewer tarpits
14:43<andythenorth>more state = more tarpit
14:44<andythenorth>more tarpit = slower development, or total stasis
14:44<TrueBrain>I really like forest, but I do agree ... but do we want to become the project that rejects all new ideas? :D
14:44<andythenorth>if only there was a really active patchpack :(
14:44<andythenorth>oh wait
14:45<TrueBrain>if only OpenTTD still had GPMI in its core ... :P (that allows binary extension via addons)
14:45<andythenorth>https://github.com/JGRennison/OpenTTD-patches/commits/jgrpp
14:45<TrueBrain>frosch123: do you agree, should we reject forest patch (refering him to the above URL)?
14:45<andythenorth>also https://wiki.openttd.org/FAQ_development#What_are_the_goals_of_the_offical_branch.3F
14:46<frosch123>TrueBrain: i have not looked at the tree patch
14:46<TrueBrain>in very simple words: it adds another tree-placement algorithm, that favors forests
14:46<frosch123>but newgrf- or squirrel-based tree stuff is the argument, that is not going to happen
14:46<frosch123>*if
14:46<TrueBrain>(YATP - Yet Another Tree Placement)
14:47<TrueBrain>no, the argument is: should 'master' have YATP, or should it be by extension (either by an addon or by a patchpack)
14:47<frosch123>i don't see the latter as a valid option
14:48<TrueBrain>care to explain why?
14:48<TrueBrain>(sounds more rude than intended :D)
14:48<TrueBrain>could you elaborate? :D
14:48<frosch123>there are many trees on the map
14:48<frosch123>neither newgrf nor scripts are good with managing that
14:48<andythenorth>do we really need so many trees?
14:48<TrueBrain>isn't that irrelevant for the choice? HOW the latter should be solved, is a second talk?
14:48<frosch123>so i am quite sure there will never be "addons" for tree placement
14:49<TrueBrain>but if we choice when to add stuff to 'master' based on how difficult it is to do it in an addon, line becomes very blurry?
14:49<TrueBrain>patchpacks are also addons, in some sense?
14:49<frosch123>anyway, i ignore trees with invisiblity. so i have no opinion on the tree patch itself
14:49<andythenorth>I would prefer to continue forcing choices by preferring content
14:49<frosch123>if it is good, it should be added
14:49-!-Progman_ [~progman@p4FD66316.dip0.t-ipconnect.de] has joined #openttd
14:49-!-Progman_ is "Peter Henschel" on #openttd #openttdcoop #openttdcoop.dev
14:49<andythenorth>I don't want to discuss an implementation, but tree tiles could be done with much less variety and nobody would notice
14:49<frosch123>i assume it does not affect savegames
14:50<frosch123>so changing/removing tree placement is fine any time
14:50<TrueBrain>but do we want to bother with that in 'master', or is that something for patchpacks?
14:51<andythenorth>patchpacks, possibly port a winning implementation if there is one
14:51<andythenorth>growing more half-assed variants is not appealing
14:51<andythenorth>and we don't seem to delete old dead implementations
14:51<TrueBrain>well, you do want to prevent another PBS, yes :P
14:51<TrueBrain>that last one, is the tricky part; once added to master, removing it is very difficult, as people start to depend on it
14:51<andythenorth>or another New Economy
14:51<TrueBrain>people still complain that the original AI is removed
14:52<TrueBrain>but OpenTTD with TGP is .. ughhhhh, sucky
14:52<TrueBrain>so there are really two sides to this coin :)
14:52<frosch123>reading it, i would complain about the description :p
14:52<andythenorth>'people complain' doesn't actually mean very much
14:52<frosch123>"'Original' plants trees uniformly scattered, 'Improved' plants them in groups, 'Forest' plants them in forests"
14:52<frosch123>^^ that says nothing
14:52<frosch123>maybe it should say "large groups"?
14:52<andythenorth>'people complain' is easily circumvented by not reading tt-forums or the german forum :P
14:52<TrueBrain>you nitpick on that in the PR, I was trying to see what we are at in the more high-level picture of this all :)
14:53<TrueBrain>when are a group of trees a forest :)
14:53<TrueBrain>for me the description reads fine btw :)
14:53<andythenorth>when nobody hears them fall
14:54<frosch123>anyway, everything the patch adds can be removed without breaking anything
14:54-!-Progman [~progman@p548D9AB5.dip0.t-ipconnect.de] has quit [Ping timeout: 480 seconds]
14:54<TrueBrain>okay; than I am going to merge it
14:54-!-Progman_ is now known as Progman
14:54<TrueBrain>or do you want the description changed?
14:55<frosch123>so, if anyone has tried it, and subjectively likes the appearance, i am +1 to it
14:55<TrueBrain>ugh, this "trying" again ....
14:55<TrueBrain>andythenorth: can you try that PR? :P :P
14:55<andythenorth>yes
14:55<andythenorth>give me 5-10 mins
14:55<TrueBrain>\o/
14:56<TrueBrain>okay ... FPS meter ... think everyone pissed over that enough ... I see no blockers ....
14:56<frosch123>changing the text can be a separate pr
14:56<TrueBrain>merging time? (going once ... goince twice ...)
14:56*andythenorth compiling
14:56<frosch123>"improved" is just as stupid :)
14:56*andythenorth needs the new quad core mac
14:58<TrueBrain>now to squash this FPS .....
14:58<andythenorth>wow my fans span up :P
14:58<TrueBrain>as 49 commits is a bit much
14:58<andythenorth>I know Apple analogies are like cat sick
14:58<TrueBrain>nielsm: only the first commit-message is sufficient? Or does it need more?
14:58<andythenorth>but I read this today, re 'people will complain'
14:58<andythenorth>https://forums.macrumors.com/threads/true-tone-on-external-displays-doesnt-work-with-macbook-pro-in-clamshell-mode-updated.2128138/#post-26259454
14:58<TrueBrain>lolz
14:59<TrueBrain>C++11 stuff .. oef .. that is a difficult one
14:59<andythenorth>ok the forest patch is bad
14:59<andythenorth>don't merge
14:59<andythenorth>I need to comment on PR :P
15:00<TrueBrain>all yours
15:00<andythenorth>just thinking how to do it kindly
15:00<TrueBrain>screenshot? :)
15:00<andythenorth>it makes random diamond shaped groups of treees
15:00<andythenorth>it k
15:00<andythenorth>screenshotting
15:01<TrueBrain>and yes: BE NICE! :)
15:01<andythenorth>https://github.com/OpenTTD/OpenTTD/pull/6848#issuecomment-406381059
15:01<andythenorth>so problems
15:01<andythenorth>- looks bad
15:02<andythenorth>- leaves no trees anywhere else
15:02<TrueBrain>diamond-shapes are to be expected :)
15:02<andythenorth>- conflates with forest industry
15:02<TrueBrain>and that was the idea: forest-only
15:02<andythenorth>- options makes no sense in world-gen menu 'none', 'original', 'improved', 'forest'
15:02<TrueBrain>feels like it needs a settings between "improved" and "forest" :D
15:02<andythenorth>UX: which do I pick?
15:03<andythenorth>why don't we just fix on one good, and remove the bullshit?
15:03<TrueBrain>yeah, as frosch123 said, "improved" is now silly
15:03<TrueBrain>okay, make this into a nice reply, state a clear opinion and direction for the author to execute
15:03<TrueBrain>(please don't leave a: you figure it out, reply; that is not nice for a first-time contributor)
15:03<andythenorth>on the plus side, reminds me of http://everygamegoing.com/ills/bbc_b/acornsoft/tapes/Jcb_Digger_002.gif
15:03<andythenorth>yeah, these replies demand the most care
15:05<TrueBrain>frosch123: to bother you some more (sorry :D), adding 2 bytes to _map, your thoughts? How is memory etc these days?
15:06<frosch123>that's no issue
15:06<frosch123>you can also add 8 just fine :p
15:06<TrueBrain>percentage-wise it is less and less :D
15:06<frosch123>map array is neglible to the rest
15:06<TrueBrain>"back in my day", it was a huge impact, as adding bytes often meant some players no longer could play big maps
15:06<frosch123>esp. on clients with 32bpp
15:07<TrueBrain>is there any "policy" in place for assignments? Or is a PR like peter1138's fine?
15:08<Eddi|zuHause>but... map array has become this mythical catch-all for rejecting any major feature. you can't just expand it on a whim and undermine that :p
15:08<frosch123>we try to put the same stuff into the same bits for different tile types
15:09<frosch123>so, unless the patch contains switches on tiletype to read on different bits, it should be fine
15:09<TrueBrain>*picks up what-ever Eddi|zuHause says, opens the door, puts it next to the trash*, anything else? :D
15:09<nielsm>newgrf tree planting mechanism ideas: https://0x0.st/sOkT.txt
15:10<TrueBrain>that only leaves me to wonder ... he added a m8 as 16bit .. while most (not all) are 8bit
15:10<TrueBrain>better to add 2 8bit, or are we just going all-the-way here
15:10<frosch123>i think we talked about that before, and i prefered 16bit
15:10<TrueBrain>(only 6 bits are used, of the 16bit)
15:11<frosch123>iirc peter had multiple versions of the patch, one with 2x8, and one with 1x16
15:11<frosch123>and the favour was for 1x16
15:11<TrueBrain>ack; that means someone just has to review the moving (and expanding) of railtypes
15:12<TrueBrain>and don't share that favour, but I don't care enough (only care enough to mention it :P)
15:13<frosch123>the idea was that reading a subset of bits is easier than merging multiple bytes into something bigger
15:13<frosch123>we have some things, like objects, where we store ids over multiple bytes
15:13<frosch123>like m2 and m7 bits 2 to 5 or something
15:13<andythenorth>nielsm: re trees, it does just need someone to pick it up and drive it through
15:14<andythenorth>many things have been declared impossible before
15:14<andythenorth>then done :P
15:14<andythenorth>'performance reasons' is ~50% bullshit excuse :)
15:14<TrueBrain>nielsm: but is the first commit message of your FPS sufficient? (I am about to squash the whole damn thing into a single commit, and want to be sure that is okay)
15:14<nielsm>https://www.tt-forums.net/viewtopic.php?f=31&t=83507#p1209912 <-- fps-meter already being used to diagnose issues!
15:14<nielsm>TrueBrain let me just check a bit
15:14<TrueBrain>yeah ... maps not being 256x256 was impossible!
15:15<TrueBrain>(and that was my first patch for OpenTTD .. .14 years ago :P)
15:15<TrueBrain>tnx btw frosch123! Always helps to know in a PR what was already talked over :)
15:16<Eddi|zuHause>most of my patches were 1-3 lines, of things other people were apparently not bothered enough to do them
15:16<TrueBrain>I added some labels in Pull Request
15:16*andythenorth looking for the 'most of savegame is trees' issue
15:16<nielsm>TrueBrain, if you can make commit message the title of PR + first paragraph in PR initial post
15:16<andythenorth>can't find it
15:16<nielsm>i.e.: Frame rate and various game loop/graphics timing measurements and graphs. Accessible via the Help menu, and can print some stats in the console via the `fps` command.
15:16<Eddi|zuHause>i think my biggest patch that got in (line-wise) was the screenshot thing
15:17<TrueBrain>nielsm: done!
15:17<TrueBrain>seriously nicely done for such a huge patch
15:17<Eddi|zuHause>where it took the area that is currently visible, but applied the max zoom to it
15:17<TrueBrain>how we say it in dutch: "petje af"
15:17-!-Thedarkb [~beno@51-171-48-3-dynamic.agg3.kny.prp-wtd.eircom.net] has joined #openttd
15:17-!-Thedarkb is "realname" on #/r/openttd #openttd #oolite
15:17-!-gelignite [~gelignite@55d4e5dc.access.ecotel.net] has quit [Quit: Match found!]
15:18<TrueBrain>so that leaves NRT and std:vector
15:18<Eddi|zuHause>which turned out not very difficult to do, just take the whole-map screenshot routine, and add some limits to it
15:18<Eddi|zuHause>all of the infrastructure for it was already in place, just had to be combined the right way
15:19<TrueBrain>frosch123: I assume you agree'd withi the std::vector stuff? (last quesiton of the evening, I promise)
15:19<TrueBrain>nielsm: your comment in #6817, is a bit vague to me; are those two changes in there, or should they be added?
15:20<andythenorth>so LordAro is ok to review this one? o_O https://github.com/OpenTTD/OpenTTD/pull/6805
15:20<nielsm>I think the std::vector patch requires C++11 but not sure
15:20<TrueBrain>LordAro: related to #6817, do we need to enforce build systems to use C++11? With that PR, won't they simply fail?
15:20<nielsm>TrueBrain the GUIBrideList is not being fixed iirc
15:21<TrueBrain>can you make that more clear in your comment, so the author knows if he has any actions left?
15:21<TrueBrain>(in general in pull requests, please make it very obvious to the author if it is an action on his side, or just a remark :D)
15:22<TrueBrain>and as it is a first-time contributor, make it something nice :) "Would you mind to also fix ... as they are really important to fix ..." :D
15:22<TrueBrain>tnx!
15:22<TrueBrain>ah, that introduces more of that 'auto' stuff ... 'auto' is dutch for 'car', so in my head I always go: BROOM BROOM
15:23<frosch123>TrueBrain: it has some codestyle issues, but the principle is fine
15:24<andythenorth>so the forest patch....is contentish trees ruled out or no?
15:24<andythenorth>before I mislead Sylvain
15:24<andythenorth>or it's a non-issue either way?
15:24<nielsm>also just before I was so busy looking at code I almost forgot my pizza in the oven :(
15:25<nielsm>got it out while it was still edible
15:25<andythenorth>:o
15:25<andythenorth>I cook using timer on my phone
15:25<andythenorth>only way
15:25<andythenorth>primary benefit of smartphone
15:25<nielsm>yeah I usually set a timer, forgot it this one time
15:25<TrueBrain>frosch123: ack, tnx :)
15:25<frosch123>i think noone read all the diffs :p
15:26<TrueBrain>my oven just stops after the time I put in
15:26<TrueBrain>avoids any mistakes :D
15:26<andythenorth>poka-yoke
15:26<frosch123>https://github.com/OpenTTD/OpenTTD/pull/6817/commits/445bcdbb3a9bf6f440560cf492692da13bc8073d#diff-0b90577e7f946552f0ac4285ea1b9ae6 <- no idea whether that is done
15:26<andythenorth>mistake of forgetting to eat the food? o_O
15:27<TrueBrain>frosch123: lolz :D
15:27<nielsm>ah yeah leaving commented-out code is a bad smell
15:27<TrueBrain>so, it needs a review; that is fine :)
15:28<TrueBrain>we closed 124 PRs already :o
15:28<TrueBrain>damn
15:28-!-glx [~glx@000128ec.user.oftc.net] has joined #openttd
15:28-!-mode/#openttd [+v glx] by ChanServ
15:28-!-glx is "Loïc GUILLOUX" on +#openttd
15:28<TrueBrain>happy the FPS stuff is in :D
15:28<TrueBrain>owh hi glx!
15:29<+glx>hi
15:29<andythenorth>TrueBrain: damn yes
15:29<andythenorth>I counted at the weekend
15:29<andythenorth>shitloads
15:29<andythenorth>just need binaries now :)
15:29<TrueBrain>the number... is just there
15:29<TrueBrain>no need to count
15:29<TrueBrain>YES! Working on it ..
15:29<TrueBrain>tomorrow call with Google Cloud Platform .. I so hope they can offer something
15:29<TrueBrain>would make shit so much easier (and faster)
15:30<andythenorth>oof I counted commits manually (by counting pages)
15:30<andythenorth>I should github better
15:35<@Alberth>better call microsoft nowadays :)
15:35<TrueBrain>to learn GitHub?
15:36<andythenorth>hmm
15:37<andythenorth>in the tank game we say 'git gud' when players are lame
15:37<andythenorth>I need to 'github gud' :P
15:37<TrueBrain>rrreeeeeeeel gud
15:40<nielsm>okay I'm impressed how MS managed to hide Safe Mode in win10 behind a maze of buttons
15:40<nielsm>it seems to prefer you reinstall windows before trying to boot to safe mode
15:41<@Alberth>instead of calling google
15:44<TrueBrain>Azure will be fine too; but for kubernetes, GCP is better :)
15:47<LordAro>TrueBrain: ideally the build system should be modified indeed
15:47<TrueBrain>a bit more snippets of information would be greatly appreciated :D
15:47<LordAro>otherwise someone will try compiling with something ancient and get some obscure error
15:47<TrueBrain>modified in what sense?
15:47<TrueBrain>just 'modified'? :D
15:47-!-sim-al2 [~sim-al2@c-75-65-196-171.hsd1.tn.comcast.net] has joined #openttd
15:47-!-sim-al2 is "sim-al2" on #openttd @#/r/openttd
15:48<LordAro>some sort of test program probably
15:48<TrueBrain>owh, you want to add a check if you are using a C++11 capable compiler!
15:48<TrueBrain>see, that is more sensible :)
15:48<LordAro>sorry, wasn't clear :p
15:48<TrueBrain>no, it was very vague :)
15:48<TrueBrain>very :D
15:49<TrueBrain>I guess porting to cmake is easier :P
15:49<LordAro>quite possibly!
15:50<@Alberth>autotools! :p
15:50<LordAro>https://cmake.org/cmake/help/latest/manual/cmake-compile-features.7.html#manual:cmake-compile-features(7) & https://cmake.org/cmake/help/latest/prop_gbl/CMAKE_CXX_KNOWN_FEATURES.html#prop_gbl:CMAKE_CXX_KNOWN_FEATURES
15:51<LordAro>Alberth: i tried that, TB shouted at me :p
15:51<@Alberth>hah :)
15:52<TrueBrain>wait, who needs to be "corrected? :P
15:52<TrueBrain>LordAro: in CMake you just say the lowest allowed compiler, and it will do its thing correctly :D Which is really nice
15:57<TrueBrain>andythenorth: also a note on the forest patch: theyALL have EXACTLY the same size
15:57<TrueBrain>bit boring
15:58<andythenorth>I am writing a comment
15:58<andythenorth>kind of hard because I can never approve it
15:58<andythenorth>unless I can? :P
15:58*andythenorth checks
15:58<TrueBrain>sure you can
15:58<TrueBrain>otherwise by proxy! :P
15:58<andythenorth>k
15:58<andythenorth>all is well
16:01<andythenorth>done that comment
16:03-!-Alberth [~alberth@00015f9e.user.oftc.net] has left #openttd []
16:04<TrueBrain>and I am off! nn!
16:24<Eddi|zuHause>there are seriously chemicals called "Alite" and "Belite"?
16:27<andythenorth> sounds like a FIRS economy
16:27<Eddi|zuHause>apparently they're components in cement
16:28<andythenorth>o_O
16:28<Eddi|zuHause>with different ratio of Ca to Si
16:28<andythenorth>worth knowinng
16:28<Eddi|zuHause>one is Ca3SiO5 and the other Ca2SiO4
16:28<Eddi|zuHause>and i instantly forgot which is which
16:29<frosch123>there is also cerite
16:31<andythenorth>cement economy
16:31<andythenorth>super extra detail
16:31<andythenorth>clinker
16:31<andythenorth>gypsum
16:31<andythenorth>slag
16:39-!-Laedek [~quassel@172.92.115.58] has quit [Ping timeout: 480 seconds]
16:49-!-nielsm [~nielsm@62-243-118-198-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
16:58<Wolf01>'night
16:58-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has quit [Quit: Once again the world is quick to bury me.]
16:58-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has quit [Quit: andythenorth]
17:26-!-Progman [~progman@p4FD66316.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
17:26-!-frosch123 [~frosch@00013ce7.user.oftc.net] has quit [Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn]
17:43-!-sim-al2 [~sim-al2@c-75-65-196-171.hsd1.tn.comcast.net] has quit [Quit: HydraIRC -> http://www.hydrairc.com <- The alternative IRC client]
17:52-!-sim-al2 [~sim-al2@c-75-65-196-171.hsd1.tn.comcast.net] has joined #openttd
17:52-!-sim-al2 is "sim-al2" on #openttd @#/r/openttd
18:03-!-Laedek [~quassel@172.92.127.86] has joined #openttd
18:03-!-Laedek is "Laedek" on #openttd
18:23-!-Thedarkb [~beno@51-171-48-3-dynamic.agg3.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
18:30-!-Thedarkb [~beno@51-171-48-3-dynamic.agg3.kny.prp-wtd.eircom.net] has joined #openttd
18:30-!-Thedarkb is "realname" on #oolite #openttd #/r/openttd
18:30-!-Lejving_ [~Lejving@81-233-148-192-no524.tbcn.telia.com] has joined #openttd
18:30-!-Lejving_ is "realname" on #openttd #/r/openttd #factoriocoop #mashinky #openttdcoop #openttdcoop.dev #openttdcoop.stable #openttdcoop.pz
18:34-!-Lejving [~Lejving@81-233-148-192-no524.tbcn.telia.com] has quit [Ping timeout: 480 seconds]
18:41-!-Wormnest [~Wormnest@s5596abd2.adsl.online.nl] has quit [Quit: Leaving]
18:47-!-RafiX [~rafix@public-gprs352496.centertel.pl] has quit [Quit: WeeChat 1.6]
19:33-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has joined #openttd
19:33-!-snail_UES_ is "Jacopo Coletto" on #openttd
19:51-!-HerzogDeXtEr [~farci@dslb-178-012-125-143.178.012.pools.vodafone-ip.de] has quit [Read error: Connection reset by peer]
20:04-!-Sacro_ [~ben@ns364742.ip-94-23-0.eu] has joined #openttd
20:04-!-Sacro_ is "Ben Woodward" on #openttd #tycoon #simsig
20:05-!-Sacro [~ben@ns364742.ip-94-23-0.eu] has quit [Ping timeout: 480 seconds]
20:05-!-TinoDidriksen [~TinoDidri@tinodidriksen.com] has quit [Ping timeout: 480 seconds]
20:07-!-TinoDidriksen [~TinoDidri@158.69.255.87] has joined #openttd
20:07-!-TinoDidriksen is "Tino Didriksen" on #openttd #opendune #debian-nordic
20:31-!-Arveen [~Arveen@p4FEB9862.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20:57<Eddi|zuHause>uhm, forum backup? i haven't seen this message in ages. also, it looks like it's 5 minutes early
21:25-!-Supercheese [~Superchee@cpe-98-146-230-183.natnow.res.rr.com] has joined #openttd
21:25-!-Supercheese is "Supercheese" on #openttd
22:06-!-LANJesus [~lj@0001a2bd.user.oftc.net] has quit [Read error: Connection reset by peer]
22:06-!-LANJesus [~lj@0001a2bd.user.oftc.net] has joined #openttd
22:06-!-LANJesus is "WOOOAAARGH!" on #openttd
22:13<SpComb>it meana that you're up at the wrong time, and should go to sleep
22:13<SpComb>or you live on the wrong continent
22:35<Eddi|zuHause>like you're any better with that :p
22:56-!-Flygon [~Flygon@124-148-170-189.dyn.iinet.net.au] has joined #openttd
22:56-!-Flygon is "Flygon" on #openttd
23:00-!-glx [~glx@000128ec.user.oftc.net] has quit [Quit: Bye]
---Logclosed Fri Jul 20 00:00:42 2018