Back to Home / #openttd / 2018 / 09 / Prev Day | Next Day
#openttd IRC Logs for 2018-09-13

---Logopened Thu Sep 13 00:00:47 2018
00:27-!-SpComb^ [] has joined #openttd
00:27-!-SpComb^ is "Tero Marttila" on #openttd #oftc #bitlbee #tycoon
00:27-!-SpComb [] has quit [Read error: Connection reset by peer]
00:41-!-Wacko1976 [] has joined #openttd
00:41-!-Wacko1976 is "The Chat Cool People Use" on #openttd #/r/openttd
00:53-!-Wacko1976 [] has quit [Ping timeout: 480 seconds]
01:28-!-ToBeFree [] has joined #openttd
01:28-!-ToBeFree is "ToBeFree" on #openttd #oolite-ger #oolite-dev #oolite #linux #https-everywhere @#freiwuppertal @#InfiniteAdventures
01:29-!-ToBeFree [] has quit []
01:49-!-OsteHovel [] has joined #openttd
01:49-!-OsteHovel is "Hovel on the Ost" on #openttd
02:21-!-Gustavo6046 [~Gustavo60@] has quit [Read error: Connection reset by peer]
02:25-!-snail_UES_ [] has joined #openttd
02:25-!-snail_UES_ is "Jacopo Coletto" on #openttd
02:45-!-Gustavo6046 [~Gustavo60@] has joined #openttd
02:45-!-Gustavo6046 is "Non dico nomen." on #openttd
03:01-!-tokai|noir [] has joined #openttd
03:01-!-mode/#openttd [+v tokai|noir] by ChanServ
03:01-!-tokai|noir is "Christian Rosentreter" on +#openttd
03:08-!-tokai [] has quit [Ping timeout: 480 seconds]
03:27-!-Supercheese [] has quit [Remote host closed the connection]
03:27-!-Supercheese [] has joined #openttd
03:27-!-Supercheese is "Supercheese" on #openttd
03:55-!-gelignite [] has joined #openttd
03:55-!-gelignite is "gelignite" on #openttd
04:38-!-snail_UES_ [] has quit [Quit: snail_UES_]
05:13-!-Arveen [] has quit [Quit: I like trains]
05:26-!-Supercheese [] has quit [Quit: Valete omnes]
05:32-!-Progman [] has joined #openttd
05:32-!-Progman is "Peter Henschel" on #openttdcoop #openttd
05:54<alluke>how many years will it take to get ratt into trunk?
05:54<alluke>1.9.0 too soon i suppose?
06:02<LordAro>which one is ratt?
06:22-!-Sacro [] has joined #openttd
06:22-!-Sacro is "Ben Woodward" on #tycoon #simsig #openttd
06:56-!-Samu [] has joined #openttd
06:56-!-Samu is "OFTC WebIRC Client" on #openttd
07:03<DorpsGek_II>[OpenTTD/OpenTTD] MosheL commented on issue #6427: [Windows] RTL bug OpenTTD 1.6.0-RC1
07:16<LordAro>fixed by uniscribe, do we think?
07:21<Eddi|zuHause>worth asking to retest with trunk
07:21<Eddi|zuHause>would be helpful if we had nightlies?
07:22<Eddi|zuHause>i'm looking for an old laptop and i can't figure out where i put it
07:28-!-gelignite [] has quit [Quit: Match found!]
07:42<LordAro>Eddi|zuHause: nightlies would be helpful, yes :p
07:54<Samu>is it possible to know to whom a road tile belongs?
07:54<Samu>namely, which town
07:54<Samu>not a company
07:55<Samu>maybe it is, let me think this through
08:01-!-Arveen [] has joined #openttd
08:01-!-Arveen is "realname" on #openttd #openttdcoop
08:31-!-snail_UES_ [] has joined #openttd
08:31-!-snail_UES_ is "Jacopo Coletto" on #openttd
08:37-!-sla_ro|master [] has joined #openttd
08:37-!-sla_ro|master is "slamaster" on #sla #openttd
09:00-!-sla_ro|master [] has quit []
09:44-!-KouDy [] has quit [Ping timeout: 480 seconds]
09:49-!-sim-al2 [] has quit [Ping timeout: 480 seconds]
10:04-!-nielsm [] has joined #openttd
10:04-!-nielsm is "Niels Martin Hansen" on #openttd #tycoon
10:10-!-Progman [] has quit [Remote host closed the connection]
10:15-!-haudrauf [] has quit [Ping timeout: 480 seconds]
10:19-!-haudrauf [] has joined #openttd
10:19-!-haudrauf is "Haudrauf" on #openttd #frickelplatz @#ffod @#ffnord @#ffki @#ffhl @#ffhh @#fffl #cryptoparty @#ccchh
10:20<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on issue #6427: [Windows] RTL bug OpenTTD 1.6.0-RC1
10:22-!-KouDy [] has joined #openttd
10:22-!-KouDy is "KouDy" on #openttd
10:30-!-Flygon [] has quit [Read error: Connection reset by peer]
10:40<Samu>local arrayMiddleTile = roadArray[roadArray.len() / 2].m_tile;
10:40<Samu>is this gonna get me the the middle tile
10:40<Samu>i hope so lol
10:49-!-snail_UES_ [] has quit [Quit: snail_UES_]
11:01-!-sla_ro|master [] has joined #openttd
11:01-!-sla_ro|master is "slamaster" on #sla #openttd
11:21-!-Gja [] has joined #openttd
11:21-!-Gja is "Martin" on #ceph #bcache #openttd
11:44-!-wodencafe [] has joined #openttd
11:44-!-wodencafe is "Woden Cafe" on #432 #openttd #oftc #moocows
11:46-!-Gja [] has quit [Remote host closed the connection]
11:47-!-FLHerne [] has quit [Quit: Goodbye (ZNC disconnected)]
11:48-!-FLHerne [] has joined #openttd
11:48-!-FLHerne is "Francis Herne" on #openttd #kernelnewbies
11:52-!-Samu [] has quit [Remote host closed the connection]
12:03-!-Samu [] has joined #openttd
12:03-!-Samu is "OFTC WebIRC Client" on #openttd
12:19<Samu>local adjacentTiles = (roadTiles = Utils.getAdjacentTiles(tile));
12:19<Samu>will this work in squirrel code?
12:31-!-HerzogDeXtEr [] has joined #openttd
12:31-!-HerzogDeXtEr is "purple" on #openttd
12:33-!-Samu [] has quit [Remote host closed the connection]
12:44<LordAro>probably not
12:49-!-Wacko1976 [] has joined #openttd
12:49-!-Wacko1976 is "The Chat Cool People Use" on #openttd #/r/openttd
13:07-!-KouDy [] has quit [Remote host closed the connection]
13:25-!-Wormnest [] has joined #openttd
13:25-!-Wormnest is "Wormnest" on #openttd
13:26-!-KouDy [] has joined #openttd
13:26-!-KouDy is "KouDy" on #openttd
13:53-!-Samu [] has joined #openttd
13:53-!-Samu is "OFTC WebIRC Client" on #openttd
14:02-!-Netsplit <-> quits: Smedles, APTX
14:02-!-Netsplit over, joins: Smedles, APTX
14:04-!-Wolf01 [] has joined #openttd
14:04-!-Wolf01 is "Wolf01" on #openttd
14:16-!-andythenorth [] has joined #openttd
14:16-!-andythenorth is "andythenorth" on #openttd
14:16<andythenorth>can I just hire TrueBrain? :|
14:19-!-Gja [] has joined #openttd
14:19-!-Gja is "Martin" on #ceph #bcache #openttd
14:19-!-KouDy [] has quit [Remote host closed the connection]
14:22-!-frosch123 [] has joined #openttd
14:22-!-frosch123 is "frosch" on #openttdcoop.devzone #openttd
14:22<TrueBrain>what do you want me to destroy andythenorth?
14:23<andythenorth>I am still looking for an SRE :P
14:23<andythenorth>I am reduced to wading through linkedin
14:23<andythenorth>spamming devops engineers
14:23<andythenorth>it's like the worst thing ever
14:23<andythenorth>but it has worked a couple of times before :|
14:23<TrueBrain>yes; that is :P
14:23<andythenorth>my eyes bleed
14:23<andythenorth>everyone will hate me
14:23<TrueBrain>reason I deleted my LinkedIn tbh
14:23<andythenorth>and linkedin only ever gets worse
14:24<Samu>damn it, for building a road depot i have to write a bajillion of lines in code
14:24<Samu> 161 lines :8
14:26<Samu>i dont need to build signs anymore, removing
14:27<Samu>160 lines
14:27<andythenorth>so can we rek any PRs? :)
14:27<TrueBrain>we should add a "rotting" process .. where PRs without attention automatically get pinged, and in the end closed
14:28<TrueBrain>I really like that in my other github projects :)
14:28<Samu>andythenorth added the waiting-on-author label 3 days ago, but I already answered :(
14:28<TrueBrain>my = many
14:28<TrueBrain>typing is hard
14:30<andythenorth>I think NRT is rotted nearly through
14:30<andythenorth>and that one by peter1138
14:30<andythenorth>new label: "didn't happen"
14:31<andythenorth>Samu: your PR is 'waiting-on-author' because it fails to meet checks
14:31<andythenorth>so not much incentive for anyone to look at it :)
14:31-!-Stimrol_ [] has quit [Read error: Connection reset by peer]
14:34<Samu>I was hoping someone would do that part for me :(
14:37<Samu>we're talking about the commit message, right?
14:40-!-Stimrol [] has joined #openttd
14:40-!-Stimrol is "Stimrol" on #openttd
14:40-!-GroovyNoodle [] has joined #openttd
14:40-!-GroovyNoodle is "" on #openttd
14:49<Samu>ah, the codestyle issue
14:51<Samu>return (Money)(int)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3;
14:51<Samu>something like this?
14:51<Samu>gonna test
14:51<@planetmaker>Money and int are both types. a double cast is not needed.
14:51<@planetmaker>Just cast to Money
14:52<@planetmaker>looking at the line you quoted I actually wonder whether any cast is needed at all
14:53<Samu>GetMaintenanceCostFactor(type) is a uint16 and can't multiply with _price[PR...
14:53<Samu>unless ... it can now, brb
14:54-!-KouDy [] has joined #openttd
14:54-!-KouDy is "KouDy" on #openttd
14:57<Samu>Error (active) more than one operator "" matches these operands:
14:57<Samu>operand types are: Money * Money
14:58<Samu>return (int)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3;
14:58<Samu>this works
14:58<Samu>but is it returning Money?
14:58<Samu> /* static */ Money ScriptAirport::GetMonthlyMaintenanceCost(AirportType type)
14:58-!-sim-al2 [~sim-al2@] has joined #openttd
14:58-!-sim-al2 is "sim-al2" on #openttd
15:05<@planetmaker>well, you will want to return a Money. So can't you cast the price to Money instead?
15:06-!-sim-al2 is now known as Guest422
15:06-!-sim-al2 [~sim-al2@] has joined #openttd
15:06-!-sim-al2 is "sim-al2" on #openttd
15:06-!-Guest422 [~sim-al2@] has quit [Ping timeout: 480 seconds]
15:09<Samu>price is Money
15:09<Samu>maintenancecost factor is uint16
15:09<Samu>and Money ScriptAirport::GetMonthlyMaintenanceCost is supposed to return Money
15:10<Samu>it works
15:10<Samu>return (int)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3;
15:11<Samu>lol montly
15:11<Samu>monthly :o
15:14<@planetmaker>casting to uint16 might work mostly. But fail for higher prices. Money is the far bigger type
15:14<@planetmaker>return GetMaintenanceCostFactor(type) * (Money) (_price[PR_INFRASTRUCTURE_AIRPORT] >> 3);
15:14<@planetmaker>^^ wouldn't that work?
15:15<Samu>gonna try
15:16<Samu>it still complains about uint16 one
15:17<Samu>the error
15:19<Samu>i suppose I have 4 choices
15:19<Samu>int64, int, uint, byte
15:19<Samu>i went with int, but maybe some other is more fitting
15:24-!-Thedarkb-T60 [] has joined #openttd
15:24-!-Thedarkb-T60 is "realname" on #openttd
15:24-!-Gja [] has quit [Quit: Going offline, see ya! (]
15:46<@planetmaker>money basically is an overflow-safe uint64 iirc
15:50-!-sim-al2 [~sim-al2@] has quit [Ping timeout: 480 seconds]
16:00<Samu>return (uint)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3;
16:00<Samu>return (int)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3;
16:00<Samu>return (int64)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3;
16:00<Samu>return (byte)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3;
16:00<Samu>which one planetmaker ?
16:10-!-sla_ro|master [] has quit []
16:13-!-GroovyNoodle [] has quit [Ping timeout: 480 seconds]
16:16<@peter1138>Is that counting from 0 or 1? :D
16:24<Samu>could someone explain me the right steps to create a pull request?
16:24<Samu>i first clicked fork
16:25<Samu>SamuXarick/OpenTTD forked from OpenTTD/
16:26<Samu>This branch is even with OpenTTD:master.
16:26<Samu>do i create a branch for every pull request?
16:26<Samu>how do i create a branch :(
16:27<Samu>maybe it's not what I want
16:27<Samu>let's say, i have this patch ready
16:28<Samu>how do i create a pull request just for this patch only
16:28<Samu>imagine i have other patches for other stuff not related to the first patch
16:29<Samu>i wanted to revert back to the original state, but without affecting the pull requests
16:29<Samu>what do I need?
16:30<Samu>patch 1: airportmaintenance for scripts, patch 2: config_random bug
16:31<andythenorth>I wrote 4 hours of code yesterday
16:31<andythenorth>for something my framework already does
16:31<andythenorth>but I assumed it wouldn't be able to do
16:32<@planetmaker>call that lerning curve ;)
16:32<LordAro>Samu: switch back to master, make a new branch from there
16:32<andythenorth>planetmaker: I wouldn't mind, but I wrote the framework :P
16:33<@planetmaker>:D :D
16:33<@planetmaker>if it is any consolance: I know that feeling first-hand
16:34<Samu>a new branch
16:39<Samu>uh, i dunno how to create a new branch
16:41<Samu>Your branches You haven’t pushed any branches to this repository.
16:47-!-andythenorth is now known as Guest435
16:48-!-andythenorth [] has joined #openttd
16:48-!-andythenorth is "andythenorth" on #openttd
16:48-!-andythenorth [] has quit []
16:52-!-Guest435 [] has quit [Ping timeout: 480 seconds]
17:00<Samu> Create a new branch for this commit and start a pull request. Learn more about pull requests.
17:00<Samu>found the holy grail
17:12-!-frosch123 [] has quit [Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn]
17:17<Samu>where do I see the list of categories?
17:18<Samu>for the docker commit log dude?
17:19<Samu>the ([<section])
17:20<Samu>*** First line of message must match: '<keyword>( #<issue>| <commit>(, (<keyword> #<issue>|<commit>))*)?: ([<section])? <Details>'
17:20<Samu>where's the list of section
17:28-!-nielsm [] has quit [Quit: wroom]
17:43-!-glx [] has joined #openttd
17:43-!-mode/#openttd [+v glx] by ChanServ
17:43-!-glx is "Loïc GUILLOUX" on +#openttd
17:44<Samu>did it work?
17:44<Samu>what am i supposed to do now?
17:45<Samu>I see a SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue 6 minutes ago
17:46<Samu>too much bureoucracy
17:46<Samu>someone explain what to do now
17:51-!-Progman [] has joined #openttd
17:51-!-Progman is "Peter Henschel" on #openttdcoop #openttd
17:53<LordAro>Samu: you've made a pull request against your fork, rather than the origin
17:53<LordAro>Samu: if you go here, it'll probably tell you you've recently pushed to a branch
17:55<LordAro>however, there is also
17:56<LordAro>(github itself gives you a link when you push a new branch to a fork)
17:57-!-Wormnest [] has quit [Quit: Leaving]
17:59<Eddi|zuHause>"python removes references to 'master'/'slave'"... that is surely not going to backfire on the twitterverse
17:59<Samu>Create Pull Request?
18:00<Samu>so it's not gonna work, I assume
18:00<Samu>the docker dude
18:02<LordAro>dunno, but you've got to actually create it first to find out :p
18:02<LordAro>Eddi|zuHause: you're about a day late
18:03<Eddi|zuHause>i live in a remote corner of the internet
18:11<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick opened pull request #6902: Fix #6892: [Script] CONFIG_RANDOM range limit
18:12-!-HerzogDeXtEr [] has quit [Read error: Connection reset by peer]
18:15-!-Wolf01 [] has quit [Quit: Once again the world is quick to bury me.]
18:15<LordAro>Samu: seems to be happy with the commit :)
18:16<Samu>it's still doing something, isn't it?
18:16<LordAro>yeah, but it's actually testing the compilation now
18:16<LordAro>which i can't imagine it'll have issue with
18:17<LordAro>given it's literally +1 :p
18:19<DorpsGek_II>[OpenTTD/OpenTTD] MosheL commented on issue #6427: [Windows] RTL bug OpenTTD 1.6.0-RC1
18:19<Samu>oh, nice :)
18:25-!-Wacko1976_ [] has joined #openttd
18:25-!-Wacko1976_ is "The Chat Cool People Use" on #openttd #/r/openttd
18:28-!-Wacko1976 [] has quit [Ping timeout: 480 seconds]
18:38<DorpsGek_II>[OpenTTD/OpenTTD] spiderbit opened issue #6903: selected rail type should be included in game saves
18:50<Samu> there's something wrong with that road piece
18:54<Samu>I think a road depot was removed, and left roadbits behind
18:56<Samu>the only time the AI demolishes roads is when it wants to build a tunnel or bridge
18:56<Samu>invisible roadbits
19:02<Samu>i can't think why would the town build a road piece there, separated from the rest of the road
19:02<Samu>have to investigate
19:22<Samu>maybe it's nothing, just my imagination
19:49-!-Thedarkb-T60 [] has quit [Ping timeout: 480 seconds]
20:01-!-sim-al2 [] has joined #openttd
20:01-!-sim-al2 is "sim-al2" on #openttd
20:20-!-Progman [] has quit [Remote host closed the connection]
20:24<Eddi|zuHause>usual caveats like multiplayer apply to savegames
21:01-!-Samu [] has quit [Quit: Page closed]
21:15-!-Flygon [] has joined #openttd
21:15-!-Flygon is "Flygon" on #openttd
22:03-!-Supercheese [] has joined #openttd
22:03-!-Supercheese is "Supercheese" on #openttd
22:12-!-glx [] has quit [Quit: Bye]
22:57-!-snail_UES_ [] has joined #openttd
22:57-!-snail_UES_ is "Jacopo Coletto" on #openttd
23:03-!-snail_UES_ [] has quit [Quit: snail_UES_]
23:08-!-snail_UES_ [] has joined #openttd
23:08-!-snail_UES_ is "Jacopo Coletto" on #openttd
23:09-!-snail_UES_ [] has quit []
23:23-!-haudrauf [] has quit [Ping timeout: 480 seconds]
23:24-!-haudrauf [] has joined #openttd
23:24-!-haudrauf is "Haudrauf" on #openttd #frickelplatz @#ffod @#ffnord @#ffki @#ffhl @#ffhh @#fffl #cryptoparty @#ccchh
---Logclosed Fri Sep 14 00:00:49 2018