Back to Home / #openttd / 2018 / 10 / Prev Day | Next Day
#openttd IRC Logs for 2018-10-02

---Logopened Tue Oct 02 00:00:07 2018
00:14-!-glx [] has quit [Quit: Bye]
00:17-!-OtakuSenpai [~OtakuSenp@] has joined #openttd
00:17-!-OtakuSenpai is "OtakuSenpai" on #openttdcoop #openttd
00:24-!-Supercheese [] has quit [Remote host closed the connection]
00:25-!-Supercheese [] has joined #openttd
00:25-!-Supercheese is "Supercheese" on #openttd
00:44-!-snail_UES_ [] has quit [Quit: snail_UES_]
01:04-!-Wacko1976 [] has quit [Quit: The early bird may get the worm, but the second mouse gets the cheese]
01:18-!-rocky11384497 [~rocky1138@] has quit [Ping timeout: 480 seconds]
01:25-!-Yotson_ [] has joined #openttd
01:25-!-Yotson_ is "." on #openttd
01:28-!-Yotson [] has quit [Ping timeout: 480 seconds]
01:56-!-Wacko1976 [] has joined #openttd
01:56-!-Wacko1976 is "The Chat Cool People Use" on #openttd #/r/openttd
02:18-!-Yotson_ is now known as Yotson
02:20-!-Wacko1976 [] has quit [Ping timeout: 480 seconds]
02:57-!-andythenorth [] has joined #openttd
02:57-!-andythenorth is "andythenorth" on #openttd
03:05-!-andythenorth [] has quit [Quit: andythenorth]
03:39-!-Supercheese [] has quit [Quit: Valete omnes]
03:45-!-andythenorth [] has joined #openttd
03:45-!-andythenorth is "andythenorth" on #openttd
04:07-!-Wacko1976 [] has joined #openttd
04:07-!-Wacko1976 is "The Chat Cool People Use" on #openttd #/r/openttd
04:18-!-OtakuSenpai [~OtakuSenp@] has quit [Quit: Leaving]
04:19-!-andythenorth [] has quit [Quit: andythenorth]
04:26-!-andythenorth [] has joined #openttd
04:26-!-andythenorth is "andythenorth" on #openttd
04:35-!-andythenorth [] has left #openttd []
06:06<Eddi|zuHause>damn irc noobs, can't even wait 6 hours for a reply! :p
06:43-!-muetD [~case@] has quit [Remote host closed the connection]
07:41-!-Samu [] has joined #openttd
07:41-!-Samu is "OFTC WebIRC Client" on #openttd
07:45<Samu>i think the limit is 64k towns
07:46<Samu>because of uint16 or something like that
07:46<Samu>he wants 80k towns
07:57-!-snail_UES_ [] has joined #openttd
07:57-!-snail_UES_ is "Jacopo Coletto" on #openttd
07:58<Samu>uint16 custom_town_number; yep
08:01<Samu>typedef Pool<Town, TownID, 64, 64000> TownPool; extern TownPool _town_pool;
08:03<@peter1138>Increase the number of towns 10 fold and then wonder why OpenTTD is so slow for such an old game...
08:04<Samu>hey, i suggested 20000, he wants 80000
08:04<Samu>pool limits to 64000, i believe
08:09-!-snail_UES_ [] has quit [Quit: snail_UES_]
08:26-!-Sacro [] has quit [Remote host closed the connection]
08:34-!-Sacro [] has joined #openttd
08:34-!-Sacro is "Ben Woodward" on #tycoon #simsig #openttd
08:44<Eddi|zuHause>the bio-computerscientists always mocked the (regular) computerscientists by saying stuff like "i don't know why computer scientists are so happy about exponential computer power growth... we just simulate one atom more, and it brings it back to its knees"
08:59-!-Compu [] has joined #openttd
08:59-!-Compu is "Compu" on #help #openttd #openttdcoop.stable #openttdcoop #/r/openttd
08:59-!-Compu [] has quit []
09:08-!-tokai|noir [] has joined #openttd
09:08-!-mode/#openttd [+v tokai|noir] by ChanServ
09:08-!-tokai|noir is "Christian Rosentreter" on +#openttd
09:15-!-tokai [] has quit [Ping timeout: 480 seconds]
09:16-!-quiznilo [] has left #openttd [WeeChat 2.1]
09:37<Samu>i'm a bit lost about this, what exactly was fixed?
09:37<Samu>in r27586. Thanks for the patch! where do I ... check r27586 nowadays?
09:44<Samu>ah, found it
09:44<Samu>sucks to navigate backwards :( there should be a search here
09:48<Samu>dang, how do I edit title name?
09:48<Samu>Add: [YAPF] Use a max penalty for finding the nearest road vehicle depot
09:48<Samu>someone put a #6410 here plz
09:52<LordAro>in the PR title, there's an edit button the right
09:53<LordAro>in the commit, that's up to you
09:53<Samu>oh, oh omg i totally missed it :p
10:04-!-sla_ro|master [] has joined #openttd
10:04-!-sla_ro|master is "slamaster" on #sla #openttd
10:06-!-Alberth [] has joined #openttd
10:06-!-mode/#openttd [+o Alberth] by ChanServ
10:06-!-Alberth is "purple" on @#openttd
10:15-!-KouDy [] has quit [Read error: Connection reset by peer]
10:20<Samu>peter1138: copy the SetMaxCost() strategy * applied in YAPF for rail. I did that
10:21<Samu>copied the strategy used by rails
10:21<Samu>also because I did it for ships
10:21<Samu>road vehicles were going to be the only one without it
10:23<Samu>i can't remember exactly, but I think the automatic servicing applies this max_penatly
10:24<@Alberth>doesn't look like a question to me :)
10:24<@peter1138>Don't write random gibberish here, put it in the PR.
10:33-!-KouDy [] has joined #openttd
10:33-!-KouDy is "KouDy" on #openttd
10:35-!-Wacko1976 [] has quit [Ping timeout: 480 seconds]
10:44<Samu>don't remember what changes exactly. I think it could prevent road vehicles going back and forth when needing to service at the nearest road depot and getting out of range
10:44<Samu>at least it solved this problem for ship depots, i would assume the same would happen for road depots
10:44<Samu>would have to recheck
10:48<LordAro>Samu: put it in the pr
10:49<LordAro>things here will be forgotten
10:49<LordAro>or ignored
10:52-!-nielsm [] has joined #openttd
10:52-!-nielsm is "Niels Martin Hansen" on #openttd #tycoon
10:57<Samu>hold on a sec, i'm rechecking, will reply there with more certainty
11:13<Samu>oh, apparently it changes nothing, but makes the pathfinder quit earlier
11:13<Samu>if it goes past the max_penalty
11:13<Samu>gonna post
11:20-!-ToBeFree is "ToBeFree" on @#freiwuppertal #debian @#InfiniteAdventures
11:20-!-ToBeFree [] has joined #openttd
11:22-!-WWacko1976-work [] has quit [Ping timeout: 480 seconds]
11:33-!-Wacko1976 [] has joined #openttd
11:33-!-Wacko1976 is "The Chat Cool People Use" on #openttd #/r/openttd
11:42-!-Alberth [] has left #openttd []
11:48<Samu>damn inconsistencies
11:49-!-rocky11384497 [~rocky1138@] has joined #openttd
11:49-!-rocky11384497 is "Your Mom" on #openttd
11:52-!-acklen [] has joined #openttd
11:52-!-acklen is "Matt" on #openttd
12:00<Samu>if someone has done before what I did, why wasn't it implemented?
12:00<Samu>josep guy has done it
12:01<LordAro>because he's not a dev
12:01<LordAro>and it's not been PR'd
12:01<LordAro>why do you think?
12:02<Samu>oh :(
12:03<Samu>who's dev then?
12:03<Samu>i thought you were
12:09<Samu>I have more aircraft hangar issues patches here, but have to be extra careful now
12:10<Samu>they are part of a feature suggestion, and were implemented with that in mind :(
12:11<LordAro>i can review stuff, but i can't commit/merge anything
12:11<Samu>have to dissect my own code :|
12:13<nielsm>never write the most clever code you can come up with, because you won't be able to understand it yourself when returning to it later!
12:16<Samu>as an extra problem, i already have the feature split into smaller patches, but they're hg
12:16<Samu>have to convert from hg to svn, to apply patch, then move it into github
12:17<nielsm>or you could just skip the svn step
12:17<Samu>i dont have a git patcher
12:18<LordAro>it's a common format
12:18<LordAro>there's nothing (very) different about svn/hg/patches
12:19<nielsm>the patch format is called "unified diff" and has been standard for 20+ years
12:19<nielsm>used everywhere in software development
12:20<LordAro>there's the -p0/-p1 difference, but that's easily worked around
12:23<Samu>regular expression should help
12:23<LordAro>does that follow from anything?
12:23<Samu>replace a\ and b\ with nothing
12:23<LordAro>i guess that's one solution
12:23<nielsm>that's what the -p1 option does that LordAro just mentioned
12:23<LordAro>not a good solution
12:23<LordAro>but a solution
12:24<Samu>i dont have command line solutions :|
12:24<LordAro>besides, you want to eliminate the svn step, not ensure it
12:24<Samu>except git bash and git cmd
12:25<LordAro>that is all you need
12:25-!-Flygon [] has quit [Read error: Connection reset by peer]
12:25<Samu>I was forced to having it because of commit messages :|
12:25-!-frosch123 [] has joined #openttd
12:25-!-frosch123 is "frosch" on #openttdcoop.devzone #openttd
12:25<Samu>but it helps, I admit
12:25<LordAro>but any patching gui worth their salt will have equivalent options for pnum
12:25<LordAro>...because of commit messages?
12:26<Samu>I mean failled commit messages
12:27<LordAro>still not understanding you
12:27<LordAro>oh, you mean "forced into having git bash"
12:28<LordAro>(incidentally, it looks like sublime merge can do rebasing/amending quite nicely)
12:30<Samu>sublime merge
12:30<Samu>will take a look at it later
12:31-!-glx [] has joined #openttd
12:31-!-mode/#openttd [+v glx] by ChanServ
12:31-!-glx is "Loïc GUILLOUX" on #opendune #openttd.noai #openttd.notice +#openttd
12:34<Samu>Evaluate for free – no account, tracking, or time limits.
12:34<Samu>hmm i have a feeling this sublime merge is a trial
12:35<Samu>Sublime Merge may be downloaded and evaluated for free, however a license must be purchased for continued use. There is currently no enforced time limit for the evaluation.
12:35<Samu>no thx
12:41<LordAro>Samu: "no enforced time limit"
12:41<LordAro>it's fine
12:42<LordAro>it's basically like winrar
12:42<LordAro>it complains at you, but it doesn't actually care
12:42<LordAro>alternatively, actually try it
12:42<LordAro>you might like it enough to buy it anyway ;)
12:43-!-Gja [] has joined #openttd
12:43-!-Gja is "Martin" on #ceph #bcache #openttd
12:44-!-HerzogDeXtEr [] has joined #openttd
12:44-!-HerzogDeXtEr is "purple" on #openttd
12:49<LordAro>regardless, don't complain about the bad tooling when you refuse to use the good tooling
12:50<nielsm>agree. becoming effective at any task requires investing time into learning the tools properly
12:59-!-andythenorth [] has joined #openttd
12:59-!-andythenorth is "andythenorth" on #openttd
13:06<Samu>is there a search here? I wanna navigate to r24855
13:07<Samu>don't want to click Older Older Older till i reach it
13:07-!-Wacko1976 [] has quit [Ping timeout: 480 seconds]
13:09<SpComb>it's pretty well hidden in the top nav bar
13:09-!-Wacko1976 [] has joined #openttd
13:09-!-Wacko1976 is "The Chat Cool People Use" on #openttd #/r/openttd
13:16<Samu>my mind isn't as it used to be :(
13:17<Samu>I made this fix for a reason, but can't remember what it was for :(
13:24<LordAro>something to do with aircraft ranges, i presume
13:24<Samu>i made this to replace that code here
13:25<Samu>something to do with it not getting the correct last and next destinations somehow?
13:26<Samu>brb checking my temp savegames, I know I have something that is supposed to expose this issue
13:32-!-Wolf01 [] has joined #openttd
13:32-!-Wolf01 is "Wolf01" on #openttd
13:42<andythenorth>lo Wolf01
13:56-!-rocky11384497 [~rocky1138@] has quit [Ping timeout: 480 seconds]
13:59<Samu>aha, I remember
13:59<Samu>it's about the order of type v->current_order.IsType(OT_GOTO_DEPOT) && v->current_order.GetDepotActionType() != ODATFB_NEAREST_DEPOT
14:00<Samu> pikka savegame is ideal to expose it too
14:01<Samu>1 go to A
14:01<Samu>2 service at nearest hangar
14:01<Samu>3 go to b
14:01<Samu>4 service at nearest hangar
14:01<Samu>the issue happens when executing order 4
14:02<Samu>it goes to a hangar that would cause the distance to A to become out of range
14:05<Samu>yeah, my fix makes the "service at nearest hangar" not do exactly as it says
14:06<Samu>it will "service at the nearest hangar that is still within range of the next destination"
14:06<Samu>to avoid the "out of range"
14:07<Samu>ok, gonna submit
14:20<andythenorth>has anyone coded pantographs yet?
14:20<andythenorth>for horse?
14:20<andythenorth>or will I have to do it? :P
14:21<SpComb>electric horses?
14:25-!-Progman [] has joined #openttd
14:25-!-Progman is "Peter Henschel" on #openttdcoop #openttd
14:28<andythenorth>graphics generation
14:28<andythenorth>draw 1 pantograph, not 10
14:47-!-Wormnest [~Wormnest@] has joined #openttd
14:47-!-Wormnest is "Wormnest" on #openttd
14:47-!-Supercheese [] has joined #openttd
14:47-!-Supercheese is "Supercheese" on #openttd
14:48-!-Gja [] has quit [Quit: Going offline, see ya! (]
14:49-!-gelignite [] has joined #openttd
14:49-!-gelignite is "gelignite" on #openttd
14:50-!-NGC3982 [] has joined #openttd
14:50-!-NGC3982 is "henrik johansson" on #openttd
14:50<NGC3982>oh my!
14:50-!-NGC3982 is now known as ngc3982
15:03-!-Gja [] has joined #openttd
15:03-!-Gja is "Martin" on #ceph #bcache #openttd
15:10-!-Gja [] has quit [Read error: Connection reset by peer]
15:25-!-sla_ro|master [] has quit []
15:54<Samu>i have a solution for this but it envolves a bit of rules changing
15:56<Samu>implies a different aircraft handling behaviour
15:58<Samu>uhm, so how do I explain this
15:59<Samu>well, nvm I'll post it the best manner I can
16:13-!-andythenorth [] has quit [Quit: andythenorth]
16:17-!-andythenorth [] has joined #openttd
16:17-!-andythenorth is "andythenorth" on #openttd
16:37<Samu>bah failed hunk
16:48<Samu>is CodeChange a thing?
16:48<Samu>whe do you use CodeChange?
16:49<Samu>oh, Codechange
16:52<andythenorth>when it changes code
16:54<Samu>i'm splitting a function in 2
16:54<Samu>what is the techincal term for this?
16:54<LordAro>sounds like a codechange
16:55<Samu>ok, ty
16:55<andythenorth>such bed
16:55-!-andythenorth [] has left #openttd []
16:55-!-nielsm [] has quit [Ping timeout: 480 seconds]
16:55<Wolf01>/me too
16:56<Samu>Codechange #6493: Refactoring NeedsServicing into NeedsServicing + HasPendingReplace
16:56<Samu>good name?
16:56-!-Wolf01 [] has quit [Quit: Once again the world is quick to bury me.]
16:57<LordAro>Samu: codechange doesn't often have an issue in it
16:57<LordAro>because codechanges don't fix issues
16:57<Samu>i see, but ultimately it will be used to fix a problem
16:58<Samu>I want to call HasPendingReplace directly, and skip the first half of NeedsServicing
16:58<LordAro>will be, sure, but is not the actual fix
16:58<Samu>so, it's a fix?
16:59<Samu>oh, it's a codechange without referring which issue it will be used for?
17:00<Samu>i'm unsure how to do this, any tips?
17:01<Samu>sec, let me link
17:02<Samu> this function here
17:04<Samu>the lines from 206 to 245 are moved into HasPendingReplace
17:04<Samu>NeedsServicing will be calling HasPendingReplace afterwards, it won't change its functionality
17:05<Samu>but I am going to call HasPendingReplace directly, skipping the first half of NeedsServicing from within aircraft_cmd.cpp file
17:05<Samu>because I need to do that for helicopters that service at helipads
17:06<LordAro>codechange without referring what issue it's for
17:07<LordAro>"refactoring" as a single commit is fine, as long as it's followed up with a reason for the refactoring
17:12<Samu>commit message: In order to verify if a helicopter with service at helipad has a pending replace, I need to create a HasPendingReplace function that can be called from some aircraft_cmd.cpp functions
17:13<Samu>commit title: Codechange: Refactoring NeedsServicing into NeedsServicing + HasPendingReplace
17:15<Samu>my english
17:20<Samu>In order to verify if a helicopter with service at helipad has a pending replace, I need to call HasPendingReplace directly, as a seperate function that can be used by some aircraft_cmd.cpp functions
17:22<Samu>, it's needed to call
17:22<Samu>In order to verify if a helicopter with service at helipad has a pending replace, it's needed to call HasPendingReplace directly, as a seperate function that can be used by some aircraft_cmd.cpp functions
17:22-!-ericnoan [] has joined #openttd
17:22-!-ericnoan is "ericnoan" on #openttd #Qubes_OS #ceph #tor-project #debian-kbsd #munin #tor-dev #linode
17:25<Samu>whatever, pushed
17:29-!-gelignite [] has quit [Quit: Match found!]
17:50<Samu>The supplied credentials are invalid to login
17:50<Samu>what is this?
17:51<Samu>Jenkins failed in OS / osx-10.9
17:51<Samu>was it my fault?
17:56<LordAro>doesn't look like anything you did
17:58<Samu>visual studio doesn't complain
17:58<Samu>how could I guess
18:02-!-frosch123 [] has quit [Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn]
18:03<Samu>anyway, the good news, I don't have anything else to commit here
18:03<Samu>ready for review
18:47-!-Progman [] has quit [Remote host closed the connection]
18:58-!-tokai [] has joined #openttd
18:58-!-mode/#openttd [+v tokai] by ChanServ
18:58-!-tokai is "Christian Rosentreter" on +#openttd
19:05-!-tokai|noir [] has quit [Ping timeout: 480 seconds]
19:26-!-Thedarkb-T60 [] has joined #openttd
19:26-!-Thedarkb-T60 is "realname" on #openttd
19:32-!-Wormnest [~Wormnest@] has quit [Quit: Leaving]
19:42-!-Samu [] has quit [Quit: Page closed]
20:10-!-rocky11384497 [~rocky1138@] has joined #openttd
20:10-!-rocky11384497 is "Your Mom" on #openttd
20:11-!-Thedarkb-T60 [] has quit [Ping timeout: 480 seconds]
20:15-!-snail_UES_ [] has joined #openttd
20:15-!-snail_UES_ is "Jacopo Coletto" on #openttd
20:53-!-HerzogDeXtEr [] has quit [Read error: Connection reset by peer]
20:58-!-Supercheese [] has quit [Quit: Valete omnes]
21:22-!-WWacko1976-work [] has joined #openttd
21:22-!-WWacko1976-work is "YO!" on #openttd #/r/openttd
21:22-!-Flygon [] has joined #openttd
21:22-!-Flygon is "Flygon" on #openttd
22:35-!-snail_UES_ [] has quit [Quit: snail_UES_]
23:12-!-haudrauf [] has quit [Ping timeout: 480 seconds]
23:17-!-haudrauf [] has joined #openttd
23:17-!-haudrauf is "Haudrauf" on #openttd #frickelplatz @#ffod @#ffnord @#ffki @#ffhl @#ffhh @#fffl #cryptoparty @#ccchh
23:33-!-Wacko1976 [] has quit [Ping timeout: 480 seconds]
23:42-!-Supercheese [] has joined #openttd
23:42-!-Supercheese is "Supercheese" on #openttd
---Logclosed Wed Oct 03 00:00:09 2018