Back to Home / #openttd / 2018 / 10 / Prev Day | Next Day
#openttd IRC Logs for 2018-10-06

---Logopened Sat Oct 06 00:00:13 2018
01:15-!-sla_ro|master [~sla.ro@84.117.88.126] has joined #openttd
01:15-!-sla_ro|master is "slamaster" on #sla #openttd
01:21-!-yellyFish [~yellyfish@181-163-247-223.baf.movistar.cl] has quit [Ping timeout: 480 seconds]
03:08-!-Mahjong [~qq@2a00:23c5:6507:1a00:bd51:ba5c:3186:ae5c] has quit [Ping timeout: 480 seconds]
03:10-!-Mahjong [~qq@2a00:23c5:6507:1a00:6c41:c86f:f746:74c] has joined #openttd
03:10-!-Mahjong is "realname" on #moocows #openttd #ohnx
03:15-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has joined #openttd
03:15-!-andythenorth is "andythenorth" on #openttd
03:23<andythenorth>o/
03:48-!-Progman [~progman@p4FD66D6E.dip0.t-ipconnect.de] has joined #openttd
03:48-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttdcoop #openttd
03:54-!-sla_ro|master [~sla.ro@84.117.88.126] has quit []
04:22-!-nielsm [~nielsm@176-23-103-56-cable.dk.customer.tdc.net] has joined #openttd
04:22-!-nielsm is "Niels Martin Hansen" on #openttd #tycoon
04:58-!-Progman [~progman@p4FD66D6E.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
04:58-!-Arveen [~Arveen@pD9FD382C.dip0.t-ipconnect.de] has joined #openttd
04:58-!-Arveen is "realname" on #openttdcoop #openttd
05:03-!-Arveen2 [~Arveen@p4FEB9F78.dip0.t-ipconnect.de] has quit [Ping timeout: 480 seconds]
05:28-!-Arveen [~Arveen@pD9FD382C.dip0.t-ipconnect.de] has quit [Ping timeout: 480 seconds]
05:31-!-Samu [~oftc-webi@pa4-84-91-142-34.netvisao.pt] has joined #openttd
05:31-!-Samu is "OFTC WebIRC Client" on #openttd
05:51<Samu>hi
05:51<LordAro>o/
05:52<LordAro>Samu: are you still wondering what the regression tests are?
05:53<Samu>yes, a bit
05:53<Samu>i can't visualize it :(
05:53<Samu>can only suspect what it does
05:53<LordAro>essentially it's an AI that runs a load of stuff to check that the game is performing as expected
05:54<LordAro>things like construction & associated costs
05:54<Samu>I suspected it built a lock
05:55<LordAro>the AI (and reference files) are in bin/ai/regression
05:55-!-sla_ro|master [~sla.ro@84.117.88.126] has joined #openttd
05:55-!-sla_ro|master is "slamaster" on #sla #openttd
05:56<Samu>@calc 465070 - 461320
05:56<@DorpsGek>Samu: 3750
06:00<Samu>https://github.com/OpenTTD/OpenTTD/blob/master/bin/ai/regression/tst_regression/main.nut#L879
06:00<Samu>yeah, it built a lock
06:01<Samu>in some unknown map, dont even know
06:01<LordAro>i imagine you can just load the save up
06:01<LordAro>it'll be in that folder somewhere
06:02<Samu>empty.sav?
06:02<LordAro>maybe
06:03<Samu>it's empty! :p
06:04<LordAro>well, the AI hasn't run on it :p
06:04<LordAro>i imagine it doesn't save the game when it runs
06:05<Samu>ah, i can scroll to the tile in question
06:06<Samu>https://imgur.com/XJKi2Uo
06:06<Samu>so that's the cost of clearing land + simulated cost of building canal
06:06<Samu>which is 3750? was expecting 5000
06:06<Samu>unless easy costs
06:07<Samu>Construction costs: Low
06:07<Samu>ok
06:07<andythenorth>peter1138: should I go try this? o_O https://www.youtube.com/watch?v=c7a8XjeDRGg
06:08<Samu>3750, confirmed
06:08<Samu>so it's fine
06:08<Samu>working as I intended
06:09<Samu>https://imgur.com/o5DIpjH
06:10<Samu>then it removes lock
06:10<Samu>simulates cost of removing canal
06:10<Samu>which is also 3750
06:11<Samu>@calc 459675 - 452175
06:11<@DorpsGek>Samu: 7500
06:11<Samu>@calc 3750 + 3750
06:11<@DorpsGek>Samu: 7500
06:11<Samu>correct
06:12<Samu>my edits to results are fine then
06:15-!-frosch123 [~frosch@00013ce7.user.oftc.net] has joined #openttd
06:15-!-frosch123 is "frosch" on #openttdcoop.devzone +#openttd.dev #openttd
06:21<TrueBrain>awh, DorpsGek still doesn't rejoin channels? BOOOO
06:22<andythenorth>yo TrueBrain
06:22<LordAro>an TrueBrain
06:22<LordAro>it got netsplitted, i think
06:23<LordAro>probably thinks it's still connected
06:23<TrueBrain>yup
06:25<TrueBrain>meh, why does PyUp make N commits, instead of just one .. this looks silly
06:25<LordAro>multiple PRs too, if the old one is still there
06:25<TrueBrain>yeah ... which is a: IF YOU WERE TOO LAZY TO ACCEPT ME, I WILL DO THIS AGAIN OKAY
06:26<TrueBrain>I think it is a good nutch to say: YOU FAILED
06:26<LordAro>yup
06:27<TrueBrain>meh, enough changes that I cannot simply accept the PR .. bah, I need more free time :(
06:28<LordAro>:(
06:29<TrueBrain>wow, indeed, the per commit stuff is very .. euh .. verbose
06:31<TrueBrain>ah, because he does it one by one to a branch in the repository
06:31<TrueBrain>yeah .. that is annoying as ...
06:34-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has joined #openttd
06:34<DorpsGek_II>[OpenTTD/DorpsGek-irc] pyup-bot merged pull request #9: Initial Update https://github.com/OpenTTD/DorpsGek-irc/pull/9
06:34-!-DorpsGek_II is "Irc bot based on irc3 http://irc3.readthedocs.io" on #openttd.notice #openttd
06:34<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain pushed 1 commits to master:
06:34<DorpsGek_II> - Initial Update (#9) Update: version update of all dependencies * Update aiohttp from 3.3.2 to 3.4.4 * Update attrs from 18.1.0 to 18.2.0 * Update irc3 from 1.1.0 to 1.1.1 * Update multidict from 4.3.1 to 4.4.2 (by pyup-bot)
06:34<DorpsGek_II>https://github.com/OpenTTD/DorpsGek-irc/commit/c7f2ab30793a
06:35<TrueBrain>oops .. that commit message was not what I wanted it to be :D
06:35-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has quit [Remote host closed the connection]
06:36<LordAro>the author, or something else? there's an issue for the former :)
06:36<TrueBrain>no, I forgot how GitHub worked, so now the commit message itself is just weird ... and not by specs :D
06:36<LordAro>hehe
06:53-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has joined #openttd
06:53<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain pushed 2 commits to master:
06:53<DorpsGek_II> - Add: create pyup.io config file (#8) (by pyup-bot)
06:53<DorpsGek_II> - Update: version update of all dependencies (#9) * Update aiohttp from 3.3.2 to 3.4.4 * Update attrs from 18.1.0 to 18.2.0 * Update irc3 from 1.1.0 to 1.1.1 * Update multidict from 4.3.1 to 4.4.2 (by pyup-bot)
06:53-!-DorpsGek_II is "Irc bot based on irc3 http://irc3.readthedocs.io" on #openttd
06:53<DorpsGek_II>https://github.com/OpenTTD/DorpsGek-irc/compare/c7f2ab30793a...4a9660406ceb
06:53-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has quit [Remote host closed the connection]
06:53<TrueBrain>I might have forced-pushed some things :D
06:54<LordAro>haha
06:58<TrueBrain>right, lets see about the bugs you lovely guys created for me :)
06:59-!-DorpsGek_II_ [~DorpsGek_@home.truebrain.nl] has joined #openttd
06:59<DorpsGek_II_>[TrueBrain/Testing] TrueBrain opened pull request #2: Testing https://github.com/TrueBrain/Testing/pull/2
06:59-!-DorpsGek_II_ is "Irc bot based on irc3 http://irc3.readthedocs.io" on #openttd
06:59<TrueBrain>oops, that should not go to this channel
06:59<TrueBrain>sorry
07:04-!-DorpsGek_II_ [~DorpsGek_@home.truebrain.nl] has quit [Remote host closed the connection]
07:07-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has joined #openttd
07:07<DorpsGek_II>[OpenTTD/DorpsGek-irc] LordAro commented on issue #7: PRQ merge messages are duplicated https://github.com/OpenTTD/DorpsGek-irc/issues/7#issuecomment-427565365
07:07-!-DorpsGek_II is "Irc bot based on irc3 http://irc3.readthedocs.io" on #openttd.notice #openttd
07:07<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain pushed 2 commits to pyup-scheduled-update-2018-10-01:
07:07<DorpsGek_II> - Update: version update of all dependencies (#8) * Update aiohttp from 3.3.2 to 3.4.4 * Update attrs from 18.1.0 to 18.2.0 * Update cryptography from 2.3 to 2.3.1 * Update gidgethub from 2.5.0.post1 to 3.0.0 * Update multidict from 4.3.1 to 4.4.2 * Update pycparser from 2.18 to 2.19 (by pyup-bot)
07:07<DorpsGek_II> - Remove: now unneeded hacks for gidgethub With version 3.0.0 of gidgethub, those hacks are now upstream. (by TrueBrain)
07:07<DorpsGek_II>https://github.com/OpenTTD/DorpsGek-github/compare/5e277fa55e8b...32ebe6b7da15
07:08<DorpsGek_II>[OpenTTD/DorpsGek-github] pyup-bot updated pull request #8: Scheduled monthly dependency update for October https://github.com/OpenTTD/DorpsGek-github/pull/8
07:08<TrueBrain>this is so unreadable :D
07:08<LordAro>i already mentioned the url shortener :p
07:08<TrueBrain>guess all non-master stuff should not be notified
07:08<LordAro>but most of that is the commit message
07:09<TrueBrain>feel free to implement the URL shortener :D
07:11<DorpsGek_II>[OpenTTD/DorpsGek-github] pyup-bot merged pull request #8: Scheduled monthly dependency update for October https://github.com/OpenTTD/DorpsGek-github/pull/8
07:11<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain pushed 2 commits to master:
07:11<DorpsGek_II> - Update: version update of all dependencies (#8) * Update aiohttp from 3.3.2 to 3.4.4 * Update attrs from 18.1.0 to 18.2.0 * Update cryptography from 2.3 to 2.3.1 * Update gidgethub from 2.5.0.post1 to 3.0.0 * Update multidict from 4.3.1 to 4.4.2 * Update pycparser from 2.18 to 2.19 (by pyup-bot)
07:11<DorpsGek_II> - Remove: now unneeded hacks for gidgethub With version 3.0.0 of gidgethub, those hacks are now upstream. (by TrueBrain)
07:11<DorpsGek_II>https://github.com/OpenTTD/DorpsGek-github/compare/718fab3cafda...757a6c32c739
07:11<TrueBrain>the wrong user is funny :)
07:12<TrueBrain>okay, so the commit message should change to only the first line
07:12<TrueBrain>not anything after that
07:12<TrueBrain>how does that work out for the translation commits
07:13<LordAro>some would argue better than it previously did :p
07:14<DorpsGek_II>[OpenTTD/DorpsGek-runner] pyup-bot merged pull request #7: Scheduled monthly dependency update for October https://github.com/OpenTTD/DorpsGek-runner/pull/7
07:14<DorpsGek_II>[OpenTTD/DorpsGek-runner] TrueBrain pushed 1 commits to master:
07:14<DorpsGek_II> - Update: version update of all dependencies (#7) * Update aiohttp from 3.3.2 to 3.4.4 * Update attrs from 18.1.0 to 18.2.0 * Update multidict from 4.3.1 to 4.4.2 (by pyup-bot)
07:14<DorpsGek_II>https://github.com/OpenTTD/DorpsGek-runner/commit/11aedf3c8206
07:14<TrueBrain>as they are not announced? :P
07:16<TrueBrain>why are they not .. .hmmmm
07:18<TrueBrain>I really do not know why they are not announced ..
07:20<andythenorth>oof
07:22*andythenorth brain ache from sprite generation
07:29-!-HerzogDeXtEr [~farci@dslb-178-000-245-235.178.000.pools.vodafone-ip.de] has joined #openttd
07:29-!-HerzogDeXtEr is "purple" on #openttd
07:31<LordAro>TrueBrain: i'm actually putting together a url shortener thing
07:31<LordAro>it's not actually too difficult
07:31<LordAro>aiohttp's documentation is reasonably nice
07:32<TrueBrain>\o/
07:32<TrueBrain>and I believe the github url shortner was also pretty nice
07:37-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has joined #openttd
07:37-!-Wolf01 is "Wolf01" on #openttd
07:37<Wolf01>o/
07:37<Wolf01>I forgot to run mirc :P
07:39<Wolf01>andythenorth: you asked what didn't work with rebase, I don't know, I'm just not used to it and with merge I feel I can do things better
07:40<DorpsGek_II>[OpenTTD/DorpsGek-irc] LordAro opened pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10
07:40<LordAro>completely untested, of course
07:40<LordAro>but that's what the CI is for!
07:42<Wolf01>https://www.youtube.com/watch?v=ZWQ0591PAxM mmmmh sprite composition, 50MB grf to 20KB! Fuck the 16GB of ram (+3GB video ones) 640KB are enough for everyone
07:43<TrueBrain>LordAro: I love how easy coroutines make adding this stuff in :)
07:44<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain opened pull request #9: Add: allow filtering for which branch push notifications work https://github.com/OpenTTD/DorpsGek-github/pull/9
07:44<TrueBrain>right, that commit should reduce the pyup spam
07:46<DorpsGek_II>[OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10
07:48<TrueBrain>guess I should test it first :)
07:48<LordAro>probably
07:50<TrueBrain>doesnt
07:50<TrueBrain>even
07:50<TrueBrain>run
07:50<Wolf01>:D
07:50<LordAro>:D
07:50<LordAro>but it passed CI!
07:51<TrueBrain>yeah .. guess CI doesnt run the code :P
07:51<TrueBrain>(I think it only builds the docker and runs flake tbh)
07:51<LordAro>did i make too many assumptions about what a ws is?
07:51<TrueBrain>no, it is a syntax error :)
07:51<TrueBrain>"async with" is not valid Python :)
07:51<LordAro>nice.
07:52<TrueBrain>you didnt make the function a coroutine :)
07:52<LordAro>wait, what
07:52<LordAro>oh
07:52<LordAro>tbf, this is the first time i've ever tried to use python coroutines :p
07:52<LordAro>s/use/write my own/
07:52<TrueBrain>async in front of the function
07:53<TrueBrain>await all usages
07:53<TrueBrain>the last return in your function can be removed
07:53<TrueBrain>(as it will never be executed)
07:53<LordAro>so when you say how easy coroutines make this stuff... :p
07:53<TrueBrain>I mean you at least have to read the "n00b guide to coroutines" :P
07:54<DorpsGek_II>[OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10
07:54<TrueBrain>ws.get doesn't exist either
07:55<TrueBrain>ws is the websocket
07:55<TrueBrain>so yeah, you cannot make another call with that
07:55<LordAro>damn
07:55<TrueBrain>you can however just use aiohttp to make a new one
07:55<LordAro>ok, i retract my previous comments about aiohttp's documentation :p
07:55<TrueBrain>well, this is not really aiohttp to blame .. 'ws' is just the WebSocket object
07:56<TrueBrain>I don't pass the session object along
07:57<LordAro>i did wonder whether i was following the code correctly
07:57<LordAro>ah well
07:57<TrueBrain>ws .. websocket .. guess it somewhat makes sense :D
07:59<DorpsGek_II>[OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10
07:59<LordAro>take 4...
08:00<TrueBrain>no clue how smart aiohttp is with session recycling .. I hope sufficient :D
08:00<LordAro>i can't imagine it's expensive
08:02<TrueBrain>response code is 200 it seems?
08:02<TrueBrain>did you test the function at least?
08:02<TrueBrain>its returning 200
08:02<LordAro>curl returns a 201...
08:03<TrueBrain>(python3; import url; await shorten(...)
08:03<TrueBrain>Sorry yo, that's an invalid URL
08:03<TrueBrain>is what it is yelling
08:04<TrueBrain>the CI is failing ... it shouldnt pass this :D
08:05<TrueBrain>it continues if flake8 fails :D
08:05<TrueBrain>hahaha
08:05<TrueBrain>oops :D
08:08<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain opened pull request #11: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-irc/pull/11
08:09<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain updated pull request #11: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-irc/pull/11
08:09<TrueBrain>good, that works now :)
08:09<LordAro>:)
08:11<Eddi|zuHause>what's better than "the CI apparently doesn't run the code"? "the CI runs the code, but ignores the result" :p
08:11<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain opened pull request #10: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-github/pull/10
08:12<DorpsGek_II>[OpenTTD/DorpsGek-runner] TrueBrain opened pull request #8: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-runner/pull/8
08:12<TrueBrain>think of it this way: at least it was consistent
08:13<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain merged pull request #11: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-irc/pull/11
08:13<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain pushed 1 commits to master:
08:13<DorpsGek_II> - Fix: fail the CI if flake8 fails (#11) Without 'set -e', an non-zero exit code from flake8 is simply ignored and test.sh continues. With 'set -e' it abort on the first non-zero exit code. (by TrueBrain)
08:13<DorpsGek_II>https://github.com/OpenTTD/DorpsGek-irc/commit/95048f7a2680
08:13<TrueBrain>yeah, I think we just have to mute the 'push' if there was a 'pr merge' of the same
08:13<TrueBrain>it doesnt add any value
08:14-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has quit [Remote host closed the connection]
08:14<Eddi|zuHause>can there be pushes without a PR?
08:14<TrueBrain>yes
08:14<TrueBrain>translator for example
08:15-!-DorpsGek_II_ [~DorpsGek_@spam.openttd.org] has joined #openttd
08:15<DorpsGek_II_>[OpenTTD/DorpsGek-github] TrueBrain updated pull request #10: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-github/pull/10
08:15-!-DorpsGek_II_ is "Irc bot based on irc3 http://irc3.readthedocs.io" on #openttd.notice #openttd
08:16-!-DorpsGek_II_ is now known as DorpsGek_II
08:19<TrueBrain>can any of you make a pull request for https://github.com/TrueBrain/Testing ?
08:19<TrueBrain>I need another username to test this username bug :D
08:20<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain merged pull request #10: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-github/pull/10
08:20<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain pushed 1 commits to master:
08:20<DorpsGek_II> - Fix: fail the CI if flake8 fails (#10) Without 'set -e', an non-zero exit code from flake8 is simply ignored and test.sh continues. With 'set -e' it abort on the first non-zero exit code. (by TrueBrain)
08:20<DorpsGek_II>https://github.com/OpenTTD/DorpsGek-github/commit/029ca44d5048
08:20<nielsm>made one
08:21<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain updated pull request #9: Add: allow filtering for which branch push notifications work https://github.com/OpenTTD/DorpsGek-github/pull/9
08:21<DorpsGek_II>[OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10
08:21<LordAro>LOUD NOISES
08:22<TrueBrain>tnx nielsm :)
08:24<TrueBrain>LordAro: that PR still doesnt work btw
08:24<DorpsGek_II>[OpenTTD/DorpsGek-runner] TrueBrain merged pull request #8: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-runner/pull/8
08:24<DorpsGek_II>[OpenTTD/DorpsGek-runner] TrueBrain pushed 1 commits to master:
08:24<DorpsGek_II> - Fix: fail the CI if flake8 fails (#8) Without 'set -e', an non-zero exit code from flake8 is simply ignored and test.sh continues. With 'set -e' it abort on the first non-zero exit code. (by TrueBrain)
08:24<DorpsGek_II>https://github.com/OpenTTD/DorpsGek-runner/commit/fd0f5c49a5d0
08:25<TrueBrain>and tnx for the reviews :)
08:27<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain opened issue #11: Wrong user in most actions https://github.com/OpenTTD/DorpsGek-github/issues/11
08:27<LordAro>TrueBrain: fine i'll actually install aiohttp locally
08:27<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain commented on issue #5: Wrong data used for merge and close notifications https://github.com/OpenTTD/DorpsGek-irc/issues/5#issuecomment-427569865
08:27<DorpsGek_II>[OpenTTD/DorpsGek-irc] glx22 closed issue #5: Wrong data used for merge and close notifications https://github.com/OpenTTD/DorpsGek-irc/issues/5
08:28<LordAro>^ nicely demonstrating the error :p
08:29<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain opened pull request #12: Fix #11: always use the 'sender' to notify who made the change https://github.com/OpenTTD/DorpsGek-github/pull/12
08:30<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain merged pull request #9: Add: allow filtering for which branch push notifications work https://github.com/OpenTTD/DorpsGek-github/pull/9
08:30<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain pushed 1 commits to master:
08:30<DorpsGek_II> - Add: allow filtering for which branch push notifications work (#9) Pyup for example creates a branch in the repository. Pushes to these branches don't have to be announced. (by TrueBrain)
08:30<DorpsGek_II>https://github.com/OpenTTD/DorpsGek-github/commit/7d589bdb6da5
08:31<LordAro>TrueBrain: incidentally, "SyntaxError: 'await' outside function"
08:31<TrueBrain>sorry?
08:32<TrueBrain>so okay, 'sender' seems to be mostly the correct one, unless an App or something triggered the event
08:32<TrueBrain>so we will have to experiment with it a bit, see how we like it
08:33<LordAro>TrueBrain: i can't run "await url.shorten(foobar)", results in that error
08:33<LordAro>and google is being unhelpful in finding a way around it
08:34<TrueBrain>owh, shit, ofc :(
08:34<TrueBrain>you need an asyncio context
08:34<TrueBrain>euuhhh
08:34<TrueBrain>this is a tiny bit more difficult
08:35<TrueBrain>I believe: asyncio.run(func())
08:35<LordAro>that's it, thanks
08:35<TrueBrain>\o/
08:36<TrueBrain>meh, the push payload doesn't indicate if it was triggered by a PR merge
08:37<LordAro>mm, i didn't think so
08:38<TrueBrain>in all my tests, the push always came after the PR
08:38<TrueBrain>but not sure if that is a guarantee or something
08:41<DorpsGek_II>[OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10
08:41<LordAro>ok, it actually works now
08:41<LordAro>promise
08:41<TrueBrain>:D
08:42<TrueBrain>and so it does :P
08:43<LordAro>bad quotes? where did those come from?
08:43<DorpsGek_II>[OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10
08:43<TrueBrain>post vs get, lol
08:43<LordAro>shhhh
08:44<TrueBrain>you moved a ' out of a ", so yeah :)
08:44<LordAro>i did not read curl's documentation closely enough
08:45<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain opened issue #13: Pull Request merge and push give duplicated information https://github.com/OpenTTD/DorpsGek-github/issues/13
08:45<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain commented on issue #7: PRQ merge messages are duplicated https://github.com/OpenTTD/DorpsGek-irc/issues/7#issuecomment-427570868
08:45<DorpsGek_II>[OpenTTD/DorpsGek-irc] LordAro closed issue #7: PRQ merge messages are duplicated https://github.com/OpenTTD/DorpsGek-irc/issues/7
08:46<LordAro>i wonder if it might be easier to solve from the irc side
08:46<LordAro>given that can cache messages (assuming push comes after merge)
08:47<Eddi|zuHause>user on "ticket closed" message still wrong
08:47<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain opened pull request #14: Fix #13: deduplicate pull request merge and push information https://github.com/OpenTTD/DorpsGek-github/pull/14
08:47<TrueBrain>Eddi|zuHause: yes, it requires a review ;)
08:47<TrueBrain>LordAro: the line between IRC and Github is a bit thin :) But I try to have most of the logic in Github for now
08:48<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain merged pull request #12: Fix #11: always use the 'sender' to notify who made the change https://github.com/OpenTTD/DorpsGek-github/pull/12
08:48<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain closed issue #11: Wrong user in most actions https://github.com/OpenTTD/DorpsGek-github/issues/11
08:49<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain merged pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10
08:50<Eddi|zuHause>i believe glx once made a ticket about the wrong user thing, but i don't know which repo he made the ticket against
08:50<LordAro>Eddi|zuHause: scroll further up
08:50-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has quit [Quit: andythenorth]
08:50-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has quit [Remote host closed the connection]
08:50<LordAro>13:27
08:50<LordAro>though it is a little tricky to see
08:50<TrueBrain>so much spam! :P
08:50-!-KouDy [~koudy@ip4-83-240-28-102.cust.nbox.cz] has quit [Read error: Connection reset by peer]
08:52<Eddi|zuHause>to be frank, it's a little intransparent which repo actually does what
08:52-!-KouDy [~koudy@ip4-83-240-28-102.cust.nbox.cz] has joined #openttd
08:52-!-KouDy is "KouDy" on #openttd
08:53<TrueBrain>the IRC repo only puts the notification on IRC
08:53<TrueBrain>it can easily be replaced with Slack, Discord, etc
08:53<TrueBrain>so there is no logic in there, just a gateway
08:54<LordAro>i do wonder if it would be better just to merge the repos
08:54<TrueBrain>the bugs like: wrong sender, etc, would be true for any of them
08:54<TrueBrain>if there would be a Slack or Discord version, it would make a lot more sense :)
08:54<TrueBrain>(and I still hope some day OpenTTD moves away from IRC :P)
08:55<LordAro>heathen
08:55<TrueBrain>LordAro: I cannot find documentation what merge_commit_sha is/does
08:55<TrueBrain>I was hoping it would be what I thought it was
08:55<Eddi|zuHause>i'm going to postulate that IRC will outlive those two things :p
08:55<LordAro>TrueBrain: sounds like Truebrain/Testing needs some use :p
08:56<TrueBrain>LordAro: fair point
08:56-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has joined #openttd
08:56-!-DorpsGek_II is "Irc bot based on irc3 http://irc3.readthedocs.io" on #openttd
08:56<DorpsGek_II>[OpenTTD/DorpsGek-github] LordAro commented on pull request #14: Fix #13: deduplicate pull request merge and push information https://git.io/fx39J
08:56<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain commented on issue #7: PRQ merge messages are duplicated https://git.io/fx39U
08:56-!-iSoSyS [~iSoSyS@2001:8a0:e960:de00:a47c:3151:4869:3899] has joined #openttd
08:56-!-iSoSyS is "realname" on #/r/openttd #openttd
08:56<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain commented on pull request #14: Fix #13: deduplicate pull request merge and push information https://git.io/fx39c
08:56<TrueBrain>something got stuck in a queue :D
08:56<LordAro>dem short urls
08:58<Eddi|zuHause>"Banksy painting spontaneously self-destructs after auction"... from "the outside" that sounds incredibly funny :p
08:58<TrueBrain>LordAro: tested both squash and rebase; does what I expect it to do :)
08:59<LordAro>nice.
08:59<LordAro>let's give it a go then
08:59<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain commented on pull request #14: Fix #13: deduplicate pull request merge and push information https://git.io/fx39z
08:59<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain merged pull request #14: Fix #13: deduplicate pull request merge and push information https://git.io/fx39g
08:59<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain closed issue #13: Pull Request merge and push give duplicated information https://git.io/fx392
08:59<TrueBrain>it is a lot better tbfh :P
09:00<LordAro>wait, why has it stopped reporting pushes on the DorpsGek-* repos?
09:00<LordAro>before you merged that
09:00<TrueBrain>because it was being deployed :)
09:01<TrueBrain>so after the pull request, it started to deploy, and the push even is never received :P
09:01<TrueBrain>ITS CHEATING :D
09:01<LordAro>and it does that silently, because it's not the irc component that was restarted
09:01<LordAro>nice
09:01<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain commented on issue #15: No message for reviews https://git.io/fx39w
09:01<TrueBrain>yup
09:02<TrueBrain>and because it is rare enough, I did not write code to capture the events and play them whenthe bot comes back online
09:02<TrueBrain>read: I was too lazy
09:02<LordAro>:)
09:07<TrueBrain>sorry for the spam nielsm :) But it is appreciated :D
09:14<LordAro>at what point do we start looking at OTTD again? :p
09:15<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain opened pull request #16: Add #15: support notifications about pull-request-review https://git.io/fx3HU
09:15<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain opened pull request #12: Add: handle the new pull_request_review actions https://git.io/fx3HT
09:17<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain opened pull request #17: Fix: don't shorten 'push' URLs https://git.io/fx3Hq
09:20<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain opened pull request #13: Fix: ignore activity on pyup- branches https://git.io/fx3Hn
09:20<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain opened pull request #18: Fix: ignore activity on pyup- branches https://git.io/fx3HC
09:20<DorpsGek_II>[OpenTTD/DorpsGek-runner] TrueBrain opened pull request #9: Dorpsgek pyup https://git.io/fx3H4
09:21<DorpsGek_II>[OpenTTD/DorpsGek-runner] TrueBrain updated pull request #9: Dorpsgek pyup https://git.io/fx3H4
09:21<TrueBrain>LordAro: it is a regex, yes; that is why it is a *?
09:22<LordAro>but that just matches any number of -
09:22<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain updated pull request #12: Add: handle the new pull_request_review actions https://git.io/fx3HT
09:22<LordAro>should be .*
09:22<TrueBrain>hmm
09:23<TrueBrain>good point :D
09:23<DorpsGek_II>[OpenTTD/DorpsGek-runner] TrueBrain updated pull request #9: Fix: ignore activity on pyup- branches https://git.io/fx3H4
09:23<LordAro>i imagine it wouldn't make a difference in practice, it's not matching the whole line, but...
09:23<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain updated pull request #18: Fix: ignore activity on pyup- branches https://git.io/fx3HC
09:23<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain updated pull request #13: Fix: ignore activity on pyup- branches https://git.io/fx3Hn
09:25<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain opened issue #14: After net-split, the bot doesn't rejoin channels https://git.io/fx3Ho
09:28<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain closed issue #6913: Request: support Discord's Rich Presence API https://git.io/fx3Hy
09:28<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on issue #6913: Request: support Discord's Rich Presence API https://git.io/fx3HS
09:28<TrueBrain>closed + commented have similar issues I see :)
09:28<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on issue #6916: Re-implement building binaries via compile farm https://git.io/fx3H9
09:29-!-gelignite [~gelignite@55d4b5f2.access.ecotel.net] has joined #openttd
09:29-!-gelignite is "gelignite" on #openttd
09:29<TrueBrain>that Discord issue :) Hihi
09:30<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain merged pull request #12: Add: handle the new pull_request_review actions https://git.io/fx3HT
09:31-!-sim-al2 [~sim-al2@c-75-65-196-171.hsd1.tn.comcast.net] has quit [Ping timeout: 480 seconds]
09:31-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has quit [Remote host closed the connection]
09:32-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has joined #openttd
09:32-!-DorpsGek_II is "Irc bot based on irc3 http://irc3.readthedocs.io" on #openttd
09:32<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain merged pull request #16: Add #15: support notifications about pull-request-review https://git.io/fx3HU
09:33<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain closed issue #15: No message for reviews https://git.io/fx3Qe
09:35<DorpsGek_II>[OpenTTD/DorpsGek-runner] TrueBrain merged pull request #9: Fix: ignore activity on pyup- branches https://git.io/fx3H4
09:35<TrueBrain>HA! No more push spam :)
09:35<DorpsGek_II>[OpenTTD/DorpsGek-irc] TrueBrain merged pull request #13: Fix: ignore activity on pyup- branches https://git.io/fx3Hn
09:36<TrueBrain>tnx for all the reviews LordAro :)
09:36-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has quit [Remote host closed the connection]
09:36-!-DorpsGek_II [~DorpsGek_@spam.openttd.org] has joined #openttd
09:36-!-DorpsGek_II is "Irc bot based on irc3 http://irc3.readthedocs.io" on #openttd
09:36<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain merged pull request #18: Fix: ignore activity on pyup- branches https://git.io/fx3HC
09:37<TrueBrain>owh, one more left to review :P
09:37<TrueBrain>means we can see if that also works now :D
09:58<DorpsGek_II>[OpenTTD/DorpsGek-github] LordAro approved pull request #17: Fix: don't shorten 'push' URLs https://git.io/fx3Qh
09:58<TrueBrain>\o/
09:58<LordAro>\o/
09:58<DorpsGek_II>[OpenTTD/DorpsGek-github] TrueBrain merged pull request #17: Fix: don't shorten 'push' URLs https://git.io/fx3Hq
09:59<TrueBrain>and look, even the names are correct :D
10:00<LordAro>well, the PR was also yours
10:00<LordAro>haven't fully checked that yet ;)
10:00<TrueBrain>I meant the approval :)
10:00<LordAro>yeah, that works
10:00<LordAro>don't know about the merge messages though :p
10:01<TrueBrain>time will tell :D
10:07-!-Progman [~progman@p4FD66D6E.dip0.t-ipconnect.de] has joined #openttd
10:07-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttdcoop #openttd
10:30-!-Wormnest [~Wormnest@35.136.176.177] has joined #openttd
10:30-!-Wormnest is "Wormnest" on #openttd
10:33<Eddi|zuHause>about the discord thing, i think the counter-suggestion was to try that via an admin port library
10:34<TrueBrain>go for it! :)
10:34<TrueBrain>:D
10:34<Eddi|zuHause>i don't think so :p
10:35<TrueBrain>exactly ;)
10:36-!-Gja [~Martin@93-167-84-102-static.dk.customer.tdc.net] has joined #openttd
10:36-!-Gja is "Martin" on #ceph #bcache #openttd
10:38-!-haudrauf [~haudrauf2@00021656.user.oftc.net] has quit [Ping timeout: 480 seconds]
10:39-!-haudrauf [~haudrauf2@p200300C35F3463003B674CEFCA796FDA.dip0.t-ipconnect.de] has joined #openttd
10:39-!-haudrauf is "Haudrauf" on #openttd #frickelplatz @#ffod @#ffnord @#ffki @#ffhl @#ffhh @#fffl #cryptoparty @#ccchh @#ccc.do
10:44<Samu>a patch for helping AI's https://www.tt-forums.net/viewtopic.php?f=33&t=75216&hilit=patch
10:44<Samu>i'm undecided
10:44<Samu>juanjo approach or my approach?
10:45<Eddi|zuHause>so, what's actually the holdup with nightly builds?
10:46<Samu>my approach feels incomplete in regards to industry tiles on water
10:46<Samu>it isn't done
10:46<LordAro>Eddi|zuHause: windows, i think
10:47<Samu>juanjo approach is kinda... too global, some situations could be excused
10:52<Samu>oh, right, object tiles on water, i haven't done that either
10:55<Samu>removing stuff shouldn't care if a ship is nearby
10:55<Samu>changing rail signals shouldn't care if a ship is nearby
10:56<Samu>hmm, i'm torn apart
10:56<LordAro>you wouldn't have thought so
10:57<Samu>i think that's what juanjo's approach is doing, it's too global
11:15<Samu>juanjo's approach has one advantage, it's much simpler, it's just that it can't be applied inside EnsureNoVehicleOnGround
11:16<Samu>must think
11:17<Samu>calls all ships and see if they're coming into "collision" route towards the tile we're working on
11:18<Samu>my approach is too manual, case by case
11:19<Samu>doesn't call all ships, it only checks for ships on the nearby tiles
11:20<Samu>what's supposedly faster?
11:20<@peter1138>Who even knows what you are doing.
11:21<Samu>check if there's a ship in 4 tiles, or check from all ships if one is coming into collision with the tile we're working on?
11:21-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has joined #openttd
11:21-!-andythenorth is "andythenorth" on #openttd
11:21<Samu>we're trying to make ships avoid deadlocks
11:23<andythenorth>do ships deadlock often? o_O
11:23<Samu>well, in AI games they do happen quite often
11:24<andythenorth>ok
11:25<Samu>i remember NoCAB, especially, would built docks in such a manner that it could make a ship become trapped between two docks, in a single tile, no means to change its route, it's stuck
11:25<Samu>going forward is dock 1, going backwards, is dock 2, stuck
11:26<Samu>and I think OtviAI was also suffering similarly, with ship depots
11:27<Samu>for human games, this is pratically a non-issue
11:27<Samu>if someone locks a ship, it's like 99% to be on purpose
11:28<andythenorth>are you trying to fix it in AI?
11:28<LordAro>doesn't sound like it
11:28<Samu>no
11:29<andythenorth>oof
11:29<andythenorth>sounds like poor AI design, but I'll leave it
11:29<LordAro>perhaps the solution is to check for adequate space when constructing the dock/depot
11:29<LordAro>doesn't help if you alter the water though
11:31<Samu>i could try make this work exclusively for AI
11:32<Samu>have seen some similar exclusivity work on BuildRoad stuff, could try mimic that
11:33<Samu>there is a 0,0000001% chance of an industry spawning on water to lock a ship
11:33<Samu>i saw some report on flyspray years ago
11:34<Samu>couldn't find it now
11:36-!-Flygon [~Flygon@106-68-83-162.dyn.iinet.net.au] has quit [Remote host closed the connection]
11:38-!-iSoSyS [~iSoSyS@2001:8a0:e960:de00:a47c:3151:4869:3899] has quit [Ping timeout: 480 seconds]
11:40<Samu>are you still planning to remove 90 degrees for ships?
11:42-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has quit [Quit: andythenorth]
11:45-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has joined #openttd
11:45-!-andythenorth is "andythenorth" on #openttd
11:46<Samu>https://imgur.com/B9GKm0S
11:46<Samu>there must be no ship coming from that direction when the oil rig is placed there
11:47<Samu>all those directions*
11:48<Samu>How am I gonna do this
11:48<Samu>the industry builder places tiles 1 by 1 :(
11:48-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has quit []
12:12-!-Wormnest [~Wormnest@35.136.176.177] has quit [Quit: Leaving]
12:13-!-Gja [~Martin@93-167-84-102-static.dk.customer.tdc.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
12:19-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has joined #openttd
12:19-!-andythenorth is "andythenorth" on #openttd
12:40<Samu>gonna pick up juanjo's work, and try to make it a bit more specialized
12:49-!-gelignite [~gelignite@55d4b5f2.access.ecotel.net] has quit [Quit: Match found!]
12:49-!-synchris [~synchris@139.138.202.72] has joined #openttd
12:49-!-synchris is "Synesios Christou" on #openttd
13:32-!-wodencafe [~cboyd@cpe-66-25-7-231.tx.res.rr.com] has joined #openttd
13:32-!-wodencafe is "Woden Cafe" on #432 #openttd #oftc #moocows
13:33<andythenorth>this is nearly a whole day's work :P
13:33<andythenorth>https://dev.openttdcoop.org/attachments/download/9152/roarer_pantographs.png
13:33<andythenorth>I blame Eddi
13:33<andythenorth>but it's nearly done
13:37-!-Thedarkb-T60 [~Thedarkb-@86-45-41-156-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
13:37-!-Thedarkb-T60 is "realname" on #openttd
13:41-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has joined #openttd
13:41-!-snail_UES_ is "Jacopo Coletto" on #openttd
13:46<Samu>who's a network expert
13:47<Samu>how would I test for desyncs?
13:53-!-yellyFish [~yellyfish@181-163-247-223.baf.movistar.cl] has joined #openttd
13:53-!-yellyFish is "yellyfish" on #openttd
13:54<Samu>hmmm nah... juanjo approach is bad
13:55<Samu>really have to do this case by case... boring
13:58-!-Code [~oftc-webi@p5DD63D87.dip0.t-ipconnect.de] has joined #openttd
13:58-!-Code is "OFTC WebIRC Client" on #openttd
13:58<Code>IDENTIFY
13:58-!-Code is now known as Guest725
13:59<Guest725>sad
13:59<Guest725>FUDGE
13:59-!-Guest725 [~oftc-webi@p5DD63D87.dip0.t-ipconnect.de] has quit []
13:59<LordAro>rip
14:00-!-yellyFish [~yellyfish@181-163-247-223.baf.movistar.cl] has quit []
14:02-!-Thedarkb-T60 [~Thedarkb-@86-45-41-156-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
14:04<Eddi|zuHause>andythenorth: except, the pantographs should be mirror images
14:05<andythenorth>yes that will come
14:05-!-Thedarkb-T60 [~Thedarkb-@86-45-41-156-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
14:05-!-Thedarkb-T60 is "realname" on #openttd
14:05<andythenorth>that's just needs some indices swapping
14:07-!-gelignite [~gelignite@55d4b5f2.access.ecotel.net] has joined #openttd
14:07-!-gelignite is "gelignite" on #openttd
14:13-!-stefino [~oftc-webi@gw-lipa-silo-1.cust.avonet.cz] has joined #openttd
14:13-!-stefino is "OFTC WebIRC Client" on #openttd
14:17<stefino>hello, Is possible to code industry what can be build only manualy? For example hotels. I could build them manualy and they will be not generated automaticly when the map is create.
14:17<Eddi|zuHause>yes
14:17<Eddi|zuHause>the default game has the tropic sawmill that can only be built manually
14:18<Eddi|zuHause>it's also really simple to do, just set the appearance chance to 0
14:19<andythenorth>oof buy menu offsets have to be different for pantographs
14:19<andythenorth>this is getting nuanced
14:20<Eddi|zuHause>just make a separate buy menu sprite without composition
14:20<andythenorth>well
14:20<andythenorth>that kind of defeats the point :P
14:20-!-Wacko1976 [~IceChat9@027-161-128-083.dynamic.caiway.nl] has joined #openttd
14:20-!-Wacko1976 is "The Chat Cool People Use" on #openttd #/r/openttd
14:20<Eddi|zuHause>why?
14:21<andythenorth>then I have just 2 sets of pantograph sprites, except where I've copied them into every purchase menu sprite
14:21<stefino>ahh, thank s a lot. we have an idea to make some objects to reduce the cash, in case you have a lot of money. So I have idea to code some industry - for example schools, hospitals etc, what will be more expensive (you will reduce cash) and it gives to you some bonus(pass production ets)
14:21<andythenorth>also I don't generally have purchase menu sprites
14:21<andythenorth>I just use sprite 6 or so
14:22<andythenorth>at this point I might as well figure out the maths for 2 more offset adjustments, then it's done
14:22<Eddi|zuHause>andythenorth: them file an issue that you want the offsets to be the same, potentially breaking some existing grfs :p
14:22<andythenorth>do you think we'd accept that PR :)
14:23<Eddi|zuHause>i don't know
14:23<andythenorth>I suspect the problem originates with me, because I center the sprites in purchase menu
14:23<Eddi|zuHause>possibly
14:23<andythenorth>not sure why the yoffs is off by one pixel
14:23<andythenorth>but the xoffs discrepancy is almost certainly my doing
14:24<Eddi|zuHause>the xoffs may be some inherited issue
14:24<Eddi|zuHause>where the bottom part of the sprite gets cut off or something
14:25<andythenorth>-${int(consist.buy_menu_width / 2)}
14:25<andythenorth>suggests the cause of the xoffs
14:25<Eddi|zuHause>andythenorth: i don't know how the compositing works exactly, but ideally you would make that adjustment after the composition
14:26<Eddi|zuHause>so the relative positions of the subsprite stay the same
14:26<andythenorth>each layer resolves to a spriteset
14:26<Eddi|zuHause>or you have to duplicate the calculation everywhere
14:26<andythenorth>I have to duplicate the calculation everywhere
14:27<andythenorth>interestingly, Horse buy menu rows are taller than default base set
14:27<andythenorth>the actual UI row
14:27<Eddi|zuHause>the ui scales to sprite sizes
14:27<andythenorth>28px vs 34px or so
14:28<andythenorth>so I am pushing sprites down further to compensate
14:28<andythenorth>which explains the yoffs discrepancy I think
14:28<Eddi|zuHause>28px does not sound like a height
14:28<Eddi|zuHause>(assuming 1x zoom)
14:29<andythenorth>it might be off by a couple, I used a screen ruler
14:30<Eddi|zuHause>but if just one buy menu sprite across all your loaded GRFs is taller than default, it's going to rescale
14:34<stefino>an how many cargo labels can I use in one inustry GRF?
14:34<stefino>my friend said that only 32?
14:43<andythenorth>https://github.com/OpenTTD/OpenTTD/pull/6802
14:44<andythenorth>stefino: ^
14:44<andythenorth>there is no stable release with that yet
14:44<andythenorth>so it's a design choice whether you use 32 or 64
14:44<andythenorth>and you'll have to compile your own OpenTTD to test the grf
14:45<andythenorth>you should also see https://github.com/OpenTTD/OpenTTD/pull/6867
14:45<andythenorth>which may or may not be approved
14:46<Samu>I have a question, how do i iterate over all ships located on a tile?
14:47<Samu>CommandCost ret = EnsureNoShipOnWater(tile); is insufficient
14:47<Samu>there could be more than 1 ship
14:47<stefino>thanks Andy
14:48<andythenorth>I am working on FIRS v4 with up to 64 cargos, and 16 in / 16 out per industry
14:48<andythenorth>I am hoping the second PR gets approved
14:51<Samu> * When you fail to do this properly you create an almost untraceable DESYNC!
14:51<Samu>I'm scared
14:51<nielsm>andythenorth: nobody has lodged any conceptual complaint over the 16 in/out patches, so them getting in should really just be a matter of code quality
14:53<andythenorth>frosch indicated same :)
14:53<andythenorth>hopefully someone will review it some time :)
14:53*andythenorth back tomorrow
14:53-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has quit [Quit: andythenorth]
14:56<Samu>https://github.com/OpenTTD/OpenTTD/blob/master/src/vehicle.cpp#L400
14:57-!-glx [kvirc@000128ec.user.oftc.net] has joined #openttd
14:57-!-mode/#openttd [+v glx] by ChanServ
14:57-!-glx is "Loïc GUILLOUX" on @#opendune @#openttd.noai #openttd.notice +#openttd
14:57<Samu>so trains are different than ships in that they can't be on top of each other
14:57<Samu>I can't resort to copy paste :(
15:00<Samu>can't do a EnsureNoShipProcZ
15:00<Samu>or the proc must return a list of vehicles on the tile, instead of returning only 1 vehicle
15:01<Samu>how to do this?
15:06-!-stefino [~oftc-webi@gw-lipa-silo-1.cust.avonet.cz] has quit [Quit: Page closed]
15:14<nielsm>what do you need a full list for?
15:15<nielsm>if your goal is to detect whether or not there are any ships on a tile, if you can get just one from a query on the tile you know there are one or more ships there
15:40-!-sla_ro|master [~sla.ro@84.117.88.126] has quit []
15:43-!-Thedarkb-T60 [~Thedarkb-@86-45-41-156-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
15:50*LordAro compiled OTTD with clang7
15:50<LordAro>only 3 new warnings (all the same thing), irritatingly from squirrel
15:51<LordAro>sqcompiler.cpp:145:10: warning: local variable 'ret' will be copied despite being returned by name
15:56<Samu>i need to check if a ship on a tile is on a specific track bit
15:57<Eddi|zuHause>C++ has "return by name"?
15:57<Samu>I am trying to avoid using FOR_ALL_SHIPS(s)
15:58<Eddi|zuHause>can't even properly imagine what that would do
15:58<Samu>hmm sec
15:59-!-HerzogDeXtEr [~farci@dslb-178-000-245-235.178.000.pools.vodafone-ip.de] has quit [Read error: Connection reset by peer]
16:00<Samu>https://paste.openttdcoop.org/pagop3ur5
16:00<Samu>this is what I have right now, but it's not sufficient, because a ship could be on those tiles and yet not coming into collision with the tile
16:01<Samu>i want to check in which tracks the ships are
16:02<Samu>i need to iterate over all the ships on a tile and check each one individually in which track they are
16:02<Samu>heh, repetition
16:03<Samu>if (s->state & DiagdirReachesTracks(DiagdirBetweenTiles(tile, s->tile)
16:04<Samu>s for vehicle of type ship
16:04<LordAro>Eddi|zuHause: i have to admit, i'm not sure
16:05<Samu>instead of CommandCost ret = EnsureNoShipOnWater(tile);, I want to get a list of vehicles on the tile :/
16:06<Eddi|zuHause>i once learned about languages like algol that "call by name" was meant as something like "everywhere the parameter appears, the expression that is passed is put in, and then evaluated in that context"
16:06-!-iSoSyS [~iSoSyS@2001:8a0:e960:de00:a47c:3151:4869:3899] has joined #openttd
16:06-!-iSoSyS is "realname" on #openttd #/r/openttd
16:06-!-frosch123 [~frosch@00013ce7.user.oftc.net] has quit [Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn]
16:07<Eddi|zuHause>but that concept always seemed so crazy to me that nobody should ever use it
16:52<nielsm>I think that warning message above might have something to do with return value optimizations, since it talks about "will be copied"
16:53<nielsm>I assume that means the compiler wasn't able to prove the variable can be constructed in the return slot in the calling function's stack, or whatever it might do
16:59-!-synchris [~synchris@139.138.202.72] has quit [Quit: yeeha!]
17:10-!-sim-al2 [~sim-al2@c-75-65-196-171.hsd1.tn.comcast.net] has joined #openttd
17:10-!-sim-al2 is "sim-al2" on #openttd
17:14<Samu>what's the difference between DiagDirection and DiagDirectionByte
17:20-!-nielsm [~nielsm@176-23-103-56-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
17:21-!-Wormnest [~Wormnest@35.136.176.177] has joined #openttd
17:21-!-Wormnest is "Wormnest" on #openttd
17:24-!-gelignite [~gelignite@55d4b5f2.access.ecotel.net] has quit [Quit: Match found!]
17:30-!-iSoSyS [~iSoSyS@2001:8a0:e960:de00:a47c:3151:4869:3899] has quit [Remote host closed the connection]
17:34-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has quit [Quit: snail_UES_]
17:41<Samu>why doesn't this work? DiagDirectionByte diag_dir_byte = axis == AXIS_X ? 1 << DIAGDIR_SE | 1 << DIAGDIR_NW : 1 << DIAGDIR_NE | 1 << DIAGDIR_SW;
17:41<Samu>Severity Code Description Project File Line Suppression State Error C2440 'initializing': cannot convert from 'int' to 'DiagDirectionByte' openttd D:\OpenTTD\OpenTTD GitHub\OpenTTD\src\water_cmd.cpp 138
17:42<Samu>gonna try byte
17:45<Samu> byte diag_dir_byte = axis == AXIS_X ? 1 << DIAGDIR_SE | 1 << DIAGDIR_NW : 1 << DIAGDIR_NE | 1 << DIAGDIR_SW;
17:52-!-HerzogDeXtEr [~farci@dslb-178-000-245-235.178.000.pools.vodafone-ip.de] has joined #openttd
17:52-!-HerzogDeXtEr is "purple" on #openttd
17:57-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has quit [Quit: Once again the world is quick to bury me.]
17:58-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has joined #openttd
17:58-!-andythenorth is "andythenorth" on #openttd
18:00-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has left #openttd []
18:33-!-Wacko1976 [~IceChat9@027-161-128-083.dynamic.caiway.nl] has quit [Ping timeout: 480 seconds]
18:37-!-Wormnest [~Wormnest@35.136.176.177] has quit [Quit: Leaving]
18:42<Eddi|zuHause>i'm not sure if i learned anything about that here... https://github.com/jarro2783/cxxopts/pull/134/commits/dadc911e44c69b1e34926586271e495749a6cfd6
18:44<LordAro>mm, that's a bit different
18:45-!-haudrauf [~haudrauf2@00021656.user.oftc.net] has quit [Ping timeout: 480 seconds]
18:46-!-haudrauf [~haudrauf2@p200300C35F38B8000EEEFBC8D462C005.dip0.t-ipconnect.de] has joined #openttd
18:46-!-haudrauf is "Haudrauf" on #openttd #frickelplatz @#ffod @#ffnord @#ffki @#ffhl @#ffhh @#fffl #cryptoparty @#ccchh @#ccc.do
19:08-!-Maarten [~maarten@2600:1700:7fd0:6e98:20c:29ff:fea0:abb6] has quit [Quit: Erection reset by beer]
19:46-!-iSoSyS [~iSoSyS@2001:8a0:e960:de00:a47c:3151:4869:3899] has joined #openttd
19:46-!-iSoSyS is "realname" on #/r/openttd #openttd
20:02<Samu>just figured out how to use proc stuff
20:02<Samu>ok cyas
20:02<Samu>good night
20:03-!-Samu [~oftc-webi@pa4-84-91-142-34.netvisao.pt] has quit [Quit: Page closed]
20:38-!-iSoSyS [~iSoSyS@2001:8a0:e960:de00:a47c:3151:4869:3899] has quit [Remote host closed the connection]
20:53-!-Flygon [~Flygon@106-68-83-162.dyn.iinet.net.au] has joined #openttd
20:53-!-Flygon is "Flygon" on #openttd
21:19-!-HerzogDeXtEr [~farci@dslb-178-000-245-235.178.000.pools.vodafone-ip.de] has quit [Read error: Connection reset by peer]
21:21-!-Progman [~progman@p4FD66D6E.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
21:52-!-glx [kvirc@000128ec.user.oftc.net] has quit [Quit: Bye]
22:26-!-quiznilo [~CC@pool-71-123-32-146.phlapa.fios.verizon.net] has joined #openttd
22:26-!-quiznilo is "CC" on #openttd
22:41-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has joined #openttd
22:41-!-snail_UES_ is "Jacopo Coletto" on #openttd
23:32-!-Fahrradkette [~jessie@178.197.234.50] has joined #openttd
23:32-!-Fahrradkette is "realname" on #openttd
23:37<Fahrradkette>greetings everybody. I'd like to download a NewGRFS from inside Openttd but the progressbar stays at 0 bytes. "ss -4 -p" reports 2 open tcp connections belonging to openttd (a http and one going to port 3978) What would be my next steps to debug that issue?
23:37<Fahrradkette>OpenTTD 1.8.0 running on debian 10 (buster)
23:52-!-haudrauf [~haudrauf2@00021656.user.oftc.net] has quit [Ping timeout: 480 seconds]
23:53-!-haudrauf [~haudrauf2@p200300C35F3F6900F46BA5CA91462255.dip0.t-ipconnect.de] has joined #openttd
23:53-!-haudrauf is "Haudrauf" on #openttd #frickelplatz @#ffod @#ffnord @#ffki @#ffhl @#ffhh @#fffl #cryptoparty @#ccchh @#ccc.do
23:57<Fahrradkette>here is the pastebin of it: https://pastebin.com/ATh0ji43
23:59<Fahrradkette>ok, scrap it. It eventually downloaded it:)
23:59<Fahrradkette>(note to myself, after writing the issue, check if it still persists)
---Logclosed Sun Oct 07 00:00:14 2018