Back to Home / #openttd / 2019 / 01 / Prev Day | Next Day
#openttd IRC Logs for 2019-01-05

---Logopened Sat Jan 05 00:00:07 2019
00:05-!-APTX [~APTX@2001:470:24:137f:2ff:ffff:fe00:1] has joined #openttd
00:05-!-APTX is "APTX" on #openttd #kernelnewbies
00:09-!-APTX [~APTX@2001:470:24:137f:2ff:ffff:fe00:1] has quit []
00:09-!-APTX [~APTX@2001:470:24:137f:2ff:ffff:fe00:1] has joined #openttd
00:09-!-APTX is "APTX" on #kernelnewbies #openttd
02:12-!-nielsm [~nielsm@176-23-103-56-cable.dk.customer.tdc.net] has joined #openttd
02:12-!-nielsm is "Niels Martin Hansen" on #openttd
02:30-!-andythenorth [~andytheno@host31-53-130-182.range31-53.btcentralplus.com] has joined #openttd
02:30-!-andythenorth is "andythenorth" on #openttd
02:33<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth updated pull request #6811: Feature: Add NotRoadTypes (NRT) https://git.io/vhlfg
02:43<andythenorth>moin
02:53<nielsm>hell-o
03:02<andythenorth>cdist :P
03:03<andythenorth>adding more trains at one node to clear the station
03:03<andythenorth>just piles up pax at the next node :P
03:03<andythenorth>adding more trains to that node to clear it
03:04<andythenorth>they bring more pax back to the middle node
03:04<andythenorth>can never clear the network :P
03:04<andythenorth>some nodes will always be overflowing
03:11-!-Thedarkb-X40 [~beno@86-40-230-133-dynamic.agg3.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
03:12<nielsm>considered whether it might make sense to have a fast service cutting through some other transfer points?
03:13<andythenorth>if it's fast enough
03:13<andythenorth>the intermediate nodes will start distributing traffic onto the fast service :P
03:13<andythenorth>you can't beat cdist :P
03:13<andythenorth>except with 999mph trains with 2048 pax each
03:28-!-Wacko1976_ [~IceChat9@027-161-128-083.dynamic.caiway.nl] has quit []
03:36-!-synchris [~synchris@139.138.202.72] has joined #openttd
03:36-!-synchris is "Synesios Christou" on #openttd
03:47-!-Borg [~borg@87-99-43-52.internetia.net.pl] has joined #openttd
03:47-!-Borg is "Unknown" on #openttd
03:58-!-chomwitt is "chomwitt" on #debian #debian-games
03:58-!-chomwitt [~chomwitt@ppp-94-69-11-229.home.otenet.gr] has joined #openttd
04:21-!-Progman [~progman@p4FD661B2.dip0.t-ipconnect.de] has joined #openttd
04:21-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttd
04:37-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has joined #openttd
04:37-!-Wolf01 is "Wolf01" on #openttd
04:37<Wolf01>o/
04:39<andythenorth>hi
04:43<Borg>hoooi :)
04:48-!-Gabda [~Gabda@catv-80-98-39-136.catv.broadband.hu] has joined #openttd
04:48-!-Gabda is "realname" on #openttd
05:01<TrueBrain>still weird; for some CIs te start I have to visit the Azure Pipelines website, but not for all CI jobs
05:01<TrueBrain>this needs more investigation :D
05:03<TrueBrain>andythenorth: translation warnings in NRT
05:03<TrueBrain>might be worth fixing :)
05:07<TrueBrain>segfaults on Linux :D
05:07<TrueBrain>nice
05:08<TrueBrain>so yeah ... work to do :D
05:11<TrueBrain>and MacOS doesn't stop when regression crashes, it seems
05:11<TrueBrain>cancelled the job :)
05:14<andythenorth>TrueBrain: translation warnings in form of 'x does not exist in master file'?
05:14<andythenorth>or something else?
05:15<TrueBrain>check the Pull Request results :)
05:15<andythenorth>I did
05:15<andythenorth>it just says build cancelled
05:15<TrueBrain>so click the link
05:15<TrueBrain>dig deeeeper
05:16<andythenorth>got it
05:16<andythenorth>4 warnings
05:16-!-HerzogDeXtEr [~farci@dslb-178-000-248-139.178.000.pools.vodafone-ip.de] has quit [Read error: Connection reset by peer]
05:16<TrueBrain>and you want to look into why regression crashes :)
05:17<TrueBrain>glx was busy adding it for Windows, but not sure where that is at
05:18<andythenorth>what I really want is to stop having no_sound.obs and friends
05:18<andythenorth>I guess I just add that to my local .gitignore
05:18<andythenorth>and everyone else does too
05:18<nielsm>a standard tool to clean up strings from translations would be nice imo
05:18<andythenorth>nielsm: like this one? :P https://dev.openttdcoop.org/projects/iron-horse/repository/entry/bin/remove_dead_lang_strings.py
05:19<andythenorth>only better
05:19<andythenorth>where even is my .gitignore?
05:19*andythenorth looks
05:19<andythenorth>I hate modifying system-wide things for specific project
05:19<andythenorth>it's dumbass
05:19<andythenorth>and fragile
05:20<andythenorth>these people who are like 'oh I just symlinked that from /bin and edited my bash conf'
05:21<andythenorth>are the people who are like "can't do any work today, rebuilding my system again"
05:22<Eddi|zuHause>andythenorth: there's usually a systemwide one, a project specific one, and a checkout specific one
05:22<LordAro>and a user specific one
05:22<andythenorth>ok so let's try and fix the root cause
05:22<andythenorth>what am I doing wrong to cause these to be generated?
05:22<andythenorth>https://paste.openttdcoop.org/pyrvrjpwp
05:22<andythenorth>it must be user error?
05:22<andythenorth>to build openttd I do 'make run -j13'
05:23<TrueBrain>you have grfcodec or one of these installed
05:23<TrueBrain>most people don't
05:23<andythenorth>right, so I need to remove grfcodec from my path?
05:23<TrueBrain>so for "normal people" those are not created
05:23<TrueBrain>I was told last time
05:23<TrueBrain>(rumours! I dont know if it is true)
05:23<Eddi|zuHause>andythenorth: i think it's an error that should be resolved project-wide
05:23<andythenorth>so I need a system for newgrf dev
05:23<andythenorth>and a system for openttd dev
05:23<TrueBrain>just add them to gitignore
05:23<andythenorth>new laptop time!
05:23<TrueBrain>I mean ... wont hurt anyone
05:23<nielsm>yeah they are generated from a template and translations, so when the translations are updated and you have the tools to rebuild those files, they get rebuilt
05:23<Eddi|zuHause>andythenorth: it's not specific to yourself
05:23<LordAro>there might be a configure flag for dsiabling grfcodec
05:24-!-sla_ro|master [~sla.ro@84.117.88.126] has joined #openttd
05:24-!-sla_ro|master is "slamaster" on #sla #openttd
05:24<Eddi|zuHause>really, the translator commits should cover these
05:24<nielsm>that would make the most sense yes
05:27-!-JimAcid [~oftc-webi@ipa5.10.tellas.gr] has joined #openttd
05:27-!-JimAcid is "OFTC WebIRC Client" on #openttd
05:28<andythenorth>we have some work projects
05:28<andythenorth>where you make a change and just ship it
05:28<andythenorth>and others where touching anything, you discover that ~everything needs rebuilt
05:28<andythenorth>OpenTTD is close to the second :P
05:29<andythenorth>obvs. the size of the project usually correlates
05:29<Eddi|zuHause>andythenorth: https://xkcd.com/1700/
05:29<LordAro>some things are dependencies of everything :p
05:30<nielsm>visual studio rebuilding almost all files when english.txt is updated is very annoying
05:30<LordAro>make does the same
05:31<Eddi|zuHause>that's because english.txt gets turned into a header file which is included in almost every cpp file
05:31<LordAro>i don't think there's any way around it, due to string tables
05:31<Eddi|zuHause>so each of these files must be rebuilt
05:31<LordAro>needs more C++ modules
05:31<LordAro>probably
05:31<andythenorth>it took me a few years before I realised that all of this is what *success* looks like :P
05:31<Eddi|zuHause>dunno what that would solve
05:31<andythenorth>rather than failure
05:32<andythenorth>TB it's nice that the azure page shows the warning in orange
05:32<andythenorth>https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=97
05:33<TrueBrain>too bad it only does it for Windows
05:33<andythenorth>oof
05:33<andythenorth>well it's helpful :)
05:33<LordAro>andythenorth: i've spent a significant time at work fixing/adding loads of build dependencies, so that people can now (fairly) reliably do incremental builds, rather than having to clean almost every time something unexpected changes
05:33<andythenorth>time saved
05:33<LordAro>when the build takes best part of an hour, this is significant
05:34<Eddi|zuHause>dependencies is tricky
05:34<andythenorth>we parallelised our selenium tests, than moved them to an EC2 pool, to reduce cycle times
05:34<andythenorth>if commit->tests-fail is like 1 hour or more
05:34<andythenorth>that's useless
05:35<LordAro>yeah
05:35<LordAro>we recently got several threadripper build servers (with all the cores)
05:35<LordAro>cut build times in half
05:35<LordAro>(and test times)
05:36<andythenorth>I don't understand this warning
05:36<andythenorth>"src/lang/indonesian.txt:4329: warning: String name 'STR_ERROR_CROSSING_DISALLOWED' does not exist in master file"
05:37<andythenorth>oh I do, it was a bad grep
05:38<andythenorth>can we merge this yet?
05:38<andythenorth>https://github.com/OpenTTD/OpenTTD/pull/6917
05:38<LordAro>i think so :p
05:38<andythenorth>to do any openttd dev, I have to have a branch, then a separate branch with 6917+my branch
05:38<andythenorth>then merge them constantly
05:39<andythenorth>it was approved 8th Dec
05:39<andythenorth>3rd / 8th /s
05:40<andythenorth>so what's the deal with getting approved PRs merged?
05:40<andythenorth>who do I bribe?
05:40<TrueBrain>needs a rebase for sure :)
05:41<LordAro>bleh
05:41<Eddi|zuHause>Passierschein A38
05:46<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth updated pull request #6811: Feature: Add NotRoadTypes (NRT) https://git.io/vhlfg
05:46<andythenorth>probably need to rebase -i that :P
05:47<andythenorth>hmm, how do I squash non-consecutive commits
05:47<TrueBrain>you need to fix the crash first anyway, so that can wait :D
05:47<andythenorth>no no the admin must be correct
05:47<andythenorth>even if the code doesn't work
05:47<andythenorth>engineering is bureaucracy :P
05:48<TrueBrain>I am a bit annoyed that a crash can keep the regression from continueing .. we should fix that :(
05:48<nielsm>now why is it repeatedly relinking strgen.exe for me... there aren't any changes to it
05:49<Wolf01>andythenorth: since when there is 2.0 after 1.9?
05:49<andythenorth>since we should
05:49<andythenorth>in 2020
05:49<andythenorth>because 2020
05:49<andythenorth>and v2
05:49<andythenorth>but yes
05:49<andythenorth>I agree
05:49<andythenorth>except v2 is better
05:49<Wolf01>Bah, I want RCT terrain for 2.0
05:49<Wolf01>After 1.9 there is 1.10 :P
05:49<Eddi|zuHause>for sure the next version after 1.9 needs to be 20
05:50<Eddi|zuHause>that way we can release OpenTTD 20.04 which will never be in the corresponding Ubuntu 20.04
05:50<nielsm>meh yeah, the scale for my candy drill rig is wrong, it needs to be 2x in every dimension (visually)
05:51<Eddi|zuHause>nielsm: primary rule of newgrf development: the scale is always wrong
05:54<andythenorth>the scale is wrong
05:54<andythenorth>just treat it like Lego
05:55<andythenorth>ha ha, I found how to change my git editor
05:56<andythenorth>oh it crashed
05:56<andythenorth>nvm
06:01<JimAcid>hi to all, I have a question, I remember that I was able to built roads end buildings over tunnel exits, but somehow I cant find how to enable it
06:01<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth updated pull request #6811: Feature: Add NotRoadTypes (NRT) https://git.io/vhlfg
06:01<nielsm>I wonder if autodesk 360 would be better to model a technical-ish model with animation in? :D
06:02<nielsm>JimAcid: that's the "new map features" patch: https://www.tt-forums.net/viewtopic.php?f=33&t=58420
06:02<nielsm>it's not in the mainline version of ottd
06:03<andythenorth>"src\tunnelbridge_cmd.cpp(723,0): Warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data" o_O
06:04<nielsm>andythenorth: the win64 build has had that warning for a while now
06:04<JimAcid>nielsm thank you
06:08<andythenorth>so a crash in linux
06:08*andythenorth no linux :P
06:08<TrueBrain>Mac also fails
06:08<TrueBrain>but the crash is not showing up because of bugs
06:08<TrueBrain>and I strongly suspect the Windows also crashes
06:09<TrueBrain>as there is a BUG
06:09<TrueBrain>:)
06:09<TrueBrain>_Z14GetAnyRoadBitsj8RoadTypeb <- part of the traceback
06:09<TrueBrain>pretty sure it is NRT related :P
06:11<andythenorth>hmm
06:11<andythenorth>my local build is useless to diagnose this :P
06:11<andythenorth>I can only compile with a havk
06:11<andythenorth>hack *
06:11<andythenorth>not science
06:12<TrueBrain>and you think regression result changes because of that?
06:12<TrueBrain>you are just looking for excuses to not look into this :)
06:12<TrueBrain>you can safely assume that how ever you compile NRT, it will always crash regression :P
06:12<andythenorth>wait, so it's a failing test?
06:12<andythenorth>not a failing build?
06:12<TrueBrain>did me telling you 10 times now it is a regression crash gave that away?
06:13<TrueBrain>open the build results andythenorth .. :)
06:13<TrueBrain>click on the full logs
06:13<TrueBrain>scroll allllll the way down
06:13<TrueBrain>https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=99&view=logs&jobId=1100b651-10a9-541e-a625-0895f51cf5ef&taskId=f60a854d-b0b3-5331-77bc-16419f352ef3&lineStart=2382&lineEnd=2383&colStart=1&colEnd=1
06:14<TrueBrain>hmm, that is stupid, that doesn open the logs
06:14<TrueBrain>why does it show me a 'link' icon, if it doesnt link
06:14<TrueBrain>I found a bug in Azure Pipelines I guess ... owh well
06:15<TrueBrain>means you have to click it yourself :D
06:17<andythenorth>I was looking at https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=97&view=logs&lineStart=2589&jobId=1100b651-10a9-541e-a625-0895f51cf5ef&taskId=f60a854d-b0b3-5331-77bc-16419f352ef3
06:18<andythenorth>2585-2588
06:18<andythenorth>I thought the makefile had died
06:38<andythenorth>what do I need to build to get regression tests?
06:39<andythenorth>can't find anything in CONTRIBUTING.md or README.md
06:39<TrueBrain>make regression
06:39<TrueBrain>:D
06:39<TrueBrain>weird if it isnt mentioned in the readmes
06:40<andythenorth>Azure test run shows ai/regression path, but I don't have it
06:40<andythenorth>not mentioned
06:40<andythenorth>afaict
06:40<andythenorth>maybe in wiki?
06:40*andythenorth looks
06:40<andythenorth>https://wiki.openttd.org/To_do_for_releases
06:40<andythenorth>oh it's bin/ai
06:40<andythenorth>ok
06:41-!-chomwitt [~chomwitt@ppp-94-69-11-229.home.otenet.gr] has quit [Quit: WeeChat 1.6]
06:41<andythenorth>so any PR should have make regression run first, really
06:42<TrueBrain>that is what the CI does :)
06:42<andythenorth>it's noisy if the author doesn't do it
06:42<andythenorth>so todo:
06:42<TrueBrain>guess because it was never easy to do it on Windows, it isnt mentioned anywhere
06:42<TrueBrain>so glx should finish his work :)
06:42<andythenorth>- update docs
06:43<andythenorth>- update .gitignore
06:43<andythenorth>- rebase 6917
06:43<andythenorth>- then learn how regression tests work
06:43<TrueBrain>you cannot gitignore btw, I noticed. Those files are already in git, so they are always tracked
06:43<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh approved pull request #6995: Fix 59e42ea17, 1f083c3ac: make clean was not fully cleaning https://git.io/fh3RA
06:43<andythenorth>ok
06:43<andythenorth>update ~./gitignore then :P
06:44<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh merged pull request #6995: Fix 59e42ea17, 1f083c3ac: make clean was not fully cleaning https://git.io/fhk6u
06:44<andythenorth>also todo: take children to soft play center
06:44<andythenorth>such
06:44<TrueBrain>sounds like a higher priority than the rest :P
06:45<andythenorth>all I wanted was tramways with optional catenary :P
06:45<andythenorth>NRT overkill :P
06:45<TrueBrain>you wanted too much :D
06:49<andythenorth>well at least I get to click all the buttons in Azure
06:49<andythenorth>it has the same mystery meat feel as old jenkins
06:50<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh opened pull request #7012: Play Fluidsynth music through the mixer https://git.io/fh30T
06:51<andythenorth>so the test fails silently on macOS?
06:51<andythenorth>or gets stuck in a loop?
06:51<nielsm>there we go, more music stuff! and also the foundation for actual sampled music support
06:51<andythenorth>🎼
06:52<andythenorth>"-n Running ai/regression/tst_regression..." is getting boring to look at :P
06:53<nielsm>hmm more stuff I should check/try on my linux machine while I have it up? :)
06:54<andythenorth>NRT :P
06:54<andythenorth>I guess it's not linux specific failure though
06:54<andythenorth>https://github.com/OpenTTD/OpenTTD/pull/6811
06:55<nielsm>"git fetch andy"
06:55<nielsm>:P
06:55<TrueBrain>andythenorth: again, regression is very likely to fail on any platform
06:55<TrueBrain>sadly, the MacOS has a bug where if it crashes, it is not reported correctly
06:55<TrueBrain>so .. it hangs
06:55<TrueBrain>same when there are no GFX
06:56<TrueBrain>(Windows also hangs if the gfx could not be loaded)
06:56<andythenorth>that makes reading the test failure....harder :)
06:56<TrueBrain>that is why you run it locally
06:56<TrueBrain>and see what happens
06:56<TrueBrain>the linux variant do show a backtrace, as I mentioned earlier :)
06:56*andythenorth must now buy a linux computer
06:56<TrueBrain>but if you run 'make regression' on your local machine, it should crash too :)
06:56<TrueBrain>there is 0 need to do any of that
06:57<TrueBrain>most likely the MacOS crash reported shows a dialog with the information
06:57<TrueBrain>sadly, this is a poor idea for a CI
06:57<TrueBrain>but on your local machine, that should be fine
06:57<andythenorth>it doesn't do that
06:57<andythenorth>it just hangs
06:57<TrueBrain>so someone fucked up months ago already ;)
06:57<andythenorth>no success / failure messages in stdout
06:58<andythenorth>at all
06:58<nielsm>building nrt branch now
06:58<TrueBrain>I like how over 10 years the regression hasnt gotten any real attention, to the point it is simply forgotten :D
06:58<TrueBrain>andythenorth: possibly if you attach gdb to it,it will report the crash
06:59<nielsm>yeah I was about to suggest that, maybe run regressions under gdb in an automated manner, to catch crashes and maybe dump backtrace to the console
06:59<TrueBrain>I wonder if the crash reporting works at all on MacOS ..
06:59<TrueBrain>nielsm: we have crash reporting that does that
06:59<TrueBrain>if you check the linux stuff, that is exactly what it does :)
07:00<TrueBrain>on Windows we make a crash.log for this
07:00<andythenorth>macOS gets crash.log
07:00<TrueBrain>guess if regression fails we should output that content
07:00<TrueBrain>andythenorth: well, that is good :)
07:01<TrueBrain>if you run the 'regression.sh' with -g
07:01<andythenorth>macOS doesn't get crash.log from regression it seems :P
07:01<TrueBrain>it attaches gdb for you
07:01<TrueBrain>so in bin: ai/regression/run.sh -g
07:01<andythenorth>so... tmp.regression
07:01<andythenorth>what is that?
07:01<andythenorth>looks like a log
07:02<TrueBrain>temporary stdout/stderr file
07:02-!-sushibear [~SushiBear@176-204-50-84.dyn.estpak.ee] has quit [Quit: "Kick them plushies! Pinch the housewife! Wreak havoc, gentlemen!"]
07:02<nielsm>https://github.com/andythenorth/OpenTTD/blob/master/src/tile_map.h#L91
07:02<nielsm>that assert fails
07:02<nielsm>when I run make regression
07:02<andythenorth>ok
07:03<andythenorth>fail the PR then I guess :)
07:03<TrueBrain>lol .. that is bad :D
07:03<TrueBrain>means something went wrong before that
07:03<andythenorth>well
07:04<andythenorth>that is probably the wrong rabbit hole for today
07:04<andythenorth>but the PR fails
07:04<TrueBrain>just make someone else fix it :D
07:04<andythenorth>how about TrueBrain?!
07:04<TrueBrain>I rather focus on the infrastructure
07:05<TrueBrain>so we can release 1.9, and get NRT in for the next release
07:05<andythenorth>far too sensible
07:05<andythenorth>NRT isn't actually a priority for me
07:05<andythenorth>I am doing this to learn how Azure and the tests work
07:05<andythenorth>and practice rebasing and crap
07:06*andythenorth is supposed to be drawing trains but eh
07:06<TrueBrain>CI needs a lot of attention to become really useable :)
07:06<TrueBrain>but that has no priority on my side ;)
07:07<DorpsGek_II>[OpenTTD/website] TrueBrain opened pull request #14: Add: [#8] add 404/500 pages to serve when page-not-found / internal-server-error https://git.io/fh30g
07:07<TrueBrain>getting ^^ reviewed does :D
07:07<TrueBrain>:D:D
07:08<DorpsGek_II>[OpenTTD/website] nielsmh commented on pull request #14: Add: [#8] add 404/500 pages to serve when page-not-found / internal-server-error https://git.io/fh30w
07:08<TrueBrain>nielsm: it is?
07:08<andythenorth>I was already looking :P
07:08<Borg>NOOOOOOOO
07:08<Borg>(0 << 0x0C) // newagerating
07:08<Borg>no .ini var to set it.... :(
07:08<TrueBrain>nielsm: for me that sounds like a fine sentence; can you indicate to me what is weird about it? (honest question)
07:09<andythenorth>just approve them if the nginx is correct, then I'll fix the pages later
07:09<nielsm>"procedure" is not a verb
07:09<TrueBrain>to produce?
07:09<nielsm>I think "produce" is the intended
07:09<andythenorth>process
07:09<nielsm>or process
07:09<andythenorth>provide
07:09<nielsm>or procure
07:09<andythenorth>or just delete that sentence
07:10<TrueBrain>ah! :D
07:10<TrueBrain>well, I misread my own sentence only 10 times
07:10<andythenorth>cute error messages died about 7 years ago
07:10<TrueBrain>its not meant to be cute andythenorth :D
07:11<andythenorth>at some point we need to not start our heading hierarchy with <h3>
07:11*andythenorth also must fix that
07:11<andythenorth>we need more of some people
07:11<andythenorth>notably andythenorth
07:11<DorpsGek_II>[OpenTTD/website] TrueBrain updated pull request #14: Add: [#8] add 404/500 pages to serve when page-not-found / internal-server-error https://git.io/fh30g
07:11<TrueBrain>tnx nielsm; I really failed to read what I wrote :)
07:11<andythenorth>I really failed to wrote what I read
07:11<TrueBrain>when I was reading that sentence in my head, I kept reading produce :)
07:11<TrueBrain>funny .. how brains are weird :D
07:12<andythenorth>WAVE hates our page :P
07:12<TrueBrain>good thing about it being on GitHub, that it is more likely someone will come and fix all these things :)
07:12<andythenorth>W3 validator hates it too
07:12<TrueBrain>it used to validate! :o
07:13<TrueBrain>(we used to have a very high score on all these things .. 10 years ago :P)
07:13<andythenorth>it's trivial things
07:13<andythenorth>we could run TV on commits :P https://www.totalvalidator.com/index.html
07:13<andythenorth>works great
07:14<andythenorth>£5 / license, I pay
07:14<andythenorth>you set it up on Docker :P
07:14<TrueBrain>lol
07:15<TrueBrain>its a gui tool :(
07:15<andythenorth>it plays nice with jenkins
07:15<andythenorth>we use it at work, I love it
07:15<andythenorth>but eh
07:15<andythenorth>maybe not
07:15<andythenorth>oof I just found a CI tool in Docker for validating Docker images for your CI
07:15<andythenorth>so you can use your CI to check the images you build your CI with
07:15<andythenorth>so you can CI
07:15<andythenorth>to make more images
07:15<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh requested changes for pull request #6811: Feature: Add NotRoadTypes (NRT) https://git.io/fh305
07:16<TrueBrain>anyway, that tool can for sure be useful to remove a lot of issues to start with :)
07:16<TrueBrain>but .. I hope others will contribute for these things :)
07:16<andythenorth>$others
07:16<TrueBrain>I amgoing to try to keep a focus on moving everything to github
07:17<DorpsGek_II>[OpenTTD/website] nielsmh approved pull request #14: Add: [#8] add 404/500 pages to serve when page-not-found / internal-server-error https://git.io/fh30x
07:17<andythenorth>focus :D
07:18<andythenorth>so many distractions https://fit2b.us/wp-content/uploads/2015/11/internet-mess.jpg
07:18<DorpsGek_II>[OpenTTD/website] nielsmh merged pull request #14: Add: [#8] add 404/500 pages to serve when page-not-found / internal-server-error https://git.io/fh30g
07:18<andythenorth>has LordAro rebased 6917 yet? :D
07:19<TrueBrain>tnx nielsm :)
07:19<TrueBrain>holy crap @ that room ... someone should be fired
07:19<Borg>its shame.. there is no way to set _ttdpatch_flags[] I mean enable/disabl bits.. via NewGRF or sth like that..
07:20<andythenorth>that would be ass backward Borg :)
07:20<andythenorth>what case is there for that?
07:20<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh commented on issue #7006: Hardware mouse cursor https://git.io/fh3Ev
07:20<Borg>andythenorth: (0 << 0x0C) // newagerating
07:21<andythenorth>what does it even do? o_O
07:21<andythenorth>station rating?
07:21<Borg>change how station rating is calculated (one of the bonuses)
07:22<Borg>actually. it should be pretty easy to implement ActD _ttdpatch_flags[] writing via 2 new commands.. setbv1 setbv0
07:24<Borg>actually it fits pefectly
07:25<Borg>first you call InitializeGRFSpecial() and then.. when NewGRF is initialized.. it can alter some bits via ActD
07:26<andythenorth>newgrf setting player flags violates proper domain
07:26<andythenorth>but eh
07:26<andythenorth>'probably fine' :P
07:26<nielsm>I'd rather have the newgrf disable itself and show an error if the game flags are set wrong for its purpose
07:27<Borg>nielsm: best would be to have proper .ini to access all flags
07:27<nielsm>what if two newgrfs tried changing the same flag to opposite values?
07:27<TrueBrain>hmm .. we really need a 'latest.html' for downloads .. you don't want to list your latest release as a versioned-URL
07:27<Borg>nielsm: yeah.. thats the problem :)
07:27<andythenorth>http://bundles.openttdcoop.org/firs/releases/LATEST/
07:28<andythenorth>dunno how it works, probably magic
07:28<TrueBrain>andythenorth: and that in jekyll :)
07:28<andythenorth>we need planetmaker to join this party
07:28<TrueBrain>I do have an idea :D
07:28-!-Gabda [~Gabda@catv-80-98-39-136.catv.broadband.hu] has quit [Quit: Leaving]
07:28<TrueBrain>every party needs a planetmaker :)
07:29<Borg>I see other interesting flags too
07:29<Borg>presignals.. for example..
07:29<Borg>so if 0 ? only block + pbs?
07:30<nielsm>yes except that you can't disable pbs in openttd (afaik?)
07:30<Borg>yep, there is no flag for it..
07:30<nielsm>or presignals
07:30-!-Gabda [~Gabda@catv-80-98-39-136.catv.broadband.hu] has joined #openttd
07:30-!-Gabda is "realname" on #openttd
07:30<Borg>hmm I see potential for _ttdpatch_flags[] modifing! :)
07:30<nielsm>consider that the var you're looking at is called ttdpatch flags
07:30<nielsm>not openttd flags
07:31<Borg>right..
07:31<Borg>it seems not used anywhere..
07:31<Borg>okey.. forgot it.. it seems I got carried away
07:33-!-JimAcid [~oftc-webi@ipa5.10.tellas.gr] has quit [Remote host closed the connection]
07:34<Eddi|zuHause>Borg: most of the ttdpatchflags are hardcoded in openttd, others are mapped to ingame settings
07:34<TrueBrain>andythenorth: the base stuff fails for 404 pages .. they can be in any folder :D
07:35<TrueBrain>that needs a reinvestigation, I guess :P
07:35<TrueBrain>why did we do it this way again? (totally forgot)
07:35<Eddi|zuHause>"i herd u like failure so we put some failure in ur failpages"
07:35<TrueBrain>(example: https://www.staging.openttd.org/downloads/catcodec-releases/adas)
07:36<Eddi|zuHause>was catcodec ever used by more than 5 people?
07:39<nielsm>do sound effects still need to be packed in cat files?
07:39<nielsm>even
07:41<Eddi|zuHause>not sure
07:41<Eddi|zuHause>theoretically you can also put sounds into a .grf file
07:41-!-Flygon [~Flygon@58-6-74-108.dyn.iinet.net.au] has quit [Quit: A toaster's basically a soldering iron designed to toast bread]
07:41<Eddi|zuHause>but i have no clue if openttd accepts that as a baseset
07:41<nielsm>I don't think it would work as baseset no
07:42<nielsm>but could be used as static newgrf overriding default sounds, I think
07:42*andythenorth bbl
07:43<Eddi|zuHause>i don't see a reason why it couldn't use a .tar file or simple directory as baseset either, but probably nobody bothered implementing that either
07:43<nielsm>you'd need a more complete wav file reader then :)
07:45<nielsm>was it not actually longer? https://github.com/nielsmh/OpenTTD/commit/3a3e0802eb3b084e8640b7759f64e99579024142#diff-a38b8a5f16c15ef8031a2a99263f5be8
07:45<nielsm>I remember spending way too music time getting that hack to work
07:50-!-andythenorth [~andytheno@host31-53-130-182.range31-53.btcentralplus.com] has quit [Ping timeout: 480 seconds]
07:52-!-Samu [Samu@pa4-84-91-142-34.netvisao.pt] has joined #openttd
07:52-!-Samu is "..." on #openttd
07:54<nielsm>what would everyone think about adding a soft dependency on ffmpeg for playing sampled music in-game?
07:56<TrueBrain>you and your music :D
07:56<DorpsGek_II>[OpenTTD/website] TrueBrain closed issue #8: No 404/500 html pages https://git.io/fhO17
07:57<nielsm>or could just make something with libogg+libvorbis and support that as the only choice
07:58<Eddi|zuHause>people will demand .flac support
07:58<Eddi|zuHause>and by "people" i mean "that one person"
07:58<nielsm>heh
07:59<TrueBrain>:D
07:59<nielsm>OPL3 emulation for the original adlib music is a more interesting project though =)
08:14<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh opened pull request #7013: Fix 6accbf9: Silence warnings about unused fread() result https://git.io/fh3ua
08:20<@planetmaker>I heard 'party'? :D
08:27<TrueBrain>if this is your reponse time to parties .... :P
08:29<Eddi|zuHause>github #7000 party?
08:29<TrueBrain>lets do 10k :P
08:31<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh opened pull request #7014: Fix 6a3d411: Silence truncation warning https://git.io/fh3uh
08:38-!-Gabda [~Gabda@catv-80-98-39-136.catv.broadband.hu] has quit [Ping timeout: 480 seconds]
08:43-!-Progman [~progman@p4FD661B2.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
08:44<TrueBrain>okay .. I want to download a file from a system that is purposely isolated from the ability to download from
08:44<TrueBrain>hmm
08:45<TrueBrain>(OpenTTD's main webserver is fully isolated, and only accepts port 80 traffic)
08:45<TrueBrain>(a security aspect)
08:45<TrueBrain>but I want the access.log from it, so I can check if I redirect all the URLs correctly :D
08:46<nielsm>heh
08:47<nielsm>let it connect to a logging server?`
08:47<TrueBrain>the logging server too is fully isolated, but even worse
08:47<nielsm>.-.
08:47<TrueBrain>write-once etc etc
08:47<TrueBrain>well, you want those systems to be very well protected :D
08:48<TrueBrain>logging servers tend to contain data, that is broken into, are pretty .... hurtful :D
08:48<TrueBrain>and I can request data from it, but not in a bulk-way :)
08:49<TrueBrain>people are still requesting URLs on www.openttd.org that link to the old website ... 15 years ago
08:49<@planetmaker>might even be in our own wiki, the old links
08:49<TrueBrain>I guess
08:49<TrueBrain>screens.php
08:50<TrueBrain>we havent been running php in .. euh .. a long time :P
09:03<DorpsGek_II>[OpenTTD/OpenTTD] LordAro approved pull request #7013: Fix 6accbf9: Silence warnings about unused fread() result https://git.io/fh3zF
09:07<TrueBrain>1650 valid URLs were served by www.openttd.org in the last 3 months
09:07<TrueBrain>excluding server-listing hits
09:07<TrueBrain>lol
09:10<TrueBrain>over a 1000 of those are "hacking" attempts, which happened to hit an URL that returned a 200
09:10<TrueBrain>lol
09:11<Eddi|zuHause>a few years ago i watched a lecture about "how to run a tracker" where they said they accept "/announce.php" simply because people randomly write that into their torrents
09:12<TrueBrain>hmm .. current URLs for news are like /en/news/123
09:12<TrueBrain>the new URLs are different
09:12<TrueBrain>do I want to map those
09:12<TrueBrain>RSS and Atom feed .. hmm
09:13<Eddi|zuHause>they also said they actually accept any url with "/a", because it's just wasted effort to check more, and they want to optimize for speed :p
09:13<TrueBrain>https://www.openttd.org/en/download-all <- why did I ever make that page ..
09:13<TrueBrain>well, that page will be gone, okay? :)
09:14<Eddi|zuHause>i've no idea which target audience you wanted to reach with that page :p
09:15<TrueBrain>10 years ago it most likely was a very good idea
09:15<TrueBrain>:D
09:15<TrueBrain>okay .. I only offer download URLs for the last 90 nightlies
09:15<TrueBrain>we used to support all of them
09:15<TrueBrain>but that is 4000 more HTML pages
09:16<Eddi|zuHause>there's a price for only serving static pages
09:16<TrueBrain>:D
09:16<Eddi|zuHause>just point them to the ftp-mirror for the older ones?
09:24<LordAro>TrueBrain: i've never heard of anyone using atom, but would be a shame to lose rss
09:24<TrueBrain>funny enough, Jekyll comes with Atom,not with RSS :P
09:24<LordAro>ha
09:26<LordAro>TrueBrain: nginx.default.conf refers to 50x.html, but 500.html exists
09:26<TrueBrain>"Great question. In short, Atom is a better format. Think of it like RSS 3.0. For more information, see this discussion on why we chose Atom over RSS 2.0."
09:26<TrueBrain>:D
09:26<TrueBrain>LordAro: lol .. knew I forgot something
09:26<TrueBrain>LordAro: https://github.com/jekyll/jekyll-feed/issues/2
09:27<LordAro>interesting
09:27<LordAro>(i don't use either, so..)
09:27<TrueBrain>will see if there is another plugin to also give RSS :P
09:28<Borg>guys.. Act7 or Act9 ?
09:28<Borg>I read the comments... still not sure :) I motly use Act7
09:29<Borg>s/motly/mostly/
09:29<nielsm>does any tool of note still not support atom?
09:29<TrueBrain>nielsm: they debate all tools do, except Apple :P
09:30<TrueBrain>tempted to redirect the RSS to Atom :P
09:31<TrueBrain>129015 www.openttd.org /en/news/atom 200
09:31<TrueBrain>460652 www.openttd.org /en/news/rss 200
09:31<TrueBrain>3 times more RSS hits
09:31-!-andythenorth [~andytheno@host31-53-130-182.range31-53.btcentralplus.com] has joined #openttd
09:31-!-andythenorth is "andythenorth" on #openttd
09:37<TrueBrain>andythenorth: why again did you do this {{ base }} stuff?
09:37<TrueBrain>why cant we do just / ?
09:37<andythenorth>didn't you do it?
09:37<TrueBrain>I haven't touched this (at all)
09:37<andythenorth>hmm
09:37<TrueBrain>you wrote base_variable.html :)
09:37<andythenorth>I did?
09:37<andythenorth>git doesn't lie
09:38<TrueBrain>*facepalm* :P
09:38<TrueBrain>so you dont remember why you did this?
09:38<andythenorth>no
09:38<TrueBrain>checking the depth of the page, and setting {{ base }} accordingly?
09:39<TrueBrain>andythenorth: https://github.com/OpenTTD/website/blob/master/_includes/base_variable.html
09:39<TrueBrain>that thing?
09:39<andythenorth>what happens if we delete it?
09:40*andythenorth deleting it
09:40<TrueBrain>that is not the point; if you dont remember why you wrote it, it is hard to make any change to it, as you dont know what it solved :)
09:40<TrueBrain>itmight be hiding :)
09:41<TrueBrain>but okay .. I will replace it with {{ site.baseurl }}
09:42<andythenorth>NFI, I rely on the commits to tell why
09:42<andythenorth>but can't find relevant commit yet
09:42<Borg>git log _include/base_variable.html ?
09:42<andythenorth>just deleting it has no negative effects
09:43<andythenorth>well it demands using 'jekyll serve' for local dev
09:43<andythenorth>but eh
09:43<andythenorth>that's not a hardship
09:44<LordAro>TrueBrain: i've seen similar things used for when the site is not served at /
09:44<LordAro>but if it's never intended to be anywhere else, it's probably fine
09:44<TrueBrain>LordAro: that is called 'baseurl' :D
09:44<TrueBrain>and Jekyll supports that :)
09:45<andythenorth>delete delete
09:45<TrueBrain>andythenorth: ah, wasnt it that you wanted to use it via file:// ?
09:45<andythenorth>yeah but there's no need
09:45<andythenorth>imo static html should not require a web server running
09:45<andythenorth>but I don't need to win that argument here
09:46<TrueBrain>you already lost :P
09:46<TrueBrain>okay, then I will change it to baseurl :)
09:46<TrueBrain>so does this also render a sitemap
09:48*andythenorth wonders how this sprite generator works
09:48<andythenorth>doubt anyone else is going to explain it to me
09:48<andythenorth>as I wrote it :P
09:49<andythenorth>maybe that reverse engineering guy could tell me https://dev.openttdcoop.org/projects/iron-horse/repository/entry/src/gestalt_graphics/pipelines.py
09:50<TrueBrain>lol .. 800 lines :D
09:52<andythenorth>think how much time I saved :P
09:52<andythenorth>if only I knew how it worked :P
09:59<TrueBrain>235 mappings to map old news to new news :D
09:59<TrueBrain>why noooottttt
10:12<DorpsGek_II>[OpenTTD/OpenTTD] LordAro approved pull request #7014: Fix 6a3d411: Silence truncation warning https://git.io/fh3rr
10:14<TrueBrain>very useful, to have 600 URLs you know should be valid :D
10:15<TrueBrain>12 fail, rest works
10:15<TrueBrain>and those 12, 8 are custom binaries we no longer do
10:16<DorpsGek_II>[OpenTTD/OpenTTD] LordAro approved pull request #7012: Play Fluidsynth music through the mixer https://git.io/fh3oO
10:18<LordAro>TrueBrain: what are the remaining 4?
10:18<TrueBrain>server-listing, stats, news/page/0, and a single screenshot
10:19<TrueBrain>server-listing is a TODO, stats will be removed, fixed the pages, and the screenshot can kiss my ass :D
10:19<DorpsGek_II>[OpenTTD/OpenTTD] LordAro approved pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929) https://git.io/fh3oC
10:21<LordAro>seems a shame to lose stats
10:21<LordAro>but not exactly feasible with a static site
10:21<TrueBrain>not feasible with a cloud-solution
10:21<LordAro>also that
10:21<TrueBrain>and as we also want to enable Steam, Epic, Flatpack, Snap, ..
10:21<TrueBrain>we will lose sight on downloads anyway
10:22<TrueBrain>additionally, that stats page is VERY slow to load, and the table broke often and frequently :)
10:22<DorpsGek_II>[OpenTTD/OpenTTD] LordAro approved pull request #7002: Add: [Win32] regression testing with MSVC https://git.io/fh3o0
10:22<TrueBrain>so yeah, I agree, it is a shame .. but ... guess progression sometimes means losing information
10:22<LordAro>indeed :)
10:26<DorpsGek_II>[OpenTTD/website] TrueBrain opened pull request #15: Add: [#9] Redirect old URLs to new URLs https://git.io/fh3oi
10:26<TrueBrain>big blob :D
10:27<TrueBrain>didnt feel like making 5 PRs, sorry about that :)
10:27<LordAro>i'll cope :p
10:28<TrueBrain>much appreciated :)
10:29<DorpsGek_II>[OpenTTD/website] TrueBrain updated pull request #15: Add: [#9] Redirect old URLs to new URLs https://git.io/fh3oi
10:29<TrueBrain>always finding this one bug just after pushing ... :D
10:30<Samu>I have a problem with this function returning VehicleID 0 in test mode
10:30<Samu>https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/script_vehicle.cpp#L64
10:31<Samu>it could actually be a real vehicle
10:31<TrueBrain>https://github.com/OpenTTD/website/blob/02caadd5b28fae776b1a34f9d5bbfce18907fc9e/nginx.default.conf <- for those who want to giggle
10:32<DorpsGek_II>[OpenTTD/OpenTTD] Hezkore commented on issue #7006: Hardware mouse cursor https://git.io/fh3o5
10:33<LordAro>TrueBrain: thoughts on using nginx to remove .html ?
10:33<DorpsGek_II>[OpenTTD/website] LordAro approved pull request #15: Add: [#9] Redirect old URLs to new URLs https://git.io/fh3oA
10:33<Samu>How do I check if I'm running in test mode vs exec mode?
10:33<TrueBrain>LordAro: I .. checked .. seems I have no feeling for either one :)
10:34<DorpsGek_II>[OpenTTD/website] TrueBrain merged pull request #15: Add: [#9] Redirect old URLs to new URLs https://git.io/fh3oi
10:34<DorpsGek_II>[OpenTTD/website] TrueBrain closed issue #9: Redirect old URLs to new URLs https://git.io/fhOMe
10:34<TrueBrain>tnx LordAro
10:35<Samu>there's AIExecMode() and AITestMode(), but what I need is to know which mode the AI is currently running at
10:36<andythenorth>hmm
10:36<andythenorth>very pixels
10:38<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on pull request #7003: Feature #6918: Add option to adjust font size separately from GUI size. https://git.io/fh3KI
10:39<Samu>moving the project to github is probably gonna be a bad decision in the long run
10:40<Samu>everyone is editing it
10:40<LordAro>...and you think that's a bad thing?
10:40<TrueBrain>collaboration is the worst!
10:40<Samu>i can already see pull requests piling up
10:40<LordAro>it's not like they weren't before
10:40<LordAro>they just weren't so obvious
10:41<@peter1138>Contributions are bad? o_O
10:41<TrueBrain>STOP DOING IT
10:41<@peter1138>I did :D
10:41<TrueBrain>good
10:41<LordAro>peter1138: you should finish your PRs :P
10:42<TrueBrain>hmm .. 2 redirect lines are not hitting on staging
10:42<TrueBrain>that is odd
10:42<Eddi|zuHause>TrueBrain: it'll be a typo that is both obvious and impossible to find at the same time
10:43<TrueBrain>oops, last minute change :D
10:43<Eddi|zuHause>TrueBrain: and after you've searched yourself to death for 2 hours, someone else will come along, take a short look and immediately find it
10:44<TrueBrain>took me 2 minutes, sorry :P
10:45<Samu>I'm a guy with little faith and negative, so, maybe you see it in another way
10:45<Eddi|zuHause>lucky :p
10:45<TrueBrain>the thousands of projects on GitHub indeed give no indication what so ever that it is a good move :)
10:46<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on pull request #7005: Fix #7004: Redraw linkgraph overlay correctly after zoom https://git.io/fh3Kz
10:47<Eddi|zuHause><TrueBrain> STOP DOING IT <-- well "someone" wanted to change to github to get more contributions and better collaboration...
10:47<TrueBrain>sounds like a horrible person
10:47<Eddi|zuHause>he must have been an idiot...
10:48<Samu>okay, I'm a different person
10:48<DorpsGek_II>[OpenTTD/website] TrueBrain opened pull request #16: Minor mistakes in redirects https://git.io/fh3K2
10:48<TrueBrain>no shit? SO AM I!
10:48<TrueBrain>BESTIES!
10:49<Samu>how would you decide what to merge, what not to merge, if the amount of code to review just keeps coming in form of pull requests?
10:49-!-Lejving [~Lejving@81-233-148-192-no524.tbcn.telia.com] has joined #openttd
10:49-!-Lejving is "realname" on @#openttdcoop.pz #mashinky #factoriocoop #/r/openttd #openttd
10:49<TrueBrain>luxary issues
10:49<Samu>how can you control it
10:50<DorpsGek_II>[OpenTTD/website] LordAro approved pull request #16: Minor mistakes in redirects https://git.io/fh3K6
10:51<Samu>just worried it would get out of control one day
10:51<andythenorth>same as we used to
10:51<andythenorth>just ignore it
10:51<andythenorth>there were hundreds of patches in flyspray and forums
10:51<andythenorth>none of my patches were ever accepted
10:51<andythenorth>but now we don't have to run our own git
10:52<andythenorth>profit
10:52<DorpsGek_II>[OpenTTD/website] TrueBrain merged pull request #16: Minor mistakes in redirects https://git.io/fh3K2
10:52<andythenorth>hmm
10:52<andythenorth>nielsm requested EMUs
10:53<andythenorth>that means I need a sprite generator for pax coaches AND pantographs
10:53<andythenorth>currently I have one of each, they don't mix
10:53*andythenorth very python
10:53<andythenorth>TrueBrain: have you written the 'close this PR' bot yet?
10:53<TrueBrain>no
10:53<TrueBrain>I have been looking how other projects go about 'rot'
10:53<andythenorth>I can do it mechanical turk style? o_O
10:54<TrueBrain>yes
10:54<andythenorth>close after 6 months
10:54<TrueBrain>most projects do rot like: a bot says something after N days, like: if you dont say this in M days, I will close this PR
10:54<TrueBrain>that seems pretty efficient
10:54<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on pull request #6988: Change: AI/GS ScriptBridge::GetName takes one extra parameter to refer the vehicle type https://git.io/fh3KM
10:54<andythenorth>yes
10:54<andythenorth>just what is N?
10:54<TrueBrain>so we might just copy/paste one of those bots out there
10:54<TrueBrain>most have N of 90, and M of 30
10:54<andythenorth>probably N days with nothing useful happening
10:55<andythenorth>not N days since created :P
10:55<TrueBrain>no, since last comment
10:55<TrueBrain>activity
10:55<andythenorth>+1
10:55<andythenorth>let's see
10:55<andythenorth>hmm maybe not
10:55<TrueBrain>I wrote DorpsGek_II with the idea we all had to do it ourself; now a lot of stuff we no longer have to do ourself, it might be easier to use existing bots :)
10:55*andythenorth is feeling too silly to do this today
10:56<andythenorth>tempted to close all my PRs :P
10:56<andythenorth>TrueBrain: do comments like this reset N? https://github.com/OpenTTD/OpenTTD/pull/6780#issuecomment-438065356
10:57<TrueBrain>a bot would think so, I would not :)
10:58<andythenorth>AI runs amok
10:58<TrueBrain>https://github.com/probot/stale
10:58<andythenorth>this is blatantly diverting andythenorth from reading 800 lines of sprite generator
10:58<andythenorth>probot is winning
10:59<TrueBrain>okay, staging now validates on all URLs I know of
10:59<TrueBrain>so .. only serverlisting to go
10:59<andythenorth>\o/
10:59<TrueBrain>`The app uses GitHub's updated search qualifier to determine staleness. Any change to an issues and pull request is considered an update, including comments, changing labels, applying or removing milestones, or pushing commits.`
11:00<TrueBrain>For Samu, from the URL I just linked:
11:00<TrueBrain>`But in any successful software project, there's always more work to do than people to do it. As more and more work piles up, it becomes paralyzing. Just making decisions about what work should and shouldn't get done can exhaust all available resources. In the experience of the maintainers of this app—and the hundreds of other projects and organiza
11:00<TrueBrain>tions that use it—focusing on issues that are actively affecting humans is an effective method for prioritizing work.`
11:01<TrueBrain>lets ask frosch when he arrives if he agrees with deploying that bot; but that is otherwise an easy fix
11:01<TrueBrain>lets do it for Pull Request only for now
11:01<andythenorth>work paralysis
11:01<TrueBrain>a lot of projects also deploy this for issues
11:01<andythenorth>how many times I've had to explain why I keep backlogs to < 100 issues
11:01<andythenorth>at work
11:01<TrueBrain>dont get me started on that :P
11:01<LordAro>i don't think it'd be very helpful on issues
11:01<TrueBrain>I have seen the weirdest backlogs
11:01<andythenorth>'we have two weeks'
11:02<LordAro>just generate noise
11:02<TrueBrain>LordAro: it really is; we now have 20+ triage tickets
11:02<andythenorth>'so we can spend 4 days on a "proper" setup'
11:02<TrueBrain>nobody is picking up any
11:02<TrueBrain>how important are they still?
11:02<andythenorth>or we can do the top 20
11:02<LordAro>TrueBrain: oh, applied to some subset, yes
11:02<TrueBrain>if you remove all triage, and a new one arrives, you are MUCH more likely to act on it
11:02<andythenorth>TrueBrain: can we be ruthless about the reported weird defects?
11:02<andythenorth>clearly if they were common, we'd hear about them more
11:03<andythenorth>we track failure demand at work and only act on commonly recurring issues, unless it's an infosec issue
11:03<TrueBrain>personally, I really dont care; closing them telling it was the first report, open if there are more, is fine by me
11:03<TrueBrain>closing them with: wontfix, less fine :)
11:03<andythenorth>I'lll look at them
11:03<TrueBrain>in agile teams, I like to just have the stakeholders make their top N list
11:03<TrueBrain>let them explain it
11:03<TrueBrain>and vote on what to pick up
11:03<TrueBrain>the N has to be small, as they only have an hour
11:04<TrueBrain>(and you round-robin their list)
11:04<Eddi|zuHause>is there something inbetween "open" and "closed"? "stale"?
11:04<TrueBrain>so it is in their best interest to have the tickets clear, actionable, and their job to have others vote for theirs
11:04<TrueBrain>important things always bubble up
11:04<TrueBrain>but stakeholders in Open Source is DIFFICULT
11:05<TrueBrain>Eddi|zuHause: with labels, yes
11:05<@peter1138>Yeah, sorry I'm just a shit dev.
11:05<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6688: Random game crash https://git.io/fh36I
11:05<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6688: Random game crash https://git.io/fh36L
11:05<andythenorth>'stakeholders'
11:05<@peter1138>I just code stuff. The rest of it is draining and too much like work so, yeah, I don't bother. I do this for fun.
11:05<DorpsGek_II>[OpenTTD/OpenTTD] LordAro requested changes for pull request #6983: Feature: Town name filtering https://git.io/fh36t
11:08<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6691: crash when first boat reaches destination for subsidised transport https://git.io/fh36W
11:08<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6691: crash when first boat reaches destination for subsidised transport https://git.io/fh36l
11:08<andythenorth>peter1138: fair :P
11:08<@peter1138>I guess my PRs will die and that's a shame.
11:08<LordAro>:(
11:09<LordAro>peter1138: i'd really like to see #6780 done, if you want something to focus on :>. Just needs a rebase, afaict
11:09<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6677: Fast Forward Button https://git.io/fh36B
11:09<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6677: Fast Forward Button https://git.io/fh36R
11:09<Eddi|zuHause>what's the magic git invocation to take a commit in master and apply it on top of a branch?
11:10<andythenorth>cherrypick is my preferred
11:10<LordAro>a specific commit? cherry-pick
11:10<andythenorth>some would rebase
11:10<andythenorth>to show off :P
11:10<TrueBrain>I love 'rebase -i'
11:10<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6668: OpenTTD crash in ICU routine https://git.io/fh360
11:10<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6668: OpenTTD crash in ICU routine https://git.io/fh36E
11:10<LordAro>andythenorth: surprised #6677 survived the previous issue cull
11:10<Eddi|zuHause>how do i spell that out?
11:11<andythenorth>well it is an issue, and was waiting for reporter to return LordAro
11:11<andythenorth>but yeah, it's 2019 now
11:11<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6675: Crash when switching language in game https://git.io/fh36u
11:11<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6675: Crash when switching language in game https://git.io/fh36z
11:11<TrueBrain>andythenorth: https://probot.github.io/apps/no-response/ ? :D
11:11<andythenorth>Eddi|zuHause: https://git-scm.com/docs/git-cherry-pick
11:12<@peter1138>LordAro, I don't even know what needs doing to 6780 now
11:12<LordAro>probably nothing :)
11:12<@peter1138>Then I'll do that then.
11:12<LordAro>(except VS project file conflicts)
11:12<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6655: Crash: [ICU] The game never opens and the Arabic language in the form of numbers and symbols https://git.io/fh36a
11:12<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6655: Crash: [ICU] The game never opens and the Arabic language in the form of numbers and symbols https://git.io/fh36V
11:12<andythenorth>I wish I didn't have an irc highlight on andythenorth right now :P
11:13<Eddi|zuHause>make highlights silent
11:13<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6882: fatal application failure https://git.io/fh36o
11:13<TrueBrain>so LordAro, what are the changes you rebase https://github.com/OpenTTD/OpenTTD/pull/6917 (while talking about rebases) :D
11:13<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6882: fatal application failure https://git.io/fh36K
11:13<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6563: Crash: [ICU] when using "Times New Roman" as large font https://git.io/fh366
11:13<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6563: Crash: [ICU] when using "Times New Roman" as large font https://git.io/fh36P
11:13<Eddi|zuHause>or in advanced clientes, make it ignore the highlight if a bot says it
11:14<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6400: Crash: ctrl-clicking a factory type in map https://git.io/fh36X
11:14<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6400: Crash: ctrl-clicking a factory type in map https://git.io/fh361
11:14<andythenorth>this is much better than fixing my sprite generator :)
11:14<andythenorth>admin ftw
11:16<DorpsGek_II>[OpenTTD/OpenTTD] LordAro dismissed a review for pull request #6917: Fix iconv and clang version detection on OSX https://git.io/fpitd
11:16<DorpsGek_II>[OpenTTD/OpenTTD] LordAro updated pull request #6917: Fix iconv and clang version detection on OSX https://git.io/fpEvc
11:16<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh merged pull request #7013: Fix 6accbf9: Silence warnings about unused fread() result https://git.io/fh3ua
11:17<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh merged pull request #7012: Play Fluidsynth music through the mixer https://git.io/fh30T
11:17<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #994: Spectator cannot see list of available vehicles https://git.io/fh36F
11:17<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #994: Spectator cannot see list of available vehicles https://git.io/fh36b
11:17<andythenorth>word soup
11:17<LordAro>LOUD NOISES
11:18<andythenorth>this is SO EASY TO FIX https://github.com/OpenTTD/OpenTTD/issues/3958
11:18<TrueBrain>lets see if CI likes your work LordAro :)
11:18<andythenorth>I shoudl do it :P
11:18<TrueBrain>I like that the ticket reads: "Patching for this was harder than I thought - more lines to touch."
11:18<TrueBrain>written by the same person who just yelled it is so easy to fix :D
11:19<LordAro>^
11:19<LordAro>but yes, you should do it
11:19<andythenorth>I was expecting a one line fix, not a five line fix
11:19<andythenorth>5x as much work :P
11:20<andythenorth>also I'd have to learn some C++
11:20<LordAro>well, get a move on then
11:20<LordAro>and you can have the honour of fixing a 9 year old bug
11:20<LordAro>i've been annoyed by this in the past as well
11:20<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5656: Orders: current order should be discard if orders are changed https://git.io/fh3if
11:20<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5656: Orders: current order should be discard if orders are changed https://git.io/fh3iJ
11:20<andythenorth>LordAro: I'm doing what I'm best at :P
11:21<andythenorth>creating spam in the channel
11:21<LordAro>haha
11:21<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh merged pull request #7014: Fix 6a3d411: Silence truncation warning https://git.io/fh3uh
11:21<LordAro>how long until TB gives in and merges the "close with comment" messages? :p
11:21<TrueBrain>LordAro: you cannot press merge on OpenTTD PRs?
11:21<LordAro>TrueBrain: i cannot
11:21<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6250: Crash: (hang) dedicated server hang with 100% CPU utilization, possibly pathfinder? https://git.io/fh3iT
11:21<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6250: Crash: (hang) dedicated server hang with 100% CPU utilization, possibly pathfinder? https://git.io/fh3ik
11:21<TrueBrain>odd
11:22<TrueBrain>ah .. I get why
11:22<TrueBrain>ugh, let me poke frosch when he joins :P
11:22<Borg>hmm :(
11:22<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6298: Crash: R27221 assertion failed crash https://git.io/fh3iO
11:22<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6298: Crash: R27221 assertion failed crash https://git.io/fh3i3
11:22<Borg>I cant find my ticket of industry text redraw issue
11:22<Borg>will it ever be handled?
11:22<TrueBrain>LordAro: merges? there is a PR for that?
11:22<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6382: Timetable: when loading a 1.4.4 saved game in 1.5.0 or 1.5.2, trains leave too early https://git.io/fh3iG
11:22<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6382: Timetable: when loading a 1.4.4 saved game in 1.5.0 or 1.5.2, trains leave too early https://git.io/fh3iZ
11:23<LordAro>andythenorth: is it a good idea to close crash bugs?
11:23<andythenorth>I wondered
11:23<andythenorth>but on balanace yes
11:23<andythenorth>unless there is a pattern of them, like ICU
11:23-!-Wormnest [~Wormnest@35.136.176.177] has joined #openttd
11:23-!-Wormnest is "Wormnest" on #openttd
11:23<andythenorth>or the AI overflow
11:23<TrueBrain>I think with that message, it is fine
11:23<LordAro>hmm
11:23<andythenorth>ICU was really clear pattern
11:23<andythenorth>and the AI crashes are too
11:23-!-glx [kvirc@000128ec.user.oftc.net] has joined #openttd
11:23-!-mode/#openttd [+v glx] by ChanServ
11:23-!-glx is "Loïc GUILLOUX" on +#openttd
11:24<TrueBrain>LordAro: I cannot make a "commented and closed", as the order of these events are unpredictable :(
11:24<TrueBrain>so I cannot keep one or the other back
11:24<LordAro>with ICU, sure (especially when they're mostly windows, which will be fixed in 1.9 anyway)
11:24<TrueBrain>(at least, I wouldnt know how)
11:24<andythenorth>well I can stop for a bit, to prevent the spam
11:24<LordAro>but other crash bugs still exist, however unlikely they may be to hit
11:24<nielsm>TrueBrain, what about delaying them by 5 seconds and coalescing if you see either order?
11:24<Borg>https://github.com/OpenTTD/OpenTTD/issues/3701 <- pffft.. fixed my ass ;)
11:24<andythenorth>LordAro: I'm not closing all of them
11:24<TrueBrain>nielsm: that is possible; delaying is only annoying, but .. I guess that would work
11:24<TrueBrain>its asyncio, so I can just start a timer in a coroutine
11:25<andythenorth>but a report of a bug in an old savegame in a newer version, where a change was already made to fix a bug, meh
11:25<andythenorth>we don't migrate all old broken savegame content, right?
11:25<LordAro>andythenorth: that one made sense, sure
11:26<+glx>oh somehow is closing all ICU issues :)
11:26<LordAro>but #6750 & #6298 seems less clear to me, especially when they have tracebacks
11:26<andythenorth>it's not fixed yet, but we have an issue for fixing it
11:26<LordAro>/assertions
11:26<LordAro>issue lists aren't priority lists
11:26<LordAro>if they get closed, the issue definitely will get lost, even if it's still there
11:27<andythenorth>I am happy to reopen them
11:28<TrueBrain>the problem is, we have 200+ tickets. The chance of these things to be picked up is ... currently VERY low
11:28<andythenorth>I'm going by the date
11:28<TrueBrain>we have nobody who is doing triage
11:28<andythenorth>reported 2015...triage requested April 2018
11:28<andythenorth>now it's 2019
11:28<TrueBrain>and as these tickets are once-in-a-milion, the chance of it happning again is VERY low
11:28<TrueBrain>so how ever bad it might seem, you are closing a real bug that "should be fixed"
11:28<TrueBrain>we have finite time ..
11:28<TrueBrain>so is keeping them around really contributing?
11:28<TrueBrain>I rather have that new triages are picked up ASAP
11:29<TrueBrain>(it is a bit of psychology)
11:29<TrueBrain>would be nice to label them as "never resolved", in what-ever way
11:29<TrueBrain>"stale" or what-ever
11:29<TrueBrain>but keeping them around for the shake of keeping them around is, how ever weird it might sound, counterproductive
11:29<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh commented on issue #6873: Jukebox not working in the flatpak version https://git.io/fh3i2
11:29<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh closed issue #6873: Jukebox not working in the flatpak version https://git.io/fh3ia
11:29<andythenorth>unwinnable game
11:30<andythenorth>make winnable games
11:30<TrueBrain>prioritze :)
11:30<andythenorth>want me to add 'unresolved bug report' or something?
11:30<andythenorth>I can do that first as a label
11:30<TrueBrain>I think "stale" is the word for this
11:30<andythenorth>ok
11:30<LordAro>that'd make me happier
11:30<TrueBrain>but others might have other opinions :)
11:30<LordAro>though not happy :p
11:30<andythenorth>I can do the label first
11:30<andythenorth>then close later
11:30<TrueBrain>label + close now?
11:30<TrueBrain>that label really is not going to change anything
11:31<TrueBrain>just that label allows us to find them back, if needed
11:31<TrueBrain>LordAro: I think everyone fully agrees with you; you just notice that andythenorth and me have management functions :D
11:31<andythenorth>oof :(
11:31<TrueBrain>we know from experience that it is a harsh world :)
11:31<LordAro>:)
11:31<Eddi|zuHause>my concern is, if you close them, nobody will ever look at them again
11:31<LordAro>ok, someone can merge #6917 now :p
11:32<andythenorth>Eddi|zuHause: nobody is ever looking at them :)
11:32<andythenorth>what changed, in information terms?
11:32<LordAro>what eddi said
11:32<TrueBrain>what andythenorth said :P
11:32<nielsm>well this certainly looks wrong... https://0x0.st/sRYi.png (re. https://github.com/OpenTTD/OpenTTD/issues/6666)
11:32*andythenorth asserts things that may not be true
11:32<andythenorth>to avoid irc hot air, these need triage https://github.com/OpenTTD/OpenTTD/issues?q=is%3Aopen+is%3Aissue+label%3A%22needs+triage%22
11:32<andythenorth>there are 29
11:32<LordAro>andythenorth: there's a difference between "unlikely for someone to look at them" and "no one will look at them"
11:32<andythenorth>they haven't been triaged since ~April 2019
11:32<Eddi|zuHause>"find them back" is also bad, because people who looked at it and said "legitimately closed", won't remove the "stale" tag
11:33<andythenorth>I am fine to go and make a pixel generator :)
11:33<TrueBrain>andythenorth: I call bullshit :P
11:33<LordAro>i'd prefer open + stale label, personally
11:33<andythenorth>no shortage of unfinished jobs :P
11:33<TrueBrain>what does the 'open' part add?
11:33<TrueBrain>nobody is going to look at these triages anyway
11:33<andythenorth>not having to argue here?
11:33<TrueBrain>nobody has in over 5 years
11:33<TrueBrain>so ..... :D
11:33<TrueBrain>I would suggest we either start doing triage
11:34<TrueBrain>or we stop caring for 2+ year old triages
11:34<TrueBrain>you can't have it both :D
11:34*andythenorth wonders what we lost when I closed 600 issues in flyspray :P
11:34<Eddi|zuHause>unfathomable values
11:34<andythenorth>@calc 600 / 29
11:34<@DorpsGek>andythenorth: 20.6896551724
11:34<andythenorth>20x worse :P
11:34<LordAro>idk
11:34<LordAro>closed implies fixed, in my head
11:35<TrueBrain>no; that is not true for sure :)
11:35<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5823: Update baseset translations atomatically via WebTranslator daemon https://git.io/fh3id
11:35<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5823: Update baseset translations atomatically via WebTranslator daemon https://git.io/fh3iF
11:35<TrueBrain>if someone reports a bug, you ask for extra information, and they don't reply in 3 months
11:35<TrueBrain>closing them doesnt mean: fixed :)
11:35<TrueBrain>it just means: never going to happen I guess
11:35<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5886: [Allegro] Messed up colors when switching to zBase and back to OpenGFX https://git.io/fh3iA
11:35<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5886: [Allegro] Messed up colors when switching to zBase and back to OpenGFX https://git.io/fh3ix
11:35<DorpsGek_II>[OpenTTD/OpenTTD] PeterN updated pull request #6780: Change: Refactor window ticks into game ticks and realtime events. https://git.io/vpDSL
11:36<TrueBrain>(that is why most systems btw have close-reason)
11:36<LordAro>andythenorth: #5823 looks like it's literally the thing you were asking for earlier
11:36<Eddi|zuHause>i think we need clearer rules to discuss: like which scenarios of tickets this applies to, which timeframe, ...?
11:36<andythenorth>LordAro: proof!
11:36<andythenorth>:)
11:36<TrueBrain>best approach most projects are finding out: all issues / pull request: 3 months stale, mark stale and ask if anyone cares. Month later, close
11:37<andythenorth>LordAro: but we already decided that it's just an issue local to me :)
11:37<andythenorth>so I have patched my ~/.gitignore
11:37<TrueBrain>we can just enable https://github.com/probot/stale on all issues too :D
11:37<Eddi|zuHause><andythenorth> LordAro: but we already decided that it's just an issue local to me :) <-- for what value of "we", "decided", "local" and "me"?
11:38<andythenorth>Truebrain told me it was
11:38<TrueBrain>stop having grfcodec installed
11:38<Eddi|zuHause>he's an idiot and knows nothing
11:38<TrueBrain>we established that, yes
11:38<andythenorth>is this one *not* ICU? o_O https://github.com/OpenTTD/OpenTTD/issues/6221
11:39<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain approved pull request #6917: Fix iconv and clang version detection on OSX https://git.io/fh3PY
11:39<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain merged pull request #6917: Fix iconv and clang version detection on OSX https://git.io/fpEvc
11:39<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain closed issue #6880: Compile fails on src/economy.cpp:702:20: error: expected expression https://git.io/fh3PO
11:39<andythenorth>wat
11:39<TrueBrain>now andythenorth doesn't need to hack :P
11:39<andythenorth>now andythenorth doesn't need to hack
11:39<TrueBrain>I closed a ticket I know NOTHING OF :P
11:39<andythenorth>now andythenorth needs to rebase :P
11:40<@peter1138>LordAro, #6780 rebased, hope it's correct :p
11:40<nielsm>yep adding some {LRE} fixes the towns list: https://0x0.st/sRYX.png
11:40<LordAro>peter1138: :)
11:40<@peter1138>Needs someone else to review becuase... er... it's my PR.
11:41<@peter1138>nielsm, what happens when it's not fixed?
11:41<nielsm>how much taboo is it to edit foreign translations to fix an entirely technical issue? :)
11:41<nielsm>peter1138: https://0x0.st/sRYi.png
11:41<nielsm>or https://bugs.openttd.org/task/6666/getfile/10959/Arabic.png
11:41<@peter1138>Ooo
11:41<Eddi|zuHause><nielsm> how much taboo is it to edit foreign translations to fix an entirely technical issue? :) <-- i'm fairly sure that has been done
11:41<LordAro>i wouldn't have an issue with it
11:41<@peter1138>Yeah, fine by me.
11:42<nielsm>the text in that bug reporter's screenshot also looks very broken regardless
11:42-!-Oroburos [~Notthatim@cpc72333-sotn15-2-0-cust299.15-1.cable.virginm.net] has joined #openttd
11:42-!-Oroburos is "realname" on #biz #redditprivacy #openttd
11:42<nielsm>I don't think there's supposed to be + and % signs everywhere
11:42<nielsm>(date and window title, for example)
11:43<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth updated pull request #6811: Feature: Add NotRoadTypes (NRT) https://git.io/vhlfg
11:43<andythenorth>that's gonna fail
11:43<andythenorth>probably need a branch just for the PR
11:44<andythenorth>and do fixes in a different branch until ready
11:44<andythenorth>very admin
11:44<TrueBrain>that is called a fork :)
11:45<Eddi|zuHause>isn't that how github tells you to do things anyway?
11:45<TrueBrain>funny enough, the first GitHub guide tells you to use a branch in the upstream repository
11:45<TrueBrain>it is only later they talk about forks
11:46<+glx>step by step :)
11:46<andythenorth>hang on I fork my fork?
11:46<andythenorth>wat?
11:46<LordAro>branch your branch, technically
11:47<TrueBrain>or use your branch in your fork
11:47<TrueBrain>that is a branch too :P
11:47<Eddi|zuHause>i'm not sure what "first" is, but what i do is pull from the upstream github repo, make my branch, and push that to my forked github repo
11:47<andythenorth>fork my branch
11:47<LordAro>"fork" is usually used for more permanent divergences
11:47<Eddi|zuHause>then make a PR from the forked repo into the upstream repo
11:48<TrueBrain>hmm .. Azure Pipelines is still weird in when it picks up work .. experiments are slow-going :D
11:48<Eddi|zuHause>only the last step needs access to github web interface (and the original forking, but that was ages ago)
11:48<Eddi|zuHause>(needs to be done only once)
11:50<TrueBrain>`The job running on agent Hosted Agent has exceeded the maximum execution time of 60. `
11:50<TrueBrain>:D
11:50<TrueBrain>gratz andythenorth :D
11:50<andythenorth>oof
11:50<andythenorth>FFS
11:50*andythenorth hates everything now
11:50<andythenorth>bug or intended? https://github.com/OpenTTD/OpenTTD/issues/6061
11:50<Eddi|zuHause>60 what? sausages?
11:51<andythenorth>plenty of issues to triage here, if anyone wants a go
11:51<TrueBrain>so mmmaaannnyyyyy :D
11:51<LordAro>andythenorth: depends what the town is trying to do, i imagine
11:51<nielsm>"git pull" and then it hangs... wtf
11:52<LordAro>#blamegithub
11:52<TrueBrain>#blameeddit
11:52<TrueBrain>hmm
11:52<TrueBrain>#blameeddi
11:52<TrueBrain>no clue why typing 'eddi' followed a t instinctively
11:52<TrueBrain>I am on reddit too much
11:52<Eddi|zuHause>andythenorth: i'm leaning towards intended, but could be an obiwan somewhere
11:53<andythenorth>I discovered today, reddit isn't just racism :o
11:53<andythenorth>there are actual communities on there
11:53<nielsm>argh I accidentally made another branch on main repo
11:53<Eddi|zuHause>i thought racism was facebook, never heard reddit in that context
11:53<andythenorth>bad nielsm
11:54<andythenorth>I have quit facebook, but it was definitely racism
11:54<TrueBrain>for every branch, a puppy dies, right? :P
11:54<@peter1138>modified: bin/baseset/no_sound.obs
11:54<@peter1138>what is this that happens
11:54<LordAro>andythenorth: not just you
11:55<LordAro>peter1138: baseset translations get updated when grfcodec on path
11:55<andythenorth>LordAro: broke it https://github.com/OpenTTD/OpenTTD/issues/6507
11:55<andythenorth>peter1138: remove grfcodec from your path
11:56<DorpsGek_II>[OpenTTD/OpenTTD] ghisvail commented on issue #6873: Jukebox not working in the flatpak version https://git.io/fh3Pj
11:56<LordAro>i think ./configure --without-grfcodec would be nicer
11:56<andythenorth>LordAro: how did you break 2 depot tiles then? o_O
11:56<LordAro>andythenorth: i have no idea
11:56<LordAro>it is an extremely old save file
11:57<TrueBrain>just close it: "incompetent user"
11:57<TrueBrain>easy :D
11:57<TrueBrain><3
11:57<LordAro>:(
11:57<andythenorth>I have stopped closing issues
11:57<andythenorth>to reduce localised anxiety levels
11:57<TrueBrain>did .. someone just ask for a release date? OMG!
11:57<Eddi|zuHause><peter1138> modified: bin/baseset/no_sound.obs <-- it's updated translations that the translator commit for some reason doesn't do automatically
11:59<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on pull request #6780: Change: Refactor window ticks into game ticks and realtime events. https://git.io/fh3XI
11:59<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh commented on issue #6873: Jukebox not working in the flatpak version https://git.io/fh3Xm
12:00<nielsm>okay I can't make git delete that remote branch...
12:00<TrueBrain>which one?
12:01<nielsm>oh maybe I found the way
12:01<nielsm>yes
12:01<+glx>click on delete in the PR
12:01<Eddi|zuHause>nielsm: you mean the branch on the remote server, or your local knowledge of the branch on the remote server?
12:03<TrueBrain>343 commits since 1.8
12:03<TrueBrain>that is almost twice as much as 1.7 -> 1.8 :P
12:03<LordAro>:)
12:03<andythenorth>loads more PRs too
12:04<andythenorth>infinite amount more
12:04<TrueBrain>okay, so I have to find a way to keep doing serverlisting via the old django thingy .. after that a release pipeline .. and setup the CDN so releases can be published there
12:04<andythenorth>TB https://www.tt-forums.net/viewtopic.php?p=1213870#p1213870
12:05<andythenorth>so 100 commits since October now
12:06<TrueBrain>release pipeline is mostly done. Does Mac have any debug symbol-like file it leaves behind?
12:06<TrueBrain>oeh!!! We can now make .dmg files for Mac! :o :D
12:06<TrueBrain>I did not realise that yet
12:06<TrueBrain>but that is awesome
12:06<LordAro>!
12:07<TrueBrain>owh, Windows installer .. that is one that might take a bit of time
12:07<TrueBrain>NSIS is not installed on the agents
12:07<TrueBrain>so we need to figure that out ..
12:07<TrueBrain>linux releases are done
12:08<TrueBrain>Mac is easy because of 'bundle_dmg'
12:08<TrueBrain>given that it still works
12:08<TrueBrain>andythenorth: if you have some spare time, can you check if 'make bundle_dmg' results in a file that still works on Mac?
12:08<TrueBrain>it should be that if you double click that file it starts OpenTTD, I believe?
12:09<andythenorth>dmg should give a disk image
12:09<andythenorth>let's see
12:10<nielsm>I think I tried make bundle_zip in my azure pipeline tests, and andy could run those builds produced
12:10<DorpsGek_II>[OpenTTD/OpenTTD] glx22 merged pull request #7002: Add: [Win32] regression testing with MSVC https://git.io/fhLHR
12:10<TrueBrain>nielsm: yeah, we used to do zips for Mac .. but dmgs are more powerful :D
12:10<TrueBrain>so that would be a very nice cherry-on-top :D
12:10<nielsm>dmg numbers
12:11<nielsm>massive dmg
12:11*andythenorth wonders why compiling is sooooooooooo slow
12:12<andythenorth>yeah dmg arrived
12:12<andythenorth>opens
12:12<andythenorth>binary works on double click
12:12<andythenorth>job done
12:12<TrueBrain>cool :D
12:12<+glx>it can't be slower than a MSVC release build
12:12<andythenorth>hmm
12:12<TrueBrain>that improves the quality a bit :)
12:12<andythenorth>didn't trigger gatekeeper
12:12<andythenorth>that's interesting
12:12<TrueBrain>so who wants to figure out how to run NSIS on Azure Pipelines? :D
12:13<+glx>there's a .bat somewhere
12:13<TrueBrain>andythenorth: is producing the dmg alone enough? Or is it common to also publish the .zip ?
12:13<TrueBrain>glx: it also needs to be installed on the agent :P
12:13<+glx>ah
12:13<andythenorth>TrueBrain: probably just dmg, I'll check some sites
12:13*andythenorth never downloads software
12:13<TrueBrain>tnx andythenorth
12:14<TrueBrain>hmm, I need a container that produces source binaries and docs
12:14<nielsm>ugh, I think last I had problems with git not connecting to github via ssh I had to reboot
12:14<+glx>https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/win/scripts/Installers/Install-NSIS.ps1
12:14<nielsm>that's so annoying
12:14<andythenorth>TrueBrain: major mac software vendors seem to use dmg and zip interchangeably
12:14<andythenorth>dunno why, but eh, probably reasons
12:14<TrueBrain>glx: cool . that suggest it is installed in the image :)
12:15<TrueBrain>it is just not in the markdown telling about it :P
12:15<Samu>what if you could refit vehicle types?
12:15<TrueBrain>right; food!
12:17<andythenorth>Samu: ??
12:18<+glx>I think it's something you must put in the image creation
12:19<andythenorth>le cheval de fer? http://www.railpictures.net/photo/683010/
12:19<Samu>refit a road vehicle into a ship or so
12:20<Samu>or an aircraft into a train
12:20<andythenorth>then the world would explode
12:20<Eddi|zuHause>it has the pantograph up on the wrong end?
12:21<+glx>hmm no it should be already in vs2017-server2016
12:21<andythenorth>maybe it's going backwards Eddi|zuHause? o_O
12:21<andythenorth>which side do they run in France?
12:21<Eddi|zuHause>the wrong side, iirc
12:21<+glx>left
12:21<andythenorth>probably
12:21<andythenorth>definitely wrong
12:21<Samu>TestRefitVehicleUnitNumber().TryRefit(new_vehicle, AIVehicle.VT_ROAD, Utils.getCargoId(m_cargoClass))
12:22<+glx>comes from the steam era
12:22<Samu>I have a requirement for the vehicle type when working with my functions, and it happened to be the refit function
12:22<Eddi|zuHause>it's all the english's fault
12:22<+glx>the man putting coal in it was usually right handed
12:22<Samu>so that's where the idea came from
12:23<andythenorth>I think I broke it
12:23<+glx>but the metro runs on the right side
12:23<+glx>it was so the train won't go on the metro :)
12:23<andythenorth>ha ha
12:25<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #4313: Mapgen: limit amount of desert in sub-Tropic https://git.io/fh31c
12:25<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #4313: Mapgen: limit amount of desert in sub-Tropic https://git.io/fh31W
12:26<Eddi|zuHause>a propos dessert...
12:26<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #4076: Vehicle List: poor contrast of light red on grey for negative earnings https://git.io/fh31R
12:26<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #4076: Vehicle List: poor contrast of light red on grey for negative earnings https://git.io/fh310
12:26<andythenorth>tropic mapgen is fixed by just using the temperate generator :P
12:26<andythenorth>but eh
12:26<andythenorth>we have to do it the hard way
12:27<andythenorth>there's no rainforest because there's no high ground
12:27<andythenorth>because somebody misguidedly applied a transform to TGP
12:27<andythenorth>which makes the map flat
12:27-!-Oroburos [~Notthatim@cpc72333-sotn15-2-0-cust299.15-1.cable.virginm.net] has quit [Quit: Leaving]
12:28<andythenorth>https://www.tt-forums.net/viewtopic.php?f=33&t=74647&p=1165875&hilit=tropic#p1165875
12:31<@peter1138>Sorry about that.
12:31<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #2738: Vehicles: road vehicle overtaking https://git.io/fh31y
12:31<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #2738: Vehicles: road vehicle overtaking https://git.io/fh31S
12:32<andythenorth>peter1138: it was you who told me it was misguided :P
12:32<andythenorth>are you sure you did it?
12:32<andythenorth>you were quite...cross about TGP at the time :P
12:32<andythenorth>something like "how was this ever supposed to work"
12:32<Eddi|zuHause>i'm pretty sure that part is older, and peter1138 was thinking of that time when he added the height distribution curves
12:33<andythenorth>yeah
12:34<@peter1138>Both really.
12:36-!-Thedarkb-T60 [~Thedarkb-@51-171-110-9-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
12:36-!-Thedarkb-T60 is "realname" on #oolite #openttd
12:37<@peter1138>I had (standalone) code to generate more interesting terrain but I think it got lost in my SSD crash.
12:37<andythenorth>I played a map you made once
12:37<andythenorth>some kind of big river
12:38<andythenorth>hmm
12:38<andythenorth>'stale' doesn't make any sense for feature requests, right?
12:38<andythenorth>TrueBrain: ^
12:39<andythenorth>most feature requests *won't* have any activity
12:39<Samu>I don't get callbacks, I never know where exactly they're triggered
12:40<Eddi|zuHause>i think there need to be different timeframe based on whether anyone claimed it as "i'm working on this"
12:41<Eddi|zuHause>and if there's code, the timeframe should not be less than 1 year
12:41<andythenorth>I marked this stale, but I don't think it helps https://github.com/OpenTTD/OpenTTD/issues/4711
12:41<andythenorth>as an example
12:43<Eddi|zuHause>i think that can safely be closed as "won't implement"
12:44<andythenorth>so are issues a roadmap?
12:44*andythenorth is confused
12:44-!-Thedarkb1-T60 [~Thedarkb-@51-171-110-9-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
12:44-!-Thedarkb1-T60 is "realname" on #oolite #openttd
12:44<Eddi|zuHause>np
12:44<Eddi|zuHause>no
12:46-!-Thedarkb-T60 [~Thedarkb-@51-171-110-9-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
12:53<Thedarkb1-T60>In case you're wondering why I lagged out, I accidentally uninstalled my network manager.
12:53<Thedarkb1-T60>Fun.
12:54<andythenorth>this again https://github.com/OpenTTD/OpenTTD/issues/5881
12:54<andythenorth>:P
13:00<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6230: Broken savegame - Referencing invalid Vehicle https://git.io/fh3Dv
13:01<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6210: More hotkeys for OpenTTD to improve gameplay https://git.io/fh3DU
13:01<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6210: More hotkeys for OpenTTD to improve gameplay https://git.io/fh3DT
13:03<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6207: Autorenew fails for articulated vehicles with mixed cargo https://git.io/fh3DL
13:03<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6207: Autorenew fails for articulated vehicles with mixed cargo https://git.io/fh3Dt
13:04<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6167: Does not display a summary of Finance https://git.io/fh3DO
13:04<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6167: Does not display a summary of Finance https://git.io/fh3D3
13:05-!-Thedarkb1-T60 [~Thedarkb-@51-171-110-9-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
13:06-!-Gja [~Martin@93-167-84-102-static.dk.customer.tdc.net] has joined #openttd
13:06-!-Gja is "Martin" on #ceph #bcache #openttd
13:06<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6544: Put into the AI company when loading savegame https://git.io/fh3DZ
13:06<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6544: Put into the AI company when loading savegame https://git.io/fh3Dn
13:08<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6525: Rating bonus for default economy also https://git.io/fh3D8
13:08<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6525: Rating bonus for default economy also https://git.io/fh3D4
13:10<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6490: appdata.xml metadata file for inclusion in Software Center https://git.io/fh3Du
13:11<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6476: Suggested changes for pathfinding for automatic servicing https://git.io/fh3D2
13:13-!-Thedarkb1-T60 [~Thedarkb-@51-171-110-9-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
13:13-!-Thedarkb1-T60 is "realname" on #openttd #oolite
13:15<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6546: Fast forward on macOS is restricted by frame refresh rate https://git.io/fh3DX
13:15<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6546: Fast forward on macOS is restricted by frame refresh rate https://git.io/fh3D1
13:18<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6661: Airport tiles overlap fence https://git.io/fh3D9
13:18<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6661: Airport tiles overlap fence https://git.io/fh3DH
13:19<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6647: Implicit order added after autorenew causing cargodist issues https://git.io/fh3D5
13:19<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6647: Implicit order added after autorenew causing cargodist issues https://git.io/fh3Dd
13:20-!-gelignite [~gelignite@55d4715b.access.ecotel.net] has joined #openttd
13:20-!-gelignite is "gelignite" on #openttd
13:21-!-Thedarkb1-T60 [~Thedarkb-@51-171-110-9-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
13:25<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6556: Windows installers creates shortcut for all users; not per user https://git.io/fh3yf
13:25<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6556: Windows installers creates shortcut for all users; not per user https://git.io/fh3yJ
13:26<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh commented on pull request #6780: Change: Refactor window ticks into game ticks and realtime events. https://git.io/fh3yI
13:28<Samu>spam
13:28<nielsm>andythenorth, you were complaining about this exact issue earlier :) https://github.com/OpenTTD/OpenTTD/issues/5823
13:28<Samu>https://github.com/notepad-plus-plus/notepad-plus-plus/issues/289 is a good question
13:28<andythenorth>yes
13:28<Samu>is there squirrel for notepad++ anywhere on the internet?
13:29<andythenorth>nielsm: it's also referenced in passing here https://github.com/OpenTTD/OpenTTD/issues/5881
13:29<LordAro>arguably it's an eints issue rather than OTTD, but...
13:29<andythenorth>(comments)
13:29<LordAro>Samu: C is usually close enough
13:30<andythenorth>oh frosch fixed my issue here already https://github.com/OpenTTD/OpenTTD/issues/5823#issuecomment-379451860
13:30<andythenorth>that's the answer then
13:30-!-HerzogDeXtEr [~farci@dslb-178-000-248-139.178.000.pools.vodafone-ip.de] has joined #openttd
13:30-!-HerzogDeXtEr is "purple" on #openttd
13:30<andythenorth>configure --without-grfcodec"
13:31<LordAro>i also said that earlier :p
13:32<nielsm>TrueBrain: could we maybe add a scheduled CI job that weekly (or whatever) regenerates the baseset files, makefiles, project files, etc. etc., and commits any changes?
13:32<LordAro>just hook it into the existing translator stuff
13:32<LordAro>imo
13:33<nielsm>it's also for things not translations
13:33<Samu>I notice that the paste webside has some kind of support
13:33<Samu>website
13:33<nielsm>e.g. source.list and the squirrel ui widgets headers
13:34<Samu>Squirrel Script with OpenTTD AI/GS in the dropdown menu
13:34<LordAro>nielsm: that should be done as part of commit checkers, imo
13:34<LordAro>Samu: planetmaker might know
13:34<Samu>https://paste.openttdcoop.org/
13:35<@planetmaker>hm?
13:36<LordAro>planetmaker: squirrel syntax highlighting
13:36<@planetmaker>I never used squirrel.
13:36<LordAro>how about anything to do with paste.ottdc.org?
13:37<@planetmaker>I'm still missing some context...
13:37<+glx>nielsm: I think I'll convert the awk to vbs for windows, should not be too hard
13:38<LordAro>planetmaker: apparently paste.ottdc.org has a squirrel highlighting mode, and Samu was asking about it
13:38<LordAro>Samu: https://www.tt-forums.net/viewtopic.php?t=69671 is this particularly helpful?
13:38<+glx>at least for generate_widget
13:38<@planetmaker>oh. It's mostly off-the shelf paste programme. We certainly didn't add our own highlighters :D
13:39<Samu>hmm maybe, let me try
13:39<LordAro>planetmaker: i feel like it's unlikely it would come with highlighting for "Squirrel Script with OpenTTD AI/GS"
13:40<+glx>doxygen_filter should be doable too, but squirrel_export is more complex, and I'm not even sure it still works
13:43<andythenorth>53 issues with patches from flyspray
13:43<andythenorth>but patches are done in PRs
13:43<@planetmaker>:D I have to agree
13:43<andythenorth>so
13:43<andythenorth>https://github.com/OpenTTD/OpenTTD/issues?q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22
13:44<@planetmaker>It's work of Ammler. That's how old it is
13:44<@planetmaker>@seen Ammler
13:44<@DorpsGek>planetmaker: Ammler was last seen in #openttd 3 years, 37 weeks, 0 days, 3 hours, 6 minutes, and 37 seconds ago: <Ammler> wow, nice openttd works now without any baseset
13:44<andythenorth>bring back Ammler
13:44<andythenorth>:P
13:45<@planetmaker>he seems very rarely online nowadays ...
13:45<@planetmaker>tbh, I tried, some time back.
13:46<andythenorth>bring back DaleStan :P
13:46<andythenorth>even...omg, bring back TrueBrain
13:46<LordAro>Truelight, surely
13:47<@planetmaker>and... y3xo, robidium, th3rken
13:47<Samu>nice, it works
13:47<Samu>ugly colours, but it's something
13:47<DorpsGek_II>[OpenTTD/OpenTTD] LordAro closed issue #6649: Modernizing for C++11: replacing instances of SmallVector https://git.io/fh3Sv
13:47<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on issue #6649: Modernizing for C++11: replacing instances of SmallVector https://git.io/fh3Sf
13:47<LordAro>Samu: did you ever make #6657 into a PR?
13:48<Samu>let me look
13:49<Samu>looks like I didn't, because someone disagreed
13:50<Samu>patch incomplete
13:50<LordAro>fair
13:51<Samu>my view on it is that the station is neutral
13:51<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6378: Erroneous behavior of Get/SetGrowthRate GS methods https://git.io/fh3SZ
13:52<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6657: Buying exclusive transport rights prevents oil rigs from using their own dock/helipad https://git.io/fh3Sn
13:52<andythenorth>sorry spam incoming :(
13:52<andythenorth>53 issues to comment on, FFS
13:52<LordAro>i feel it's unfair to threaten to close FS issues
13:52<LordAro>given it's quite likely the actual owner hasn't noticed
13:53<andythenorth>I wondered about that
13:53<Samu>neutral would mean, anyone can use it, but that's just my point of view
13:53<andythenorth>but nobody is picking them up?
13:53<Samu>nielsm disagrees
13:53<andythenorth>I mean, I tried to test a bunch of FS patches
13:53<andythenorth>but they go nowhere
13:54<andythenorth>even the ones that appear to work, diddly squat of them got merged
13:54<andythenorth>e.g. https://github.com/OpenTTD/OpenTTD/issues/6078
13:55<TrueBrain>nielsm: are those things that should have been part of a commit? As we might also tune the CI to fail of such files are not updated correctly?
13:55<TrueBrain>nielsm: or are these things that just change once in a while, and need an update?
13:55<LordAro>andythenorth: well, because no one made it a PR
13:55*andythenorth tries to envision who is going to rebase 53 rotting patches and PR them
13:55<andythenorth>what if they were done in small batches?
13:56<LordAro>possibly
13:56<LordAro>i could look at a few
13:56<andythenorth>https://github.com/OpenTTD/OpenTTD/issues?q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22
13:57<andythenorth>I see no path to invite the original FS contributors to github
13:57<LordAro>not without unarchiving FS
13:57<LordAro>probably
13:57<TrueBrain>even the emails on file are stale :P
13:58<andythenorth>I don't know what basis the emails were collected under
13:58<TrueBrain>I guess we can close any issue that takes more than 1 hour or so to put in a PR
13:58*andythenorth food
13:58<TrueBrain>we can think of all kind of ways to contact the authors .. but in all honesty, what are we expecting
13:59<TrueBrain>they clearly haven't checked in for over a year
13:59<TrueBrain>if you would have written a patch, and lost sight of this project .. would you make it into a PR?
13:59<TrueBrain>so I think this is only the feeling of nostalgia to hold on
14:01-!-Wormnest [~Wormnest@35.136.176.177] has quit [Ping timeout: 480 seconds]
14:07-!-Borg [~borg@87-99-43-52.internetia.net.pl] has quit [Quit: leaving]
14:10<TrueBrain>hmm .. was Make installed on Windows agents ..
14:12<nielsm>I don't think they have a full mingw/msys environment
14:12<nielsm>just msys-git
14:13<TrueBrain>bah; that sucks :P
14:14*andythenorth food complete
14:14<TrueBrain>nielsm: from what I can tell, things like baseset and projects can be easily validated with the ci-commit-checker
14:14<TrueBrain>just a few deps to install
14:14<TrueBrain>does that help, preventing that PR, or is that more annoying?
14:15<nielsm>I guess it's mostly that they're annoying to do
14:16<TrueBrain>we can also automate the update; I dont really care tbh :)
14:17<nielsm>the baseset things should probably be handled by eints, since it's closely tied to translations
14:17<nielsm>and the rest could just be commit checker yelling at you
14:18-!-sla_ro|master2 [~sla.ro@84.117.88.126] has joined #openttd
14:18-!-sla_ro|master [~sla.ro@84.117.88.126] has quit [Read error: Connection reset by peer]
14:18-!-sla_ro|master2 is "slamaster" on #sla #openttd
14:18<Samu>bad behaviour
14:19<Samu>the squirrel lang you linked LordAro
14:19<Samu>doesn't detect brackets that well
14:20<TrueBrain>nielsm: k; will talk to frosch about eints, and I hope someone can look into hooks for the commit checker :) Would you mind making a bug ticket out of it? (I guess it should go in https://github.com/OpenTTD/OpenTTD-CF ; possibly in git-hooks)
14:21-!-Wormnest [~Wormnest@35.136.176.177] has joined #openttd
14:21-!-Wormnest is "Wormnest" on #openttd
14:21<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6078: Orders: it does not jump order by remaining lifetime https://git.io/fh39a
14:22<Samu>Lua looks almost good, but still with some issues
14:23<andythenorth>anyone know if J0anJosep is juanjo?
14:23<andythenorth>writing style is same
14:23<LordAro>yeah
14:24<TrueBrain>owh, Windows seems to have 'make' :D
14:24<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5978: Autoreplace window isn't updated after group hierarchy changes https://git.io/fh39K
14:24<TrueBrain>ssswwweeettttt
14:24<Samu>C# looks alright for squirrel
14:24<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5944: Track type change breaks Two-Way EOL https://git.io/fh39i
14:24<Eddi|zuHause>duuuudeee
14:24<TrueBrain>SWEEEETTTTTTT
14:25<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5735: Signals: signal window - show one signal variant at a time https://git.io/fh391
14:25<Samu>well, not really, many stuff missing highlight
14:25<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5877: Motion counter continues to increase while train is waiting at non-path signals https://git.io/fh39M
14:25<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #4684: Use shift to estimate costs only with a certain type of commands https://git.io/fh39y
14:25<Eddi|zuHause><TrueBrain> owh, Windows seems to have 'make' :D <-- i'm pretty sure i've seen "make" in my dos days, but that might have been on Novell Dos
14:25<TrueBrain>a release is 13 jobs .. lol
14:26<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #2155: Console: heightmaps for dedicated server https://git.io/fh39S
14:26<Eddi|zuHause>also, i had no clue what that even did back then
14:26<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #2944: Timetable: auto-reset delay counter https://git.io/fh399
14:26<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #4540: Orders: toggle display of implicit orders https://git.io/fh39Q
14:27<andythenorth>this one looks done?
14:27<andythenorth>https://github.com/OpenTTD/OpenTTD/issues/6422
14:27<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6422: [patch] GS function to scroll viewport for all players in company https://git.io/fh395
14:28<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6640: Less towns than set in menu https://git.io/fh39F
14:28<Samu>how is try { bla } catch (bla) { bla } used ? :(
14:28<Samu>is it for callbacks?
14:28<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5078: NOAI API lack vehicle is old event https://git.io/fh39N
14:28<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5208: Console: make console commands 'ls' and 'load' work with scenarios https://git.io/fh39x
14:29<Eddi|zuHause>if it has a patch, why not just commit it?
14:29<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5377: AIs cannot detect river tiles https://git.io/fh39p
14:29<andythenorth>Eddi|zuHause: list the procedure for doing that....
14:30*andythenorth tries
14:30<andythenorth>- download
14:30<andythenorth>- make a branch
14:30<andythenorth>- rebase patch to current master
14:30<andythenorth>- fix any conflicts
14:30<andythenorth>- compile
14:30<andythenorth>- fix any compile issues
14:30<andythenorth>- test
14:31<andythenorth>- check code style
14:31<andythenorth>- check it actually is a good idea
14:31<andythenorth>- make a PR
14:31<andythenorth>- persuade someone to review
14:31<TrueBrain>I like how you went all in on this :D
14:31<Eddi|zuHause>easy, right?
14:31<andythenorth>- persuade someone to merge
14:31<andythenorth>- close issue
14:31<TrueBrain>you forgot:
14:32<andythenorth>just saying it's a lot of work for someone who's totally disinterested
14:32<TrueBrain>- get frustrated as nobody really cared in the first place
14:32<TrueBrain>- you let it go stale
14:32<TrueBrain>- a bot closes your PR
14:32<Eddi|zuHause>i'd put the "make a PR" step earlier
14:32<andythenorth>otoh I've seen peter1138 commit about 30 FS patches in one day
14:32<andythenorth>so eh, depends on your person
14:32<TrueBrain>2019-01-05T19:32:19.5571987Z /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/liblzo2.a(lzo_util.o): relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC
14:32<TrueBrain>2019-01-05T19:32:19.5574721Z /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/liblzo2.a: error adding symbols: Bad value
14:32<TrueBrain>this sounds bad
14:32<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5321: AI: allow placing waypoints like human player (next to each, other, covering more than 1 tile etc) https://git.io/fh3HU
14:32<Eddi|zuHause>it depends whether you're bureaucratically aligned or "just do it"
14:33<nielsm>TrueBrain: https://github.com/OpenTTD/OpenTTD-CF/issues/14
14:33<TrueBrain>nielsm: ty!!
14:33<andythenorth>look this one I even made a frigging video https://github.com/OpenTTD/OpenTTD/issues/6145#issuecomment-379453516
14:33<andythenorth>ok it's a .mov :P
14:34<andythenorth>still no-one is picking it up and PR-ing it
14:34<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6145: High CPU usage for ships with empty orders https://git.io/fh3Hq
14:35<andythenorth>ok this one, I'll eat my own advice https://github.com/OpenTTD/OpenTTD/issues/4754#issuecomment-381081296
14:35<andythenorth>PR incoming
14:35<TrueBrain>what can I do about the lzo error .. does it suggest I compile lzo with -fPIC, or OpenTTD with -fPIC ..
14:36<TrueBrain>2019-01-05T19:36:16.9944594Z cp: cannot stat 'objs//Release/openttd.pdb': No such file or directory
14:36<TrueBrain>hmm .. why is the pdb not created ..
14:37<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6422: [patch] GS function to scroll viewport for all players in company https://git.io/fh3H3
14:37<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6422: [patch] GS function to scroll viewport for all players in company https://git.io/fh3Hs
14:37<TrueBrain>glx: you happen to know?
14:37<LordAro>TrueBrain: probably the former
14:37<TrueBrain>owh, TARGET is empty ..
14:37<TrueBrain>PLATFORM is empty
14:37<TrueBrain>right, my bad
14:37<TrueBrain>fixing :D
14:38<Eddi|zuHause>ok, 2 out of 2 hunks failed, that's a good start?
14:38<Eddi|zuHause>"at least the files still exist"? :p
14:38<TrueBrain>LordAro: any clue why it happens, or what I can reasonably do about it?
14:41<LordAro>TrueBrain: not really
14:41<TrueBrain>it is weird, not? Most 64bit deb-based systems give me that error
14:43<Xaroth>I blame TrueBrain.
14:44<TrueBrain>go find a nice coop game to play plz
14:44<Xaroth>OpenTTD? :P
14:44<andythenorth>or do some PRs
14:44<Xaroth>... you really want -me- to go through PRs?
14:44<andythenorth>eh how do I fake the author in a git commit?
14:44<TrueBrain>there is a reason you don't have any permissions Xaroth
14:45<Xaroth>^
14:45<andythenorth>I am making a PR for https://github.com/OpenTTD/OpenTTD/issues/4754#issuecomment-381081296
14:45<TrueBrain>andythenorth: don't. Add (patch by ..) behind the commit message
14:45<andythenorth>which is frosch
14:45<TrueBrain>it is evil to fake authors :P
14:46<TrueBrain>okay, I am just going to skip deb-based releases for nightlies :P
14:47<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth opened pull request #7015: Change: Desert tiles are now half-desert if a neighboured tile is non… https://git.io/fh3Ho
14:48<TrueBrain>OMG THAT IDEA IS HORRIBLE
14:48<TrueBrain>(sorry, I just had to)
14:48<Eddi|zuHause>hm, i don't find a rev where the patch applies
14:49<andythenorth>eh TB have any macOS binaries got built yet?
14:49<andythenorth>I want to close this
14:49<andythenorth>https://github.com/OpenTTD/OpenTTD/issues/6978
14:49<TrueBrain>hold your horses :P
14:50<andythenorth>Horses is only alpha 2
14:50<andythenorth>I am holding it
14:50<Xaroth>Alpha 2 doesn't sound like you're holding it
14:50<andythenorth>I am supposed to be drawing more trains for it
14:50<andythenorth>but TrueBrain made me do admin
14:51<Xaroth>Admin is also useful
14:51<TrueBrain>yes; I told him: YOU ARE NOT GOING TO SPEND YOUR TIMING UNDERSTANDING A PYTHON SCRIPT
14:51<TrueBrain>and he listened
14:51<Xaroth>o_O
14:51<andythenorth>this is much more fun than combinatorial shit
14:51<TrueBrain>hmm .. how to detect the name of the bundles ..
14:52<TrueBrain>I forgot how we used to do that :(
14:52<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6851: Application data shouldn't be written to ~/Documents/OpenTTD on OSX https://git.io/fh3H1
14:52<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6851: Application data shouldn't be written to ~/Documents/OpenTTD on OSX https://git.io/fh3HM
14:53<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6865: Drawing vertical/horizontal lines of width>1 problem https://git.io/fh3Hy
14:54<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6634: Most AI scripts from official extensions crash frequently https://git.io/fh3HF
14:54<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6634: Most AI scripts from official extensions crash frequently https://git.io/fh3Hb
14:57<TrueBrain>seems I am not the only one with issues related to fpic and lzo: https://bugs.launchpad.net/ubuntu/+source/lzo2/+bug/1638535
14:57<TrueBrain>2016
15:01<DorpsGek_II>[OpenTTD/OpenTTD] George-VB opened issue #7016: New variables for railtype https://git.io/fh3QT
15:01<andythenorth>anyone know the size of return values in cb36?
15:01<andythenorth>I can't see it in docs
15:01<andythenorth>for some reason my comments say frosch told me it's 32k
15:01<andythenorth>which seems odd
15:02<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z commented on issue #5944: Track type change breaks Two-Way EOL https://git.io/fh3QI
15:02<andythenorth>all cbs are 15 bit return values?
15:02<andythenorth>so that's 32k?
15:03<Eddi|zuHause>yes
15:03<LordAro>@calc 2**15
15:03<@DorpsGek>LordAro: 32768
15:03<+glx><TrueBrain> owh, Windows seems to have 'make' :D <-- yes they have mingw32 installed it seems
15:04<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6581: NewGRF cannot configure purchase prices per wagon https://git.io/fh3QZ
15:04<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6581: NewGRF cannot configure purchase prices per wagon https://git.io/fh3Qn
15:04<TrueBrain>glx: yup; works like a charm
15:04<Eddi|zuHause>technically, it could be larger, if the content of var1C is evaluated instead of the "result"
15:04<+glx>so nsis should be installed too
15:04<TrueBrain>2019-01-05T20:04:14.0015138Z /usr/bin/sh: makensis.exe: command not found
15:04<TrueBrain>awh
15:05<TrueBrain>possibly it is not on path or something
15:05<TrueBrain>or not known in mingw
15:06<+glx>probably not known in mingw if mingw doesn't use global path
15:08<TrueBrain>do you happen to have NSIS installed? and mingw? what would the path be?
15:08<+glx>you could try to run the .bat, but I guess the hardcoded path is wrong in it
15:08<TrueBrain>I am now running 'bundle_exe'
15:08<TrueBrain>which runs makensis
15:09<TrueBrain>.bat wont work, as it needs the 9x
15:09<+glx>.bat fails for me because nsis is in program files(x86)
15:10<TrueBrain>in mingw this is just /c/Program Files (x86)/NSIS, right?
15:10<+glx>hmm you could echo the path somewhere ;)
15:11<TrueBrain>good point
15:11<+glx>and same from a cmd task
15:11<+glx>to compare
15:12<TrueBrain>right, while that is running .. how did we plan to do the versions with git?
15:12<TrueBrain>openttd-trunk-r12345 will no longer fly
15:12<TrueBrain>openttd-nightly-20190105-g96blabla ?
15:12<+glx>date and hash seems good
15:13<Eddi|zuHause>we still skipped the question of how to do NewGRF version stepping between releases
15:13<andythenorth>is this a performance problem? https://github.com/OpenTTD/OpenTTD/issues/7016
15:13<andythenorth>or just we don't want to do it? ^
15:13<TrueBrain>Eddi|zuHause: not my department :)
15:14<Xaroth>andythenorth: define 'nearby' ?
15:15<Eddi|zuHause>andythenorth: railtype vars were always discouraged because of "performance concerns", it was never checked whether that is actually a real "issue", i think...
15:15<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6505: Allow rail when ships are on lower halftile https://git.io/fh3QP
15:15<andythenorth>surely we just cache them? :P
15:16<andythenorth>easy to say :P
15:16<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5944: Track type change breaks Two-Way EOL https://git.io/fh3QS
15:16<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5944: Track type change breaks Two-Way EOL https://git.io/fh3Q9
15:17<Eddi|zuHause>andythenorth: cache the spriteID in mWhatever, and only recalculate in the tileloop?
15:18<andythenorth>something like that
15:18<Eddi|zuHause>that's not really going to work as there are multiple sprites per tile
15:19<Eddi|zuHause>(6 potential trackbits plus 6 catenary bits)
15:20<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6381: Game Script: method to change company rating in town https://git.io/fh3Qj
15:21<andythenorth>Eddi|zuHause: gravedig this one? o_O https://github.com/OpenTTD/OpenTTD/issues/6360
15:22<andythenorth>planetmaker: is this the missing support for runway skid sprites? o_O https://github.com/OpenTTD/OpenTTD/issues/6334
15:23<Eddi|zuHause>how do i close a branch in git?
15:23<andythenorth>Samu: related to your AI work with autorenew? o_O https://github.com/OpenTTD/OpenTTD/issues/6323
15:23<andythenorth>Eddi|zuHause: git branch -D?
15:23<andythenorth>or -d
15:25<Eddi|zuHause>no conflicts...
15:25<Eddi|zuHause>(on 6360)
15:26<Eddi|zuHause>but if i turn that into a PR, it will have my name attached instead of Cirdan's
15:27<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6053: Vehicle Groups: packing and unpacking subgroups https://git.io/fh37W
15:27<andythenorth>Eddi|zuHause: yup
15:27<andythenorth>:|
15:28<andythenorth>Eddi|zuHause: cf https://github.com/OpenTTD/OpenTTD/pull/7015
15:28<andythenorth>I am now frosch :P
15:29<@planetmaker>andythenorth, I think so, yes
15:29<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5872: No wait cursor while autosaving https://git.io/fh378
15:32<Eddi|zuHause>bah, i forgot to check out the branch after creating it... again
15:37<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5679: Allow characters as hotkey instead of assuming everyone uses a Latin keyboard https://git.io/fh37P
15:38<TrueBrain>hmm, Azure Pipelines uses a detached head ... hmmm
15:38<dwfreed>that's pretty common in CI frameworks; they'll checkout the commit ID, thus detaching HEAD from a branch
15:39<TrueBrain>yup; it is just annoying :D
15:40<@planetmaker>TrueBrain, *please* tell me how to get the branch name :) I'm struggling with that, too...
15:40<@planetmaker>once you find out :P
15:40<@planetmaker>I find that behaviour also super annoying
15:41<TrueBrain>if you have a ref, it is impossible to know 100% sure what the branchname is, without additional information
15:41<TrueBrain>as there might be several
15:41<TrueBrain>but .. hmm
15:41<TrueBrain>there is Build.SourceBranchName
15:41<TrueBrain>and Build.SourceBranch
15:41<TrueBrain>but that feels dirty :P
15:41<@planetmaker>it does... as it might potentially give you another ref
15:41<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z opened pull request #7017: Add: Conditional order for max. reliability (patch by Cirdan, #6360) https://git.io/fh37d
15:41<dwfreed>yeah, was going to say, Azure Pipelines should be including the branch information somewhere
15:41<@planetmaker>race conditions or stuff
15:41<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5564: Wagons: (non-powered train vehicles) show introduction date and lifetime https://git.io/fh37b
15:41<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5564: Wagons: (non-powered train vehicles) show introduction date and lifetime https://git.io/fh37N
15:42<TrueBrain>planetmaker: easily solved by doing a 'git checkout -B $(Build.SourceBranchName)' I guess
15:42<TrueBrain>still keeps the current source, and names the head
15:42<TrueBrain>but still ... feels ...
15:42<@planetmaker>hm
15:43<Eddi|zuHause>andythenorth: did i even interpret the feature description right?
15:43<@planetmaker>so, are you then sure that it's the correct hash? Or is that given somewhere, too?
15:43<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5451: Do not overlap vehicle view window with child windows (orders, timetable, details) https://git.io/fh37x
15:44<TrueBrain>planetmaker: capital B overwrites any existing branch, and makes the branchnamepoint to the current HEAD
15:44<TrueBrain>forced
15:44<+glx>the hash should be correct as it's the one used to pull the source
15:44<TrueBrain>so I guess that should work
15:44<@planetmaker>ah!
15:44<TrueBrain>glx: NSIS is not in c:\Program Files (x86) .. I did expect it there :(
15:44<@planetmaker>yes, feels dirty. But meh
15:44<@planetmaker>go for it, seems to be the git way ;)
15:44<andythenorth>Eddi|zuHause: afaict yes
15:45<andythenorth>in the country of the blind, one eyed man is king :P
15:45<+glx>https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/win/scripts/Installers/Install-NSIS.ps1
15:45<TrueBrain>hmm .. so I change the BuildNumber, but other jobs do not see it ..
15:45<@planetmaker>Eddi|zuHause, andythenorth can't you set a different committer name in git?
15:46<Xaroth>planetmaker: does this work perhaps: ``` git branch --remote --verbose --no-abbrev --contains | sed -rne 's/^[^\/]*\/([^\ ]+).*$/\1/p' ```
15:46<Eddi|zuHause>planetmaker: possibly, but i wouldn't know how, and i can't be bothered to look up
15:46<+glx>it should be there, unless ${env:ProgramFiles(x86)} is not in c:
15:46<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5317: AI: Lack of RegisterAI in info.nut is not reported with enabled debug console https://git.io/fh35J
15:46<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5317: AI: Lack of RegisterAI in info.nut is not reported with enabled debug console https://git.io/fh35U
15:47<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5304: Game Script: GSTown.SetCargoGoal() and GSTown.SetGrowthRate() affecting all towns in one step https://git.io/fh35k
15:47<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5304: Game Script: GSTown.SetCargoGoal() and GSTown.SetGrowthRate() affecting all towns in one step https://git.io/fh35I
15:47<Eddi|zuHause>planetmaker: does Cirdan have a github?
15:47<+glx>all these DorpsGek_II spam starts to be annoying
15:47<andythenorth>:|
15:47<andythenorth>I get highlighted everytime I do one
15:47<Xaroth>use a different IRC name :P
15:47<Eddi|zuHause>rightclick->ignore DorpsGek_II
15:47<@planetmaker>Not sure... what's his git URL for his branch?
15:47<TrueBrain>people are always complaining ... either there is no notification in this channel, people complain .. and than there is too much ..
15:47<@planetmaker>I *thought* it was on GitHub - but I might be wrong
15:48<@planetmaker>TrueBrain, yes. But tbh it's good to see the notifications here.
15:48<Eddi|zuHause>planetmaker: he apparently wasn't in 2014
15:48<TrueBrain>planetmaker: I know :)
15:48<TrueBrain>planetmaker: just someone had to complain again about it being here :P
15:48<@planetmaker>We used to have the .notice... but it's dead since the GitHub move - and I didn't shed a tear for it ;)
15:48<andythenorth>Eddi|zuHause: I can't find a github
15:48<andythenorth>just the thread
15:48<andythenorth>I thought there was one
15:49<TrueBrain>planetmaker: changing the Author name is evil .. I think I even configured GitHub to deny those pushes
15:49<andythenorth>TrueBrain: the people complaining aren't the high activity ones :x
15:49<TrueBrain>Author should always be the person pushing
15:49<TrueBrain>(otherwise you can do some nasty nasty shit)
15:49<Eddi|zuHause>andythenorth: there's only https://repo.or.cz/w/openttd/fttd.git which was linked in the earlier ticket
15:50<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5244: Allow editing new-game settings in-game https://git.io/fh35c
15:50<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5244: Allow editing new-game settings in-game https://git.io/fh35C
15:50<milek7>isn't author and commiter separate in git?
15:50<TrueBrain>they are
15:50<Eddi|zuHause>well, if you tell me how to set author, i can update the PR
15:50<@planetmaker>TrueBrain, you can always do nasty shit ;)
15:50<TrueBrain>Eddi|zuHause: again, don't :)
15:51<TrueBrain>give credit in your commit message, and you are good
15:51<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5006: Railtypes: 'hide railtype' flag https://git.io/fh35l
15:51<Eddi|zuHause>did that
15:51<TrueBrain>(most tools show Author as 'person responsible' for a commit .. it is very evil to put someone elses name there :D)
15:51<TrueBrain>lets contribute all commits to ...... Donald Trump!
15:52<TrueBrain>(please don't :P)
15:52<Eddi|zuHause>Drumpf, please
15:52<TrueBrain>I believe you have a Patch-By entry, if you want to be real fancy
15:52<Eddi|zuHause>again, i wouldn't bother, but if people insist and give me a quick command...
15:53<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6323: AI: autorenew failed event https://git.io/fh35B
15:53<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6323: AI: autorenew failed event https://git.io/fh35R
15:53<TrueBrain>again, I will promptly deny your PR in that case :)
15:53<andythenorth>198 issues now
15:53<andythenorth>so about 40 killed today
15:53<andythenorth>and about 50 will be gone next weekend
15:53<TrueBrain>damn, this git branch issue is tricky as fuck
15:54<andythenorth>TAF
15:54<TrueBrain>nice work andythenorth :)
15:54<TrueBrain>if we continue like this,w e might set reasonable goals for releases again
15:54<ST2>call it a good "hunting season" - just to leave my thanks for all your efforts :)
15:54<TrueBrain>like: no more than N open bugs :P
15:54<Eddi|zuHause>andythenorth: problem with "batch-stale-ing" issues is that nobody can use the stirred up interest to actually review all of them
15:54<andythenorth>+1
15:54<Eddi|zuHause>andythenorth: if you picked one per day, that would catch more of them
15:54<TrueBrain>only a one-time issue :)
15:54<andythenorth>a bunch of them are junk anyway
15:55<andythenorth>but there are maybe 10 or so
15:55<andythenorth>that ought to be considered seriously
15:55<Eddi|zuHause>yeah, 10. and we looked at... 2?
15:55<andythenorth>yeah we have a week
15:55<Eddi|zuHause>that's 8 down the drain which will never come back
15:55<andythenorth>to triage the other 50 or so
15:56<andythenorth>issue trackers are an object lesson in loss aversion theory
15:56<@planetmaker>hm, the one-per-day stir-up sounds like an idea worth trying
15:56<andythenorth>based on what I know about frosch
15:56<andythenorth>this is 'no'
15:57<andythenorth>https://github.com/OpenTTD/OpenTTD/issues/6908#issuecomment-423330322
15:57<andythenorth>only frosch is super polite
15:58<TrueBrain>planetmaker: nah, we should install that bot, which automatically does it after 60 days of no activity
15:58<TrueBrain>then it stirs up depending on the rate of the community :D
15:58<TrueBrain>just a bit of backlog now :P
15:58<TrueBrain>"nightly-20190105-azure_release-g37f997f5"
15:58<TrueBrain>a nightly that is not master, lol
15:59<LordAro>now that's definitely too long for the network version :p
15:59<andythenorth>planetmaker: that airport one is a clear candidate
15:59<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6633: cargomonitor industry delivery https://git.io/fh35i
15:59<@planetmaker>andy: which #?
16:00<TrueBrain>145 unread mails
16:00<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6592: Missing symbols while linking with MinGW and LTO https://git.io/fh35S
16:00<andythenorth>is this maybe one for glx? https://github.com/OpenTTD/OpenTTD/issues/6592
16:01<TrueBrain>anyway, planetmaker, "git checkout -B ${BUILD_SOURCEBRANCHNAME}" works for me
16:01<TrueBrain>findversion.sh also does what it should, in that case
16:02<TrueBrain>openttd-nightly-20190105-azure_release-g37f997f5-linux-generic-amd64.tar.xz
16:02<TrueBrain>LOL
16:03<andythenorth>planetmaker: https://github.com/OpenTTD/OpenTTD/issues/6334
16:04<+glx>andythenorth: well it's silly a compiler should not optimise out the program entry point
16:05<andythenorth>silly patch or silly issue? o_O
16:05<+glx>silly issue
16:05<@planetmaker>ty
16:05<+glx>it's like not finding main()
16:05<andythenorth>PR? o_O
16:06<TrueBrain>glx: turns out NSIS is not installed on the image I was using
16:06<andythenorth>also so are we going to PR peter1138's patch here? https://github.com/OpenTTD/OpenTTD/issues/6145#issuecomment-379453512
16:06<TrueBrain>"VS2017-Win2016"
16:06<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z commented on issue #6908: Request: Persistent storage for vehicles https://git.io/fh35p
16:07<+glx>but it should be, it's in https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/win/vs2017-Server2016-Azure.json
16:07<TrueBrain>possibly they are not in sync?
16:07<+glx>line 438
16:07<TrueBrain>19th of October it got added
16:07<Eddi|zuHause>andythenorth: if frosch's answer is a "no", then i'm on the opposing side
16:07<TrueBrain>guess they havent updated yet .. I read more that they dont have a CI/CD on it :D
16:08<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6908: Request: Persistent storage for vehicles https://git.io/fh3de
16:09<DorpsGek_II>[OpenTTD/OpenTTD] planetmaker commented on pull request #7017: Add: Conditional order for max. reliability (patch by Cirdan, #6360) https://git.io/fh3dL
16:10<+glx>you maybe need to build your own 2017 image
16:10<DorpsGek_II>[OpenTTD/OpenTTD] planetmaker approved pull request #7017: Add: Conditional order for max. reliability (patch by Cirdan, #6360) https://git.io/fh3dq
16:10<TrueBrain>glx: not possible for free accounts
16:10<DorpsGek_II>[OpenTTD/OpenTTD] planetmaker merged pull request #7017: Add: Conditional order for max. reliability (patch by Cirdan, #6360) https://git.io/fh37d
16:10<andythenorth>:)
16:11<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6360: Orders: 'max reliability' order filter https://git.io/fh3dm
16:11<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6360: Orders: 'max reliability' order filter https://git.io/fh3dY
16:11<@planetmaker>stupid github. I just wanted to merge it. But no, I first have to make a review :P
16:11<+glx>too bad because https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/docs/vs2017.md clearly says to use vs2017-Server2016-Azure.json
16:12<andythenorth>this is old, but looks like a candidate for PR https://github.com/OpenTTD/OpenTTD/issues/2155
16:13<andythenorth>previous review by yexo, idea seems uncontroversial
16:13<TrueBrain>glx: https://github.com/Microsoft/azure-pipelines-image-generation/issues/627
16:13<TrueBrain>we are not alone :D
16:14<+glx>and https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=vsts&tabs=yaml says "Software on Microsoft-hosted agents is updated once each month."
16:14<TrueBrain>LIES! :P
16:14<andythenorth>everything is awful
16:14<TrueBrain>for now, I can just do like the script would do :D
16:15<Eddi|zuHause>"updated once a month" doesn't mean "uses bleeding edge"
16:15<andythenorth>'update: nope nothing stable'
16:15<Eddi|zuHause>the "debian stable" kind of "update"
16:16<andythenorth>so I already tested this one, someone reviewing it? o_O https://github.com/OpenTTD/OpenTTD/issues/6145
16:17<TrueBrain>so that just leaves the liblzo2 issue for deb-based amd64 systems
16:17<TrueBrain>really no clue how to approach that issue
16:17<+glx>TrueBrain: indeed, choco should at least be present and able to install nsis for us
16:18<+glx>it's clearly listed in the installed softwares
16:18<@planetmaker>andythenorth, so... how would I tell github "yes, please make a PR from the attached patch"?
16:18<@planetmaker>The procedure is not clear to me
16:18<@planetmaker>re #6956
16:19<@planetmaker>or #6145
16:19<TrueBrain>create fork, download patch, checkout fork, checkout branch, apply patch, commit, push to fork, make pull request
16:19<@planetmaker>seem to be... similar?
16:19<andythenorth>I would http://webster.openttdcoop.org/?channel=openttd&date=1546646400#1546716594
16:19<+glx>but they should indicate somewhere the current version of the image, or at least the build date
16:19<TrueBrain>glx: I agree
16:19<TrueBrain>seems we cannot have it all :D
16:20<@planetmaker>https://github.com/OpenTTD/OpenTTD/pull/6956 <-- what is this actually "waiting for status"? Will that ever turn green or is it ... just not working for those?
16:20<+glx>"Components marked with * have been upgraded since the previous version of the image." <-- means they indicate outdated stuff in the readme ?
16:20<TrueBrain>planetmaker: needs rebase
16:20<TrueBrain>guess I can comment that on all old PRs
16:21<@planetmaker>uh-oh. *That* is totally not clear from the status-report's wording as-is
16:21<TrueBrain>I noticed; bit sad
16:22<TrueBrain>"We recently switched from Jenkins as CI to Azure Pipelines as CI. This means you need to rebase before this Pull Request will pass its checks. Sorry for the troubles!" <- clear enough?
16:22<TrueBrain>(before I post this 20 times)
16:22<Eddi|zuHause>TrueBrain: additionally to all the build tasks a task that has a checkmark if it's based against current trunk?
16:22<TrueBrain>Eddi|zuHause: ask GitHub plz :D
16:22<andythenorth>TrueBrain: works for me
16:22<TrueBrain>I have no means to implent that :(
16:23<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6784: Ship cpu hog workaround for #6145 https://git.io/fh3dg
16:23<@planetmaker>I guess that's understandable, yes
16:23<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6817: PR for Modernizing for C++11: replacing instances of SmallVector https://git.io/fh3d2
16:23<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6846: Feature: Allow flip of train vehicles in depot independently of NewGRF property https://git.io/fh3dV
16:23<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6848: Feature : New Trees Placement Algorithm "Forest". https://git.io/fh3dw
16:23<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6872: Add: Houses can accept up to 16 different cargo types via NewGRF https://git.io/fh3dr
16:23<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6925: Fix #6574 #6636 #5405 #6493: Aircraft hangar issues https://git.io/fh3do
16:23<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6926: Change: Allow dock to be constructed in more locations https://git.io/fh3dK
16:24<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6927: Change: Forbid dock placement on docking area https://git.io/fh3d6
16:24<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fh3di
16:24<Eddi|zuHause>SPAAAAAAM
16:24<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6929: Add #6410: [YAPF] Use a max penalty for finding the nearest road vehicle depot https://git.io/fh3dP
16:24<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6931: Change: Prevent town growth from blocking ships https://git.io/fh3dX
16:24<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6933: Fix #6233: Improve lock pricing and infrastructure counting, to achieve better consistency https://git.io/fh3d1
16:24<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6935: Add: EnsureNoShipFromDiagDirs https://git.io/fh3dM
16:24<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6956: Fix #6145: Prevent ships without valid orders from moving https://git.io/fh3dD
16:24<@planetmaker>eddi was faster :) Was going to say so, too :P
16:24<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6965: Add: Four alternative town cargo generation methods https://git.io/fh3d9
16:24<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #6973: Add: Unique ID to savegames to prevent accidental overwriting https://git.io/fh3dH
16:25<TrueBrain>I hate you both :P
16:25<TrueBrain>there we go :)
16:25<Eddi|zuHause><planetmaker> eddi was faster :) <-- is not a sentence i hear very often :p
16:25<TrueBrain>and a free poke for all of them!
16:25<TrueBrain>glx: 2019-01-05T21:24:58.9757988Z Plugin not found, cannot call NSIS7z::Extract
16:25<TrueBrain>... *sad panda*
16:26<nielsm>okay was just about to reboot, but then I randomly tried closing _all_ WSL windows etc, waiting a bit, and starting ubuntu bash again
16:26<nielsm>and then it can connect to github again via ssh
16:27<nielsm>yay didn't have to reboot
16:27<TrueBrain>gratz :D
16:27-!-synchris [~synchris@139.138.202.72] has quit [Quit: yeeha!]
16:27<Eddi|zuHause>"have you tried defragging"?
16:28<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh updated pull request #6872: Add: Houses can accept up to 16 different cargo types via NewGRF https://git.io/fNanB
16:28<TrueBrain>ah, 7z stuff is needed for the external thingies
16:29<TrueBrain>I remember ..
16:29<TrueBrain>ironical, to install NSIS plugins you have to do some manual labor
16:30<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh updated pull request #6965: Add: Four alternative town cargo generation methods https://git.io/fpkqa
16:31<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh updated pull request #6990: Fix: Correct display of industry requires/produces in Build Industry window https://git.io/fhTef
16:32<Eddi|zuHause>TrueBrain: that sounds better than "install an unzip program that is compressed as a zip"
16:32<TrueBrain>the URL for NSIS7z ..... omg .. a forum attachment
16:32<TrueBrain>that never went wrong etc etc
16:33<andythenorth>omg so many GH notifications
16:33<andythenorth>bloody hell
16:33<andythenorth>'mark all as read'
16:33<+glx>and a nice very outdated 7z version
16:34<Samu>[20:23] <andythenorth> Samu: related to your AI work with autorenew? o_O https://github.com/OpenTTD/OpenTTD/issues/6323
16:34<Samu>no
16:34<+glx>https://nsis.sourceforge.io/Nsis7z_plug-in it's on SF
16:34<andythenorth>'totally fine'
16:34<Samu>it's unrelated
16:34<andythenorth>ok thanks Samu
16:35<Samu>but yeah, there's no event for that
16:35<+glx>but only the full version, indeed the binaries only are from a forum
16:36<TrueBrain>glx: like I said ;)
16:36<Samu>considering the vehicle failed to autorenew, the vehicle_id is unchanged, so no, it's not related
16:36<TrueBrain>possibly it would be good if we can replace this plugin for something ... sane? :D
16:36<nielsm>can I get some opinions on the remaining bullet point for this one? https://github.com/OpenTTD/OpenTTD/pull/6990 --- keep the number visible, re-introduce a "skip"/"ignore" insertable, or don't support pluralization?
16:37<andythenorth>do we have precedent elsewhere nielsm ?
16:37<andythenorth>re: pluralisation?
16:38<nielsm>of the existing languages, turkish has singular for "requires" when there is only one
16:38<nielsm>everything else uses the same term or something that looks like a mistake
16:38<nielsm>(spanish or some other language had the same term for 1 and 3 requires, but a different for 2)
16:38<andythenorth>industry window has 'requires' already
16:38<andythenorth>do whatever that does :)
16:39<nielsm>it does nothing about plurals
16:39<andythenorth>do that then
16:39<nielsm>so just do nothing here either
16:39<andythenorth>it's a generic issue
16:39<Eddi|zuHause>nielsm: i'd be in favour of "static text, no plural"
16:39<andythenorth>so someone else can fix it :)
16:39<TrueBrain>I agree with andythenorth; don't try to solve a generic issue in a PR doing something else :D
16:40<TrueBrain>make a bug about it if you want to fix it :P
16:40<+glx>oh no DorpsGek doesn't recognize me
16:40<TrueBrain>(the endless pit of: owh, and this bug, owh, and that bug, etc :D)
16:40<Eddi|zuHause>how dare he?
16:40<TrueBrain>@whoami
16:40<@DorpsGek>TrueBrain: I don't recognize you.
16:41<TrueBrain>you are not alone
16:41<Eddi|zuHause>he's feeling rebellious today?
16:41<Samu>@whoami
16:41<@DorpsGek>Samu: I don't recognize you.
16:41<Samu>ok then
16:41<+glx>ok fixed
16:41<+glx>whoami
16:41<+glx>@whoami
16:41<@DorpsGek>glx: glx
16:42<TrueBrain>DorpsGek: forget glx
16:42<@DorpsGek>test
16:42<TrueBrain>he is almost 14 years old ... guess it is that age
16:42<+glx>just needed to use the identify command
16:42<+glx>at least I was still registered :)
16:42<Eddi|zuHause>they say that the younger one tends to be the rebellious one and the older one is more rules-abiding
16:45<andythenorth>this _might_ be a good PR, but I don't get the benefit tbh https://github.com/OpenTTD/OpenTTD/issues/6613
16:45<nielsm>wth happened? font rendering looks terrible all of a sudden: https://0x0.st/sRE6.png
16:45<andythenorth>it's not solving a real issue afaict
16:45<+glx>vcpkg freetype
16:46<+glx>probably not compiled with the same options we used in our own freetype build
16:46<TrueBrain>you can ... compile-time make freetype do different things?
16:46<TrueBrain>that would be horrible :P
16:46<Eddi|zuHause>andythenorth: what's the problem with that? i read that as "allow building non-rectangular airports on uneven ground"
16:46<TrueBrain>but for sure we jumped a few versions .. openttd-useful uses an older version :P
16:47<+glx>some stuff is disabled by default IIRC in freetype
16:47<andythenorth>Eddi|zuHause: how could we test it?
16:47<andythenorth>o_O
16:47<Eddi|zuHause>andythenorth: diagonal airport grf?
16:47<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh updated pull request #6990: Fix: Correct display of industry requires/produces in Build Industry window https://git.io/fhTef
16:48<TrueBrain>awh, cannot run fakeroot with WSL :D
16:48*andythenorth looks for diagonal airport
16:48<TrueBrain>I find the order of findversion odd .. date-branch-git .. why not branch-date-git?
16:48<TrueBrain>why is the date this important :P
16:49<TrueBrain>guess if you are going to strip, this is better
16:49<TrueBrain>but looks weird
16:49<Eddi|zuHause>i agree with branch-date-git
16:50<TrueBrain>not sure how to feel .. Eddi|zuHause agree's with me ... I am a bit scared now ...
16:50<TrueBrain>:D <3 :)
16:50<Eddi|zuHause>could be worse, i could agree with V453000 :p
16:51<andythenorth>hmm newgrf airports died apparently
16:51<TrueBrain>they crashed into a mountain?
16:51<TrueBrain>it couldn't maintain lift?
16:51<TrueBrain>there was too much drag?
16:51<andythenorth>dunno
16:51<andythenorth>mostly I think yexo left :P
16:51<TrueBrain>booooooo
16:51<Eddi|zuHause>Kracken... wait, wrong game
16:51<TrueBrain>I am going to call my friends at Google
16:51<TrueBrain>this is unacceptable
16:51<TrueBrain>:D
16:52<TrueBrain>Install the plugin, runs, fails
16:52<TrueBrain>WUTH?!
16:52<andythenorth>call Munich :P
16:53<andythenorth>according to LinkedIn horrorshow
16:53<Eddi|zuHause>Munich airport apparently also died :p
16:53<andythenorth>so we're down to 38 stale patches from flyspray
16:53<andythenorth>fill your boots if you want to save any
16:53<andythenorth>https://github.com/OpenTTD/OpenTTD/issues?page=1&q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22+label%3A%22stale%22&utf8=%E2%9C%93
16:53<andythenorth>otherwise I close them next weekend, and they're.....gone forever! :O
16:59<TrueBrain>okay, I think ..... that I have a nightly-like build working
16:59<TrueBrain>still needs work, but it is a good first step
16:59<andythenorth>\o/
17:01<Samu>[20:59] <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6633: cargomonitor industry delivery https://git.io/fh35i eh... I was actually waiting for an answer
17:01<Samu>but k
17:02<Samu>will do a PR
17:02<Samu>not the kind of answer I expected
17:04<andythenorth>I have done about 40 of those comments today :)
17:04<andythenorth>housecleaning
17:06<nielsm>https://github.com/OpenTTD/OpenTTD/pull/6990 <-- squash to a single commit, or preseve "remove unused strings" as separate commit but squash rest?
17:07-!-andythenorth_ [~andytheno@host31-53-130-182.range31-53.btcentralplus.com] has joined #openttd
17:07-!-andythenorth is now known as Guest1797
17:07-!-andythenorth_ is now known as andythenorth
17:07-!-andythenorth_ is "(unknown)" on (unknown)
17:07<TrueBrain>"2019-01-05T22:06:35.6391329Z Plugin not found, cannot call GetVersion::WindowsPlatformArchitecture" WHEN DOES THE HURTING STOP
17:07<andythenorth>when you fall asleep
17:08<Eddi|zuHause>i have no opinion on squashing
17:09<TrueBrain>nielsm: I believe people prefer having the remove unused as a new commit
17:09<TrueBrain>I think that is because the old old old WebTranslator couldn't handle it otherwise
17:09<TrueBrain>so that might just became a policy out of a technical limitation :D
17:10-!-andythenorth [~andytheno@host31-53-130-182.range31-53.btcentralplus.com] has quit [Read error: Connection reset by peer]
17:11-!-andythenorth [~andytheno@host31-53-130-182.range31-53.btcentralplus.com] has joined #openttd
17:11-!-andythenorth is "andythenorth" on #openttd
17:12-!-Guest1797 [~andytheno@host31-53-130-182.range31-53.btcentralplus.com] has quit [Ping timeout: 480 seconds]
17:13<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh updated pull request #6990: Fix: Correct display of industry requires/produces in Build Industry window https://git.io/fhTef
17:16-!-andythenorth is now known as Guest1798
17:16-!-andythenorth [~andytheno@host31-53-130-182.range31-53.btcentralplus.com] has joined #openttd
17:16-!-andythenorth is "andythenorth" on #openttd
17:16-!-Progman [~progman@p4FD661B2.dip0.t-ipconnect.de] has joined #openttd
17:16-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttd
17:18<andythenorth>worth saving from the bonfire? https://github.com/OpenTTD/OpenTTD/issues/6562
17:18<andythenorth>65k stations per grf
17:18<andythenorth>because the UI works so well already
17:18<Eddi|zuHause><andythenorth> hmm newgrf airports died apparently <-- i think because of a lack of progress on statemachines. simple recombinations of existing statemachines with new graphics only gets you so far creatively...
17:18<andythenorth>why the fuck, honestly do we need 65k stations per grf?
17:19<andythenorth>unless we rework the UI to handle it
17:19<TrueBrain>andythenorth: I think the question is not: do we need 64k, but: do we need more than 256
17:19<Eddi|zuHause>andythenorth: needs collecting in a "when we bother updating to grfv9" topic
17:19<TrueBrain>going from 256 to 64k .. is .. well, just the next step
17:19<TrueBrain>and yes, 64k, not 65k. We do base2 here!
17:20<andythenorth>ok so PR that one :)
17:20<TrueBrain>I did not say we need more than 256 :)
17:21<TrueBrain>I just said you were asking the wrong question :P
17:21<andythenorth>frosch already told me it's a valid patch
17:21<andythenorth>I was just being grumpy
17:21<andythenorth>because the station UI is crap
17:21<TrueBrain>an old grumpy dude
17:21<TrueBrain>hmm
17:21<TrueBrain>:D
17:21<TrueBrain><3
17:21<andythenorth>but I can't open an issue about station UI because I am wading through all this old shit we keep around
17:22<andythenorth>I will PR 6562
17:22<TrueBrain>and I am constantly making a change, waiting 10 minutes ... failed, repeat
17:22<TrueBrain>slow Windows binaries
17:22<andythenorth>oof
17:22<Eddi|zuHause>my laziness tells me that it's not worth PR-ing that before we decide to actually go forward with grfv9
17:22<Eddi|zuHause>but that needs a "protect from stale-ness" flag
17:23<Eddi|zuHause>and a "grfv9" flg
17:23<Eddi|zuHause>flag
17:23<andythenorth>we do things differently at work
17:23-!-Guest1798 [~andytheno@host31-53-130-182.range31-53.btcentralplus.com] has quit [Ping timeout: 480 seconds]
17:24<andythenorth>there's a couple of hundred tickets open, but 'on ice'
17:24<andythenorth>to take them out of sight, but avoid endless flail about closing them
17:24<Eddi|zuHause>yes
17:24<Eddi|zuHause>that
17:24<TrueBrain>it would be nice if GitHub could support more workflow like behaviour
17:25<andythenorth>then after 5 years or so I just close them all :)
17:25<TrueBrain>you see that Azure DevOps does have that, for example
17:25<Eddi|zuHause>once we decide to do grfv9, it must be easy to find that one
17:25<TrueBrain>create a project?
17:25<andythenorth>commit it to a branch
17:25<andythenorth>grfv9
17:25<TrueBrain>same effect, different form
17:25<TrueBrain>(as closing the ticket)
17:26<Eddi|zuHause>commiting to branch would close the ticket?
17:26<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6230: Broken savegame - Referencing invalid Vehicle https://git.io/fh3NH
17:27<Eddi|zuHause>branch is probably the correct answer
17:27<TrueBrain>its funny .. I knew Windows was going to take most of my time ... clearly it did ... I hate Windows :(
17:27<Eddi|zuHause>TrueBrain: i said "i hate when i'm right" at least once last year
17:29<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6562: Stations: extended byte for NewStation ID https://git.io/fh3N7
17:29<TrueBrain>20 builds .. each build taking 2x10 + 2x8 + 6 = 42 ... I used ~1000 CPU minutes on Azure Pipelines this evening :P
17:29<andythenorth>fix from frosch looks simple enough
17:29<andythenorth>https://github.com/OpenTTD/OpenTTD/issues/5877#issuecomment-379452165
17:31<Eddi|zuHause>"We need a property - vehicle_is_waiting_on_red_signal. Without it we can't test, it is moving very slow or stands on signal" <-- is a valid request, but probably outside of the scope of this ticket
17:31<Eddi|zuHause>probably a vehicle flag: standing, accelerating, cruising, decelerating
17:32<Eddi|zuHause>, unloading, loading
17:32<TrueBrain>2019-01-05T22:32:11.9806388Z Plugin not found, cannot call FindProcDLL::FindProc
17:32<TrueBrain>could I already have known which plugins we needed?
17:33<Eddi|zuHause>TrueBrain: no, you need to rerun a 10 minute process to find out a tiny bit of information that should be obvious
17:33<@peter1138>hi
17:33<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth opened pull request #7018: Fix: Don't increase motion counter while train is waiting at non-path… https://git.io/fh3Nb
17:33<@peter1138>what do i need to do?
17:33<Eddi|zuHause>peter1138: turn an old patch of yours into a PR
17:33<andythenorth>peter1138: mumble mumble ships
17:33<@peter1138>Oh, patches. Oh, ships.
17:34<@peter1138>I need to be able to... get into the game again.
17:34<andythenorth>peter1138: https://github.com/OpenTTD/OpenTTD/issues/6145#issuecomment-379453512
17:35<andythenorth>oh wait did nielsm commit that?
17:35<andythenorth>the issue is still open
17:35*andythenorth looks
17:35<nielsm>no I offered an alternative fix
17:35<nielsm>neither should be merged afaik?
17:35<TrueBrain>okay, a fast scan indicates this should be the last plugin .. *fingers crossed*
17:36<@peter1138>I really dislike that alternative.
17:36<Eddi|zuHause>the "alternate fix" seemed a bit off
17:36<andythenorth>https://github.com/OpenTTD/OpenTTD/pull/6956
17:36<andythenorth>nah it's weird
17:36<TrueBrain>Eddi|zuHause: Trump is reaching all of us
17:37<TrueBrain>"alternative" anything will never be the same again :P
17:37<Eddi|zuHause>TrueBrain: i didn't even think of that
17:37<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on pull request #6956: Fix #6145: Prevent ships without valid orders from moving https://git.io/fh3Nh
17:37<andythenorth>alternative alternative
17:38<Eddi|zuHause>TrueBrain: means i can still successfully block him out of some of my thoughts
17:38<TrueBrain>concratz :D
17:39<TrueBrain>so we use 3 different NSIS plugins, which are all stored at a different location (wiki attachment, forum attachment, upload to random host), and all 3 are differently packed
17:39<TrueBrain>I see NSIS is awesome :P
17:39<TrueBrain>bit scared of the quality there, but who am I to judge :)
17:40<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6315: Advanced Fences: (with patch) https://git.io/fh3AI
17:40<Eddi|zuHause>TrueBrain: you'll be the person most hated by the you 3 months from now
17:40<TrueBrain>why?
17:40<TrueBrain>what did I do? :(
17:40<TrueBrain>the 3 months from now me wants to know now!
17:40<Eddi|zuHause>we'll know in 3 months :p
17:40<nielsm>I don't like NSIS either, for the record
17:41<TrueBrain>I would be shocked if none of these plugins contain spyware :P
17:41<TrueBrain>I didn't even have checksums to validate the content
17:41<TrueBrain>*feels dirty*
17:41<andythenorth>well can we at least keep the btc they'll mine?
17:42<Eddi|zuHause>i'm assuming AWS will quickly tell us about the btc-miner
17:42<andythenorth>oh just run that node.js vuln and we can steal the miners' btc
17:42<andythenorth>all is well
17:42<Eddi|zuHause>but i thought btc mining was dead anyway?
17:43<andythenorth>Eddi|zuHause: you have to hodl
17:43<andythenorth>and believe
17:43<andythenorth>https://www.coinbase.com/price/bitcoin
17:43<andythenorth>it's just like a currency
17:44<Eddi|zuHause>if "a currency" is zimbabwe dollar?
17:44<andythenorth>the problem with currency is if everyone hodls
17:44<TrueBrain>okay, it ALMOST worked this time ...
17:44<andythenorth>then it doesn't circulate
17:44<TrueBrain>there were just some lies
17:44<TrueBrain>2019-01-05T22:44:06.2927597Z Output: "D:\a\1\s\os\windows\installer\openttd-1.9.0-beta1-win32.exe"
17:44<TrueBrain>how ....... why .....that name is WRONG
17:44<TrueBrain>ffs
17:45<Eddi|zuHause>andythenorth: that was always the problem with btc, too many people speculating, too few people using as actual currency
17:45<nielsm>you heard it, version 1.9.0 is officially in beta now!
17:45<nielsm>:)
17:45<andythenorth>but it's rising, quick buy! https://www.coinbase.com/price/bitcoin
17:45<+glx>maybe we could just switch to wix, but last time I used it (it was for OpenDUNE) it was not nice for me
17:45<andythenorth>those charts are funny over the different time periods
17:46<andythenorth>I could make them into any narrative I like :P
17:46<nielsm>I've managed to build some (tiny) wix installers for internals tools at work
17:46<andythenorth>'bitcoin is crashed, sell'
17:46<andythenorth>'bitcoin is crashed, buy'
17:46<andythenorth>etc
17:46<+glx>well for opendune it worked yes
17:46<nielsm>but wix does feel very boilerplate-ey
17:46<TrueBrain>it took me over 3 hours to get it working, WE ARE GOING TO USE NSIS NOW! :P
17:46<TrueBrain>nah; I dont care
17:47<+glx>but I think it's less friendly to write than NSIS
17:47<TrueBrain>I leave that to guys like you two, as I know nothing about Windows Installers .. I just now how to install them in a pipeline :)
17:47<Eddi|zuHause>andythenorth: there was a "hacker conference" last week, and they asked the room "how many of you would have been bitcoin millionaires, if you hadn't bought a burger 10 years ago?"
17:47<andythenorth>https://breakermag.com/trapped-at-sea-with-cryptos-nouveau-riche/
17:47<Eddi|zuHause>lots of hands going up :p
17:49<Eddi|zuHause>andythenorth: if you switch the view to "all", how can the current price be 3801 but the gain 3825?
17:49<andythenorth>[shrug]
17:49<nielsm>it's somewhat problematic to use as a currency when a single transaction requires several kWh of electricity to process, if not MWh
17:49<andythenorth>that too
17:49<TrueBrain>banks also consume power :P
17:49<andythenorth>mining: nice business selling shovels
17:49<andythenorth>the real money is in the custom ASIC designs
17:50<andythenorth>meanwhile another vintage peter1138 https://github.com/OpenTTD/OpenTTD/issues/6155#issuecomment-379453570
17:50<andythenorth>I hate issues like this
17:50<andythenorth>it's probably wrong, but fixing it = politics
17:51<andythenorth>and nobody will want to close it, because that's politics too
17:51<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6155: Vehicles are sometimes incorrectly shown as refittable https://git.io/fh3AV
17:51*andythenorth does politics
17:53<Eddi|zuHause> <andythenorth> the real money is in the custom ASIC designs <- you mean it was, 1 year ago
17:53<andythenorth>well they made it now :)
17:53<andythenorth>the real money is in custom ASIC designs which can switch to mining coin-du-jour
17:53<andythenorth>or in just scamming people of course
17:56<TrueBrain>okay, NSIS works now .. just ..
17:56<TrueBrain>2019-01-05T22:54:32.1573989Z /usr/bin/sh: zip: command not found
17:56<TrueBrain>REALLY?! :P
17:57<+glx>that's for the zip version :)
17:57<TrueBrain>I know
17:57<TrueBrain>but ... GRR
17:57<TrueBrain>how do I get zip ..
17:57<+glx>you could just install 7zip
17:57<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6155: Vehicles are sometimes incorrectly shown as refittable https://git.io/fh3AS
17:58<andythenorth>all these little issues are so fricking dull :D
17:58<TrueBrain>meh. bundle_zip should "just work"
17:59<+glx>no, zip is supported natively by explorer but there's no tool installed I think
17:59<TrueBrain>*Facepalm*
17:59<andythenorth>bye all, time for bed
17:59<andythenorth>enough github paperwork
17:59-!-andythenorth [~andytheno@host31-53-130-182.range31-53.btcentralplus.com] has left #openttd []
18:00<nielsm>there should be a step in the azure pipelines to archive files
18:00<nielsm>as zip, 7z, or tar (with optional compression)
18:00-!-sla_ro|master2 [~sla.ro@84.117.88.126] has quit []
18:01<TrueBrain>yes, but this is the bundle_zip
18:01<TrueBrain>so .. that is not much good to me :D
18:01<nielsm>ah
18:03<TrueBrain>lets see what Chocolatey can do for me
18:04<+glx>hmm but unzip is possible in bash script, so zip
18:04<+glx>should work too
18:05<TrueBrain>it indeed is a bit weird that unzip is available, but zip isnt
18:06<TrueBrain>owh well, "choco install zip" seems to give access to zip from bash
18:11<+glx>weird I'm sure I used wix for opendune, but can't find any trace
18:12<TrueBrain>whoho, it worked :o
18:13<TrueBrain>https://dev.azure.com/truebrain/OpenTTD/_build/results?buildId=163
18:13<TrueBrain>okay .. it has artifacts
18:13<LordAro>:o
18:14<TrueBrain>not sure you can download artifacts, or if you have to download the bundle
18:14<TrueBrain>setup reads 1.9.0-beta1 everywhere
18:14<TrueBrain>that is bad
18:15<TrueBrain>otherwise the win64 (both exe and zip) works
18:16<TrueBrain>okay ... now the question .. do the linux and macos work?
18:16<TrueBrain>and how am I going to fix NSIS, so it works for nightlies
18:17<TrueBrain>ah, top of the install.nsi does this
18:17<TrueBrain>that is why the current nightly has no executable
18:17<TrueBrain>okay .. fine .. be like that
18:17<TrueBrain>but yeah .. first release binaries :D
18:17<TrueBrain>getting there!
18:17<TrueBrain>(still lots to do)
18:18<+glx>hmm better not create installer for nightlies
18:18<milek7>linux bundle works
18:18<milek7>is that azure thing free?
18:18<TrueBrain>free for Open Source, yes
18:18<TrueBrain>and tnx
18:18<TrueBrain>means only OSX left to validate
18:19<TrueBrain>stupid andy went to bed ofc :P
18:21<nielsm>even for non-open projects you can get a number of free build minutes each month on azure pipelines
18:22<TrueBrain>true!
18:22<nielsm>(open projects have unlimited minutes)
18:24<TrueBrain>okay, many improvements, and now only .zip ..
18:24<TrueBrain>should be good
18:26<TrueBrain>so I only have to figure out what the hell is going on on .deb x64 creation
18:26<+glx>ah it was not for opendune, it was for gpmi
18:26<TrueBrain>glx: that was LONG ago :P
18:26<+glx>yeah wix was quite new at that time
18:31<+glx>indeed 2010
18:31<Eddi|zuHause><TrueBrain> stupid andy went to bed ofc :P <-- he does that... typically 5 seconds before i finish typing an answer to the question he asked half an hour ago
18:31<TrueBrain>https://dev.azure.com/truebrain/OpenTTD/_build/results?buildId=164 <- okay, that should be a "nightly" (just on the wrong branch)
18:33<TrueBrain>right, time for some sleep; this took way too long
18:33<Eddi|zuHause>what's the "skipped" task?
18:33<TrueBrain>skipped because it is a nightly
18:33<TrueBrain>release does more
18:33<TrueBrain>I wonder if I can add a reason for skip
18:34<TrueBrain>good night!
18:34<Eddi|zuHause>"use version version"
18:42<Samu>my terrible coding style...
18:42<Samu>new_vehicle = TestCloneRoadVehicle().TryClone(this.m_depotTile, Utils.GetVehicleID(clone_vehicle_num, clone_vehicle_num_type), (Utils.IsValidVehicle(share_orders_num, share_orders_num_type) && share_orders_num == clone_vehicle_num ? true : false));
18:58-!-nielsm [~nielsm@176-23-103-56-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
19:00-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has quit [Quit: Once again the world is quick to bury me.]
19:07-!-gelignite [~gelignite@55d4715b.access.ecotel.net] has quit [Quit: Good fight, good night!]
20:07-!-Flygon [~Flygon@58-6-74-108.dyn.iinet.net.au] has joined #openttd
20:07-!-Flygon is "Flygon" on #openttd
20:14-!-Gja [~Martin@93-167-84-102-static.dk.customer.tdc.net] has quit []
20:19-!-wodencafe [~cboyd@2605:6000:1517:462e:724d:7bff:fe63:71b6] has quit [Quit: Konversation terminated!]
20:23-!-Oroburos [~Notthatim@cpc72333-sotn15-2-0-cust299.15-1.cable.virginm.net] has joined #openttd
20:23-!-Oroburos is "realname" on #biz #redditprivacy #openttd
20:23-!-EnglandIsMyCity [~Notthatim@cpc72333-sotn15-2-0-cust299.15-1.cable.virginm.net] has joined #openttd
20:23-!-EnglandIsMyCity is "realname" on #biz #redditprivacy #openttd
20:31-!-EnglandIsMyCity [~Notthatim@cpc72333-sotn15-2-0-cust299.15-1.cable.virginm.net] has quit [Quit: Leaving]
20:33-!-Wormnest [~Wormnest@35.136.176.177] has quit [Quit: Leaving]
20:40-!-wodencafe [~cboyd@2605:6000:1517:462e:724d:7bff:fe63:71b6] has joined #openttd
20:40-!-wodencafe is "Woden Cafe" on #432 #openttd #oftc #moocows
20:45-!-wodencafe [~cboyd@2605:6000:1517:462e:724d:7bff:fe63:71b6] has quit [Quit: Konversation terminated!]
20:53-!-Progman [~progman@p4FD661B2.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
22:09-!-wodencafe [~cboyd@2605:6000:1517:462e:724d:7bff:fe63:71b6] has joined #openttd
22:09-!-wodencafe is "Woden Cafe" on #432 #openttd #oftc #moocows
22:32<DorpsGek_II>[OpenTTD/OpenTTD] btzy commented on pull request #7005: Fix #7004: Redraw linkgraph overlay correctly after zoom https://git.io/fhsJN
22:49<Samu>omg, my AI is terribly slow now
22:50<Samu>creating a list of vehicles by their unitnumber is horribly slow
23:00<Samu>it's taking months for each list, bah
23:02-!-Oroburos [~Notthatim@cpc72333-sotn15-2-0-cust299.15-1.cable.virginm.net] has quit [Read error: Connection reset by peer]
23:10<Samu>how can I speed this up ?
23:10<Samu>https://paste.openttdcoop.org/pbq3ammjp
23:17<Samu>local vehicleList = Utils.VehicleUnitNumberList_Station(AIStation.GetStationID(this.m_stationFrom), AIVehicle.VT_ROAD);
23:17<Samu>it's still executing this
23:17<Samu>then there's valuators after, omg... i'm disappointed
23:17<Samu>so much work for nothing
23:18<Samu>unbearable speed, slower than a snail
23:18<Samu>feels like I downgraded from a Core i7 to a calculator cpu
23:29-!-Samu [Samu@pa4-84-91-142-34.netvisao.pt] has quit []
---Logclosed Sun Jan 06 00:00:09 2019