Back to Home / #openttd / 2019 / 01 / Prev Day | Next Day
#openttd IRC Logs for 2019-01-12

---Logopened Sat Jan 12 00:00:17 2019
00:46-!-glx [kvirc@000128ec.user.oftc.net] has quit []
00:52-!-Gja [~Martin@93-167-84-102-static.dk.customer.tdc.net] has joined #openttd
00:52-!-Gja is "Martin" on #ceph #bcache #openttd
00:56-!-Gja [~Martin@93-167-84-102-static.dk.customer.tdc.net] has quit [Remote host closed the connection]
02:03<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth approved pull request #7038: Fix: Replace duplicate town name "Huacho" https://git.io/fhnsR
02:15<DorpsGek_II>[OpenTTD/OpenTTD] btzy updated pull request #7028: Feature: Option to group vehicle list by shared orders https://git.io/fhGxd
02:16-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has joined #openttd
02:16-!-andythenorth is "andythenorth" on #openttd
02:31<@planetmaker>moin
02:32-!-chomwitt is "chomwitt" on #debian #debian-games
02:32-!-chomwitt [~chomwitt@ppp-94-69-11-160.home.otenet.gr] has joined #openttd
02:33<DorpsGek_II>[OpenTTD/OpenTTD] planetmaker merged pull request #7038: Fix: Replace duplicate town name "Huacho" https://git.io/fhnYg
02:38-!-sla_ro|master [~sla.ro@84.117.88.126] has joined #openttd
02:38-!-sla_ro|master is "slamaster" on #sla #openttd
02:39<andythenorth>moin
02:39<andythenorth>if we keep merging, LordAro won't be able to finish the changelog....ever
02:39<andythenorth>:)
02:41<@planetmaker>if *that* is our main concern, then I'm happy to have him shove that problem on the feet :P
02:42<@planetmaker>and that sentence no grammar
02:43<@planetmaker>also... we have our commit message style so that a script can make the changelog :P
02:44<@planetmaker>I rather accidentially setup my git repo such that it pulls the pull requests, too. But I find that surprisingly convenient
02:47<andythenorth>no need to fetch the PR from upstream?
02:48<@planetmaker>yep. And I can quickly build them to actually check what it looks or feels like
02:48<@planetmaker>it's all just different branches in my OpenTTD.git
02:50<@planetmaker>https://paste.openttdcoop.org/px9lcajoc <-- a bit lengthy ... but who cares
02:58<DorpsGek_II>[OpenTTD/OpenTTD] btzy opened issue #7039: In viewport.cpp at function UpdateViewportPosition(Window *w), what is the purpose of bool update_overlay? https://git.io/fhnGv
03:08<DorpsGek_II>[OpenTTD/OpenTTD] btzy closed issue #7039: In viewport.cpp at function UpdateViewportPosition(Window *w), what is the purpose of bool update_overlay? https://git.io/fhnGv
03:23<DorpsGek_II>[OpenTTD/OpenTTD] planetmaker commented on pull request #7003: Feature #6918: Add option to adjust font size separately from GUI size. https://git.io/fhnGk
03:58-!-debdog [~debdog@2a00:79c0:622:7e00:7a24:afff:fe8a:d04d] has quit [Ping timeout: 480 seconds]
03:59-!-nielsm [~nielsm@176-23-103-56-cable.dk.customer.tdc.net] has joined #openttd
03:59-!-nielsm is "Niels Martin Hansen" on #openttd
04:10<TrueBrain>and if you don't want to pull everything like planetmaker does, https://help.github.com/articles/checking-out-pull-requests-locally/ is a good way to do that :)
04:12<andythenorth>so
04:13<andythenorth>what visual effect for a zero-emissions hydrogen train?
04:13<andythenorth>o_O
04:15<TrueBrain>dead people where ever it passes through
04:15<TrueBrain>it sends out a vibration that instantly rips open all your organs
04:15<TrueBrain>really horrible
04:15<TrueBrain>but, zero-emissions!
04:16<Heiki>no effect normally, but a massive explosion when it breaks down
04:17<SpComb>morbid
04:17<Heiki>clearing at least 100 tiles around it in every direction
04:17<andythenorth>rainbows?
04:18<TrueBrain>unicorns!
04:18<Heiki>🌈 🌈
04:18<SpComb>zero-emission unicorns fart rainbows, not unicorns
04:19<TrueBrain>and if zero-emissions rainbows fart unicorns, we have infinite energy!
04:20<andythenorth>assuming you can find the unicorn
04:20<TrueBrain>and the rainbow, ofc
04:20<andythenorth>it will be at the end of the rainbow
04:20<andythenorth>just go there
04:20-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has joined #openttd
04:20-!-Wolf01 is "Wolf01" on #openttd
04:20<TrueBrain>okay ... so today I have to find back a 'changelog.sh' script that is on some server in some /root folder ..
04:20<Wolf01>Moin
04:20<TrueBrain>but in that script there should be some magic code that makes nice changelogs between nightlies
04:32<TrueBrain>owh, that script mostly only works for subversion
04:32<TrueBrain>DOH
04:33<TrueBrain>owh well, something for later today :)
04:42<LordAro>good moin
04:43<nielsm>andythenorth just poopping out a trail of water as it travels
04:43<andythenorth>bubles
04:43<andythenorth>bubbles *
04:44<andythenorth>there are some in toyland sprites
04:44<nielsm>or really, some thin steam
04:45-!-Gabda [~Gabda@catv-80-98-39-136.catv.broadband.hu] has joined #openttd
04:45-!-Gabda is "realname" on #openttd
04:45<Gabda>o/
04:45<DorpsGek_II>[OpenTTD/OpenTTD] Gabda87 commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhnG1
04:47<andythenorth>BBL etc
04:47-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has quit [Quit: andythenorth]
04:51<DorpsGek_II>[OpenTTD/OpenTTD] Gabda87 updated pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhsu0
05:12<TrueBrain>how do I find which commit was done 7 days before the current HEAD
05:12<TrueBrain>in git
05:14<LordAro>--since
05:15<LordAro>oh hey, it'll even do --since="1 week ago"
05:16<TrueBrain>yes .. but that is from the current date
05:16<TrueBrain>not from the HEAD date
05:16<TrueBrain>and I am not willing to change my clock :D
05:17<LordAro>ah
05:18<LordAro>--since="somedate - 1 week" works as well
05:18<LordAro>so just need to get the date of HEAD
05:19-!-debdog [~debdog@2a00:79c0:62f:e700:7a24:afff:fe8a:d04d] has joined #openttd
05:19-!-debdog is "Wowbagger" on #bitlbee #openttd
05:20<TrueBrain>yeah ..
05:20<TrueBrain>so we are going old-style
05:20<TrueBrain> revdate=$(git log -1 --pretty=format:"%ci")
05:20<TrueBrain> last_week=$(date -u -d "$revdate -7days" +"%Y-%m-%d %H:%M")
05:20<TrueBrain>was hoping to avoid that :)
05:20<LordAro>you can avoid most of that
05:20<TrueBrain>hmm .. by default 'git log' shows the author date
05:21<TrueBrain>which is often weird
05:21<TrueBrain>should I just use commit date instead?
05:21<LordAro>probably
05:21<LordAro>given rebase/squash
05:22<TrueBrain>and "most of that" is only the second line :P
05:22<TrueBrain>so that is strictly seen 50% :P
05:22<LordAro>well, yeah :p
05:22<LordAro>it's longer than the first line
05:22<TrueBrain>just less git-depending :)
05:22<TrueBrain>(I copied this from the subversion script)
05:22<TrueBrain>http://ftp.snt.utwente.nl/pub/games/openttd/binaries/nightlies/trunk/r28004/changelog.txt
05:22<TrueBrain>this is what it used to be
05:22<TrueBrain>do I want to match that
05:23<TrueBrain>or just use git log --pretty=fuller
05:28<TrueBrain>I think fuller is more than sufficient
05:30<TrueBrain>LordAro: difference between 'zip' and 'zip -9' is huge
05:30<TrueBrain>and of course it is better to spend some extra CPU cycles getting binaries smaller :)
05:31<TrueBrain>if I remember correctly, it was bytes with the other compressions, but huge chunks with zip :P
05:32<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnZO
05:38-!-synchris [~synchris@139.138.202.72] has joined #openttd
05:38-!-synchris is "Synesios Christou" on #openttd
05:41-!-Progman [~progman@p57A2BFF5.dip0.t-ipconnect.de] has joined #openttd
05:41-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttd
05:51-!-nielsm [~nielsm@176-23-103-56-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
05:59<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
05:59<TrueBrain>hmm, that was unneeded
06:09<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnZ6
07:06<TrueBrain>"2019-01-12T12:05:25.6308700Z touch: illegal option -- d"
07:06<TrueBrain>pffft @ Mac OS X!
07:08<LordAro>TrueBrain: why do you want to get a week old commit, anyway?
07:17<DorpsGek_II>[OpenTTD/OpenTTD] btzy opened pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnn8
07:18-!-Thedarkb-T60 [~Thedarkb-@86-42-116-99-dynamic.agg3.kny.prp-wtd.eircom.net] has joined #openttd
07:18-!-Thedarkb-T60 is "realname" on #oolite #openttd
07:27<DorpsGek_II>[OpenTTD/OpenTTD] btzy updated pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnn8
07:45<Eddi|zuHause>so it's illegal in MacOS land to touch d?
08:12-!-kgz [~kragniz@nyaa.kragniz.eu] has quit []
08:14-!-gelignite [~gelignite@55d4528f.access.ecotel.net] has joined #openttd
08:14-!-gelignite is "gelignite" on #openttd
08:17-!-tokai|noir [~tokai@00012860.user.oftc.net] has joined #openttd
08:17-!-mode/#openttd [+v tokai|noir] by ChanServ
08:17-!-tokai|noir is "Christian Rosentreter" on +#openttd
08:20-!-Thedarkb-T60 [~Thedarkb-@86-42-116-99-dynamic.agg3.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
08:24-!-tokai [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
08:26-!-gelignite2nd [~gelignite@55d4a5eb.access.ecotel.net] has joined #openttd
08:26-!-gelignite2nd is "gelignite" on #openttd
08:32-!-gelignite [~gelignite@55d4528f.access.ecotel.net] has quit [Ping timeout: 480 seconds]
08:32-!-chomwitt [~chomwitt@ppp-94-69-11-160.home.otenet.gr] has quit [Ping timeout: 480 seconds]
08:33<DorpsGek_II>[OpenTTD/OpenTTD] btzy opened issue #7041: Cargo flow legend not fully redrawn when middle of station is moved https://git.io/fhncf
08:45-!-chomwitt is "chomwitt" on #debian #debian-games
08:45-!-chomwitt [~chomwitt@ppp-94-69-11-160.home.otenet.gr] has joined #openttd
08:51<TrueBrain>LordAro: changelog.txt for nightlies are always the last 7 days
08:51<TrueBrain>just to put something in there :)
08:52<TrueBrain>so I dont want a week old commit, I want the log between them
08:52<TrueBrain>and in git world, getting the commit and the log is the same thing :)
08:52<LordAro>ah yeah
08:56-!-Thedarkb-T60 [~Thedarkb-@86-42-116-99-dynamic.agg3.kny.prp-wtd.eircom.net] has joined #openttd
08:56-!-Thedarkb-T60 is "realname" on #openttd #oolite
08:56<TrueBrain>okay, I now have a released.txt, README.md and changelog.txt .. last one left: manifest.yaml .. which is a post-job
08:57<TrueBrain>Also changed the way I fetch the source .. just once now, make a tarball, give that to all the other jobs
08:57<TrueBrain>so we are sure we are building the same thing :D
08:59-!-kragniz [~kragniz@nyaa.kragniz.eu] has joined #openttd
08:59-!-kragniz is "kragniz" on #bcache #openttd
09:00<TrueBrain>so many Doxygen errors and warnings
09:01<LordAro>pretty much all of them should just be to do with missing docs
09:01<LordAro>at least they were a couple of months ago when i fixed all of them :p
09:02<TrueBrain>no clue; just watched the long list passing by :D
09:06-!-glx [~glx@000128ec.user.oftc.net] has joined #openttd
09:06-!-mode/#openttd [+v glx] by ChanServ
09:06-!-glx is "Loïc GUILLOUX" on +#openttd
09:11<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
09:16-!-Flygon [~Flygon@58-6-78-6.dyn.iinet.net.au] has quit [Read error: Connection reset by peer]
09:18-!-WWacko1976-work [~IceChat9@ip-80-113-66-42.ip.prioritytelecom.net] has joined #openttd
09:18-!-WWacko1976-work is "YO!" on #openttd #/r/openttd
09:44<DorpsGek_II>[OpenTTD/OpenTTD] btzy opened issue #7042: Use intrinsics for bit twiddling? https://git.io/fhnch
09:52-!-Samu [Samu@pa4-84-91-142-34.netvisao.pt] has joined #openttd
09:52-!-Samu is "..." on #openttd
09:56<Gabda>is it normal that a road bridge is owned by 2 towns?
09:57<Samu>really? that happens?
09:57<Eddi|zuHause>owner or local authority?
09:57<Eddi|zuHause>is a different thing
09:58<Gabda>the 2 different ends has different owners and local authority
09:58<TrueBrain>did they both pay for it? :P
09:59<Gabda>i was looking for exotic town placements to understand how the local authority works on roads
09:59<Samu>bt, I found a bug regarding town bridges, during world generation the code deletes towns that are generated with 0 population, but by doing so, nearby bridges are also removed
09:59<Samu>btw*
09:59<Eddi|zuHause>then maybe the code that assigns bridge ownership is wrong?
10:00<Samu>those bridges didn't belong to the town being deleted
10:00<Gabda>it is a world generated bridge
10:00<Samu>it results in disconnected towns
10:01<Samu>posted a few screenshots a few days ago, let me find them
10:03<Samu>ah, here they are
10:03<Samu>https://imgur.com/a/hqCAgsO
10:03<Samu>chronologic order is, image at the top fist, then later on, image at the bottom
10:04<Gabda>I pissed off one of the towns, so I couldn't demolish anything anymore, not even the bridge
10:04<Eddi|zuHause>probably code that has opon founding a town take over ownership of nearby roads
10:04<Eddi|zuHause>modulo grammar
10:04<Gabda>but I could demolish it from the other side of the bridge :D
10:06<Gabda>but the road continuing the bridge belongs to the first city again
10:06<Gabda>like A city, B city, No owner, Road, Bridge
10:07<Eddi|zuHause>other roads built after game start?
10:07<Gabda>R R R R R B B B B B B B B B R R R R R
10:08<Gabda>A A A A A A N N N N N N N B A A A A A
10:08<Gabda>didn't play with the game, so I don't know that one
10:10<Gabda>I think it doesn't have any effect on anything, I just found it funny enough to share :)
10:11<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhnCC
10:13<@peter1138>Morning
10:13<@peter1138>#7027 sounds interesting
10:15<Samu>peter1138 hi, you broke framerate window recently, can u fix? was gonna use them to time ship pathfinders
10:15<@peter1138>-> report on github or it doesn't exist
10:15<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhnC4
10:18<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick opened issue #7043: Disconnected towns during world generation https://git.io/fhnCg
10:19<DorpsGek_II>[OpenTTD/OpenTTD] Gabda87 commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhnC2
10:21<@peter1138>Well there's some other windows I broke :p
10:21<@peter1138>Oh well, I'll fix.
10:21<LordAro>are you suggesting that someone didn't review your PR well enough?
10:23<Samu>do I really have to
10:23<Samu>:(
10:24<Gabda>So it is not normal that you have to close and open the framerate window to update the data?
10:24<@peter1138>OnTick is no longer called, but a couple of windows still have it :p
10:24<@peter1138>That's why it doesn't update.
10:24<Gabda>I used that window for the first time today, and it was a little odd.
10:27<@peter1138>Heh
10:31-!-Wormnest [~Wormnest@35.136.176.177] has joined #openttd
10:31-!-Wormnest is "Wormnest" on #openttd
10:34<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick updated pull request #6926: Change: Allow dock to be constructed in more locations https://git.io/fhnCx
10:37<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick dismissed a review for pull request #6927: Change: Forbid dock placement on docking area https://git.io/fxptD
10:37<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick updated pull request #6927: Change: Forbid dock placement on docking area https://git.io/fhnCh
10:39<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick updated pull request #6933: Fix #6233: Improve lock pricing and infrastructure counting, to achieve better consistency https://git.io/fhnWe
10:39<Samu>dismissed?
10:39<Samu>i'm only refreshing
10:43-!-gelignite2nd [~gelignite@55d4a5eb.access.ecotel.net] has quit [Ping timeout: 480 seconds]
10:43<LordAro>Samu: you could also say it was "invalidated"
10:43<Samu>Falling back to patching base and 3-way merge...
10:43<Samu>i had a weird rebase
10:44<Samu>what does that mean?
10:44-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has joined #openttd
10:44-!-andythenorth is "andythenorth" on #openttd
10:44<andythenorth>no but seriously
10:44<andythenorth>rainbows
10:44<TrueBrain>welcome back andythenorth
10:45<andythenorth>what changed?
10:45<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick updated pull request #6935: Add: EnsureNoShipFromDiagDirs https://git.io/fxno7
10:45<Samu>whatever
10:45<DorpsGek_II>[OpenTTD/OpenTTD] btzy commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhnWL
10:45<Samu>if something's wrong, i hope i know it
10:45<Samu>from azure pipeliner dude
10:48<andythenorth>TrueBrain: today is the deadline you set for removing stale issues
10:48<andythenorth>so I will be doing that
10:48<andythenorth>anyone want to save any more FS patches? :)
10:48<TrueBrain>blame me, fine :P
10:49<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep opened pull request #7044: Codechange: Define INVALID_TOWN as a TownID. https://git.io/fhnW3
10:49<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick updated pull request #6925: Fix #6574 #6636 #5405 #6493: Aircraft hangar issues https://git.io/fpJfr
10:51<DorpsGek_II>[OpenTTD/OpenTTD] LordAro approved pull request #7044: Codechange: Define INVALID_TOWN as a TownID. https://git.io/fhnWc
10:52<LordAro>andythenorth: i've not had chance to look through them yet, gimme a few more hours?
10:52-!-Thedarkb-T60 [~Thedarkb-@86-42-116-99-dynamic.agg3.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
10:53<andythenorth>sure
10:53<TrueBrain>only approved? Not even merged?
10:53<TrueBrain>:P
10:53<LordAro>CI hadn't finished :p
10:53<TrueBrain>:D
10:53<andythenorth>LordAro: https://github.com/OpenTTD/OpenTTD/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22+label%3A%22stale%22+
10:53<andythenorth>35
10:53<TrueBrain>going for quickest PR of th week, I guess
10:54<andythenorth>^^^ pretty mixed batch
10:54<Samu>how do i quote code on gitgub :(
10:54<andythenorth>I already picked out some where I recognise the author, it's had prior review etc
10:54<andythenorth>also the ones where it's not politics whether it's merged or not
10:55<Samu>andythenorth I wanna reply to you but i fail at quoting code
10:55<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick commented on pull request #6927: Change: Forbid dock placement on docking area https://git.io/fhnW8
10:55<andythenorth>Samu: "yes" / "no" would be enough :)
10:56<Samu>ah, found it
10:56<Samu>https://github.com/OpenTTD/OpenTTD/pull/6927/files#r230102973
10:56<andythenorth>for saving FS patches, the ones that are easy to test are also preferable
10:57<andythenorth>e.g. timetable stuff is a fricking tarpit to test
10:57<Samu>it's hidden
10:57<Samu>it's a resolved converstation thing
10:57<andythenorth>I like this one https://bugs.openttd.org/task/5735/getfile/9334/new-signal-gui.png
10:57<andythenorth>https://github.com/OpenTTD/OpenTTD/issues/5735
10:58<TrueBrain>15 minutes between attempts for the final pieces of the release pipeline .. this is annoyingly slow :D
10:58<Samu>https://github.com/OpenTTD/OpenTTD/pull/6927/files#r230428556 ... damn it, im not getting the correct link
10:58<andythenorth>very cycle time
10:58<andythenorth>such slow
10:58<andythenorth>much annoy
10:59<Samu>andythenorth you have to click to show "This conversation was marked as resolved by nielsmh
10:59<Samu> Show conversation "
10:59<Samu>I answered there
11:00<DorpsGek_II>[OpenTTD/OpenTTD] Gabda87 commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhnWu
11:04<Samu>oh no, build errors
11:05<Samu>somebody ruined my patch
11:05<Samu>whoever made the airport tile check
11:06<Samu>the rebase wasn't clear, it only said something weird about 3-way merge
11:07<Gabda>does the codebase have a function that loops over all the tiles that are within a certain (manhattan) distance from a source tile?
11:07<TrueBrain>plenty of variants :D
11:09<Samu>he renamed tile_cur to tile_iter
11:09<Samu>interesting
11:09<Samu>now I understand the importance of keeping the same variable names
11:11<Gabda>TrueBrain: can you give a hint on the name, of the file they are defined in?
11:11<Samu>https://github.com/OpenTTD/OpenTTD/commit/06cd561cea26c41553b7a6b327a7ac1fbdea23d2
11:12<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep opened pull request #7045: Codechange #5859: Simplify CheckTrainStayInDepot(). https://git.io/fhnWi
11:13<TrueBrain>Gabda: I wish I knew :D Havent touched the code in 10+ years :P
11:13<TrueBrain>sorry for not being helpful
11:14<TrueBrain>pretty sure that if you open any _cmd file you will find plenty
11:14<TrueBrain>https://github.com/OpenTTD/OpenTTD/blob/master/src/station_cmd.cpp#L107
11:14<Gabda>I found a search patter for it, I hope "#define FOR_" will help me :)
11:15<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhnWP
11:15<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep commented on issue #6476: Suggested changes for pathfinding for automatic servicing https://git.io/fhnWX
11:16<Gabda>this AddWrap can be interesting, thanks :)
11:16<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6476: Suggested changes for pathfinding for automatic servicing https://git.io/fhnWD
11:16<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6476: Suggested changes for pathfinding for automatic servicing https://git.io/fhnWy
11:17-!-Mahjong [~qq@2a00:23c5:6526:4400:90a6:fc8d:3aad:874b] has quit [Read error: Connection reset by peer]
11:17-!-Mahjong [~qq@2a00:23c5:6526:4400:90a6:fc8d:3aad:874b] has joined #openttd
11:17-!-Mahjong is "realname" on #openttd #ohnx
11:20<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep commented on issue #5978: Autoreplace window isn't updated after group hierarchy changes https://git.io/fhnW9
11:20<andythenorth>'Hydrogen' or 'Fuel Cell'
11:20<andythenorth>Pikka did 'Fuel Cell' in UKRS
11:20<andythenorth>I never used them, dunno why
11:21<TrueBrain>https://www.tt-forums.net/viewtopic.php?f=33&t=84609 <- I changed the topic
11:21<TrueBrain>got annoyed by "security vuln"
11:21<TrueBrain>it is not
11:21<andythenorth>fanks
11:21<andythenorth>triggered me ;P
11:22<TrueBrain>yeah ... me too
11:22<andythenorth>hmm novely train power doesn't really work
11:22<andythenorth>Steam | Diesel | Electric
11:22<andythenorth>stick to the knowns :P
11:23<Samu>EnsureNoShipFromDiagDir, basically makes ship size appears like they're 3 tile-wide
11:23<andythenorth>Fuel Cell, Hydrogen, Electro-diesel, Battery, not so good for ottd
11:23<Eddi|zuHause>fuel cell is just a variation on diesel?
11:23<andythenorth>hydrogen usually
11:23<andythenorth>reverse electrolysis or something
11:23*andythenorth chemically vague ;P
11:23<Eddi|zuHause>i mean in terms of game mechanics
11:23<andythenorth>yes
11:23<andythenorth>it's just words
11:23<andythenorth>and remove the visual effect
11:23<Eddi|zuHause>just make fuel cell the diesel of 2020+
11:24<andythenorth>the problem is that I like the rolling coal smoke effect :P
11:24<andythenorth>and we don't have rainbows
11:24<Eddi|zuHause>just like the switch from steam to diesel
11:24<Eddi|zuHause>switch from diesel to fuel cell
11:24<Eddi|zuHause>at a certain year
11:24<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
11:24<TrueBrain>now with a Manifest! :D
11:25<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnWp
11:26<TrueBrain>https://dev.azure.com/truebrain/OpenTTD/_build/results?buildId=223 <- who can test the MacOS binaries for me? Specifically, if the version ingame is the same as the name of that build?
11:26*andythenorth whistles innocently
11:26<andythenorth>who indeed?
11:27<andythenorth>you could just highlight me :P
11:27<TrueBrain>you didnt do the last round of testing :)
11:27<TrueBrain>we have more MacOS users these days helping out!
11:27<TrueBrain>YOU ARE NOT SPECIAL
11:27<TrueBrain>:D
11:27<@peter1138>Oops, I fell asleep o_O
11:28<Samu>who's a git command line expert? https://paste.openttdcoop.org/prkv7boyh
11:28<andythenorth>of course I'm special
11:28<Samu>what happened there?
11:28<andythenorth>I have a fruit on my computer
11:28<andythenorth>think of how important that makes me
11:28<TrueBrain>hmm ... fruit ...
11:29<andythenorth>version # from azure 20190112-azure_release2-g7ba4856b
11:29<andythenorth>version # in the binary package 20190112-azure_release2-g7ba4856b
11:29<TrueBrain>ingame too?
11:30<andythenorth>version # ingame: 20190112-azure_release2-g7ba4856b
11:30<TrueBrain>sweet
11:30<andythenorth>in all the many places
11:30<TrueBrain>thank you!
11:30<TrueBrain>nearly done :D
11:34<andythenorth>Eddi|zuHause: switching at a certain point was my plan, but it's meaningless in-game, except for the loss of effects :P
11:34<Eddi|zuHause>so?
11:35<Eddi|zuHause>lots of things are meaningless
11:35<andythenorth>so what effect can I abuse?
11:36<andythenorth>there's some white vapour industry smoke
11:37<andythenorth>think it's too big
11:38<Gabda>Samu something happened that shouldn't have?
11:39<Gabda>it seems like there was no merge conflict
11:43<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
11:44<andythenorth>so can we use the topology of the cargo graph as a factor in town pax generation?
11:44<andythenorth>somewhat IRL, number of nodes in the network is a factor in pax numbers
11:44<andythenorth>I think we can re-interpret that to a game world, in a way that is fun
11:45<andythenorth>it doesn't have to be realistic, nor scale perfectly
11:46<Samu>there was no conflict detected, but there was a problem, someone made changes to airport tile iterator and renamed a variable name which made my patch fail to pass the test on azure pipeliner
11:46<Samu>now i wonder if there were more problems
11:48<@peter1138>Well, did you not actually compile it yourself?
11:48<Samu>no
11:48<@peter1138>That's your first mistake.
11:48<Samu>because rebase 99% never fail
11:48<Samu>but fail
11:49<Xaroth>Isn't the idiom "Compile before comitting/submitting" ?
11:50<andythenorth>99% of my failures are due to not compiling before commit
11:50<Samu>I didn't make any change
11:50<Xaroth>irrelevant
11:50<Samu>i only put everything up to date
11:50<andythenorth>^^ that is complete lies, 99% of my failures are due to not using 'hg add'
11:50<Samu>somebody renamed tile_cur to tile_iter
11:50<Samu>that made it fail
11:51<Samu>the rebase didn't mention any conflict
11:51<Xaroth>Rebasing has little to do with checking the validity of your code
11:51<andythenorth>thre is no conflict there
11:51<Xaroth>only that changes can be applied one atop of another.
11:52<Xaroth>If you assume that if a rebase works, that your changes will work as well, you're in for a lot of hurt :P
11:52<TrueBrain>wait, there is no magic rabbit? AWH!
11:52<Samu>t.t
11:52*andythenorth reading ground_vehicle.cmd for acceleration
11:52<Samu>so it's my fault, not the fault of the other guy?
11:52<Xaroth>yes
11:52<andythenorth>I've been testing, would kind of like a gearing concept
11:52<Samu>oki :|
11:52<Xaroth>well, maybe not fault
11:53<Xaroth>but responsibility
11:53<Samu>rebases are too complicated for my underttanding
11:53<Xaroth>this problem isn't intrinsic to git, it's a common workflow in any programming collaboration
11:54<Xaroth>nor is it inherent to rebases only :)
11:54<Xaroth>if you have a patch set (plain old diff patches), and upstream something changes, your patch will fail to run, just like with this
11:55<LordAro>TrueBrain: https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=236 well that's even weirder
11:55<TrueBrain>LordAro: no, that sadly is more common than I would like
11:55<TrueBrain>Docker Hub is really terrible in availability
11:55<DorpsGek_II>[OpenTTD/OpenTTD] LordAro approved pull request #7035: Add: Mexican Peso currency https://git.io/fhnlu
11:55<TrueBrain>I cannot understand that it is .. but it is
11:56<LordAro>remind me, does anyone care either way wrt rebase vs squash?
11:57<TrueBrain>squash is there to make it easier to squash in case someone didnt rebase, but merged/added to his PR
11:57<TrueBrain>which is a fine workflow
11:57<TrueBrain>rebase is the easiest in most cases
11:57<DorpsGek_II>[OpenTTD/OpenTTD] LordAro merged pull request #7035: Add: Mexican Peso currency https://git.io/fhZFR
11:57<LordAro>that's what i thought
11:57<TrueBrain>I squash 1 commit PRs often so the PR number gets added
11:57<TrueBrain>so what-ever .. just don't squash if the individual commits are useful
11:58<LordAro>:+1:
11:58<TrueBrain>?
11:58<Xaroth>This isn't slack :P
11:59<LordAro>(y)
11:59<TrueBrain>we are moving to slack?
11:59<TrueBrain>cool! :D
11:59<LordAro>dammit
11:59<TrueBrain>retrigged the job LordAro
11:59<TrueBrain>I really want to move away from Docker Hub
11:59<TrueBrain>not sure how yet
11:59<TrueBrain>setting up our own registry, possibly
11:59*andythenorth read how max_te is used
11:59<LordAro>mm, probably
12:00<andythenorth>practically, testing in-game with hills, TE makes piss all difference to trains
12:00<andythenorth>only HP is relevant to acceleration
12:01<andythenorth>fwiw, I'm not looking for realism, I'm looking for performance variation in vehicles :P
12:02-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has joined #openttd
12:02-!-snail_UES_ is "Jacopo Coletto" on #openttd
12:02<DorpsGek_II>[OpenTTD/OpenTTD] LordAro requested changes for pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnl2
12:03<DorpsGek_II>[OpenTTD/OpenTTD] LordAro approved pull request #7045: Codechange #5859: Simplify CheckTrainStayInDepot(). https://git.io/fhnla
12:04<DorpsGek_II>[OpenTTD/OpenTTD] LordAro merged pull request #7045: Codechange #5859: Simplify CheckTrainStayInDepot(). https://git.io/fhnWi
12:04<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
12:04<DorpsGek_II>[OpenTTD/OpenTTD] LordAro closed issue #5859: Calling VehicleEnterDepot for a train frees the reservation of the depot https://git.io/fhnlw
12:07<LordAro>TrueBrain: https://dev.azure.com/truebrain/OpenTTD/_build/results?buildId=223 why is it that linux is "skipped" but none of the others are? something to do with "part of the docker image" ?
12:07<TrueBrain>LordAro: read the pipeline :D
12:07<LordAro>:<
12:07<TrueBrain> # If this is false, not all targets are triggered. For example:
12:07<TrueBrain> # both the NSIS installer for Windows and the creation of debs only work
12:07<TrueBrain> # for releases. Not for any other type of binary.
12:08<TrueBrain>Azure Pipelines doesn't allow giving reasons WHY something is skipped
12:08<LordAro>ah right
12:08<TrueBrain>I wish I could make it more clear, but there isn't really ..
12:08<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick updated pull request #6935: Add: EnsureNoShipFromDiagDirs https://git.io/fxno7
12:09<LordAro>and because the linux build does so little as part of the pipeline (as opposed to in the docker image), it means it looks like the whole linux build was skipped?
12:10-!-frosch123 [~frosch@00013ce7.user.oftc.net] has joined #openttd
12:10-!-frosch123 is "frosch" on +#openttd.dev #openttd
12:11<LordAro>also 245 build is completely different to 223 anyway :>
12:11<LordAro>quak
12:11<TrueBrain>LordAro: I can make it skip steps, instead of jobs, if that helps
12:11<TrueBrain>there is no build 245
12:11<LordAro>https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=245 beg to differ
12:12<TrueBrain>yes; check the URL :)
12:12<TrueBrain>2 completely different projects :P
12:12<LordAro>oh, bleh
12:12<TrueBrain>and of course, that 245 is the CI
12:12<TrueBrain>has nothing to do with releases :)
12:12<Gabda>can I have two PR-s with the same commit msg?
12:12<TrueBrain>https://dev.azure.com/truebrain/OpenTTD/_build/results?buildId=226 <- for example a release build
12:13<LordAro>Gabda: no reason why not, but.. why?
12:13<TrueBrain>LordAro: basically, it skips the 'linux', as all those targets will not be able to build a release. I can also skip them after expansion I guess .. but it still is vague
12:13<TrueBrain>I can make two pipelines
12:13<TrueBrain>but that is a lot of duplication
12:14<LordAro>mm
12:14<LordAro>wait, there is no linux build in 223?
12:14<LordAro>i'm confused
12:14<Gabda>I made a fundamentally different approach for a problem, and I want them reviewed separately
12:14<TrueBrain>LordAro: you should be; you were going to make me a linux build that is generic :D
12:14<LordAro>oh right, and you took that out for now?
12:14<TrueBrain>yes; it was broken
12:15<TrueBrain>so no generic linux builds for now :)
12:15<LordAro>shame, but ok
12:15<TrueBrain>I am hoping someone comes up with a good way to make generic linux builds :)
12:15<TrueBrain>can even be a .deb :P
12:15<TrueBrain>but currently debs only really work for releases
12:15<LordAro>Gabda: should probably put something in the PR title to show that its different. commit messages can be the same though
12:16<TrueBrain>over time I hope we get Steam releases too, for nightlies .. but .. lets just do the bare minimum first :)
12:16<TrueBrain>no need to build a complete castle first
12:16<TrueBrain>I am happy with a house :)
12:16<andythenorth>both these trains started at the same time https://dev.openttdcoop.org/attachments/download/9239/TE_vs_HP.png
12:17<andythenorth>pretty similar weight and HP
12:17<Gabda>I thought PR title is the first line of the commit msg. I set it when make a PR, of after that?
12:17<TrueBrain>LordAro: if you click on the Linux (skipped), and than the (!), it shows why it was skipped btw
12:17<Gabda>*Can I set it...
12:17<LordAro>Gabda: both :)
12:17<LordAro>PR title is mostly unconnected with the commit messages
12:17<LordAro>unless the PR gets squashed
12:18<LordAro>but then whoever's squashing can review the message anyway
12:18<Gabda>ok, thanks
12:19<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep opened pull request #7046: Fix #5978: Update some stats and lists caused by group hierarchy. (3298 and Juanjo) https://git.io/fhnlj
12:20<@peter1138>Hmm, I wonder when the OnTick of a dropdown list happens.
12:20<andythenorth>for the first time in years #openttd.dev might be useful :P
12:20<TrueBrain>meh; seems we are not the only one with docker hub issues .. meh
12:20<@peter1138>Something to do with scrolling, but it seems to scroll fine without it;.
12:20<@peter1138>andythenorth, this is where we dev
12:20<andythenorth>isn't it
12:21<TrueBrain>LordAro: would it help if I call it "Linux (Stable)" .. meaning it would resolve to "Linux (Stable) linux-ubuntu-xenial-i386-gcc" when not skipped
12:22<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
12:23<TrueBrain>"Linux (Stable only)"
12:23<TrueBrain>hmm
12:23<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
12:24<TrueBrain>https://dev.azure.com/truebrain/OpenTTD/_build/results?buildId=228
12:24<TrueBrain>looks better, I guess
12:25<TrueBrain>but two pipelines might be better
12:25<TrueBrain>hmm, yes, that would make other things easier too I guess
12:26<TrueBrain>first, food
12:28<Samu>looks like i have nothing more to refresh
12:31<Samu>yesterday night I sent 5000 ships to depots
12:32<Samu>the yapf result was surprisingly good
12:32<Samu>a stall of 2.7 seconds
12:33<Samu>which makes me wonder if my implementation was actually working
12:33<Samu>better recheck
12:39<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhn8h
12:44-!-Gja [~Martin@93-167-84-102-static.dk.customer.tdc.net] has joined #openttd
12:44-!-Gja is "Martin" on #ceph #bcache #openttd
12:54<Samu>forbid 90 degs improve pathfinder times
12:55<@peter1138>Let options to try.
12:58<Samu>something that juanjo has done was the removal of water tracks if the adjacent tiles were land
12:59<DorpsGek_II>[OpenTTD/OpenTTD] Gabda87 opened pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhn44
12:59<Samu>wondering if that could be implemented on the real openttd
13:01<Samu>it would break savegame compatibility
13:01<Samu>so I guess not
13:02-!-Thedarkb-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
13:02-!-Thedarkb-T60 is "realname" on #openttd #oolite
13:03<Samu>maybe it could be implemented for pathfinders decision logic?
13:03<@peter1138>One way to improve ship pathfinding: explicit ship tracks.
13:04<@peter1138>Then it would be similar in performance to trains.
13:04<@peter1138>I wonder if implicit-semi-explicit could work.
13:08<andythenorth>can we implicitly lay some?
13:08<andythenorth>when orders are created?
13:09<andythenorth>lay track bits in water tiles?
13:09<andythenorth>then pathfinding is 'next tile'
13:10*andythenorth wavey hands
13:14<@peter1138>Quite
13:14<andythenorth>'auto track maker'
13:15-!-Thedarkb1-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
13:15-!-Thedarkb1-T60 is "realname" on #openttd #oolite
13:17<Samu>strange, I have all 5000 ships stopped in depots but the framerate still registers ship tick activity
13:17<@peter1138>Could it be that checking 5000 ships to see if they are stopped costs CPU time?
13:18<Samu>averaging 0.55 ms
13:19<Samu>maybe it's doing some other type of checks, not just pathfinder
13:19<Samu>dont know how this was implemented
13:21-!-Thedarkb-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
13:22<Samu>just started 5000 ships with opf, about 4100 ms spike
13:22<Samu>the number disappears too fast
13:23<Samu>too spiky atm
13:23<@peter1138>Hmm, should I double my RAM to 64GB?
13:23<@peter1138>And then add a few uint64s to the map array :D
13:24<Samu>https://imgur.com/OzkHlB5
13:25-!-Thedarkb1-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
13:27<andythenorth>peter1138: free RAM with every OpenTTD download
13:27<andythenorth>send us a coupon, we mail it out
13:27<@peter1138>RAM Doubler
13:30<Samu>lets see how many opf ships get lost when sending them to depot
13:34<Samu>going to compare the result with how many opf ships get lost when sending them to depot on 1.8.0
13:35<andythenorth>can I name a train Hermes?
13:35<andythenorth>or does it sound like a courier company? :P
13:41<Samu>26 ships lost with my implementation
13:42<Samu>out of 5000
13:42<Samu>for opf
13:46<Samu>52 ships lost for opf in 1.8.0, out of 5000
13:47<Samu>next is npf
13:49<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5978: Autoreplace window isn't updated after group hierarchy changes https://git.io/fhnB3
13:54<TrueBrain>"WARNING: Url has SSL/TLS available, switching to HTTPS for download" <- how is that a warning?
13:59<Samu>4 ships lost for npf in my implementation, out of 5000
13:59<Samu>7 ships lost for npf in 1.8.0, out of 5000
14:00<Samu>something's wrong, I was expecting 0
14:00<Samu>but ok, will investigate later
14:00<Samu>next is yapf
14:02-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has quit [Quit: snail_UES_]
14:03<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
14:03<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
14:04<TrueBrain>LordAro: this should fix most of the confusion, I hope :) Lemme know :)
14:04<DorpsGek_II>[OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnBg
14:04<Samu>wow, yapf is really good
14:05<Samu>0 ships lost for yapf in my implementation, out of 5000
14:05<Samu>0 ships lot for yapf in 1.8.0, out of 5000
14:05<Samu>lost*
14:05<LordAro>we call that "actually works"
14:05<LordAro>TrueBrain: cool, will take a look
14:05<LordAro>but first, some food
14:06<TrueBrain>no rush
14:07<andythenorth>oof, some projects might have quietly deleted the old pathfinders
14:08<andythenorth>mumble mumble savegames
14:08<DorpsGek_II>[OpenTTD/OpenTTD] PeterN opened pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnBV
14:09<TrueBrain>we still have multiple PFs? Silly :D
14:09<andythenorth>you know why :P
14:09<@peter1138>TrueBrain, yes :(
14:09<andythenorth>the terrible even might happen
14:09<andythenorth>one person might post something rude in the forums
14:09<andythenorth>event *
14:10<andythenorth>also the only person here who seems to like scorched earth
14:10<andythenorth>is andythenorth
14:10<Samu>must investigate why npf is failing
14:10<@peter1138>Delete it.
14:10<TrueBrain>andythenorth: I honestly don't know why it still is in there
14:10<andythenorth>TrueBrain: I posted the reason above
14:10<TrueBrain>I know 10 years ago it was a hot thing to even talk about
14:10<TrueBrain>but ... 10 years :P
14:10<@peter1138>I like scorched earth.
14:10<andythenorth>it's the fear that someone has a saved game
14:11<Samu>it's failing even in 1.8.0
14:11<andythenorth>and makes a post questioning the decision
14:11<TrueBrain>so start a deprecation! :P
14:11<andythenorth>remember depot-flip controversy?
14:11<TrueBrain>no
14:11<@peter1138>But... I played it about, hmm, 25-30 years ago?
14:11<andythenorth>the only feature that was ever removed
14:11<TrueBrain>you could flip depots? :P
14:11<andythenorth>you could flip trains in depots
14:11<TrueBrain>or was that what that AI did and made massive amounts of money
14:11<TrueBrain>ah :)
14:11<andythenorth>it was / is broken for newgrf vehicles
14:11<andythenorth>so it was removed
14:11<TrueBrain>that clearly was abuse/bug :)
14:11<andythenorth>mega rage quits
14:11<andythenorth>such woe
14:12<TrueBrain>I love that an AI author found out it was better to have trains do one-ways (and sell/buy constantly)
14:12<andythenorth>wait until I delete 'Extreme' in FIRS 4 :P
14:12<andythenorth>then we'll see woe
14:13<TrueBrain>okay, building nightlies seems to be in good order
14:13<TrueBrain>just needs a CDN to publish the binaries on
14:13<andythenorth>they would build faster
14:13<andythenorth>and be smaller
14:13<TrueBrain>and .. then we need to get the new website online :)
14:13<TrueBrain>sadly, 0 contributions :(
14:13<andythenorth>if they had fewer pathfinders
14:14<TrueBrain>https://github.com/OpenTTD/website/issues <- still 3 things we need fixing
14:14<andythenorth>I can do https://github.com/OpenTTD/website/issues/11 if no-one else can be arsed to
14:14<andythenorth>probably can't do this well https://github.com/OpenTTD/website/issues/10
14:15<TrueBrain>I was hoping putting the issues there would attract a few people more helping out :P
14:15-!-Gja [~Martin@93-167-84-102-static.dk.customer.tdc.net] has quit [Remote host closed the connection]
14:15<TrueBrain>https://github.com/OpenTTD/website/issues/13 I really need to fix myself I guess :)
14:15<andythenorth>kinda
14:16<andythenorth>LA is also busy reviewing stuff
14:16<TrueBrain>yeah :D
14:16<andythenorth>and making some kind of changelog
14:17<TrueBrain>hmm .. when I move everything to a DO CDN, I increase the montly bill with 30 dollars ..
14:17<TrueBrain>in return I no longer have to maintain this custom mirror stuff :P
14:17<andythenorth>what are our funds? :P
14:17<TrueBrain>I have been told I have nothing to worry about
14:17<andythenorth>I have NFI what the money situation is
14:18<TrueBrain>the one thing we are not really open about; not sure why not
14:18<andythenorth>because people can be weird about money?
14:18<TrueBrain>something down the line to look at, I guess
14:18<TrueBrain>yeah .. especially salaries :D
14:18<TrueBrain>anyway, I believe that if we had no donations, we could still run our infrastructure for several years, or something
14:19<TrueBrain>but people are kind enough to still donate
14:19<Samu>aha, I see what's wrong
14:19<TrueBrain>people are awesome like that
14:20<Samu>it's turning an automatic service order to an unreachable depot into a manual order to stop at the same unreachable depot, instead of computing another
14:20<Samu>searching for another
14:20<Samu>and there really is a depot just 10 tiles away
14:20<Samu>:(
14:20<Samu>reachable
14:21<Samu>where in the code are automatic service orders changed to manual
14:24<@peter1138>Hmm
14:24<@peter1138>My PR failed CI. Github issue or something I did?
14:25<@peter1138>Oh right. Commit message wrong. Hmm.
14:25<@peter1138>Haha old style -Fix :p
14:25<DorpsGek_II>[OpenTTD/OpenTTD] PeterN updated pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnBV
14:26<@peter1138>Unable to find image 'openttd/compile-farm-ci:commit-checker' locally
14:26<@peter1138>^ That kinda confused me :p
14:26<TrueBrain>fix it and make a PR :D
14:26<@peter1138>I'm gonna fix dinner firsty.
14:26<@peter1138>FIRSTY
14:27<TrueBrain>Docker really is not the best piece of software out there :(
14:27<TrueBrain>the CLI is so freakinglish inconsistent
14:32<andythenorth>secondy
14:32<andythenorth>dinner
14:37<Samu>i found the problem
14:37<Samu>https://github.com/OpenTTD/OpenTTD/blob/master/src/vehicle.cpp#L2299
14:37<Samu>the same depot happens to be unreachable
14:37<Samu>what can I do?
14:37<Samu>it doesn't even check with pathfinder
14:37<Samu>it's skipped
14:40<DorpsGek_II>[OpenTTD/OpenTTD] LordAro requested changes for pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnB7
14:41<Eddi|zuHause>what's wrong with youtube? trying to show me videos such as "why are british trains so bad" and "why is DB so bad"?
14:43<andythenorth>Eddi|zuHause: "why are british trains so bad" is being highly recommended to me also
14:43<andythenorth>are you me?
14:45<Wolf01>Meh, I finished the robotic arm and configured the sbrick profile with the controls (with icons too!) now I have *ache, put any body part in place of * and you'll guess right...
14:46<Wolf01>Youtube for me only suggests lego, spacex, and numberphile
14:55<Eddi|zuHause>i've been subscribed to numberphile for years
15:00<frosch123>do you want links to ruin your suggestions?
15:01<DorpsGek_II>[OpenTTD/OpenTTD] PeterN updated pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnBV
15:01-!-nielsm [~nielsm@176-23-103-56-cable.dk.customer.tdc.net] has joined #openttd
15:01-!-nielsm is "Niels Martin Hansen" on #openttd
15:02<@peter1138>LordAro, such a noob ;(
15:02<LordAro>:p
15:04<LordAro>peter1138: given you actually know stuff about the map array, do you think you could offer your thoughts on #7047?
15:04-!-Thedarkb1-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
15:04-!-Thedarkb1-T60 is "realname" on #openttd #oolite
15:05-!-synchris [~synchris@139.138.202.72] has quit [Ping timeout: 480 seconds]
15:06<TrueBrain>hmm .. so Sentry manual suggests to commit the sentry_sdk.init URL in your VCS
15:07<TrueBrain>but that means anyone can report issues on that project ..
15:07<TrueBrain>is it me, or does that sound strange
15:09<DorpsGek_II>[OpenTTD/OpenTTD] PeterN commented on pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhnR1
15:10<@peter1138>Oh..
15:11<DorpsGek_II>[OpenTTD/OpenTTD] PeterN commented on pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhnRD
15:12<LordAro>TrueBrain: depends what you want to achieve, i guess. the other project i know uses an environment variable when running. ...but that's because it's a single instance of an irc bot and rather easier to constrain access to it
15:12<TrueBrain>if I want to achieve people being asses and submit all kinds of bugs via the public DSN, I should put it in git yes :P
15:12<andythenorth>usually Sentry would be in a less open source env?
15:13<andythenorth>access control and all that jazz
15:13<TrueBrain>guess that means I have to setup a Secret on production, and put it in there
15:13<TrueBrain>andythenorth: I don't follow, sorry? :(
15:13<andythenorth>usually you'd be putting that URL in a private VCS?
15:14<andythenorth>with only employees having access
15:14<andythenorth>not github
15:14<TrueBrain>or some other method
15:14<TrueBrain>but the getting started kinda suggests to just put it in your code
15:14<TrueBrain>which feels odd :P
15:14<andythenorth>we used Sentry
15:14<andythenorth>it's kinda odd
15:14<TrueBrain>but a search on github gave me a lot of people doing that :D
15:14<andythenorth>we kinda dropped it
15:14<TrueBrain>Sentry is pretty nice for Python and Javascript
15:14<TrueBrain>and free for Open Source, so meh :)
15:14<andythenorth>"the problem was us, not Sentry"
15:14<TrueBrain>any monitoring better than none :D
15:15<andythenorth>probably
15:15<LordAro>andythenorth: less "open source env" and more "open env", i think
15:15<@peter1138>Hmm, I think I need a bigger microSD card for my retropie. PSX images are big :p
15:15<LordAro>wonder how other systems do error reporting
15:15<LordAro>there must be something out there
15:15<andythenorth>there are tools
15:15<andythenorth>datadog and stuff
15:15<andythenorth>but Sentry seems to be default last time I checked
15:16<andythenorth>or you can....read the logs :P
15:16<andythenorth>weird idea
15:16*andythenorth looking at flyspray patches
15:17<TrueBrain>if you have any system that digests logs, you are fine :)
15:17<andythenorth>https://github.com/OpenTTD/OpenTTD/issues/6657 <- that's the intended behaviour IMHO, closing that
15:17<TrueBrain>but reading logs yourself is ... very odd andythenorth :P
15:17<TrueBrain>like someone is having a tail open 24/7 :D
15:17<LordAro>yeah, who would do that
15:17<andythenorth>I have to fill in security questionnaires that require it
15:18<andythenorth>as part of bid process
15:18<andythenorth>not even server logs, wifi access logs
15:18<andythenorth>have to be read in detail
15:18<TrueBrain>normally you use SIEMs/SIMs for that :P
15:18<andythenorth>no they require them to be manually audited
15:18<andythenorth>'best practice'
15:18<andythenorth>because wifi
15:18<LordAro>andythenorth: idk, it's very weird that the oil rig would be "banned" from using its own station
15:19<andythenorth>no
15:19<andythenorth>you bought exclusive transport rights
15:19<andythenorth>the clue is in the name
15:19<andythenorth>:)
15:19<andythenorth>it's correct behavour
15:19<andythenorth>behaviour *
15:19<LordAro>guess it boils down to whether "exclusive transport rights" in a town applies to oil rigs
15:19<andythenorth>it does
15:19<andythenorth>it's exclusive
15:20*andythenorth takes a stance
15:20<andythenorth>or we can roll a die
15:20<andythenorth>flip a coin
15:20*TrueBrain sees andy drawing a line in the sand
15:20<andythenorth>but changing it is...change
15:20<TrueBrain>I DARE YOU :P
15:21<andythenorth>DOUBLE DARE
15:21<andythenorth>this, NFI, sounds like a bug
15:21<andythenorth>https://github.com/OpenTTD/OpenTTD/issues/6636
15:21<andythenorth>diff seems quite clean, but eh, dunno
15:22<LordAro>andythenorth: also already part of a PR
15:23<andythenorth>it is? :o
15:23<andythenorth>I can't see the PR reffed on the ticket, I should get my glasses
15:23<LordAro>yeah, it's only referenced in the last commit, annoyingly
15:24<andythenorth>this sounds nice, but fails to apply https://github.com/OpenTTD/OpenTTD/issues/6635
15:25<LordAro>sounds like it would be confusing
15:25<LordAro>can't imagine it would be difficult to make it apply again though
15:25<nielsm>okay so I could write a decoder for the dos adlib music and import the dosbox adlib emulation to render it... or I could do something actually worthwhile but perhaps less fun
15:25<nielsm>(for certain definitions of fun)
15:25<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6636: airplane going for helistation depot https://git.io/fhn0a
15:26<andythenorth>it sounds confusing to have to ctrl-click titlebars
15:26<andythenorth>windows remembering position isn't a bad idea, but meh
15:26<TrueBrain>https://pypi.org/project/PyYAML/#history <- there is a CVE against 3.13 .... so ...... yeah ...
15:26-!-Wormnest [~Wormnest@35.136.176.177] has quit [Ping timeout: 480 seconds]
15:26<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6635: Save default window position https://git.io/fhn0r
15:26<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6635: Save default window position https://git.io/fhn0o
15:27<andythenorth>this sounds like a bug patch
15:27<andythenorth>https://github.com/OpenTTD/OpenTTD/issues/6633
15:27<andythenorth>but diff is relatively big for the issue
15:28<andythenorth>has a test sav if anyone wants to try, otherwise closing
15:29<LordAro>nah, leave it
15:29<LordAro>if nothing else it's a bug
15:29<LordAro>even if the patch isn't useful
15:29<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhn06
15:30<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6657: Buying exclusive transport rights prevents oil rigs from using their own dock/helipad https://git.io/fhn0i
15:30<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6657: Buying exclusive transport rights prevents oil rigs from using their own dock/helipad https://git.io/fhn0P
15:31<@peter1138>Hmm, MacOS Job failed.
15:31<@peter1138>"The agent: Hosted Agent lost communication with the server. Verify the machine is running and has a healthy network connection." o_O
15:31<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6633: cargomonitor industry delivery https://git.io/fhn01
15:31<andythenorth>bloody macOS
15:31<LordAro>can't blame docker hub for that one
15:31<LordAro>probably
15:32<andythenorth>I confirmed this is a bug in 2017, but does the patch fix it? ;) https://github.com/OpenTTD/OpenTTD/issues/6599
15:32*andythenorth tries
15:33<TrueBrain>funny error .. first time I have seen thatone :D Hopefully also the last ..
15:33<TrueBrain>weird that the rerun button doesnt work
15:33<andythenorth>patch thinks this has already been applied in master :o https://bugs.openttd.org/task/6599/getfile/10802/3-use-gui-sorlists-for-buildvehgui-engines-filtering.diff
15:33*andythenorth is not good enough to know how to resolve that :P
15:33<LordAro>probably by skipping it :p
15:34<LordAro>git blame to work out when it got included, see if anything else got included with it
15:35<LordAro>a glance at build_vehicle_gui.cpp suggests that it has not been applied
15:35<LordAro>also, `git apply` might be more effective
15:35*andythenorth tries stuff
15:35<LordAro>or it might barf at the hg patch, who knows
15:36<andythenorth>meh, I did 'apply anyway' and the compile barfs
15:38<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6599: Can still click on buy button in vehicle selection window even if no vehicle is selected https://git.io/fhn0Q
15:38<Eddi|zuHause>i don't think that applies cleanly on anything
15:38<andythenorth>it's a stupid small issue
15:38<andythenorth>it's more than an edge case
15:39<andythenorth>but TMWFTLB?
15:39<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhn07
15:39<Eddi|zuHause>you need to apply the patches in order
15:39<andythenorth>oh yes
15:39<andythenorth>meh
15:39<andythenorth>I think that one should be left open TBH
15:40<LordAro>#6599? yeah
15:40<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6598: Possible for client to be in a nonexistent company on a server; but then the client crashes. https://git.io/fhn05
15:40<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6598: Possible for client to be in a nonexistent company on a server; but then the client crashes. https://git.io/fhn0d
15:41<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh commented on pull request #6935: Prevent water construction where it could block nearby ships https://git.io/fhn0b
15:43<LordAro>andythenorth: easily reproducible crash/invalid state stuff should be kept open, imo
15:43<andythenorth>this one, if I understand the comments correctly, is all commited apart from patch 5 https://github.com/OpenTTD/OpenTTD/issues/6472
15:43<andythenorth>NFI if it's worth saving or not
15:44<andythenorth>I suspect fonso would have just committed it if was valid
15:44<LordAro>presumably only because of the last comment?
15:44<LordAro>@seen fonsinchen
15:44<@DorpsGek>LordAro: fonsinchen was last seen in #openttd 1 year, 44 weeks, 5 days, 3 hours, 38 minutes, and 25 seconds ago: <fonsinchen> There we go.
15:45<LordAro>i'd like to keep it, those performance improvements seem worth it
15:45<LordAro>and JGR's stuff is usually good
15:46<LordAro>feel free to assign me :p
15:46<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6472: Cargodist: various link graph performance improvements https://git.io/fhn0x
15:46<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6472: Cargodist: various link graph performance improvements https://git.io/fhn0p
15:46<andythenorth>ok I re-open
15:46*andythenorth is behind the times
15:46<LordAro>:>
15:46<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6472: Cargodist: various link graph performance improvements https://git.io/fhn0h
15:48<andythenorth>you want this one too LordAro ? https://github.com/OpenTTD/OpenTTD/issues/6470
15:48<Eddi|zuHause>andythenorth: so the 3-patch seems to conflict on a uint32/CargoType rename, and something else that seems to already have happened on a completely unrelated thing. should be trivial to solve
15:49<andythenorth>Eddi|zuHause: for 6599? Would definitely be worth solving
15:49<andythenorth>if I can get a clean PR with no faff, I'll test it happily
15:49<LordAro>oh, i didn't even notice that 4/5 patches had already been applied, but cool
15:50<LordAro>andythenorth: given JGR is actually on github, give them a poke first
15:50<Eddi|zuHause>andythenorth: i need to come up with commit messages before pushing this
15:51<nielsm>yeah if the author of a flyspray-imported ticket has a github account, @-mentioning them when updating that ticket could help get it on track
15:51<Eddi|zuHause>andythenorth: at least seems to compile now
15:52<andythenorth>LordAro: I @ JGR already :)
15:52<Eddi|zuHause>what's the easiest way to batch-edit commit messages?
15:52<andythenorth>if the author is on GH, I do @ them
15:52<LordAro>andythenorth: not on 6470
15:52<andythenorth>Eddi|zuHause: rebase -i ?
15:52<@peter1138>Hmm, should I try rebasing my RGB company colours patch? :p
15:53<@peter1138>Last commit was in 2013, although it was rebased in May last year.
15:54<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6470: Link graph job thread-join schedule changes https://git.io/fhnEq
15:54<andythenorth>peter1138: group liveries :P
15:54<andythenorth>delete the current UI, put a menu on every group, just pick two colours
15:54<andythenorth>make a nice palette colour choose thing
15:54<andythenorth>profit
15:55<andythenorth>this one has a patch, but maybe the bug is the useful part of the ticket? https://github.com/OpenTTD/OpenTTD/issues/6468
15:56<Eddi|zuHause>where's the list of commit message prefixes?
15:57<LordAro>on the wiki :p
15:57<Wolf01>Uh oh, big update for mashinky
15:57<andythenorth>https://wiki.openttd.org/Commit_style#Commit_message
15:57<LordAro>https://github.com/OpenTTD/OpenTTD-git-hooks/blob/master/hooks/check-message.py#L5
15:58<LordAro>andythenorth: definitely bug, patch is... unclear
15:58<andythenorth>yair I'll change the labels
15:58<andythenorth>Eddi|zuHause: mostly for dev stuff I start by looking here https://github.com/OpenTTD/OpenTTD/blob/master/CONTRIBUTING.md
15:59<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6468: Loading savegame with AI loaded as specific version of that AI fails to load correct version of AI https://git.io/fhnEn
15:59<Eddi|zuHause>dunno what prefix applies to these... picking "Change" for now
16:00*andythenorth tests https://github.com/OpenTTD/OpenTTD/issues/6453
16:00<andythenorth>anyone want to read this before I spend time testing? https://bugs.openttd.org/task/6453/getfile/10825/fs6453.diff
16:00<andythenorth>looks straightforward
16:01<LordAro>yeah
16:01<nnyby>so when will 1.9.0 be released? :P
16:01<LordAro>probably April
16:01<LordAro>probably betas and release candidates before that
16:01<andythenorth>I can't repro this, https://github.com/OpenTTD/OpenTTD/issues/6453
16:02<andythenorth>closing it
16:02<Eddi|zuHause>andythenorth: rebase -i just complains i have no tracking branch
16:02<andythenorth>HEAD~n
16:02<andythenorth>?
16:02<andythenorth>rebase -i is remarkably hard to learn
16:02<andythenorth>but not remarkably hard to actually do
16:02<Eddi|zuHause>ok, rebase -i master works
16:03<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6453: Crash: scrolling down list of (none) GS parameters https://git.io/fhnEW
16:03<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6453: Crash: scrolling down list of (none) GS parameters https://git.io/fhnEl
16:03<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnE8
16:05<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6439: Aircraft will not move if company is bought while displaying "too far to next destination" https://git.io/fhnER
16:05<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6439: Aircraft will not move if company is bought while displaying "too far to next destination" https://git.io/fhnE0
16:05<@peter1138>andythenorth, hmm, the vehicle-type liveries was quite a wanted feature back in the day :/
16:06<andythenorth>I bet
16:06<andythenorth>I'm not saying it's crap, burn it with fire
16:06<andythenorth>but there's a more interesting way to do it?
16:06<andythenorth>the UI is crap though :D
16:06<@peter1138>Well we can do that AND have group colours.
16:07<@peter1138>My livery patch removed the checkbox stuff.
16:07<andythenorth>well ship that :D
16:07<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z opened pull request #7049: 6599 https://git.io/fhnEu
16:07<andythenorth>it's just weird, 4 ways to configure pax coach colours
16:07<andythenorth>but not mail
16:07<andythenorth>and freight gets 1 way
16:08<Eddi|zuHause>dunno if any of that is right
16:08<andythenorth>and the whole thing pretends newgrfs don' exist
16:08<andythenorth>don't *
16:08<@peter1138>Not really, it works with company-colour newgrfs.
16:09<andythenorth>I mean the steam / diesel / electric split
16:09<@peter1138>And the original classes was done because that's how TTDPatch did it!
16:09<andythenorth>although those are the correct categories :P
16:09<andythenorth>I tried Hydrogen today, and it's weird
16:09<@peter1138>https://www.tt-wiki.net/wiki/EnhancedGraphicalUserInterface/2.5
16:09<Eddi|zuHause>andythenorth: newgrfs also only know about these three
16:09<andythenorth>mail isn't pax though, I don't think I lose that argument
16:09<andythenorth>Eddi|zuHause: I concede defeat on that point :P
16:09<@peter1138>Mail ISN'T passengers, but "pax" covers mail and passengers.
16:10<andythenorth>ha ha the TTDP one is brilliant
16:10<andythenorth>it colours the dropdowns in
16:10<andythenorth>rainbow menus
16:10<@peter1138>The argument for mail being included is that passengers/mail often travel together.
16:10<@peter1138>Yeah, I didn't bother with that.
16:10<nielsm>https://github.com/OpenTTD/OpenTTD/issues/6470 is definitely in JGR's own builds so it probably is actively being ported up
16:11<andythenorth>the coloured dropdowns are every rule of UI design style broken
16:11<nielsm>and might be possible to pull almost unchanged from his branch
16:11<andythenorth>I love them
16:11<Eddi|zuHause>andythenorth: maybe rules of UI design were different 10 years ago?
16:11<andythenorth>not that many
16:11<andythenorth>bevels vs flat
16:11<andythenorth>not much else
16:12<andythenorth>is it 20 years yet?
16:12<Eddi|zuHause>bevels were more pronounced in original TT
16:12<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on issue #2155: Console: heightmaps for dedicated server https://git.io/fhnE2
16:12-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has joined #openttd
16:12-!-snail_UES_ is "Jacopo Coletto" on #openttd
16:12<Eddi|zuHause>so it got flatter between 1994 and 1996
16:13<andythenorth>Eddi|zuHause: so 7049 - the fix is that it selects another vehicle, when hiding one?
16:13<andythenorth>works for me, if that's the intent
16:13<Eddi|zuHause>i have no clue about intent
16:14<Eddi|zuHause>also no clue if my distribution of "Change" and "Codechange" is correct
16:14<andythenorth>I'm assuming it's intended due to title of patch 1 https://bugs.openttd.org/task/6599/getfile/10797/1-select-first-available-rail-engine-to-buy.diff
16:14<andythenorth>anyway it resolves the issue
16:15<andythenorth>also for the "filter cargo 'none'" case
16:15<Eddi|zuHause>only the first commit seems to be related to the original issue, the rest is "bonus" of some sort
16:15<LordAro>i like #4540, and it has a fonsichen and/or 3298 patch, unstaled
16:16<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on pull request #7049: Fix #6599: Can still click on buy button in vehicle selection window even if no vehicle is selected https://git.io/fhnEw
16:16<andythenorth>bonus scares me but eh
16:16<andythenorth>LordAro aren't implicit orders solved yet?
16:17<LordAro>i have no idea tbh, never use them :p
16:18<DorpsGek_II>[OpenTTD/OpenTTD] Gabda87 commented on pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhnEr
16:18<andythenorth>do the patches apply?
16:19<LordAro>#4684 seems nice, but perhaps confusing?
16:19<andythenorth>https://github.com/OpenTTD/OpenTTD/issues/2155 seems like an obviously missing feature, and I agree to keep....but dead since 2012 :P
16:19<andythenorth>nvm
16:19<andythenorth>4684 is tarpit politics
16:19<andythenorth>and doesn't win much
16:19<LordAro>mm
16:20<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #4684: Use shift to estimate costs only with a certain type of commands https://git.io/fhnEo
16:20<andythenorth>freeing up shift is questionable
16:20<andythenorth>it often won't be free when it's wanted
16:20<andythenorth>so don't bother
16:20<@peter1138>Oh, this is a nightmare: "both modified: media/extra_grf/openttdgui.png"
16:20<@peter1138>:p
16:21<andythenorth>frigging openttdgui again
16:21<andythenorth>every time
16:21<nielsm>seriously, split it into multiple files
16:21<@peter1138>Was it not possible to use separate files?
16:21<@peter1138>Heh
16:21<andythenorth>"but one spritesheet is so much more efficient"
16:21<nielsm>possibly even one per sprite
16:21<andythenorth>some retro misunderstood bollocks about minimising http requests probably
16:21<andythenorth>or just inertia
16:21<nielsm>obviously not efficient for the workflow
16:21<andythenorth>optimise for collaborative development
16:22<nielsm>eh perhaps for the artist being able to easier copy-paste pixels bewteen sprites
16:22<@peter1138>Ok, when I have a rebase conflict on a binary file, how do I pick which file I want to edit?
16:22<nielsm>(then group a few related sprites into each spritesheet, but still individual files per concern)
16:22<@peter1138>--ours --theirs :/
16:23<andythenorth>peter1138: NFI, does it matter? You have to open both anyway
16:23*andythenorth should merge all these spritesheets, for 'efficiency'
16:23<andythenorth>https://dev.openttdcoop.org/projects/iron-horse/repository/show/src/graphics/pony
16:23<@peter1138>Yes, but in the rebased state you only get one.
16:23<@peter1138>git checkout --ours was the correct incantation.
16:24<@peter1138>Oh, actually no.
16:25<andythenorth>someone file a ticket for me to split it up?
16:25<andythenorth>that's how work gets done right? :P
16:25<@peter1138>--ours/--theirs is the wrong way around to what I was expecting.
16:26<Eddi|zuHause><nielsm> eh perhaps for the artist being able to easier copy-paste pixels bewteen sprites <-- because it is so mind-boggingly difficult to have two images open at the same time?
16:26<andythenorth>wait, this is merged? https://github.com/OpenTTD/OpenTTD/issues/6397
16:26<LordAro>andythenorth: #4540 doesn't apply, but i think it's quite close
16:26<andythenorth>Eddi|zuHause: it probably started small and no-one split it
16:26<andythenorth>the other sprite files are quite split up iirc
16:26<andythenorth>inertia :P
16:27<@peter1138>Not one per sprite.
16:27<andythenorth>one per sprite is not useful for, e.g. the canals stuff
16:27<andythenorth>that's split up by concern quite well
16:28<andythenorth>but openttdgui.png is too many concerns in one file
16:28<LordAro>^
16:28<andythenorth>toolbar, window buttons etc
16:28<@peter1138>Well yeah, one-per-sprite for the GUI file is what I was thinking.
16:28<andythenorth>LordAro: comment on #4540 then?
16:29<andythenorth>I like implicit orders being displayed, but eh, people used to moan a lot about them
16:29<Eddi|zuHause>clearly a toggle between show/hide implicit?
16:29<andythenorth>peter1138: you proposing to do it, or you want to wait until I do?
16:30-!-Thedarkb2-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
16:30-!-Thedarkb2-T60 is "realname" on #openttd #oolite
16:30<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on issue #4540: Orders: toggle display of implicit orders https://git.io/fhnEP
16:31<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6397: Keep town growth rate in sync with house count https://git.io/fhnEM
16:31<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6397: Keep town growth rate in sync with house count https://git.io/fhnED
16:32<andythenorth>eh looks like some or all of this is merged too? https://github.com/OpenTTD/OpenTTD/issues/6378
16:32<LordAro>"some", i think
16:32<LordAro>difficult to tell how much
16:33<andythenorth>Eddi|zuHause: want to try and gravedig this? It's potentially a useful feature https://github.com/OpenTTD/OpenTTD/issues/6328
16:33<andythenorth>I'm closing 6378 and @ dp to tell me if I'm wrong
16:33<Eddi|zuHause>andythenorth: re: #6397: i'm not sure how much of that was actually in the commit. the description is a bit fuzzy
16:33<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on issue #5078: NOAI API lack vehicle is old event https://git.io/fhnES
16:34<@peter1138>Hmm, how do I force openttd.grf to be rebuilt? o_O
16:34<andythenorth>Eddi|zuHause: you could read the diffs if you could be bothered? :)
16:34<Eddi|zuHause>i don't think i could be bothered :p
16:35<Eddi|zuHause>peter1138: if in doubt, make -B :p
16:35<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6378: Erroneous behavior of Get/SetGrowthRate GS methods https://git.io/fhnEH
16:35<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6378: Erroneous behavior of Get/SetGrowthRate GS methods https://git.io/fhnEQ
16:35<@peter1138>I've never heard of -B
16:35<Eddi|zuHause>there might be a makefile in /media
16:35<Eddi|zuHause>-B ignores timestamps/dependencies
16:35<Eddi|zuHause>and makes everything
16:35<andythenorth>if grfcodec is in the path, and the nfo is changed?
16:35<andythenorth>doesn't it just build?
16:36<Eddi|zuHause>peter1138: only people who fucked up their dependencies usually need -B :p
16:36<@peter1138>make -B fails with OpenTTD.
16:36<LordAro>doesn't surprise me
16:36-!-Thedarkb1-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
16:36<@peter1138>andythenorth, hmm, maybe I need to reconfigure
16:36<LordAro>did you configure with --without-grfcodec or similar?
16:36<@peter1138>Yeah that'll be it.
16:37<andythenorth>because of those .obs files?
16:37<@peter1138>I installed grfcodec just now, after deinstalling it the other day due to those spurious changed files :p
16:37<andythenorth>I have to git reset --hard every frigging time I want to rebase
16:37<andythenorth>it's really low-level hostile :P
16:37<andythenorth>I tried global .gitignore, but didn't do it right
16:38<@peter1138>Ah right, I remember now, the group livery stuff relied on resizing a matrix which just doesn't work :p
16:38<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5872: No wait cursor while autosaving https://git.io/fhnE5
16:38<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5872: No wait cursor while autosaving https://git.io/fhnEd
16:39<LordAro>andythenorth: hmm, #5377 has a PR #6751... which was closed
16:39<andythenorth>it does? o_O
16:39<Eddi|zuHause>andythenorth: #6328 has a few more conflicts
16:40<LordAro>it was closed unsatisfactorily, imo
16:40-!-Thedarkb2-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
16:40-!-Gabda [~Gabda@catv-80-98-39-136.catv.broadband.hu] has quit [Remote host closed the connection]
16:40<Eddi|zuHause>uhoh, saveload changes :/
16:40<andythenorth>I would leave 6751 closed, no use case given
16:41<DorpsGek_II>[OpenTTD/OpenTTD] nikolas opened issue #7050: Compiling with --disable-network yields error https://git.io/fhnEF
16:41<andythenorth>maintainers go mad just trying to please people
16:41<andythenorth>APIs *should* be complete in theory
16:41<andythenorth>but let people come with actual problems they can't solve
16:42<Eddi|zuHause>where do i edit my local gitignore?
16:42<LordAro>andythenorth: i think my "GetWaterTile" idea is best :p
16:43<LordAro>Eddi|zuHause: https://help.github.com/articles/ignoring-files/
16:43<nnyby>Eddi|zuHause: ~/.gitignore
16:43<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5377: AIs cannot detect river tiles https://git.io/fhnEN
16:43<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5377: AIs cannot detect river tiles https://git.io/fhnEA
16:43<Eddi|zuHause>there also seems to be .git/info/exclude
16:43<nnyby>well the filename is flexible. it's configured like this: git config --global core.excludesfile ~/.gitignore_global
16:43<Eddi|zuHause>for repo-specific
16:44<nnyby>just read the article LordAro linked to
16:44<nnyby>Eddi|zuHause: for repo-specific it's just the .gitignore file in each directory
16:44<nnyby>i wouldn't mess with what's in .git/, that's internal git stuff
16:44<Eddi|zuHause>nnyby: no, there's a repo-specific-but-local-gitignore
16:44<nnyby>only stuff i alter in there is .git/config, to set up origin to be my repo, vs upstream OpenTTD
16:45<Eddi|zuHause>i.e. "only in this repo, and only on this computer"
16:45<nnyby>ah okay
16:45<nnyby>yeah, i've never needed to use that feature
16:45<Eddi|zuHause>where .gitignore is "only in this repo, but shared between everyone"
16:45<nnyby>right
16:46<Eddi|zuHause>but probably ~/.gitignore would be more appropriate for now
16:46<LordAro>nielsm: care to take up #5735? :p
16:47<andythenorth>only 15 left, some of which we triaged already https://github.com/OpenTTD/OpenTTD/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22+label%3A%22stale%22
16:47<andythenorth>I didn't test 5735 because it's queue faff, but it's a good feature
16:48<andythenorth>*way* too many signals in the UI
16:49<LordAro>#5977 is trivial, and applies
16:49*LordAro takes
16:49<andythenorth>yeah 3298's stuff was pretty good
16:49<andythenorth>I tested quite a bit of it
16:50<LordAro>shame he didn't get on with github
16:50<andythenorth>shame
16:50<andythenorth>there is a forum ticket with a bunch of useful fixes in
16:50<LordAro>i noticed in his forum post that he cited having to pay for private repos as an issue
16:50<LordAro>now that that is no longer the case...
16:50<andythenorth>JJ has been picking some of the fixes out
16:51<Eddi|zuHause>so... gitignore sorted out, distributed stuff between ~/.gitignore and .git/info/exclude appropriately, i think
16:51<andythenorth>3298's primary problem was being tracked
16:51<andythenorth>but eh distractions
16:51<andythenorth>Eddi|zuHause: can we all have our gitignore fixed?
16:51<andythenorth>I will mail you my computer
16:51<Eddi|zuHause>now back to the actual conflict
16:51<Eddi|zuHause>andythenorth: teamviewer? :)
16:51<andythenorth>:P
16:52<andythenorth>timetable bugs are an absolute tarpit for testing https://github.com/OpenTTD/OpenTTD/issues/2944
16:52<andythenorth>there's no save attached
16:52<andythenorth>it's not from a contributor I recognise
16:52<andythenorth>2009 :P
16:53<nielsm>LordAro I'd do the signal GUI completely different myself from that patch in 5735 :)
16:53<nielsm>but don't really feel like working on GUI right now
16:53<LordAro>that's fair
16:53<LordAro>andythenorth: kill it ^
16:53<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #2944: Timetable: auto-reset delay counter https://git.io/fhnuJ
16:53<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #2944: Timetable: auto-reset delay counter https://git.io/fhnuU
16:54<andythenorth>I don't actually much like the new signal ui in the attached PNG
16:54<andythenorth>it's not....good
16:54<nielsm>right now: https://0x0.st/s7lP.png
16:54<Eddi|zuHause>andythenorth: i'm not sure if i understand #2944, i thought that's how it already behaves?
16:54<andythenorth>Eddi|zuHause: NFI, timetables don't work for me ever :)
16:54<LordAro>nielsm: dare i ask?
16:54<andythenorth>something about having to use full load, or not
16:54<andythenorth>timetables are super confusing and broken
16:55<andythenorth>actually I lie 100%
16:55<nielsm>LordAro, I want to make a decoder for the dos adlib music (ADLIB.CAT) and play it through emulation
16:55<andythenorth>I use 'wait at station for n days' on nearly all pax routes :P
16:55<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on issue #6266: UI Zoom: ugly lists in network windows on double/quad interface sizes with custom fonts https://git.io/fhnuI
16:55<Eddi|zuHause>timetables are ok, but miss a lot of advanced features
16:56<Eddi|zuHause>too much micromanagement
16:57<andythenorth>why it's not just a cadence of vehicles I don't know :P
16:57<andythenorth>seems very complex
16:58<andythenorth>it's for modelling real world timetables for train fans, right?
16:58<LordAro>oh
16:58<LordAro>i can't actually compile on mingw
16:58<LordAro>that's unfortunate
17:01-!-chomwitt [~chomwitt@ppp-94-69-11-160.home.otenet.gr] has quit [Ping timeout: 480 seconds]
17:01<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5735: Signals: signal window - show one signal variant at a time https://git.io/fhnuq
17:01<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5735: Signals: signal window - show one signal variant at a time https://git.io/fhnum
17:05<andythenorth>oof this one modifies openttdgui.png :( https://github.com/OpenTTD/OpenTTD/issues/5981
17:05<andythenorth>I don't think making 'location' an icon is wise
17:05<Eddi|zuHause>src/depot_base.h:46:13: error: ‘const struct Depot’ has no member named ‘type’
17:05<Eddi|zuHause> return d->type == this->type;
17:05<Eddi|zuHause>more problems
17:06<andythenorth>Eddi|zuHause: TMWFTLB?
17:06<Eddi|zuHause>not yet
17:06<Eddi|zuHause>but also not trivial, like the other one
17:06<andythenorth>I wonder if it has more work behind it https://github.com/OpenTTD/OpenTTD/issues/6328#issuecomment-379454447
17:06<andythenorth>order handling might need adjusted
17:07-!-debdog [~debdog@2a00:79c0:62f:e700:7a24:afff:fe8a:d04d] has quit [Quit: Initiating getting-the-hell-out-of-here maneuver!]
17:07<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #5981: Unify appearance and position of location buttons (wanted contributions-list) https://git.io/fhnus
17:07<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5981: Unify appearance and position of location buttons (wanted contributions-list) https://git.io/fhnuG
17:08<andythenorth>101 issues open
17:08<Eddi|zuHause>so what happened to depot types?
17:08<andythenorth>TrueBrain: ready for Probot yet? ^
17:08<andythenorth>NotDepotTypes Eddi|zuHause ?
17:08<andythenorth>;)
17:10<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6060: Allow drawing dropdown lists with scrollbars above the widgets https://git.io/fhnuC
17:11<Eddi|zuHause>can't i browse through just changes to a specific file on git?
17:11<Eddi|zuHause>i can get the changelog for that file
17:11<Eddi|zuHause>but it'll lead me to complete repo diffs
17:12<andythenorth>is there a blame view
17:12<andythenorth>?
17:12*andythenorth looking
17:12<andythenorth>Eddi|zuHause: https://help.github.com/articles/tracking-changes-in-a-file/
17:13<andythenorth>can't figure out how to use it though :P
17:13<andythenorth>oh found it
17:14<andythenorth>Eddi|zuHause: https://help.github.com/articles/tracking-changes-in-a-file/
17:14<andythenorth>nope wrong paste
17:14<andythenorth>https://github.com/OpenTTD/OpenTTD/blame/master/src/airport.cpp
17:15<Eddi|zuHause>i found a deeply hidden thing in git gui that does what i want
17:15<Eddi|zuHause>but i found no evidence of depot type ever being a thing
17:16<Eddi|zuHause>maybe it's a badly ordered patch queue, i'll ignore it and go ahead
17:17<Eddi|zuHause>if it works after all patches are applied, then maybe consider squashing?
17:20<andythenorth>this one is very interesting https://github.com/OpenTTD/OpenTTD/issues/6060
17:20<andythenorth>the original issue seems to be fixed
17:20<andythenorth>I can crash r27656 by making the window size too small to display a dropdown menu
17:20<andythenorth>which is clown shoes, but seems fixed in 1.8.0
17:20<andythenorth>I don't know what the remaining patches fix
17:25-!-Thedarkb2-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
17:25-!-Thedarkb2-T60 is "realname" on #openttd #oolite
17:25<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6583: Scrolling down/right out of map on a 255 high flat map bounces viewport back to edge of map https://git.io/fhnu0
17:26-!-Wormnest [~Wormnest@35.136.176.177] has joined #openttd
17:26-!-Wormnest is "Wormnest" on #openttd
17:26<andythenorth>peter1138: any interest in JFDI-ing this? https://github.com/OpenTTD/OpenTTD/issues/6155. Comment from 23 Mar 2017 smells of 'incoming politics' :P
17:27<Eddi|zuHause>so complete queue compiles
17:27<andythenorth>:)
17:30-!-Thedarkb-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
17:30-!-Thedarkb-T60 is "realname" on #openttd #oolite
17:31<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z opened pull request #7051: Feature: Moveable depots #6328 https://git.io/fhnug
17:33*andythenorth tests
17:33<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6583: Scrolling down/right out of map on a 255 high flat map bounces viewport back to edge of map https://git.io/fhnur
17:34-!-Thedarkb2-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
17:35<andythenorth>Eddi|zuHause: did you test it? o_O
17:35<Eddi|zuHause>no
17:36<andythenorth>it's pretty neat
17:37<andythenorth>the building / rebuilding is pretty straightforward
17:37<Eddi|zuHause>yeah, i do remember going "why does this not work?" a while ago
17:37<andythenorth>I've got a train stuck though
17:38<andythenorth>I gave it orders to a depot, then deleted the depot
17:38<Eddi|zuHause>but it's not quite merge-ready i think
17:38<andythenorth>actually it's user error I think
17:38<andythenorth>the order has been invalidated
17:38<andythenorth>probs fine
17:38<Eddi|zuHause>i'm assuming it's going to disappear after a month like invalid station?
17:39<andythenorth>yup
17:39<andythenorth>think so
17:39<andythenorth>yeah
17:39<andythenorth>kind of thing that needs a long-run game to test it
17:39<andythenorth>or just putting in a nightly :P
17:40*andythenorth wonders what it does with airport hangars
17:41<andythenorth>seems to work
17:41-!-Thedarkb1-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
17:41-!-Thedarkb1-T60 is "realname" on #openttd #oolite
17:42<andythenorth>distance is 8 tiles Eddi|zuHause ?
17:42<andythenorth>approx?
17:43-!-Thedarkb-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
17:43<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on pull request #7051: Feature: Moveable depots #6328 https://git.io/fhnuM
17:47<andythenorth>just 7 left
17:47<andythenorth>https://github.com/OpenTTD/OpenTTD/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22+label%3A%22stale%22
17:47<andythenorth>I think this is dead? https://github.com/OpenTTD/OpenTTD/issues/6490
17:48<LordAro>maybe
17:48<LordAro>i feel like i saw something about an appdata.xml somewhere else recently anyway
17:48<andythenorth>also the dude was just plain rude
17:48<andythenorth>"Copying it into your repository shouldn't be that much of an effort. If your attitude would be more friendly and your source code repository more accessible, "
17:48<andythenorth>is 50% accurate, at the time :P
17:49<andythenorth>it was FS :P
17:49<andythenorth>closing, there's nothing useful to test there, just another grumpy open source developer
17:49<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6490: appdata.xml metadata file for inclusion in Software Center https://git.io/fhnuF
17:49<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6490: appdata.xml metadata file for inclusion in Software Center https://git.io/fhnub
17:50<andythenorth>this one needs the 'escalated quickly' gif https://github.com/OpenTTD/OpenTTD/issues/6583
17:50<andythenorth>scroll bug -> refactor tile heights completely :P
17:50<Samu>ok, gonna create an assert
17:51<Samu>for this https://github.com/OpenTTD/OpenTTD/pull/6928#discussion_r247325714
17:52<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6505: Allow rail when ships are on lower halftile https://git.io/fhnuN
17:52<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #6505: Allow rail when ships are on lower halftile https://git.io/fhnuA
17:53<andythenorth>frosch123: any recollections about https://github.com/OpenTTD/OpenTTD/issues/6060
17:53<Samu>aha, an assert was triggered
17:53<andythenorth>specifically https://github.com/OpenTTD/OpenTTD/issues/6060#issuecomment-453784718
17:57<Samu>nielsm was right, now the ship is told to reverse
17:57<frosch123>andythenorth: you need a dropdown with a lot of entries
17:57<frosch123>possibly translation selection or so
17:57<andythenorth>ok
17:58<frosch123>then make the main window very small in height
17:58<Samu>would not reverse otherwise, but I can't see where the shit is
17:58<Samu>ship*
17:58<andythenorth>I did trigger the previous assert with very small window height
17:58<frosch123>so that the whole selection doe snot fit
17:58<frosch123>then position the combobox in the upper or lower half of the main window
17:58<Eddi|zuHause>andythenorth: seems that regression failed
17:59-!-Thedarkb1-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
17:59<andythenorth>frosch123: all of that seems to work fine ?
17:59-!-Wormnest [~Wormnest@35.136.176.177] has quit [Ping timeout: 480 seconds]
17:59<andythenorth>in master
17:59<Eddi|zuHause>and that errors are still useless
18:00<Eddi|zuHause>andythenorth: so that definitely needs more work
18:00<andythenorth>2019-01-12T22:39:23.2400344Z Running ai/regression/tst_regression... failed!
18:01<Eddi|zuHause>andythenorth: the linux ones contain actual regression output
18:01<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on pull request #7051: Feature: Moveable depots #6328 https://git.io/fhnzv
18:01<frosch123>andythenorth: the window still scrolls when holding the button down
18:02<frosch123>i have no idea whether parts of that diff were committed or whether someone else implemented the same
18:02<frosch123>(svn r27820) -Fix: Allow dropdown to be drawn above origin widget even with scrollbar (Juanjo)
18:03<andythenorth>I can't trigger any scroll behaviour that looks weird
18:03<frosch123>ah, that's the reivision that's mentioned in the issue as well
18:04<andythenorth>yes
18:04<frosch123>andythenorth: make the combobox open above the widget with a scrollbar
18:04<Samu>ah i see
18:04<frosch123>open the combobox with keeping the button pressed down, not releasing it
18:04<andythenorth>frosch123: I did
18:05<andythenorth>then I can mousewheel scroll as expected
18:05<Samu>assert((dist <= rev_dist) == (dist2 <= rev_dist2));
18:05<frosch123>there are two ways to use a combobox: 1 click open + 1 click select, and press to open + release to select
18:05<+glx><EddizuHause> andythenorth: the linux ones contain actual regression output <-- indeed in the windows vbs I just do a <content of file A> = <content of file B> with no diff
18:05<Samu>yeah, this reversal is bad behaviour, well uhm, how am i gonna do this
18:05<frosch123>in the second method the window scrolls with the mouse is above/below the combowindow
18:06<Samu>just spotted the ship
18:06<andythenorth>oof
18:06<+glx>that's assuming the sh/awk fails too on other platforms
18:06<andythenorth>I can't repro
18:06<andythenorth>but I have the ottd mac-specific scroll stuff disabled, because it's bollocks
18:06<andythenorth>let me turn on it
18:06<frosch123>well, my repository is in november, no idea whether something changed in past 2 months
18:07<Eddi|zuHause>glx: i can't tell from the regression output what it was trying to do and whether that is a "good" or "bad" change
18:08<Eddi|zuHause>was there ever some followup to https://github.com/OpenTTD/OpenTTD/issues/6862 ?
18:09<+glx>it's related to depots ;)
18:09<Eddi|zuHause>glx: yeah, i see that :p
18:09<LordAro>i don't actually know how to get larger interface on the menu screen
18:09<Eddi|zuHause>glx: whic might be somewhat expected since we changed depot code :p
18:09<LordAro>which makes it a bit difficult to test #6212
18:09<+glx>and line numbers should match the .nut
18:09<LordAro>#6266*
18:11<+glx>ah no it doesn't because iterators
18:11<andythenorth>LordAro: game options?
18:11<LordAro>oh.
18:11<LordAro>how long has that been there>
18:12<Eddi|zuHause>probably years.
18:12<andythenorth>since peter1138 did it :)
18:12<andythenorth>best feature ever, at the time
18:12<Eddi|zuHause>we need 1.5 zoom. or sqrt(2)
18:13<nnyby>C++ is so much harder to use than javascript/python lol
18:13<+glx>Eddi|zuHause: running regression with -k flag used to keep result.txt, but I think it's overwritten by the second test
18:14<Eddi|zuHause>glx: not going to look at this today...
18:14<andythenorth>Eddi|zuHause: "add your vote" https://github.com/OpenTTD/OpenTTD/issues/6797
18:14<andythenorth>because votes = patches, right? :P
18:14<frosch123>andythenorth: so, something changed from november to now
18:14<frosch123>someone broke or removed the scrolling
18:15<+glx>Eddi|zuHause: I'll look at it and put it in comments
18:17<andythenorth>not getting much here frosch123 https://github.com/OpenTTD/OpenTTD/commits/master/src/widgets/dropdown.cpp
18:17<andythenorth>I'm assuming it's somewhere else :P
18:17<frosch123>i am compiling the revision before the ontick stuff
18:18<andythenorth>k
18:18<LordAro>andythenorth: frosch123: are you missing https://github.com/OpenTTD/OpenTTD/pull/7048 ?
18:19<LordAro>6266 looks fine though
18:19<LordAro>i'll make that into a PR at some point, probably
18:19*LordAro bedteim
18:19<andythenorth>not bad eh
18:19<andythenorth>cleared out a bunch, saved a few
18:20<DorpsGek_II>[OpenTTD/OpenTTD] LordAro merged pull request #7044: Codechange: Define INVALID_TOWN as a TownID. https://git.io/fhnW3
18:20<frosch123>so, the scrolling still happens before the ontick stuff, and probably again with 7048
18:20<andythenorth>frosch123: shall I update the issue, or you will?
18:21<frosch123>please do
18:21<andythenorth>thanks
18:22<DorpsGek_II>[OpenTTD/OpenTTD] LordAro dismissed a review for pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnB7
18:23<DorpsGek_II>[OpenTTD/OpenTTD] LordAro approved pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnzB
18:23<DorpsGek_II>[OpenTTD/OpenTTD] LordAro merged pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnBV
18:23<LordAro>andythenorth: there you go :p
18:23<andythenorth>ta
18:25*andythenorth compiling
18:26<andythenorth>frosch123: repro-ed
18:26<+glx>oh macOS task is the best way to look at regression diff ;)
18:26<+glx>in linux tasks it's hidden in the logs
18:27<+glx>but still doesn't tell what the regression was testing exactly
18:27<LordAro>https://i.imgur.com/MjgTv6G.png osht
18:27<LordAro>grats andythenorth
18:28<andythenorth>:P
18:28<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6060: Allow drawing dropdown lists with scrollbars above the widgets https://git.io/fhnzu
18:29<andythenorth>this is ready for PR afaict https://github.com/OpenTTD/OpenTTD/issues/6060#issuecomment-379453143
18:29<andythenorth>but very bedtime
18:33<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6078: Orders: it does not jump order by remaining lifetime https://git.io/fhnzr
18:34<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #5321: AI: allow placing waypoints like human player (next to each, other, covering more than 1 tile etc) https://git.io/fhnz6
18:35<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #4754: Scenario Editor: rivers with desert https://git.io/fhnzi
18:35<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth closed issue #4754: Scenario Editor: rivers with desert https://git.io/fhnzP
18:35-!-Samu [Samu@pa4-84-91-142-34.netvisao.pt] has quit [Read error: Connection reset by peer]
18:35-!-Samu [Samu@pa4-84-91-142-34.netvisao.pt] has joined #openttd
18:35-!-Samu is "..." on #openttd
18:36-!-andythenorth [~andytheno@cpc87219-aztw31-2-0-cust178.18-1.cable.virginm.net] has quit [Quit: andythenorth]
18:44-!-rocky1138 [~rocky1138@kwat.chat] has quit [Quit: The Lounge - https://thelounge.github.io]
18:46-!-rocky1138 [~rocky1138@kwat.chat] has joined #openttd
18:46-!-rocky1138 is "Your Mom" on #openttd
18:47-!-rocky1138 [~rocky1138@kwat.chat] has quit []
18:49-!-frosch123 [~frosch@00013ce7.user.oftc.net] has quit [Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn]
18:58<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnzj
18:59<+glx>ok I have a PR to write to improve regression
19:17<Samu>*fstd.best_track = INVALID_TRACK; expression must have class type
19:18<Samu>what does it mean?
19:18-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has quit [Quit: Once again the world is quick to bury me.]
19:19<Samu>fstd->best_bird_dist = INVALID_TRACK;
19:22<DorpsGek_II>[OpenTTD/OpenTTD] glx22 commented on pull request #7051: Feature: Moveable depots #6328 https://git.io/fhngR
19:23<+glx>it's a fun regression error
19:28<DorpsGek_II>[OpenTTD/OpenTTD] glx22 commented on pull request #7051: Feature: Moveable depots #6328 https://git.io/fhng0
19:39<DorpsGek_II>[OpenTTD/OpenTTD] glx22 commented on pull request #7051: Feature: Moveable depots #6328 https://git.io/fhngr
19:40<+glx>ok found the cause, thanks to regression :)
19:54<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z opened pull request #7052: Change: Allow drawing dropdown lists with scrollbars above the widget… https://git.io/fhngQ
20:00-!-sla_ro|master [~sla.ro@84.117.88.126] has quit []
20:03<DorpsGek_II>[OpenTTD/OpenTTD] glx22 opened pull request #7053: Fix: make -k switch useful when testing regression https://git.io/fhngj
20:06-!-Progman [~progman@p57A2BFF5.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20:07-!-Thedarkb1-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
20:07-!-Thedarkb1-T60 is "realname" on #openttd #oolite
20:09-!-Flygon [~Flygon@114-198-99-240.dyn.iinet.net.au] has joined #openttd
20:09-!-Flygon is "Flygon" on #openttd
20:09<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep commented on pull request #7052: Change: Allow drawing dropdown lists with scrollbars above the widget… https://git.io/fhn2f
20:36<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z closed pull request #7052: Change: Allow drawing dropdown lists with scrollbars above the widget… https://git.io/fhngQ
20:36<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z commented on pull request #7052: Change: Allow drawing dropdown lists with scrollbars above the widget… https://git.io/fhn2s
20:46-!-nielsm [~nielsm@176-23-103-56-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
21:04<Eddi|zuHause>" assert_compile(VEH_TRAIN == (int)ScriptTile::TRANSPORT_RAIL);" is that really necessary?
21:05<+glx>it's a safety check
21:05<Eddi|zuHause>well, i can leave it in
21:08<+glx>unless enum TransportType and enum VehicleType equivalence is checked somewhere else it's better to keep it
21:10<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z updated pull request #7051: Feature: Moveable depots #6328 https://git.io/fhnug
21:11<Eddi|zuHause>still leaves the "unclean" part of the queue to be resolved
21:11<+glx>I'm doing a quick fix for 7050
21:14<+glx>hmm mingw decided to fail to build
21:15<+glx>oh I know why, the c++11 PR has been merged
21:15<Eddi|zuHause>can't help you with that :p
21:16<Samu>i think i found a problem here https://github.com/OpenTTD/OpenTTD/blob/master/src/pathfinder/opf/opf_ship.cpp#L169
21:17<Samu>r can generate a number from 0 to 255, isn't it?
21:17<Samu>but is uint
21:17<Samu>what if it is 30 and then r-30 happens?
21:17<Samu>can't go below 0?
21:18<Samu>shouldn't r be int?
21:19<Samu>ops, r-80
21:19<Samu>@calc 30 - 80
21:19<@DorpsGek>Samu: -50
21:20<Samu> r 4294967284 unsigned int
21:20<Samu>oh, it goes back to a big number?
21:21<Samu>@calc 68 - 80
21:21<@DorpsGek>Samu: -12
21:22<DorpsGek_II>[OpenTTD/OpenTTD] btzy commented on pull request #7005: Fix #7004: Redraw linkgraph overlay correctly after zoom https://git.io/fhn27
21:23<Samu>@calc 0xffffffff - 12
21:23<@DorpsGek>Samu: 4294967283
21:23<Samu>@calc 0xffffffff - 11
21:23<@DorpsGek>Samu: 4294967284
21:28<Samu>I don't think 4294967284 <= 127
21:28<Samu>is true
21:28<Samu>is this a bug? intended bug?
21:30<DorpsGek_II>[OpenTTD/OpenTTD] btzy commented on pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhn2A
21:31<DorpsGek_II>[OpenTTD/OpenTTD] btzy updated pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnn8
21:33<DorpsGek_II>[OpenTTD/OpenTTD] btzy updated pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnn8
22:07<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick updated pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhZzm
22:20-!-debdog [~debdog@2a00:79c0:64d:3400:7a24:afff:fe8a:d04d] has joined #openttd
22:20-!-debdog is "Wowbagger" on #openttd #bitlbee
22:24<DorpsGek_II>[OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnaC
22:40-!-Samu [Samu@pa4-84-91-142-34.netvisao.pt] has quit []
23:46-!-Thedarkb1-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has quit [Ping timeout: 480 seconds]
23:51<DorpsGek_II>[OpenTTD/OpenTTD] nikolas opened pull request #7054: Fix: grammar in a bunch of comments https://git.io/fhnap
23:54-!-HerzogDeXtEr1 [~farci@dslb-188-103-133-217.188.103.pools.vodafone-ip.de] has joined #openttd
23:54-!-HerzogDeXtEr1 is "purple" on #openttd
23:55-!-Thedarkb1-T60 [~Thedarkb-@86-45-41-11-dynamic.agg2.kny.prp-wtd.eircom.net] has joined #openttd
23:55-!-Thedarkb1-T60 is "realname" on #openttd #oolite
---Logclosed Sun Jan 13 00:00:18 2019