Back to Home / #openttd / 2019 / 01 / Prev Day | Next Day
#openttd IRC Logs for 2019-01-04

---Logopened Fri Jan 04 00:00:06 2019
01:34-!-Tshaw [~Tshaw@2001:5b0:2337:c368:4c34:20a7:fea2:b127] has joined #openttd
01:34-!-Tshaw is "realname" on #openttd
01:36-!-Tshaw [~Tshaw@2001:5b0:2337:c368:4c34:20a7:fea2:b127] has quit []
02:25-!-andythenorth [] has joined #openttd
02:25-!-andythenorth is "andythenorth" on #openttd
03:35-!-smoke_fumus [~smoke_fum@] has joined #openttd
03:35-!-smoke_fumus is "KVIrc 4.2.0 Equilibrium" on #qemu #oolite #openttd
03:56-!-Samu [] has joined #openttd
03:56-!-Samu is "..." on #openttd
04:07-!-Samu [] has quit []
04:14-!-andythenorth is now known as Guest1691
04:14-!-Guest1691 [] has quit [Ping timeout: 480 seconds]
04:14-!-andythenorth [] has joined #openttd
04:14-!-andythenorth is "andythenorth" on #openttd
04:14-!-andythenorth [] has quit []
04:25-!-Lejving [] has quit [Read error: Connection reset by peer]
04:38-!-chomwitt [] has joined #openttd
04:38-!-chomwitt is "chomwitt" on #oolite #openttd #qemu #debian #debian-games
04:49<crem>When is openttd 2.0.0? :)
05:07-!-Mahjong1 [] has joined #openttd
05:07-!-Mahjong1 is "realname" on #ohnx #openttd
05:11-!-sla_ro|master [] has joined #openttd
05:11-!-sla_ro|master is "slamaster" on #sla #openttd
05:11-!-Mahjong [~qq@2a00:23c5:6526:4400:90ca:588b:881a:ba6b] has quit [Ping timeout: 480 seconds]
05:18-!-Progman [] has joined #openttd
05:18-!-Progman is "Peter Henschel" on #openttd
05:20-!-andythenorth [] has joined #openttd
05:20-!-andythenorth is "andythenorth" on #openttd
05:24-!-andythenorth [] has quit [Read error: Connection reset by peer]
05:25-!-andythenorth [] has joined #openttd
05:25-!-andythenorth is "andythenorth" on #openttd
05:32-!-andythenorth [] has quit [Read error: Connection reset by peer]
05:32-!-andythenorth [] has joined #openttd
05:32-!-andythenorth is "andythenorth" on #openttd
05:38<andythenorth>"all my errors"
06:43-!-lugo [] has joined #openttd
06:43-!-lugo is "..." on #debian #openttd
06:52<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep commented on pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929)
06:54<LordAro>crem: when it's finished
06:56<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929)
06:58-!-Samu [] has joined #openttd
06:58-!-Samu is "..." on #openttd
07:03<crem>Hm so 2.0.0 will be the ultimate openttd version when it's finished.. Make it last longer then!
07:18<DorpsGek_II>[OpenTTD/website] LordAro requested changes for pull request #7: Add: downloads pages, and links from header/index to them
07:38<@peter1138>LordAro, surely there should be a behaviour change with 7009?
07:39-!-Thedarkb-T60 [] has joined #openttd
07:39-!-Thedarkb-T60 is "realname" on #openttd #oolite
07:41<Eddi|zuHause>i think he forgot the word "unexpected"?
07:42<LordAro>er, yes
07:45<Samu>do wagons have a unitnumber?
07:45<Samu>must check
07:55<@peter1138>No they don't.
08:05-!-Borg [] has joined #openttd
08:05-!-Borg is "Unknown" on #openttd
08:10-!-Flygon [] has quit [Quit: A toaster's basically a soldering iron designed to toast bread]
08:22-!-Thedarkb-T60 [] has quit [Ping timeout: 480 seconds]
08:23-!-lugo [] has quit []
08:41<Samu>Types of rail known to the game.
08:41<Samu>Invalid RailType.
08:41<Samu>does not compute
08:45<andythenorth>it's not valid
08:46<LordAro>Samu: it's similar to the way "null" is used
08:52-!-milek7 [] has joined #openttd
08:52-!-milek7 is "m7" on #openttd
08:55-!-Thedarkb-T60 [] has joined #openttd
08:55-!-Thedarkb-T60 is "realname" on #openttd #oolite
08:57-!-synchris [~synchris@] has joined #openttd
08:57-!-synchris is "Synesios Christou" on #openttd
09:07-!-Thedarkb-T60 [] has quit [Ping timeout: 480 seconds]
09:17-!-nielsm [] has joined #openttd
09:17-!-nielsm is "Niels Martin Hansen" on #openttd
09:19-!-Thedarkb-T60 [] has joined #openttd
09:19-!-Thedarkb-T60 is "realname" on #openttd #oolite
09:19<Samu>so there are no rail types at all? can't be
09:20<Samu>there are 4 at least
09:25<Samu>Train 0, lol
09:25<Samu>so, wagons vehicles have names
09:26<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep commented on pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929)
09:26<Samu>unit number of wagons is 0
09:27<Samu>what if i have multiple wagons?
09:44<Samu>still 0
09:45<Samu>so -1 for invalid vehicle, 0 for wagons, 1 to 5000 for real vehicles
09:45<Samu>i mean -1 for invalid unitnumber
09:48<Samu>rail type 0 exists, but has no name, is that intended?
09:49<Samu>the enumerator only got RAILTYPE_INVALID, where are the others
09:57<Samu>I need another type
09:57<Samu>there's VehicleID, can I invent UnitID?
09:57<Samu>well, not invent, i mean reuse
09:57<Samu>erm, dunno how to explain
09:58<Samu>static bool IsValidVehicle_UnitNumber(UnitID vehicle_uid);
09:58<Samu>UnitID vehicle_un?
09:59<Samu>_un ? _uid? what's better?
09:59<nielsm>"uid" is commonly an abbreviation for Unique ID so it might be misunderstood
09:59<Samu>so _un?
10:00<Samu>or maybe better
10:00<dwfreed>why not vehicle_unitnumber?
10:00<Samu>kinda big name, but meh
10:00<Samu>if that is ok
10:01<andythenorth>bigger the better
10:01*andythenorth looks for some long var names
10:01<dwfreed>descriptive is better than brief
10:02<andythenorth>hmm can't find any really good ones
10:02<Samu>static bool IsValidVehicle_UnitNumber(UnitID vehicle_unitnumber);
10:02<andythenorth>visual_effect_override_by_railtype is kind of ok
10:02<Samu>oh, that's actually incomplete
10:03-!-Thedarkb-T60 [] has quit [Ping timeout: 480 seconds]
10:03<Samu>static bool IsValidVehicle_UnitNumber(UnitID vehicle_unitnumber, ScriptVehicle::VehicleType vehicle_type);
10:03<andythenorth>hehe classname PassengerVeryHighSpeedMiddleEngineConsist()
10:04<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep opened pull request #7010: Defined constants instead of their values
10:09<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh commented on pull request #7010: Defined constants instead of their values
10:16-!-HerzogDeXtEr [] has joined #openttd
10:16-!-HerzogDeXtEr is "purple" on #openttd
10:18<Samu>vehicle_unitnumber <= max<UnitID>
10:18<Samu>how do I extract the maximum value that UnitID can have?
10:19<Samu>all I know is that it's uin16
10:19<Samu>vehicle_unitnumber <= UINT16_MAX
10:19<Samu>looks ugly
10:19<Samu>max<UnitID> doesn't work, im noob
10:21-!-GroovyNoodle [] has joined #openttd
10:21-!-GroovyNoodle is "" on #openttd
10:21<Samu>and if it's uint16, it can never be -1... uh oh, that is a problem
10:23<Samu>looks like i'm gonna be forced to use int32
10:23<Samu>because of -1
10:24<Samu>rip UnitID
10:24<nielsm>or you could do it like INVALID_CARGO etc. that uses the maximum value as sentinel
10:24<nielsm>CargoID is a byte and the invalid value is 255
10:24<Samu>can i define typedef or so?
10:25<Samu>i saw a list of typedefs somewhere
10:25<Samu>typedef uint32 UnitID;
10:25<Samu>wait, not uint
10:27<Samu>all the other typedefs are uints
10:27<Samu>i am a bit lost here
10:28<Samu> this is the file
10:28<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep commented on pull request #7010: Defined constants instead of their values
10:29<Samu>where do I see that table?
10:29<Samu>in the comment
10:30<Samu>seems to be a table
10:31<nielsm>good question, it seems that file isn't included in the doxygen runs for some reason
10:37<DorpsGek_II>[OpenTTD/OpenTTD] LordAro approved pull request #7010: Defined constants instead of their values
10:37-!-Wormnest [~Wormnest@] has joined #openttd
10:37-!-Wormnest is "Wormnest" on #openttd
10:38<Samu>seems that it was documented the autorenew would screw vehicle ids
10:41-!-andythenorth is now known as Guest1710
10:41-!-andythenorth [] has joined #openttd
10:41-!-andythenorth is "andythenorth" on #openttd
10:44-!-Guest1710 [] has quit [Ping timeout: 480 seconds]
10:44-!-GroovyNoodle [] has quit [Quit: Leaving]
10:47<andythenorth>such draw
10:47<andythenorth>very sprites
10:48<Samu>typedef int32 UnitID; ///< The unitnumber of a vehicle-type of a company
10:48<Samu>good english? explanation?
10:48<Samu>the unit number of a full consist vehicle of a type of a company?
10:49<Samu>i need to explain that wagons are not considered
10:49<Samu>their ID is always 0, that would make it not unique
10:52<Samu>and the invalid value is -1, if i want to maintain compatibility with the previous apis
10:53<LordAro>Samu: get it working first, worry about wording of comments later
10:55<Samu>ok, guess i need to make it compatible
10:55<Samu>and turn it into uint16
10:56-!-frosch123 [] has joined #openttd
10:56-!-frosch123 is "frosch" on #openttd
10:57<Samu>current api treats it as a int32 and returns -1 for invalid, how to make it uint16 and return INVALID_UNITNUMBER
10:58<andythenorth>84% complete
10:58<andythenorth>also quak
11:19<LordAro>someone should merge some PRs
11:28<andythenorth>that mac os fix :P
11:28<andythenorth>which I have to merge into every PR I test currently
11:29<Samu> static const UnitID INVALID_UNITNUMBER = 0xFFFFui16; ///< Invalid UnitID.
11:33<andythenorth>0xFFFFui16 isn't something I've seen before
11:34<Samu>is it wrong?
11:35<dwfreed>I don't think i16 is a thing
11:37<Samu>ok then UINT16_MAX
11:37<Samu>or 0xFFFF
11:37<Samu>dont know which one is uglier
11:38<dwfreed>use UINT16_MAX
11:42<Samu>i'm unsure if i need to edit the bin/ai/compat_ files
11:43<nielsm>those are only needed if the API of an old feature has changed
11:43<nielsm>to translate from old calls to new calls
11:44<Samu>i am changing a return value from -1 to UINT16_MAX
11:44<andythenorth>I should make a bot
11:44<nielsm>then you'd need to add some compat wrappers
11:46<Samu>changing it sligthly
11:46<Samu>. /* static */ int32 ScriptVehicle::GetUnitNumber(VehicleID vehicle_id)
11:47<Samu>int32 to UnitID which is uint16
11:47<Samu>if (!IsValidVehicle(vehicle_id)) return -1;
11:47<Samu>-1 to UNITNUMBER_INVALID which is UINT16_MAX
11:49<Samu>how to wrap?
11:52<Samu>ah, I think I know what to do
11:56-!-Thedarkb-T60 [] has joined #openttd
11:56-!-Thedarkb-T60 is "realname" on #openttd #oolite
11:56-!-andythenorth is now known as Guest1713
11:56-!-andythenorth [] has joined #openttd
11:56-!-andythenorth is "andythenorth" on #openttd
11:59<Samu> looks wrong
11:59-!-Guest1713 [] has quit [Ping timeout: 480 seconds]
12:00<Samu>i dont know if i want to return -1
12:01<Samu>for the old apis
12:03<Samu>screw it
12:03<Samu>im goin with int32
12:03<Samu>less trouble
12:04<Samu>and -1
12:19<Samu> error C2371: 'UnitID': redefinition; different basic types
12:19<Samu>what if I call it
12:20<Samu>will it shut up?
12:30<Samu>i'm unsure what to do about GS'es
12:30<Samu>it requires them to be in a company to get the correct vehicle
12:33<Samu>there can be up to (15 companies * 4 vehicle types) vehicles with the same UnitNumber
12:33<Samu>vehicle type is enforced as a parameter
12:33<Samu>but company isn't
12:37<Samu>so... there can still be 15 vehicles with the same unitnumber when being OWNER_DEITY? or 0
12:38-!-Thedarkb-T60 [] has quit [Remote host closed the connection]
12:41<Samu>EnforcePrecondition(false, ScriptObject::GetCompany() != OWNER_DEITY);
12:41<Samu>rip GS'es
12:54-!-Wolf01 [] has joined #openttd
12:54-!-Wolf01 is "Wolf01" on #openttd
13:08<TrueBrain>andythenorth: yup, that python script will fill your _downloads folder for you
13:08<TrueBrain>tnx LordAro, for review
13:09<LordAro>np :)
13:09<TrueBrain>so if you click resolve, it eats your comment
13:09<TrueBrain>that is evil
13:10<LordAro>only hides it
13:10<andythenorth>oof which python version does it need
13:10*andythenorth looks
13:10<LordAro>because async stuff
13:10<andythenorth>5th time lucky
13:11<LordAro>i didn't think to check that :p
13:11<andythenorth>my 3.6 doesn't have aiohttp
13:11<andythenorth>so eh
13:11<andythenorth>I will fix that...another time
13:11<LordAro>well it's an external library, so it won't :p
13:11<andythenorth>I read the html, it basically looks fine
13:11<DorpsGek_II>[OpenTTD/website] TrueBrain commented on pull request #7: Add: downloads pages, and links from header/index to them
13:12<TrueBrain>LordAro: COPY .flake8 .flake8 copies the file .flake8 inside the docker under the same name
13:12<TrueBrain>what did you find weird about the statement?
13:12<TrueBrain>(your comment is a bit vague)
13:13<LordAro>yeah, thought it was something like that
13:14<LordAro>just my lack of knowledge of docker :)
13:14<LordAro>(thought maybe it was doing `cp foo foo`)
13:14<TrueBrain>ah :)
13:14<LordAro>given all the other COPYs have different destinations
13:15<TrueBrain>hmm .. can I use a variable in
13:15<TrueBrain>I can not
13:15<Wolf01> <- I'm really tempted from this shit
13:16-!-Gabda [] has joined #openttd
13:16-!-Gabda is "realname" on #openttd
13:17<LordAro>last commit 5 months ago isn't a great sign
13:20<DorpsGek_II>[OpenTTD/website] TrueBrain commented on pull request #7: Add: downloads pages, and links from header/index to them
13:20<Borg>guys... will be easy to merge maglev -> monorail?
13:20<Borg>using newgrf?
13:20<DorpsGek_II>[OpenTTD/website] TrueBrain commented on pull request #7: Add: downloads pages, and links from header/index to them
13:20<TrueBrain>annoying, I cannot bundle my comments :(
13:21<nielsm>Borg that has already been done?
13:21<Borg>nielsm: huh? where?
13:22<Borg>nvm! if its done. great
13:22<DorpsGek_II>[OpenTTD/website] TrueBrain updated pull request #7: Add: downloads pages, and links from header/index to them
13:22<Borg>I will read how to do it.. and I will do it myself :)
13:23<TrueBrain>andythenorth: btw, I know how I want to solve downloads in the end-state; it won't stay in 'website' (but we just generate index.html files on the CDN which show a similar page). But that is future work :D
13:24<TrueBrain>*focus TrueBrain, FOCUS*
13:24<andythenorth>ok that's cool
13:25<TrueBrain>so, nginx redirects and server-listing left
13:26<TrueBrain>lets see if that can be done in this weekend or something
13:26<TrueBrain>LordAro: bit difficult to see on gtihub, but I tihnk I fixed all the things you mentioned :) Tnx again!
13:28-!-Gja [] has joined #openttd
13:28-!-Gja is "Martin" on #ceph #bcache #openttd
13:29<nielsm>hmm I swear I've seen a newgrf that just unifies monorail/maglev but maybe I'm confusing it with a ttdpatch option that does this?
13:30<DorpsGek_II>[OpenTTD/website] LordAro approved pull request #7: Add: downloads pages, and links from header/index to them
13:30<LordAro>nielsm: pretty sure there's a grf that does something like that
13:31<LordAro>i think it just makes the trains compatible with both track types
13:31<nielsm>yes, or moves them to use the other type or somesuch
13:31<LordAro>or, replaces them with trains that are compatible
13:31<Samu>isn't EnforcePreCondition supposed to crash the script? I'm confused
13:32<DorpsGek_II>[OpenTTD/website] TrueBrain merged pull request #7: Add: downloads pages, and links from header/index to them
13:33<Borg>nielsm: yeah.. I heard that is such newgrf.. cant find it for now
13:33<LordAro>TrueBrain: excite
13:34<nielsm>LordAro that's not quite the same :)
13:34<TrueBrain>andythenorth: we also need a 404 and 500 page I guess; just to be fancy :)
13:34<LordAro>nielsm: pretty sure that's the one i was thinking of, anyway :p
13:35<DorpsGek_II>[OpenTTD/website] TrueBrain opened issue #8: No 404/500 html pages
13:37<DorpsGek_II>[OpenTTD/website] TrueBrain opened issue #9: Redirect old URLs to new URLs
13:37<TrueBrain> <- w00p!
13:37<LordAro>it even downloads stuff!
13:38<andythenorth>TrueBrain: I'll do those in a bit
13:38<DorpsGek_II>[OpenTTD/website] TrueBrain opened issue #10: Auto-detect most likely download
13:38<Borg>nielsm: hmm seems u cannot merge it.. at least I dont think there is easy way to do it
13:38<TrueBrain>andythenorth: no rush; I decided to make bug-tickets for all the missing stuff, so anyone can help (hint hint) :D
13:39<nielsm>Borg no, the approach should be to change the (default) trains so they only run on one of the railtypes
13:41<DorpsGek_II>[OpenTTD/website] TrueBrain opened issue #11: Make the copyright in the bottom automatically bump years
13:43<DorpsGek_II>[OpenTTD/website] LordAro commented on issue #11: Make the copyright in the bottom automatically bump years
13:43<LordAro>#10 seems very doable with some basic JS
13:44*andythenorth likes the idea of more contributors
13:44<andythenorth>maybe someone can kill the remaining 2001-style css :P
13:44<LordAro>i fear i did not have as much time as i was expecting over christmas, so did not have any significant time for ottd :(
13:45<DorpsGek_II>[OpenTTD/website] TrueBrain opened pull request #12: Fix: don't only print DATE after VERSION, but also set the BuildNumber as such
13:45<TrueBrain>nasty bug :D
13:45*LordAro is currently on train heading away from parents
13:45<TrueBrain>LordAro: nobody blames you; we are just a bit disapointed, that is all :P
13:45<LordAro>TrueBrain: what did that cause?
13:45<LordAro>TrueBrain: :p
13:46<TrueBrain>LordAro: docker image names are wrong
13:46<Gabda>Hi everyone!
13:46<TrueBrain>the tag is only the git-tag
13:46<TrueBrain>and I wanted it postfixed with the date :)
13:46<DorpsGek_II>[OpenTTD/website] TrueBrain commented on issue #11: Make the copyright in the bottom automatically bump years
13:47<TrueBrain>LordAro: #10 is indeed doable, especially as we did it server-side already (and there you have less data)
13:47<TrueBrain>we just have to pick a good javascript library which does this :)
13:47<TrueBrain>(there are awesome small ones that do this for you)
13:47<LordAro>pretty sure no external js is required
13:47<LordAro>just a case of reading the user agent
13:47<andythenorth>just install all of react, grunt, gulp, node
13:47<andythenorth>it'll be fine
13:47<TrueBrain>you want to use an existing library, as you dont want to know what you need to do to get it correct :P
13:47*LordAro twitches
13:48<TrueBrain>(let others do the hard work :P)
13:48<LordAro> easy :p
13:49<TrueBrain>I really would like to avoid writing "our own", where others did already figure it out :P
13:50<TrueBrain> <- I do not want to support shit like this :P
13:50-!-gelignite [] has joined #openttd
13:50-!-gelignite is "gelignite" on #openttd
13:50<DorpsGek_II>[OpenTTD/website] TrueBrain merged pull request #12: Fix: don't only print DATE after VERSION, but also set the BuildNumber as such
13:51<LordAro>TrueBrain: pretty sure that's just browser detection rather than os detection :p
13:51<LordAro>but sure
13:52<TrueBrain>I know that we use to do the simply checks
13:52<TrueBrain>and that we were often wrong
13:52<TrueBrain>so we used a python lib to do it for us
13:52<TrueBrain>never had an issue since :D
13:52<TrueBrain>that is my only scare here
13:54<TrueBrain>is there a limit on tag-length? :P
13:55<TrueBrain>possibly we need to put that tag in the HTML, so we can see what is served :)
13:55<TrueBrain>expectation vs reality :P
13:56<TrueBrain> <- only 50MiB :D
13:57<TrueBrain>that is a bit weird ... added a shitton of downloads, and it didnt icnrease in size
13:57<TrueBrain>compression much? :P
14:00<Samu>I've been thinking through this and wonder if I need more functions other than what i've done already
14:00<DorpsGek_II>[OpenTTD/OpenTTD] Gabda87 commented on issue #6887: Add layer showing boundaries for local authorities
14:00<Samu>Vehicle lists returning the unitnumber and a function that redirects unitnumber to the current vehicle index
14:00<LordAro>TrueBrain: nice, the same size as an electron app :p
14:01<Samu>i can build my own valuators
14:01<Samu>dont need the api to have them
14:03<DorpsGek_II>[OpenTTD/OpenTTD] LordAro commented on issue #6887: Add layer showing boundaries for local authorities
14:06<Samu>i'm confused
14:16<andythenorth>TrueBrain: just keep using the python lib, via XHR :P
14:16<Borg>is acceleration model of railtype is actually used?
14:16<Borg>because engine have traction type..
14:17<andythenorth>borg AIUI it's used
14:17<LordAro>TrueBrain: it occurs to me that there's going to have to be a way to update the website every time the downloads list changes, without any actual change to the website content. i assume you've accounted for that?
14:20<Borg>andythenorth: AIUI??
14:20<andythenorth>as I understand it, sorry
14:20<Borg>As I understand It? ;)
14:20<Borg>got an idea how to merge maglev and monorail :)
14:21-!-Gabda [] has quit [Remote host closed the connection]
14:23<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6887: Add layer showing boundaries for local authorities
14:24<Borg>btw, what ID should I use for railtype ID when Im changing existing one? this is noet clearnly documented
14:25-!-Tirili [] has joined #openttd
14:25-!-Tirili is "realname" on #openttd #holarse-gaming
14:28<andythenorth>dunno, railtypes are a mystery :)
14:36<Borg>okey, lets use 00 and see what happens
14:36<@peter1138>Pretty they are GRF-local only, it's the labels that matter.
14:38<Borg>seems so
14:38<Borg>used 00 and its all right
14:39<Borg>YAY... merging maglev -> monorail was easy
14:39<Borg>redefining 4 trains
14:43<Samu>wow, i've been an idiot all this time
14:44<Samu>the functions I am making for the API could be made on the AI
14:44<Samu>perhaps lists as well
14:45<Samu>it just that it takes tons of turns to do the same job
14:56-!-Gja [] has quit []
15:01-!-Gabda [] has joined #openttd
15:01-!-Gabda is "OFTC WebIRC Client" on #openttd
15:02-!-glx [] has joined #openttd
15:02-!-mode/#openttd [+v glx] by ChanServ
15:02-!-glx is "Loïc GUILLOUX" on @#openttd.noai #openttd.notice +#openttd
15:08<Gabda>andythenorth: what are function of patch packs here? they are optional to add to their own copy, ot these pathes will be included after a while to the game?
15:09-!-Gja [] has joined #openttd
15:09-!-Gja is "Martin" on #ceph #bcache #openttd
15:11<andythenorth>Gabda: patch packs are just personal projects by the author
15:11<andythenorth>they have no relation to official release
15:11<andythenorth>but they are encouraged
15:12<nielsm>okay now, why is it not using my graphics...
15:13<Gabda>and what happens when a patch, like the zoning patch you mentioned solves two issues (requests)?
15:13<Borg>nielsm: I made it :D
15:14<andythenorth>nielsm: I'm looking
15:14<Borg>nielsm: not merged technically.. but moved Maglev engines to monorail.. and kept monorail engines too.. now its mixed.. monorail/maglev
15:15<Samu> tragic work just to redirect to the current vehicle_id, it's probably slow
15:15<Samu>but at least I didn't need to change the API
15:17<nielsm>andythenorth: I can confirm my graphics is getting included at least, I can browse to them in the sprite aligner
15:17<andythenorth>oof FIRS code :P
15:17<andythenorth>such baroque
15:18<andythenorth>what's the 'default' prop in 'graphics'?
15:18*andythenorth looks it up
15:18<nielsm>as far as I understand, the actual spriteset to use
15:18<andythenorth>hmm it's some kind of optional nml keyword I think
15:18<andythenorth>FIRS doesn't use it, but docs do
15:19<nielsm>let's try without it
15:19<nielsm>no dif
15:20<nielsm>actually, maybe the issue is in the tilelayout
15:21<DorpsGek_II>[OpenTTD/OpenTTD] Gabda87 commented on issue #6887: Add layer showing boundaries for local authorities
15:21<nielsm>because it seems like it might really be using one of the original industrytiles
15:22<DorpsGek_II>[OpenTTD/OpenTTD] andythenorth commented on issue #6887: Add layer showing boundaries for local authorities
15:23<andythenorth>can't see anything wrong with your tilelayout
15:24<andythenorth>nielsm: does it show the water even?
15:24<andythenorth>can you get the tile IDs out of debug tools?
15:24*andythenorth looks
15:24<Samu>i see some kind of light at the end of the tunnel for my AI :)
15:25<Samu>candy coal
15:25<andythenorth>nielsm: no debug tools? o_O
15:25<nielsm>running a release build atm because it's faster :)
15:25-!-Gabda [] has left #openttd []
15:26<andythenorth>newgrf dev tools could use some extension :)
15:26<andythenorth>tile ID would be helpful
15:27<andythenorth>hmm maybe var 62 will give it
15:27<andythenorth>yes it does, if given the offset 0000
15:30<nielsm>m5 = 0 for all the tiles, that's the coal mine tile
15:30<nielsm>matching graphics
15:33<nielsm>think this is the nfo generated for it:
15:33<nielsm>0A \b1 \d68 introduces the tilelayout, which looks correct (the industrytile ids are nonzero)
15:37<andythenorth>it will be something obvious we're overlooking :P
15:38<andythenorth>nielsm: try setting override
15:39<andythenorth>don't think it's relevant but eh
15:41<andythenorth>the docs say don't use override, but FIRS does, dunno why
15:44<andythenorth>nielsm: try moving the tile definition above the layout definition
15:44<andythenorth>I can't remember nfo FIRS, but iirc order of declaration was significant
15:45<andythenorth>not sure how nml handles that :P
15:45<andythenorth>if this was just a typo, you'd have a syntax errror, right?
15:45<andythenorth>and the correct grf is loaded? o_O
15:53-!-Gabda [] has joined #openttd
15:53-!-Gabda is "realname" on #openttd
15:59<TrueBrain>LordAro: that is why I added the ${DATE} to the tag, yes :)
15:59<TrueBrain>LordAro: over time, downloads will be removed from website; for now it needs to be triggered every time a new download is added
15:59<TrueBrain>its a rare event, so we should be fine :)
16:00<andythenorth>nielsm: you won :P
16:00<andythenorth>x and y switched? o_O
16:01<nielsm>nope, I overrode the oilrig tile ids and used those original ids in the tilelayout instead
16:01<TrueBrain>hmm .. self host Sentry, or use the limited cloud solution .. hmm
16:01<nielsm>but yes I switched x and y in the layout ;)
16:02<DorpsGek_II>[OpenTTD/website] glx22 commented on issue #10: Auto-detect most likely download
16:03<DorpsGek_II>[OpenTTD/website] TrueBrain commented on issue #10: Auto-detect most likely download
16:04<TrueBrain>oeh, you can apply for a free Sentry account if you are Open Source .. that might be a good idea
16:04<andythenorth>as long as you don't want too many nodes :P
16:04<andythenorth>oh no I'm thinking of Server Density
16:04<andythenorth>confused andythenorth
16:05<LordAro>TrueBrain: sentry for error collection?
16:05<TrueBrain>LordAro: yes; mostly for the Python parts
16:05<LordAro>are you expecting lots of errors? :p
16:05<TrueBrain>no; but errors will be invisible now
16:05<TrueBrain>so I want something that creates a ticket for any error that comes by
16:06<TrueBrain>I rather have a ticket about an error, than a user telling me something doesnt work :)
16:06<LordAro>now you can have both!
16:08*LordAro whispers admin port
16:09<andythenorth>so can haxors own me through openttd?
16:09<andythenorth>hey, I got one of those 'I have video of you watching adult content, send me btc' emails today
16:09<LordAro>i feel like some sort of fail2ban integrarion shouls be possible...
16:10<andythenorth>never had one before
16:10<LordAro>but as a separate script, ofc
16:10<nielsm>ugh can't override indtile 0x18 to not accept passengers, without losing the magic oilrig station behavior
16:10<andythenorth>'you will see that I have sent this from your account, proving I have your password'
16:10<LordAro>oilrigs are still very magic
16:10<andythenorth>nielsm: you can't
16:10<andythenorth>there was a simple patch to provide it
16:10<andythenorth>but it fell into the hellchasm called newgrf airports about 8 years ago
16:10<andythenorth>so it died of course
16:11<andythenorth>nothing kills good ideas like newgrf airports :P
16:11<LordAro>i thought that was ntrt?
16:11<andythenorth>nah, NRT hasn't blocked other stuff
16:11<andythenorth>'your anti-virus can't stop me, I have installed this malware via the driver'
16:12<nielsm>should have an indtile special flag for "creates dock" and "creates helipad"
16:12<andythenorth>nielsm: yes, but then THAT PREVENTS NEWGRF AIRPORTS EVER, or something silly :)
16:12<andythenorth>I have a screenshot
16:12<TrueBrain>lol @ tt-forums post andythenorth .. "aware of this problem" .. which problem?
16:12<TrueBrain>what got hacked?
16:13<TrueBrain>so many questions
16:13<TrueBrain>so few answers :P
16:13<andythenorth>so many
16:13<LordAro>someone had their password set to password, probably
16:13<TrueBrain>or did the server got hacked? which runs OpenTTD? :P
16:13<TrueBrain>right, requested access for an Open Source sentry account
16:13<TrueBrain>see what happens
16:14<+glx>maybe just company auto clean removed the password
16:14<TrueBrain>the logs allow that option, yes
16:14<TrueBrain>the logs just show someone that connects, and starts to play
16:14<TrueBrain>so .. yeah ..
16:15<TrueBrain>maybe someone should ask nicely what the fuck he is on about :P
16:15<andythenorth>not me now
16:16<andythenorth>I am all out of nice today
16:16<LordAro>TrueBrain: but you're so good at it :p
16:16<TrueBrain>I do the polite shit on GitHub, you can do it on tt-forums, okay? :)
16:17<andythenorth>I did it on Flyspray
16:17<andythenorth>in 500 tickets :P
16:17<andythenorth>my work is done
16:17<TrueBrain>so tag, LordAro is it
16:17<andythenorth>just wait for Eddi|zuHause to do it
16:17<andythenorth>Eddi|zuHause is good at it
16:17<TrueBrain>the same way an axe is good in chopping wood, I assume
16:18<andythenorth>eddi is unfailingly polite, but technically accurae
16:18<andythenorth>accurate *
16:18<TrueBrain>I like how and are nearly identical
16:18<TrueBrain>its sweet :D
16:19<LordAro>as it should be ^^
16:19<andythenorth>there is a screaming difference
16:19<andythenorth>the drop shadow doesn't use as many images
16:19<TrueBrain>the bottom is different too
16:19<TrueBrain>but .. that is fine
16:19<TrueBrain>LordAro is going to fix it all anyway, he promised
16:19<andythenorth>I changed it deliberatlely
16:20<TrueBrain>we should cleanup the Developers list soon
16:20<TrueBrain>if no activity for N years, remove from list
16:20<LordAro>unless ludde
16:20<TrueBrain>ludde is not on that list
16:20<TrueBrain>DV isn't even
16:20<LordAro>oh, that developers list
16:21<LordAro>i was thinking of the ingame/readme/wiki developers list
16:21<TrueBrain>ah; yeah, we should just update there who is retired :)
16:22<nielsm>I wrote a reply to that supposed vuln
16:22<LordAro>retired/mia, same diff
16:22<TrueBrain>nielsm: nice :D
16:22<TrueBrain>LordAro: yup .. we have some MIAs ...
16:23<TrueBrain>of some I still wonder what happened :P
16:23<LordAro>Yexo went to google, i think pm said?
16:23<TrueBrain>so people said, yes
16:23<TrueBrain>how about adf88?
16:23<LordAro>adf had some polish weirdness happen
16:24<LordAro>that's as detailed as i can get :p
16:24<LordAro>@seen Belugas
16:24<@DorpsGek>LordAro: Belugas was last seen in #openttd 1 year, 39 weeks, 6 days, 1 hour, 5 minutes, and 44 seconds ago: <Belugas> yeah, a birthday :) a good friend of mine!
16:24<TrueBrain>Terkhen is still idling here .. but I guess it is safe to remove him from the list :)
16:24<TrueBrain>@seen Zuu
16:24<@DorpsGek>TrueBrain: Zuu was last seen in #openttd 1 week, 1 day, 20 hours, 13 minutes, and 51 seconds ago: <Zuu> So any data that is slow to determine for saving has to be pre-cached already before Save() is called. Load is easier, just save the data to this._save and handle it in Start() and you are good.
16:24<LordAro>zuu's inactive at most
16:25<LordAro>@seen Terkhen
16:25<@DorpsGek>LordAro: Terkhen was last seen in #openttd 2 years, 47 weeks, 5 days, 2 hours, 48 minutes, and 7 seconds ago: <Terkhen> Hello
16:25<TrueBrain>Rubidium isnt even on IRC anymore? :o
16:25<TrueBrain>owh, he is, just not here :P
16:25<TrueBrain>cannot blame him :D
16:25<LordAro>when did that happen?
16:25-!-synchris [~synchris@] has quit [Quit: yeeha!]
16:25<LordAro>@seen Rubidium
16:25<@DorpsGek>LordAro: Rubidium was last seen in #openttd 22 weeks, 6 days, 12 hours, 22 minutes, and 10 seconds ago: <Rubidium> peter1138: but then the 4-5 day shipping holds, right? Friday, Saturday, Sunday and finally arriving on Monday; I count 4 days of shipping ;)
16:26<LordAro>6 months ago, fine
16:26<TrueBrain>I think mostly that list should be people who can be contacted
16:26<TrueBrain>I dont care if they have commit-rights etc
16:27<TrueBrain>but at least that list should somewhat give names which you can poke for certain stuff
16:27<andythenorth>yeah yexo is apparently a google SRE in Munich
16:27<andythenorth>time for a clean up then TB
16:28<TrueBrain>yeah .. but first I am going to work towards getting it production-ready :P
16:29<andythenorth>90% Horse
16:29<andythenorth>that's 'done'?
16:29<andythenorth>probly not then
16:30<andythenorth>alpha 2 maybe :P
16:30-!-sla_ro|master [] has quit []
16:30<DorpsGek_II>[OpenTTD/website] TrueBrain opened issue #13: Server-listing cannot be on
16:32-!-gelignite [] has quit [Quit: Good fight, good night!]
16:41-!-Tirili [] has quit [Ping timeout: 480 seconds]
16:44<nielsm>andythenorth: painting or deleting? :)
16:44<andythenorth>urgh, I was about to ship an alpha using a var that doesn't exist
16:45<TrueBrain>bad andythenorth
16:45<TrueBrain>bad! :P
16:45-!-Borg [] has quit [Quit: leaving]
16:45<andythenorth>kittens would have died
16:47<TrueBrain>guess it is a good thing we only care about frogs
16:47<andythenorth>oh I was better than I thought
16:47<andythenorth>I'd already fixed that :P
16:49<TrueBrain>we always knew you were awesome
16:49<TrueBrain>too bad it took this long to shine; but better late than never!
16:49<TrueBrain><3 :D
16:50<andythenorth>been hiding my ligth
16:50<andythenorth>for years
16:50<andythenorth>under a bushel
16:51-!-Tirili [] has joined #openttd
16:51-!-Tirili is "realname" on #holarse-gaming #openttd
16:51*andythenorth tags it
16:54-!-Gabda [] has quit [Quit: Leaving]
16:56<LordAro>no going back now
16:57<TrueBrain>WE ARE DOOMED!
16:57<TrueBrain>TO THE SHELTERS
16:58<andythenorth>oops, I broke Jenkins
16:58<andythenorth>jenkins doesn't have 'time'
17:04<TrueBrain>nobody has time
17:04<TrueBrain>we all have to make due
17:05-!-Wacko1976 [] has joined #openttd
17:05-!-Wacko1976 is "The Chat Cool People Use" on #openttd #/r/openttd
17:08-!-Tirili [] has quit [Quit: Leaving]
17:09-!-Tirili [] has joined #openttd
17:09-!-Tirili is "realname" on #openttd #holarse-gaming
17:12<nielsm>okay I think there is a bug with newgrf handling of industry tiles
17:12<nielsm>that don't have an override property set
17:13-!-Tirili [] has quit []
17:14<nielsm>here it's checked whether the tile id is overridden to something else:
17:14<nielsm>INVALID_INDUSTRYTILE is 0x1FF
17:15<nielsm>but the way the IndustryTileOverrideManager is implemented in newgrf_commons.(h|cpp) the override value is a byte, so the default of "not overridden" is not possible
17:15<nielsm>and isn't used either
17:16<nielsm>as far as I can tell this means it's impossible to actually define a new and usable industrytile, you have to re-purpose an existing tile
17:17<nielsm>okay the global instance _industile_mngr does get initialized with an invalidID=INVALID_INDUSTRYTILE
17:17<nielsm>but I'm not sure I follow the conditions for the invalidID to actually get used
17:18<andythenorth>all of the FIRS tiles use substitute
17:18<andythenorth>but FIRS industry uses both substitute and over-ride, which I'm not sure why, might just be error
17:18<andythenorth>override /s
17:19<nielsm>hmm FIRS tiles only substitute, never override?
17:24<andythenorth>code says so
17:24<andythenorth>I don't know what nml is doing
17:24*andythenorth looks
17:27<andythenorth>casual check suggests nml is doing prop 0x08 and 0x09 correctly
17:27<nielsm>it is
17:27<nielsm>I've checked the generated NFO and it looks fine
17:42<nielsm>well that was a wild chase
17:43<nielsm>when the reason was indeed definition order in nml
17:43<nielsm>the industry defined before the tiles
17:43<nielsm>so when the tilelayout is read from the grf it refers to tiles that don't exist yet
17:43<nielsm>moving the industry def below the tile defs makes it work
17:44<andythenorth>feel like I could have saved you some time there, sorry :P
17:45<nielsm>on the positive side, I learned some more about how grf loading happens :D
17:46<DorpsGek_II>[OpenTTD/OpenTTD] slhurst opened issue #7011: Towns don't grow if first tile of station is outside authority area
17:47<nielsm>and that also got me a bunch more indtiles fixed :)
17:48*andythenorth bed
17:48-!-andythenorth [] has left #openttd []
17:51-!-NoMorePacers_ [] has joined #openttd
17:51-!-NoMorePacers_ is "OFTC WebIRC Client" on #openttd
17:53<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh commented on issue #7011: Towns don't grow if first tile of station is outside authority area
17:55<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh merged pull request #7010: Defined constants instead of their values
18:10<DorpsGek_II>[OpenTTD/OpenTTD] slhurst commented on issue #7011: Towns don't grow if first tile of station is outside authority area
18:19<DorpsGek_II>[OpenTTD/OpenTTD] Eddi-z commented on issue #7011: Towns don't grow if first tile of station is outside authority area
18:37-!-nielsm [] has quit [Ping timeout: 480 seconds]
18:39<Samu>found a bug here
18:39-!-NoMorePacers_ [] has quit [Remote host closed the connection]
18:39<Samu>it is looking for waypoints, but there is already a way to get waypoints
18:41<Samu>actually line 36
18:43<Samu>oh no, sorry, not a bug, I'm confused
18:57-!-Wacko1976_ [] has joined #openttd
18:57-!-Wacko1976_ is "The Chat Cool People Use" on #openttd #/r/openttd
19:03-!-Wacko1976 [] has quit [Ping timeout: 480 seconds]
19:11-!-chomwitt [] has quit [Ping timeout: 480 seconds]
19:41-!-Wolf01 [] has quit [Quit: Once again the world is quick to bury me.]
20:19-!-Flygon [] has joined #openttd
20:19-!-Flygon is "Flygon" on #openttd
20:59-!-frosch123 [] has quit [Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn]
21:10-!-Oroburos [] has joined #openttd
21:10-!-Oroburos is "realname" on #biz #redditprivacy #openttd
21:18-!-Oroburos [] has quit [Quit: Leaving]
21:21-!-Thedarkb-X40 [] has joined #openttd
21:21-!-Thedarkb-X40 is "realname" on #openttd #/r/openttd #oolite
21:25-!-Laedek [~quassel@] has joined #openttd
21:25-!-Laedek is "Laedek" on #openttd
21:27-!-Wormnest [~Wormnest@] has quit [Quit: Leaving]
21:47-!-Gja [] has quit [Remote host closed the connection]
21:49-!-smoke_fumus [~smoke_fum@] has quit [Quit: KVIrc 4.2.0 Equilibrium]
21:49-!-Progman [] has quit [Remote host closed the connection]
22:20-!-glx [] has quit []
22:56-!-Samu [] has quit []
23:12-!-Thedarkb-X40 [] has quit [Ping timeout: 480 seconds]
23:18-!-Thedarkb-X40 [] has joined #openttd
23:18-!-Thedarkb-X40 is "realname" on #openttd #/r/openttd #oolite
23:26-!-Afdal [] has joined #openttd
23:26-!-Afdal is "realname" on #openttd #nuts #hazzard
23:26-!-Afdal [] has left #openttd [Leaving]
---Logclosed Sat Jan 05 00:00:07 2019