Back to Home / #openttd / 2019 / 02 / Prev Day | Next Day
#openttd IRC Logs for 2019-02-14

---Logopened Thu Feb 14 00:00:03 2019
01:08-!-Smedles [] has quit [Ping timeout: 480 seconds]
01:10-!-Smedles [] has joined #openttd
01:10-!-Smedles is "Paul Smedley" on #openttd
01:34<DorpsGek_II>[OpenTTD/OpenTTD] PeterN opened pull request #7227: Replace Window::scrolling_scrollbar with Window::active_widget
01:37<DorpsGek_II>[OpenTTD/OpenTTD] PeterN commented on pull request #7209: Fix: volume slider behavior in music gui
02:05-!-andythenorth [] has joined #openttd
02:05-!-andythenorth is "andythenorth" on #openttd
02:10-!-Pokka is now known as Pikka
02:42<@peter1138>Is it?
02:42-!-Eddi|zuHause2 [] has joined #openttd
02:42-!-Eddi|zuHause2 is "Johannes E. Krause" on #openttd
02:47-!-Eddi|zuHause [] has quit [Ping timeout: 480 seconds]
02:51<@peter1138> < I might need help eating this...
02:58<andythenorth>is it some kind of special day?
03:12<@peter1138>Not sure.
03:27-!-andythenorth [] has quit [Quit: andythenorth]
03:57-!-andythenorth [] has joined #openttd
03:57-!-andythenorth is "andythenorth" on #openttd
04:00<LordAro>peter1138: doesn't matter; got cake?
04:12-!-samu [] has joined #openttd
04:12-!-samu is "OFTC WebIRC Client" on #openttd
04:18<@peter1138>I have got cake :D
04:29<debdog>certainly better than cmake
04:35<samu>oh, npf crashed
04:36<samu>I failed to trigger that crash
04:43<samu>got it
04:43<samu>requires 90 degrees forbidden
04:44<samu>if it happens for ships, i suppose it should also happen for trains, let me test
04:50<samu>hmm nop, doesnt happen for trains
05:02<samu>interesting though
05:03<samu>NPF is dumber
05:03<samu>doesn't consider reversing for trains
05:22-!-andythenorth [] has left #openttd []
05:31-!-Eddi|zuHause2 is now known as Eddi|zuHause
05:32<Eddi|zuHause>aren't these the kinf of things that hang on the wall for years and then nobody dares to touch it because they forgot how long it was?
05:41<samu>it was touched recently
05:51<@peter1138>Well it looks easy to partially revert that.
05:55-!-andythenorth [] has joined #openttd
05:55-!-andythenorth is "andythenorth" on #openttd
05:55<andythenorth>Pikka: HSTs, mail or no mail?
05:56<@peter1138>I'd go for no mail.
05:59<andythenorth>design innit
05:59<andythenorth>trains + sandwiches
06:01<andythenorth>no mail is simplest
06:01<andythenorth>kind of wastes some tile space though :P
06:02-!-andythenorth [] has left #openttd []
06:12<DorpsGek_II>[OpenTTD/OpenTTD] PeterN commented on issue #7226: NPF: Ship: Assertion failure when ship encounters shore
06:22-!-Pikka [] has quit [Quit: Leaving]
06:56<samu>no need to revert too much
06:57<samu>seems to be a case of 90 degrees
06:58<samu>need to see how this was before the change
06:58<samu>I think the assert doesn't need to be there
07:00<samu>result.best_trackdir = INVALID_TRACKDIR;
07:00<samu>there is indeed no track, that a reverse should be happening
07:01<@peter1138>That's why I said partially revert. Literally junk that hunk.
07:01<samu>just for the ship
07:02<@peter1138>I can do a PR when I have my lunchbreak.
07:02<samu>for train it doesn't happen, because PBS reserved stuff
07:02<samu>not really sure why
07:02<samu>but it's pbs related
07:03<@peter1138>Yeah, but white chocolate lion bars are incredibly sweet.
07:03<samu>for road vehicle, the code makes a reverse track special bit
07:05<samu>if (type != TRANSPORT_ROAD || HasBit(subtype, ROADTYPE_TRAM)) return;
07:05<samu>but if it is a tram
07:05<samu>it apparently can asser
07:06<samu>how do i test trams... need newgrfs
07:07<@peter1138>Yeah, get a tram set.
07:14<samu>hmm nop, doesn't assert, or i dont know how to
07:18-!-Flygon [] has quit [Read error: Connection reset by peer]
07:21<samu>well, it's just the ship
07:21<samu>maybe don't ask the pathfinder for a track if 90 degrees
07:21<samu>if none ahead
07:22<samu>reverse before asking pathfinder
07:22<samu>and keep the assert
07:22<samu>what u think?
07:22<@peter1138>Pathfinder should say no path if there's no path.
07:22<@peter1138>Not crash.
07:23<samu>but it's a single tile, the tile just next
07:28<samu>u got this at line 478 ship_cmp.cpp /* Can't continue in same direction so pick first available track. */
07:29<samu>maybe should be repeated just before line 500
07:29<samu>erm 501
07:29<samu>if (tracks == TRACK_BIT_NONE)
07:32<samu>hmm opf doesnt have 90 degrees :|
07:33<samu>it really has to ask the pathfinder because of opf
07:44<@peter1138>Doesn't have 90 degrees?
07:53-!-samu [] has quit [Remote host closed the connection]
08:09-!-sla_ro|master [] has joined #openttd
08:09-!-sla_ro|master is "slamaster" on #sla #openttd
08:25-!-Extrems [] has quit [Ping timeout: 480 seconds]
08:26-!-Extrems [] has joined #openttd
08:26-!-Extrems is "" on #openttd
08:26-!-Markk [] has joined #openttd
08:26-!-Markk is "Bjum Bjumfors" on #openttd #bitlbee
08:27<DorpsGek_II>[OpenTTD/OpenTTD] glx22 commented on pull request #7227: Replace Window::scrolling_scrollbar with Window::active_widget
08:31<DorpsGek_II>[OpenTTD/OpenTTD] PeterN commented on pull request #7227: Replace Window::scrolling_scrollbar with Window::active_widget
08:33-!-snail_UES_ [] has joined #openttd
08:33-!-snail_UES_ is "Jacopo Coletto" on #openttd
08:35-!-andythenorth [~andytheno@] has joined #openttd
08:35-!-andythenorth is "andythenorth" on #openttd
08:39<andythenorth>maybe I go on a train ride
08:40<andythenorth>the power->weight on those is insane
08:43<andythenorth>4500hp / 260t
08:44<andythenorth>I should go to exeter
08:46<Eddi|zuHause>how does that compare to
08:46<Eddi|zuHause>i remember someone mentioning instances where one of those engines went with a single passenger car
08:47<andythenorth>is that a Ludmilla?
08:50<DorpsGek_II>[OpenTTD/OpenTTD] MrMamen opened pull request #7228: Update changelog.txt
08:51<Eddi|zuHause>the only way you could make that worse is having two of these, because you lack a steering car for push-pull-service
08:53-!-Gustavo6046 [~Gustavo60@2804:14d:4cd8:81a4:b572:f565:9ac3:eb56] has joined #openttd
08:53-!-Gustavo6046 is "Non dico nomen." on #openttd #oftc #moocows
08:56-!-snail_UES_ [] has quit [Quit: snail_UES_]
09:04<DorpsGek_II>[OpenTTD/OpenTTD] PeterN opened pull request #7229: Fix #7114: Partial revert of 7d06fec799 for ship pathfinding.
09:05<@peter1138>Oh, samu left.
09:12-!-samu [] has joined #openttd
09:12-!-samu is "OFTC WebIRC Client" on #openttd
09:18<samu>when will this be
09:20<@peter1138>When 1.9.0 is released.
09:22<@peter1138>You can build your own docs though, of course.
09:23<andythenorth>maybe I should add some more trains
09:24<andythenorth>then it will be 85% again
09:25<Eddi|zuHause>andythenorth: think of it this way: "everybody has to die" is not true, if you count up the number of people who ever have died against the ones that have ever been born, you get a number something along the lines of 95%. if that ever reaches 100% it means mankind is extinct
09:26<andythenorth>it's the exact analogy
09:26<Eddi|zuHause>if your project ever reaches 100% completion it is dead
09:26<andythenorth>OTOH, I do have to release 2.0.0 sometime :P
09:26<andythenorth>2.0.0 doesn't mean dead
09:27<@peter1138>If only you had engine variations...
09:31<andythenorth>I didn't want to mention :P
09:31<andythenorth>so how are we doing that again?
09:32<Eddi|zuHause>so, i haven't solved any of my performance problems, but i haven't had any system freezes when i manually echo high/low to /sys/class/drm/card0/device/power_dpm_force_performance_level instead of keeping it at auto
09:32<@peter1138>Have you considered it might be faulty hardware?
09:32-!-kapamat [] has joined #openttd
09:32-!-kapamat is "kapamat" on #openttd
09:33-!-kapamat [] has quit []
09:33<Eddi|zuHause>yes, but the alternative hardware is worse/older/less supported/not dx11
09:39<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep commented on issue #7226: NPF: Ship: Assertion failure when ship encounters shore
09:51-!-nielsm [] has joined #openttd
09:51-!-nielsm is "Niels Martin Hansen" on #openttd
10:00<samu>add 90 degrees for opf?
10:04<DorpsGek_II>[OpenTTD/OpenTTD] nikolas closed pull request #7209: Fix: volume slider behavior in music gui
10:05<DorpsGek_II>[OpenTTD/OpenTTD] nikolas commented on pull request #7209: Fix: volume slider behavior in music gui
10:10<samu>Should I use autoreplace or should I not
10:10<samu>for my AI
10:13<samu>I'm 50%/50%
10:15<andythenorth>is opf deleeted yet?
10:15<andythenorth>or even deleted?
10:19<@peter1138>Sadly not.
10:20<@peter1138>samu, "90 degrees for opf" ... what does that mean?
10:20<@peter1138>With OPF, ships do turn 90 degrees.
10:21<samu>forbid 90 degrees
10:21<samu>i had a patch request about it, but got rejected
10:23<DorpsGek_II>[OpenTTD/OpenTTD] PeterN updated pull request #7227: Replace Window::scrolling_scrollbar with Window::active_widget
10:24<@peter1138>Yeah we're more likely to remove that option, at least for ships.
10:24<@peter1138>And more likely to remove OPF.
10:25<LordAro>^ pls
10:26<andythenorth>pls, it's healthy to delete stuff
10:26<andythenorth>ok maybe not as much as I want to delete :P
10:26<andythenorth>but some
10:30<andythenorth>samu: maybe you could do a PR removing OPF? o_O
10:30<andythenorth>you've probably seen a lot of that code?
10:30<andythenorth>and you could find all the regressions
10:34-!-Wormnest [~Wormnest@] has joined #openttd
10:34-!-Wormnest is "Wormnest" on #openttd
10:36<andythenorth>dunno if anyone would approve it though :x
10:40-!-samu [] has quit [Remote host closed the connection]
10:43<DorpsGek_II>[OpenTTD/OpenTTD] nikolas commented on pull request #7228: Update changelog.txt
10:48-!-Samu [] has joined #openttd
10:48-!-Samu is "realname" on #openttd
10:53<Samu>so i installed HexChat
10:53<Samu>text is blurry
10:53<Samu>how to fix?
10:55<Samu>gonna try dpi aware stuff, brb
10:55-!-Samu [] has left #openttd [Leaving]
10:59-!-Samu [] has joined #openttd
10:59-!-Samu is "realname" on #openttd
10:59<Samu>it was high dpi aware stuff
11:12<DorpsGek_II>[OpenTTD/OpenTTD] glx22 commented on pull request #7228: Update changelog.txt
11:25-!-Progman [] has joined #openttd
11:25-!-Progman is "Peter Henschel" on #openttd
11:28-!-Gja [] has joined #openttd
11:28-!-Gja is "Martin" on #ceph #bcache #openttd
11:38-!-HerzogDeXtEr [] has joined #openttd
11:38-!-HerzogDeXtEr is "purple" on #openttd
11:42-!-synchris [~synchris@] has joined #openttd
11:42-!-synchris is "Synesios Christou" on #openttd
11:59<DorpsGek_II>[OpenTTD/OpenTTD] MrMamen updated pull request #7228: Update changelog.txt
12:00<DorpsGek_II>[OpenTTD/OpenTTD] MrMamen commented on pull request #7228: Update changelog.txt
12:01-!-acklen_ [] has quit [Quit: leaving]
12:02-!-APTX [~APTX@2001:470:24:137f:2ff:ffff:fe00:1] has quit [Quit: No Ping reply in 180 seconds.]
12:03-!-APTX [~APTX@2001:470:24:137f:2ff:ffff:fe00:1] has joined #openttd
12:03-!-APTX is "APTX" on #openttd #kernelnewbies
12:33<Samu>arf, my AI doesn't work well with groups
12:33<Samu>wasn't built with it in mind :|
12:35<andythenorth>so eh
12:35<andythenorth>what does Article 13 mean for Bananas?
12:37<nielsm>well I suppose technically it'd mean everything had to be manually reviewed before becoming available
12:38-!-acklen [] has joined #openttd
12:38-!-acklen is "Matt" on #openttd
12:38<andythenorth>but how do we know what infringes copyright?
12:39<andythenorth>does this mean Bananas is over?
12:40<nielsm>well isn't part of the uploader agreement that you give bananas a non-exclusive, non-retractable license to distribute the uploaded work forever?
12:41<nielsm>of course you can only grant that if you actually have the rights to grant those rights
12:42<andythenorth>there's no case law obviously
12:42<andythenorth>and limited legal opinons, it's too new
12:43<andythenorth>but there seems to be a requirement to deploy content recognition technology on uploads to prevent infringement
12:43<nielsm>add a feature to bananas to allow people to upload material they do _not_ want available on bananas
12:44<andythenorth>interesting idea
12:44<andythenorth>but we'd need them to delegate us the rights to hold that copyrighted material
12:44<andythenorth>I can think of at least one contributor who won't do that
12:45<nielsm>well, if they won't let the service provider do automatic screening against their material they don't have a good case if someone else uploads their material and it can't be recognized, imo
12:46<nielsm>specifically for GRFs could allow registering just GRFid's of course
12:46<@peter1138>Personally I'd just ignore it all.
12:46<nielsm>as long as nobody sues there's no problem
12:47<@peter1138>It's clearly an ill-thought out law that's designed to only apply to the likes of Facebook, Instagram and Twitter...
12:47<@peter1138>I better go and get some dog food.
12:49<andythenorth>just move Bananas to the UK
12:49<andythenorth>article 13 probably won't apply eh
12:49<andythenorth>we opted out of this stuff :P
12:50<nielsm>the article 11 link tax is the most ridiculous though
12:50<nielsm>why must I pay you to refer people to you?
12:50-!-andythenorth [~andytheno@] has quit [Quit: andythenorth]
12:50<nielsm>did I ever pay for the right to suggest someone go to the store and buy a newspaper?
12:53-!-frosch123 [] has joined #openttd
12:53-!-frosch123 is "frosch" on #openttd
12:56-!-Wormnest [~Wormnest@] has quit [Ping timeout: 480 seconds]
13:11-!-Wolf01 [] has joined #openttd
13:11-!-Wolf01 is "Wolf01" on #openttd
13:14-!-glx [] has joined #openttd
13:14-!-mode/#openttd [+v glx] by ChanServ
13:14-!-glx is "Loïc GUILLOUX" on +#openttd
13:18<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep opened pull request #7230: Fix #7226: No ship track due to "forbid 90 deg turns"-> Do not call pathfinders.
13:21<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep commented on pull request #7230: Fix #7226: No ship track due to "forbid 90 deg turns"-> Do not call pathfinders.
13:22-!-andythenorth [] has joined #openttd
13:22-!-andythenorth is "andythenorth" on #openttd
13:24<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh approved pull request #7228: Update changelog.txt
13:25<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh merged pull request #7228: Update changelog.txt
13:29<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh updated pull request #7178: Add AI and GS to framerate window
13:35<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh approved pull request #7217: Fix #6599: Disable build and rename button in build vehicle window when no vehicle is selected.
13:35<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh merged pull request #7217: Fix #6599: Disable build and rename button in build vehicle window when no vehicle is selected.
13:35<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh closed issue #6599: Can still click on buy button in vehicle selection window even if no vehicle is selected
13:39<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh requested changes for pull request #7169: Fix: Spectator color
13:43<Samu>90 degrees for opf soon!
13:45<LordAro>Samu: it's like you totally ignored what everyone said
13:45<Eddi|zuHause>that sounds like my experience
13:48<Eddi|zuHause><nielsm> the article 11 link tax is the most ridiculous though <-- the worst part about that is that they passed the exact same law in germany, and it turned out to be completely useless
13:50<Eddi|zuHause>half of the news publishers went "what? that's crazy even for our standards, google can just link our news for free"
13:50<Eddi|zuHause>and for the other half google went "what? that's crazy, so we shorten our links to not contain any content, see how many people click on that"
13:50<Eddi|zuHause>then they tried to force google to show the full details (and get paid), which didn't work
13:51<Eddi|zuHause>and after like 2 years they finally gave in and said "fine, you can also show it for free"
13:52<Eddi|zuHause>so in the end, google (which is 99% of all links) pays nothing, and smaller news aggregators can't compete with google anymore. nobody gets paid.
13:53<Eddi|zuHause>well, except for the lawyers
13:59<andythenorth>kinda wonder how it's supposed to work
14:00<andythenorth>these EU-wide laws
14:00<DorpsGek_II>[OpenTTD/OpenTTD] nielsmh approved pull request #7224: Change: Use selected group as parent when creating a new group.
14:00<andythenorth>that seem to benefit nobody
14:02<nielsm>laws that think to protect people who don't understand technology against technology, enacted by people who don't understand technology
14:04<andythenorth>that benefit technology giants
14:06<andythenorth>like GDPR
14:06<andythenorth>which means we've all opted in to data collection, through all those popups
14:10<@peter1138>Hi, I have dog food now.
14:10<@peter1138>And I have raw milk.
14:10<@peter1138>And the missus is cooking a giant dinner.
14:11<@peter1138>nielsm, is the AI/GS framerate stuff near ready?
14:11<nielsm>well, it works as-is, question is mostly about presentation I suppose
14:12<@peter1138>Scrollbar :-)
14:14<andythenorth>peter1138: are those the ingredients? :o
14:14<@peter1138>I hope not.
14:19<@peter1138>I should start removing old branches, yes.
14:23<DorpsGek_II>[OpenTTD/OpenTTD] PeterN updated pull request #6811: Feature: Add NotRoadTypes (NRT)
14:25-!-Thedarkb1-T60 [] has joined #openttd
14:25-!-Thedarkb1-T60 is "realname" on #openttd #oolite
14:26<@peter1138>^ Just a rebase, nothing new since... the other day, I guess.
14:32-!-Gja [] has quit []
14:40-!-Thedarkb1-T60 [] has quit [Ping timeout: 480 seconds]
14:44<andythenorth>bananas, multiple people can upload the same grf right?
14:45<andythenorth>I have uploaded my grfs from both coop and my account
14:45<andythenorth>planetmaker: ^
14:45<@peter1138>Does it not at least check the GrfID?
14:45-!-gelignite [] has joined #openttd
14:45-!-gelignite is "gelignite" on #openttd
14:47<DorpsGek_II>[OpenTTD/OpenTTD] PeterN opened pull request #7231: Add: Add flag and railtype sprite type to draw pre-combined ground sprites.
14:47<@peter1138>I just discovered the Draft feature... nice.
14:48<@peter1138>Ah but the list doesn't show Draft status.
14:50-!-Thedarkb-T60 [] has joined #openttd
14:50-!-Thedarkb-T60 is "realname" on #openttd #oolite
14:50<@peter1138>PR list.
14:52<andythenorth>eh I have FIRS uploaded from 2 accounts on bananas
14:53<andythenorth>but I can't upload FIRS 3 from my account, only coop
14:53<andythenorth>don't really understand that
14:54<@peter1138>Just turn it into a free-for-all.
14:54<@peter1138>Problem is, that person expects it to be curated.
14:56<andythenorth>person is not native english speaker
14:57<andythenorth>so I'm not just dismissing as a fuckwit
14:57<andythenorth>but eh
14:57<@peter1138>Well, it's not a stupid request, it's just not what Bananas is.
14:57<andythenorth>it's a confusing and inconsistent request
14:58<andythenorth>I should probably stay out of it, I don't really have any use for bananas
15:05-!-Gja [] has joined #openttd
15:05-!-Gja is "Martin" on #ceph #bcache #openttd
15:06<@peter1138>You don't?
15:08<nielsm>bananas are useful for making desserts
15:08<andythenorth>I just upload stuff
15:08<andythenorth>I downloaded some pikka grfs years ago
15:08<andythenorth>sometimes I have to test some savegame from GH or something
15:08<andythenorth>then find all the missing content
15:09<andythenorth>I don't really use grfs tbh
15:09<@peter1138>I used to always use them.
15:09<@peter1138>Now I just can't be bothered to set them up.
15:10<@peter1138>Even though it's easier than it ever was.
15:10<@peter1138>A GUI! Even for parameters! It's magic.
15:11-!-Gja [] has quit []
15:12<andythenorth>I have 10
15:12<andythenorth>I made 6 of them :P
15:22<andythenorth>so station tiles with weird catchments peter1138? o_O
15:24<@peter1138>Is it useful?
15:24<Eddi|zuHause>make catchment area work the intuitive way that everyone thinks it does?
15:24<Eddi|zuHause>also, make the game more euclidean
15:25<@peter1138>When do oil rigs appear?
15:25<Eddi|zuHause>1960? 70?
15:25<Eddi|zuHause>somewhere in that range
15:26<Eddi|zuHause>never at mapgen, though
15:26<@peter1138>Do they appear on new game during that date?
15:26<@peter1138>Well, at least FFWD is... fast :)
15:27<Eddi|zuHause>scenario editor? fund?
15:28<andythenorth>I was just thinking bigger / smaller :P
15:28<Eddi|zuHause>andythenorth: that is pretty meaningless as long as just the largest radius counts
15:29<andythenorth>dunno how it would work anyway
15:29<Eddi|zuHause>and if you want beautification tiles that don't increase area you got newobjects
15:29<andythenorth>I was thinking something like, rail tiles are radius 1
15:30<andythenorth>eye candy tiles get radius 20 or something
15:31<andythenorth>need to figure out *something* so I can make use of industry > more cargos out
15:31-!-synchris [~synchris@] has quit [Quit: yeeha!]
15:31<andythenorth>stations are quite limiting there
15:33<nielsm>random thought: would be cool if different railtypes (and roadtypes) could add their own icons to station signs
15:33<nielsm>so e.g. traditional rail and monorail could have different icons
15:34<@peter1138>That could be doable.
15:34<nielsm>and the same for NRT
15:34<andythenorth>no steam train icon? :o
15:34<andythenorth>hmm, dump truck icon for HAUL
15:35<@peter1138>Hmm, yeah, it's doable, but these are text glyphs rather than sprites.
15:35<nielsm>also, again I'm going to suggest having some kind of compressed map block storage that could be used anywhere
15:35<@peter1138>Just a little bit fiddly.
15:35<nielsm>(which could move some map data out of map arrays even)
15:36<nielsm>e.g. a compressed bitmap (either by eliding blank blocks or using RLE) of a station's catchment area
15:36<nielsm>so you do a rough check for stations possibly in catchment, then check the bitmaps for each of those stations for accurate result
15:37-!-Thedarkb-T60 [] has quit [Ping timeout: 480 seconds]
15:38<nielsm>or well, complex catchment areas with per-tile catchment could actually be calculated and cached on demand
15:38<@peter1138>I... I'm about to do that last thing anyway.
15:38<Eddi|zuHause>each station gets a hashmap of which tiles it covers
15:38<@peter1138>Stations have tons of off-map storage anyway
15:40<Eddi|zuHause>on industry production, you loop through each station and find a non-empty intersection between station area tiles and industry tiles
15:40<Eddi|zuHause>on vehicle delivery you loop through all catchment area tiles
15:40<Eddi|zuHause>or something along those lines
15:40<Eddi|zuHause>it's neither crazy memory nor crazy runtime heavy
15:41<@peter1138>Yeah, I'm... about to do that ;)
15:41-!-Thedarkb-T60 [] has joined #openttd
15:41-!-Thedarkb-T60 is "realname" on #openttd #oolite
15:41<@peter1138>Although I admit I was going to do an x,y array unless you wrote hashmap... D'oh.
15:42<nielsm>nah std::set is probably not good
15:42<Eddi|zuHause>i did 3 days worth of coding with STL containers, i'm now an expert
15:43<@peter1138>nielsm, I'll start off with whatever works, and then consider performance later.
15:43<nielsm>for caching I think an RLE bitmap is the most efficient
15:44<nielsm>in terms of cpu/memory balance
15:44<Eddi|zuHause>what are we sending faxes or something? :p
15:44<@peter1138>Forget about space. Dedicated servers don't come with 1KB RAM...
15:44<nielsm>a straight bitmap would be the fastest in straight cpu
15:44<nielsm>yeah but if you have 4000 stations with large catchment areas now you're suddenly using rather much regardless
15:44<Eddi|zuHause>i think CPU time is the more important one to optimize
15:45<nielsm>also be wary of data structures that cause memory fragmentation
15:46<@peter1138>4000 stations can't all cover the same area.
15:47-!-supermop_Home [] has quit [Ping timeout: 480 seconds]
15:50<Eddi|zuHause>i don't see memory fragmentation becoming an issue. if the station area is modified, you can easly scrap the cache and rebuild it from scratch
15:50<Eddi|zuHause>it only happens on user interaction, so can be a more expensive operation
15:52-!-HerzogDeXtEr1 [] has joined #openttd
15:52-!-HerzogDeXtEr1 is "purple" on #openttd
15:53<_dp_>hi! does anyone know why msvc here gives error C2061: syntax error: identifier 'Polyline' ?
15:53<_dp_>static bool FindPolyline(const Point &pt, const LineSnapPoint &start, Polyline *ret)
15:53<_dp_>it's defined as a struct earlier in the same file and it compiles fine with g++
15:54<nielsm>well I don't know if you suggested std::set as a joke, but it would get you a ton of tiny heap allocations (it's a balanced tree) so likely have poor cpu cache locality and cause potential trouble for the heap allocator if some of the elements are freed or moved around during building
15:54<nielsm>_dp_ file and line?
15:55<Eddi|zuHause>_dp_: is that the complete message?
15:55<Eddi|zuHause>_dp_: almost always "syntax error"-style messages mean something went wrong BEFORE that point
15:56<Eddi|zuHause>it's just at that point the compiler got confused enough to give up
15:58-!-HerzogDeXtEr [] has quit [Ping timeout: 480 seconds]
15:58<Eddi|zuHause>_dp_: could be somthing interfering from a MSVC-specific header
15:59<_dp_>full compiler output:
15:59<nielsm>you have an #include at line 968 well past the usual include block, try moving that
15:59<_dp_>Eddi|zuHause, yeah, I though of that but couldn't find anything
16:00<nielsm>and another later too
16:00<_dp_>also I compiled 1.8 version with studio before
16:00<Eddi|zuHause>_dp_: have you tried just the polyline patch individually?
16:01<nielsm>viewport.cpp(2920): warning C4551: function call missing argument list
16:01<nielsm>2920: Polyline polyline;
16:01<nielsm>it absolutely thinks Polyline is the name of a function, not your struct
16:01<ST2>_dp_: I've also had issues with msvc project files, but sidework made me postpone this :|
16:02<_dp_>Eddi|zuHause, no but it's a bit modified patch already, don't have it separate
16:03<nielsm>likely that one
16:03<_dp_>also experimenting with azure so it's not quite easy to try random guesses :(
16:03<_dp_>since it don't have studio myself and can only run pipelines
16:04<_dp_>nielsm, hm, interesting
16:04<_dp_>nielsm, I'll try renaming it than, thanks!
16:04<Eddi|zuHause>definitely move those stray #includes
16:04<Eddi|zuHause>so your struct definition will happen later
16:05<Eddi|zuHause>(and people wonder why we didn't include some patches in master)
16:06<Eddi|zuHause>(after all, they were "well tested" for years)
16:06<_dp_>Eddi|zuHause, stray includes come from vanilla openttd btw
16:07<_dp_>well, it's is tested... as long as it compiles :p
16:07<@peter1138>Okay, so with #7230
16:07<nielsm>hmm true yes, those includes are in master
16:08<@peter1138>The question is... *should* the 90 degree checks be moved outside of the pathfinder?
16:08<@peter1138>forbidding 90 degree turns is basically a feature OF the pathfinder, so...
16:09<nielsm>it looks like that's the only call site of that function
16:09<nielsm>and where it's used is pretty much already pathfinding code
16:09<DorpsGek_II>[OpenTTD/OpenTTD] PeterN commented on pull request #7230: Fix #7226: No ship track due to "forbid 90 deg turns"-> Do not call pathfinders.
16:09<Eddi|zuHause>peter1138: really, ships shouldn't forbit 90° turns
16:10<Eddi|zuHause>there is no sane reason for doing it
16:10<@peter1138>Eddi|zuHause, that isn't the point
16:11*peter1138 rebases his patch which removes it for ships.
16:11<Eddi|zuHause>the diff looks sane though
16:13<Eddi|zuHause>but why do we need both a DiagDir and a TrackDir? that seems redundant
16:14<@peter1138>TrackDir identifies upper/left or lower/right track bits.
16:15<@peter1138>DiagDir is just the 4 directions.
16:15<@peter1138>So they are not equivalent.
16:16<Eddi|zuHause>i mean, you could infer the diagdir from the trackdir
16:17<DorpsGek_II>[OpenTTD/OpenTTD] PeterN opened pull request #7232: Change: Don't apply forbid 90 deg turn settings to ships.
16:19<@peter1138>Better comment.
16:19<@peter1138>Looks like OPF and NPF didn't forbid 90 deg turns anyway?
16:19<@peter1138>Anything in NPF mentions trains.
16:20<@peter1138>And OPF just doesn't.
16:20<Eddi|zuHause>no idea
16:21<@peter1138>Hmm, actually forbidding 90 deg turns now makes ships faster, as on-the-spot rotation makes it stop.
16:21<@peter1138>Hmm, I guess increase penalty for 90 degree turns?
16:24-!-nielsm [] has quit [Ping timeout: 480 seconds]
16:29<@peter1138>Ok, where's the function to get Direction from Trackdir, anyway? :/
16:33-!-andythenorth [] has quit [Quit: andythenorth]
16:34-!-gelignite [] has quit [Quit: Good fight, good night!]
16:34<Samu>removing opf?
16:34<Samu>removing 90 degrees?
16:35<Samu>npf forbids 90 deg
16:35<@peter1138>remove forbid 90 degrees.
16:35<Samu>it was only opf that didn't
16:35<@peter1138>Onlly removing it for ships, not trains.
16:36<Samu>it's ... hmm somewhere in npf, driveable trackbits i think
16:39<@peter1138>Oh, of course. I already patched that out!
16:40<@peter1138>Only checks for TRANSPORT_RAIL :)
16:42<Samu>then that was it
16:42<@peter1138>Yeah, sorry. Forgot I'd taken care of it.
16:44<Eddi|zuHause>peter1138: something about "trackdir to exitdir" pops into my head
16:45<@peter1138>Nah, that's a DiagDir
16:51<Eddi|zuHause>that's what we wanted, i thought?
16:54<@peter1138>No, I wanted a Direction.
16:56-!-HerzogDeXtEr1 [] has quit [Read error: Connection reset by peer]
16:57<@peter1138>Hmm, well, adding a penalty doesn't seem to work :/
16:59-!-frosch123 [] has quit [Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn]
17:06-!-Wolf01 [] has quit [Quit: Once again the world is quick to bury me.]
17:19-!-Flygon [] has joined #openttd
17:19-!-Flygon is "Flygon" on #openttd
17:26-!-Pikka [] has joined #openttd
17:26-!-Pikka is "realname" on #openttd
17:34<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep commented on pull request #7230: Fix #7226: No ship track due to "forbid 90 deg turns"-> Do not call pathfinders.
17:41-!-sla_ro|master [] has quit []
17:43<DorpsGek_II>[OpenTTD/website] andreszs commented on issue #48:
17:48<DorpsGek_II>[OpenTTD/OpenTTD] PeterN commented on pull request #7230: Fix #7226: No ship track due to "forbid 90 deg turns"-> Do not call pathfinders.
17:49<@peter1138>Hmm, so the penalty *is* working...
17:49<@peter1138>Just not on the last segment.
17:50<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep commented on pull request #7232: Change: Don't apply forbid 90 deg turn settings to ships.
17:53<Samu>oh no... rip 90 deg
17:54-!-Supercheese [] has joined #openttd
17:54-!-Supercheese is "Supercheese" on #openttd
18:00<DorpsGek_II>[OpenTTD/OpenTTD] J0anJosep commented on pull request #7224: Change: Use selected group as parent when creating a new group.
18:17<DorpsGek_II>[OpenTTD/OpenTTD] PeterN commented on pull request #7224: Change: Use selected group as parent when creating a new group.
18:21<@peter1138>So remind me under what circumstances is forbid 90 degree turns for ships harmful?
18:32<Samu>it's ok,
18:32<Samu>makes my friendly rivers complete
18:33<Samu>lock friendly rivers
18:34<@peter1138>Does forbidding 90 degree turns help that someho?
18:36<@peter1138>I'd think permitting 90 degree turns would help it.
18:55<Samu>permiting helps
18:58-!-supermop_Home [] has joined #openttd
18:58-!-supermop_Home is "Guest" on #openttd
18:58<@peter1138>Well then.
18:58<@peter1138>Removing the option for ships means it would always be permitted.
18:59<+glx>forbit 90° was a train thing anyway
18:59<@peter1138>Originally, yes.
18:59<+glx>and it's really the only transport type where it makes sense
19:00<@peter1138>^ J0anJosep thinks it should stay.
19:00<+glx>I was already about to read it
19:01<DorpsGek_II>[OpenTTD/OpenTTD] PeterN commented on pull request #7232: Change: Don't apply forbid 90 deg turn settings to ships.
19:02<DorpsGek_II>[OpenTTD/OpenTTD] glx22 commented on pull request #7232: Change: Don't apply forbid 90 deg turn settings to ships.
19:02-!-tokai|noir [] has joined #openttd
19:02-!-mode/#openttd [+v tokai|noir] by ChanServ
19:02-!-tokai|noir is "Christian Rosentreter" on +#openttd
19:03<+glx>wow YAPF had a no90 for roads too ???
19:03<+glx>how silly
19:03<@peter1138>It was there but never used.
19:04<@peter1138>Yapf has a load of cruft that's never used elsewhere.
19:04<@peter1138>Its own custom debug helpers.
19:04<@peter1138>CStrA, DumpTarget...
19:04<+glx>yeah only to slow down the compilation
19:04<@peter1138>They were 'borrowed' from ... smatz's workplace.
19:06<+glx>I personnaly can't read yapf code ;)
19:07<@peter1138>I sometimes wonder about changing it to follow our naming conventions.
19:09-!-tokai [] has quit [Ping timeout: 480 seconds]
19:21-!-Smedles [] has quit [Ping timeout: 480 seconds]
19:23-!-Smedles [] has joined #openttd
19:23-!-Smedles is "Paul Smedley" on #openttd
19:26<Samu>can I do something about
19:26<Samu>I want to make it unavailable from 1.9.0 on
19:26<Eddi|zuHause>uhm, KUDr did yapf, not smatz
19:29<@peter1138>It did feel wrong :-)
19:29<@peter1138>Yes, definitely KUDr.
19:29<Eddi|zuHause>he didn't even want to make yapf, he wanted to make PBS
20:10<@peter1138>Which he didn't do.
20:17-!-Supercheese [] has quit [Quit: Valete omnes]
20:33-!-Thedarkb-X40 [] has joined #openttd
20:33-!-Thedarkb-X40 is "realname" on #openttd #/r/openttd #oolite
20:47-!-Progman [] has quit [Remote host closed the connection]
21:19-!-Wormnest [~Wormnest@] has joined #openttd
21:19-!-Wormnest is "Wormnest" on #openttd
21:37<nnyby>when i enable zBase the menu buttons seem twice as big as they should be. is there an easy way to change that?
21:37<@peter1138>Yes, don't switch back to not using zBase.
21:37<@peter1138>They're not even twice as big, it's just a random size.
21:37<@peter1138>Somebody conflated more colours with larger... :(
21:38<@peter1138>Frankly the whole thing is ugly.
21:38<@peter1138>All the vehicles are too big as well.
21:41<nnyby>hah interesting... yeah. this bus is driving on both sides of the road!
21:43<nnyby>i usually use opengfx but once in a while try zbase. it is impressive. seems a shame to dismiss for these issues that are maybe fixable? oh well.
21:43<@peter1138>Sure. The source is in, er, mercurial.
21:44<nnyby>in general i do like opengfx more, but it would be nice if the sharpness remained the same when i zoom in all the way
21:44<@peter1138>OpenGFX is still pretty ugly.
21:44<@peter1138>Original TTD is, of course, the best.
21:45<nnyby>is that what you usually play with? i should try that. i think i first played openttd when that was still required
21:45<nnyby>then when i saw opengfx i was like ehh, this will do. and then i just got used to it cause it's easy and comes with the game
21:50-!-Smedles [] has quit [Quit: No Ping reply in 180 seconds.]
21:51-!-Smedles [] has joined #openttd
21:51-!-Smedles is "Paul Smedley" on #openttd
21:52<@peter1138>So that's an interesting thing...
21:55-!-Wormnest [~Wormnest@] has quit [Quit: Leaving]
22:02-!-Samu [] has quit [Quit: Leaving]
22:06<@peter1138>Well shit, I got it working...
22:08<nnyby>haha wow, openttd with vector graphics?
22:08<@peter1138>I'd say render to normal sprites, but yeah.
22:08<nnyby>yea these original graphics and sound sets are really great i forgot about these. using these from now on
22:15-!-snail_UES_ [] has joined #openttd
22:15-!-snail_UES_ is "Jacopo Coletto" on #openttd
22:27<DorpsGek_II>[OpenTTD/OpenTTD] PeterN commented on pull request #7232: Change: Don't apply forbid 90 deg turn settings to ships.
22:28-!-D-HUND [~debdog@2a00:79c0:674:2900:7a24:afff:fe8a:d04d] has joined #openttd
22:28-!-D-HUND is "Wowbagger" on #bitlbee #openttd
22:30-!-glx [] has quit []
22:32-!-debdog [~debdog@2a00:79c0:648:5200:7a24:afff:fe8a:d04d] has quit [Ping timeout: 480 seconds]
22:45<DorpsGek_II>[OpenTTD/OpenTTD] PeterN updated pull request #6811: Feature: Add NotRoadTypes (NRT)
23:18-!-Thedarkb-X40 [] has quit [Ping timeout: 480 seconds]
---Logclosed Fri Feb 15 00:00:05 2019