Back to Home / #openttd / 2021 / 01 / Prev Day | Next Day
#openttd IRC Logs for 2021-01-08

---Logopened Fri Jan 08 00:00:45 2021
01:20-!-FLHerne [~flh@flherne.uk] has quit [Quit: Goodbye (ZNC disconnected)]
01:20-!-FLHerne [~flh@flherne.uk] has joined #openttd
01:20-!-FLHerne is "Francis L Herne" on #openttd #kernelnewbies
01:55-!-tejanos [~oftc-webi@c-67-168-111-57.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
02:21-!-sla_ro|master [slamaster@89.136.179.137] has joined #openttd
02:21-!-sla_ro|master is "slamaster" on @#sla #openttd
02:42-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has quit [Quit: snail_UES_]
03:29-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:4c99:2a10:9a3e:70ab] has joined #openttd
03:29-!-DasPoseidon is "DasPoseidon" on #openttd
03:32-!-Smedles [~quassel@61-245-148-167.3df594.adl.nbn.aussiebb.net] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
03:33-!-Smedles [~quassel@61-245-148-167.3df594.adl.nbn.aussiebb.net] has joined #openttd
03:33-!-Smedles is "Paul Smedley" on #openttd
03:53-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has joined #openttd
03:53-!-andythenorth is "andythenorth" on #openttd
04:12<@DorpsGek>[OpenTTD/OpenTTD] LordAro approved pull request #8523: Codechange: Check if access __attribute__ is supported before trying to use it. https://git.io/JLpJi
04:12<TrueBrain>LordAro: coding style seems off?
04:12<@DorpsGek>[OpenTTD/OpenTTD] LordAro merged pull request #8523: Codechange: Check if access __attribute__ is supported before trying to use it. https://git.io/JLxHj
04:12<TrueBrain>(I was about to comment on that :P)
04:12<TrueBrain>gave me no time at all :'(
04:13<@DorpsGek>[OpenTTD/OpenTTD] orudge updated pull request #8340: Draft: Feature: Create Universal (x86_64 + Apple Silicon) build on macOS https://git.io/JkqLt
04:13<LordAro>oh no
04:13<TrueBrain>it is what it is :D
04:14<TrueBrain>static_cast<uint>(std::min<size_t>( <- wow, that is a lot of casting
04:15<andythenorth>le oof
04:15*andythenorth woke up
04:15<TrueBrain>LordAro: shall I rebase your std::min/max for you?
04:16<TrueBrain>(to merge glx' work so it passes CI)
04:16<LordAro>sure
04:16<LordAro>or do it better :p
04:17<TrueBrain>I wouldn't know how :)
04:17<andythenorth>oof triggered https://www.tt-forums.net/viewtopic.php?p=1240214#p1240214
04:17<andythenorth>can someone reply to that
04:17*andythenorth has just deleted the "I have no idea what this complete crap you've posted is"
04:18<andythenorth>doesn't help
04:18<andythenorth>I hate these whiney twats who turn up out of context and complain that "popular people get special treatment"
04:20<LordAro>"can you please clarify ..."
04:20<TrueBrain>tl;dr: he had a meltdown, because he felt there was injustice. He burned bridges to get to his "right", and it was all caused because he was being an ass to the author, and the author did not really understand what was going on (the author clearly doesn't speak English as a native language)
04:21<TrueBrain>if you want to have a good read, open DIscord, #development, last night
04:22<andythenorth>I haven't had had coffee yet
04:23<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLNcq
04:24<TrueBrain>the irony is, that he himself posted work that clearly violated licenses weeks before; but that was okay, as someone else was also not following licensing. I think that sums up the story nicely
04:25<andythenorth>I wrote 'please explain'
04:25<andythenorth>coffee time!
04:25<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLpUt
04:30<TrueBrain>let's see if I can fix that annoying Windows warning ... if we can get ride of all the warnings, we can make warnings fail CI .. that would be swell :D
04:30<TrueBrain>now too easy overlooked :D
04:32<LordAro>aye
04:32<LordAro>feasible to do that now
04:33<TrueBrain>well, there are 2 things we can do: -Werror on all targets, but I was also thinking: enable a post github workflow check, that tells when there was any warning in any job
04:34<TrueBrain>not sure about the first
04:34<TrueBrain>the last has this annoying 'tar' issue :P
04:45<TrueBrain>bah; GNU tar is not compatible with "save-cache"
04:45<TrueBrain>tar: c:\vcpkg: Cannot stat: No such file or directory
04:45<TrueBrain>no clue where that extra \ is coming from :D
04:49<TrueBrain>andythenorth: if you think your commit messages are so-so, check this: https://github.com/lukka/run-vcpkg/commit/a1b6a0046a28c09f4bcc8caa9eecec9a8e512152 :D
04:49<andythenorth>ooh that's a nice one
04:49<andythenorth>being strict, have they just squashed a load of things there?
04:51<TrueBrain>yeah
04:52<TrueBrain>https://github.com/lukka/run-vcpkg/pull/65 was the source
04:52<TrueBrain>squash vs rebase vs merge :)
04:58<TrueBrain>attrib -r "c:/vcpkg" /s
04:58<TrueBrain>Parameter format not correct -
04:58<TrueBrain>tnx ....... windows .... this is very clear now to me
05:09<TrueBrain>LordAro: https://github.com/OpenTTD/OpenTTD/pull/8502 <- CI says yes .. merge? :D
05:09<LordAro>could do!
05:11<TrueBrain>\o/
05:16<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLNcq
05:16<TrueBrain>this version so needs a beta now :P
05:17<LordAro>my changelog is out of date now!
05:17<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed issue #8050: Scoring year is -1 when loading old savegame https://git.io/Jv7Ei
05:17<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8512: Several mistakes with ending-year and extreme values https://git.io/JLANI
05:18<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8513: Fix: for arctic and tropic, make sure we have at least a few hills https://git.io/JLxrv
05:18<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8513: Fix: for arctic and tropic, make sure we have at least a few hills https://git.io/JLxTc
05:20<TrueBrain>haha, and is that a bad thing? :D
05:20-!-Compu [~Compu@0001feeb.user.oftc.net] has joined #openttd
05:20-!-Compu is "Compu" on #help #openttd #/r/openttd
05:20<TrueBrain>bah, 2 PRs need rebasing, that already had approvals :P
05:21-!-Compu [~Compu@0001feeb.user.oftc.net] has quit [Remote host closed the connection]
05:21<TrueBrain>he came, he saw, and he got the hell out of here
05:21<TrueBrain>would it been personal you think?
05:24<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8508: Fix #7656: destroying a tunnel/bridge now first removes the tracks for cost calculation https://git.io/JLxoE
05:24<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8508: Fix #7656: destroying a tunnel/bridge now first removes the tracks for cost calculation https://git.io/JLARD
05:24<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8516: Fix #7972: show invalid orders to stations that don't accept your vehicle https://git.io/JLxcf
05:25<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLx6I
05:25<andythenorth>TrueBrain he saw your message and ran away
05:25<TrueBrain>can't blame him
05:28<TrueBrain>hmm ... run-vcpkg now doesn't want to cache for me .. that is annoying, how can I test if this works if it doesn't want to cache?! :P
05:31<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #8524: Fix: [Actions] remove read-only flag from c:\vcpkg https://git.io/JLpIE
05:32<TrueBrain>so lets just try it in our own repo
05:37<TrueBrain>seems to work :D
05:37<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8524: Fix: [Actions] circumvent Windows tar warning about read-only files https://git.io/JLpIE
05:37<TrueBrain>now to fix the silly commit message ..
05:38<@DorpsGek>[OpenTTD/OpenTTD] LordAro commented on pull request #8524: Fix: [Actions] circumvent Windows tar warning about read-only files https://git.io/JLpIy
05:39<TrueBrain>did you seriously just not read the comments LordAro ? :D
05:39<TrueBrain>I only did not want to link our issue to his, as .. GitHub
05:40<TrueBrain>(lot of comments in workflow)
05:40<TrueBrain> # In other words: this is a hack!
05:40<TrueBrain> # See: https://github.com/lukka/run-vcpkg/issues/61
05:40<TrueBrain>:)
05:43<LordAro>i think you're being too averse to GH links :p
05:43<LordAro>also, no, i just looked at the PR text :p
05:43<TrueBrain>:D
05:44<TrueBrain>I really really hate that GitHub makes all these cross-links without you asking it to
05:44<TrueBrain>but I am happy I am not alone in this, as frosch also clearly dislikes that :)
05:44<TrueBrain>just because I reference another ticket, doesn't mean it is interesting to the other ticket to know about that
05:45<LordAro>eh, lets them know it's important to other people
05:46<TrueBrain>if they would make it less annoying in the interface, I guess
05:46<TrueBrain>but it is now just way too much in-your-face :)
05:47<TrueBrain>anyway, more importantly: NO WARNINGS!
05:49<LordAro>\o/
05:52<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8524: Fix: [Actions] circumvent Windows tar warning about read-only files https://git.io/JLpLl
05:53<TrueBrain>so, what is left for 1.11 ..
05:53<TrueBrain>only 3 bugs I have on the list, of which I suspect we won't solve 2 for 1.11
05:55<TrueBrain>that leaves https://github.com/OpenTTD/OpenTTD/pull/7286, which basically needs to be redone, https://github.com/OpenTTD/OpenTTD/pull/8169, which I have to read up about, and https://github.com/OpenTTD/OpenTTD/issues/7869, which seems like an easy fix
05:55<TrueBrain>lets start with the second :)
05:56<andythenorth>8169 I understand the underlying issue, if that helps
05:56<@DorpsGek>[OpenTTD/OpenTTD] J0anJosep updated pull request #8480: Multitile depots https://git.io/JL5Hh
05:57<LordAro>did anyone test the OSXI release build yet?
05:57<LordAro>yes, i'm calling it OSXI to be annoying
05:57<TrueBrain>LordAro: what do you mean?
05:58<TrueBrain>if people tried the nightly MacOS build?
05:58<LordAro>the build produced by the CI for the Apple Sillion
05:58<LordAro>Sillion. yes.
05:58<TrueBrain>the PR is still in Draft :)
05:58<TrueBrain>the author is still working on that :)
05:58<andythenorth>hmm, 8169 that attached save doesn't demonstrate the problem
05:58<LordAro>no it isn't?
05:59<TrueBrain>did he sneaky finish it without telling us?
05:59<TrueBrain>pfft
05:59<TrueBrain>owh, you removed Draft
05:59<TrueBrain>that doesn't mean it is less of a draft :)
05:59<LordAro>from the title, because it wasn't a Draft PR any longer
05:59<LordAro>unless i've become confused
05:59<TrueBrain>was it ever? :D
05:59<LordAro>pretty sure it was...
06:00<@DorpsGek>[OpenTTD/OpenTTD] LordAro approved pull request #8508: Fix #7656: destroying a tunnel/bridge now first removes the tracks for cost calculation https://git.io/JLpLQ
06:00<@DorpsGek>[OpenTTD/OpenTTD] LordAro approved pull request #8513: Fix: for arctic and tropic, make sure we have at least a few hills https://git.io/JLpL7
06:00<TrueBrain>I think he never hit the "this is a draft" button, honestly :) Anyway, last I heard, he was working on it :)
06:00<TrueBrain>https://github.com/orudge/OpenTTD/actions <- like 11 minutes ago :)
06:01<LordAro>consider it readded :)
06:01<andythenorth>did we always have a depot refit order?
06:01*andythenorth finds new bits of OpenTTD UI
06:01<TrueBrain>but the new OSX targets are really annoying, as they don't have enough of them
06:01<TrueBrain>so they stall a lot and often
06:01<TrueBrain>makes testing SSLLOOWWWW as fuck
06:02<@DorpsGek>[OpenTTD/OpenTTD] LordAro commented on pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JLpLj
06:02<TrueBrain>andythenorth: if you have a savegame for me, that would be lovely
06:02<andythenorth>8169 the save is correct
06:02<andythenorth>on the ticket
06:02<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed issue #7656: Bridge/tunnel remove cost does not take into account road/tram/rail remove cost. https://git.io/fj1vu
06:02<andythenorth>it does work, the issue shown is a different one to my expectation
06:02<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8508: Fix #7656: destroying a tunnel/bridge now first removes the tracks for cost calculation https://git.io/JLARD
06:02<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed issue #6337: Mapgen: no tropical trees and no snow with default world generation settings https://git.io/JLpte
06:02<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8513: Fix: for arctic and tropic, make sure we have at least a few hills https://git.io/JLxTc
06:02<TrueBrain>rgr
06:03<TrueBrain>the one thing I do not like about that PR, that it is not throwing an error, but a news message
06:03<TrueBrain>owh, auto-renew
06:03<TrueBrain>fine
06:06<TrueBrain>wow, that news pops up every time it tries autorenew?
06:06<TrueBrain>damn, that is annoying
06:06<@DorpsGek>[OpenTTD/OpenTTD] LordAro commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JLptn
06:07<andythenorth>we never found a better way
06:08<andythenorth>autorenew or autoreplace?
06:08<TrueBrain>a new GUI! :)
06:08<TrueBrain>auto-replace, sorry
06:08<LordAro>autochange
06:08<@orudge>TrueBrain: sorry, trying to get it to actually build is proving fun, clearly a severe lack of agents...
06:08<andythenorth>template replacement :P
06:08<andythenorth>shadow off-screen vehicles
06:08<TrueBrain>orudge: no need to be sorry :)
06:09<TrueBrain>orudge: have you tried the older version, if that can produce binaries?
06:09<@orudge>Not yet, let me check the installed software list
06:11-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
06:11-!-tokai is "Christian Rosentreter" on #openttd
06:11-!-mode/#openttd [+v tokai] by ChanServ
06:11<TrueBrain>besides some coding-style thingies, I am fine with 8169. I just don't know enough about auto-replace to know if his function is correct
06:12<@DorpsGek>[OpenTTD/OpenTTD] orudge updated pull request #8340: Draft: Feature: Create Universal (x86_64 + Apple Silicon) build on macOS https://git.io/JkqLt
06:12<@orudge>OK, it seems that the 10.15 VMs do have the newer xcode and SDK on, and enabled by default
06:13<@orudge>so let's see how well that works
06:15<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8169: Fix #8153: Report autoreplace failure when new vehicle cannot carry the cargo https://git.io/JfVAv
06:15<TrueBrain>LordAro: if you can spare some cycles, would you mind looking at ^^ ? I can't tell if the code is doing what it should :)
06:15<TrueBrain>andythenorth: you agree that this functionality is wanted?
06:15<@DorpsGek>[OpenTTD/OpenTTD] orudge updated pull request #8340: Draft: Feature: Create Universal (x86_64 + Apple Silicon) build on macOS https://git.io/JkqLt
06:16<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8169: Fix #8153: Report autoreplace failure when new vehicle cannot carry the cargo https://git.io/JfVAv
06:17<andythenorth>TrueBrain it addresses the reported issue in https://github.com/OpenTTD/OpenTTD/issues/8153
06:17<andythenorth>I don't have much more opinion than that sorry
06:17<andythenorth>I never encounter the issue, I don't play the game that way
06:17<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8169: Fix #8153: Report autoreplace failure when new vehicle cannot carry the cargo https://git.io/JLptN
06:17<TrueBrain>I like explicit failures over silence
06:18<TrueBrain>other autoreplace failures use news too
06:18-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
06:18<andythenorth>yes
06:18<TrueBrain>text looks okay-ish
06:18<andythenorth>I don't see anything controversial
06:18<TrueBrain>so I am fine with the functionality myself
06:18<andythenorth>if this is a mistake, we'll get told?
06:18<TrueBrain>I am not scared of that :) I am just evaluating :)
06:20<TrueBrain>owh, right, that heightmap PR did 10 things, I forgot
06:21<TrueBrain>and I don't agree with 1/3rd of the PR, so that was the issue :D
06:21<@DorpsGek>[OpenTTD/OpenTTD] orudge updated pull request #8340: Draft: Feature: Create Universal (x86_64 + Apple Silicon) build on macOS https://git.io/JkqLt
06:21<Heiki>/usr/local/src/openttd/src/strgen/../stdafx.h:142:62: error: attribute ‘access’ invalid mode ‘none’; expected one of ‘read_only’, ‘read_write’, or ‘write_only’
06:22<TrueBrain>cc --version Heiki ? :)
06:22<Heiki>gcc version 10.2.1 20201224 (Debian 10.2.1-3)
06:22<@orudge>Apologies for the spam, I should probably push this to a non-PRed branch until it's working :D
06:22<TrueBrain>orudge: who am I to tell you anything about spamming this channel with DorpsGek text :D
06:23<TrueBrain>so "none" is GCC 11 only, I am guessing
06:23<TrueBrain>things that sound like an easy change ... can easily lead to fix after fix after fix :D
06:23<Heiki>haha
06:24<TrueBrain>I can look into this after lunch; no clue what "access" does, so would need to read up on that first :)
06:28<LordAro>linked in the original PR
06:31-!-WormnestAndroid [~WormnestA@35.136.189.95] has quit [Remote host closed the connection]
06:31-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:4c99:2a10:9a3e:70ab] has quit [Ping timeout: 480 seconds]
06:31-!-WormnestAndroid [~WormnestA@35.136.189.95] has joined #openttd
06:31-!-WormnestAndroid is "WormnestAndroid" on #openttd
06:36-!-J0anJosep [~J0anJosep@185.242.251.207-ip.operadors.cat] has joined #openttd
06:36-!-J0anJosep is "Joan Josep" on #openttd
06:39<@orudge>Hurrah, a build at last
06:49*Timberwolf stares into the abyss of road types drama.
06:50-!-WormnestAndroid [~WormnestA@35.136.189.95] has quit [Read error: Connection reset by peer]
06:50<Timberwolf>I don't understand why that one small corner of newgrf development is such an ongoing tyre fire.
06:50-!-WormnestAndroid [~WormnestA@35.136.189.95] has joined #openttd
06:50-!-WormnestAndroid is "WormnestAndroid" on #openttd
06:52<andythenorth>Timberwolf I could try and explain
06:54*andythenorth remains baffled that JGR is somehow expected to support savegames from other patchpacks :P
06:54<andythenorth>including ones featuring broken patches
06:54<andythenorth>people!
06:54<andythenorth>are amazing!
06:57-!-J0anJosep [~J0anJosep@185.242.251.207-ip.operadors.cat] has quit [Ping timeout: 480 seconds]
06:57<Timberwolf>Heh, yes. JGR has a lot of patience :)
06:57<@orudge>So, now we hit the next snag. I had read some articles about this, but it appears that Apple Silicon apps do indeed need to be signed to run. The previous workaround of right-clicking and holding down a key while opening doesn't work for Silicon.
06:57<@orudge>There is a workaround where you can de-quarantine an app and then it runs
06:57-!-J0anJosep [~J0anJosep@185.242.251.207-ip.operadors.cat] has joined #openttd
06:57-!-J0anJosep is "Joan Josep" on #openttd
06:57<@orudge>But for a reasonable user experience, we might need to get that "licensing" company set up and get an Apple Developer ID
06:58<@orudge>(I'm willing to do that as indicated previously)
07:03*andythenorth procrastinating
07:06<TrueBrain>orudge: I suspect we hit the same issue again for Windows too
07:06<TrueBrain>regarding setting up what-ever company, we never figured out if we wanted short-term or long-term for that
07:07<@orudge>Well, I can register a UK company very cheaply and easily, and the admin is quite minimal. I am happy, at least in the short term, to do that. The plan would be for a simple company to handle our store licensing but nothing else (it wouldn't take donations for instance).
07:07<@orudge>Should we transition to something more appropriate in the medium or long term, then this can simply be wound up.
07:08<andythenorth>we can always sell the company to a charity P
07:08<@orudge>For Apple, I think there's a €99/year fee, which isn't ideal, but we aren't exactly short on money. (Could stick a PayPal link into the Mac build :P)
07:09<andythenorth>€99 is less than I currently donate to openttdcoop :P
07:10<andythenorth>hmm coop is maybe dead though, I should look into that
07:10<@orudge>I'll get my Apple Silicon PR ready (it does work, if you put the workaround in place), but won't make it universal at this time
07:10<TrueBrain>orudge: as I said: for a company we stalled on: do we want a Stichting, which would also allow donations, or do we want an LLC, which doesn't allow donations
07:10<@orudge>I don't know who exactly needs to "approve" my plan, but unless anybody is unhappy, I can go and register a company and get an Apple Developer account, and put in a new PR to sign the Mac builds.
07:10<TrueBrain>it felt silent after that
07:11<TrueBrain>doing the work is never the issue here, of course; it is just that nobody seems to care enough to voice an opinion on the matter :)
07:11<@orudge>TrueBrain: mm. From my point of view at least, the latter is simple, as it effectively has no more work for me other than filling out a form or two once a year.
07:11<TrueBrain>both are equally simple
07:11<TrueBrain>there is no difference
07:11<TrueBrain>just you have experience with one
07:11<TrueBrain>:)
07:11<@orudge>well, quite
07:11<TrueBrain>but it is as simple to setup a Stichting vs an LLC UK
07:12<TrueBrain>the main difference will be, that the first has more members and a policy how to deal with everything
07:12<TrueBrain>the latter is a YOLO
07:12<@orudge>Yeah
07:12<andythenorth>we only need YOLO
07:12<TrueBrain>so again, short-term vs long-term :)
07:12<TrueBrain>there is a risk involved with YOLOing stuff
07:12<Eddi|zuHause>YOLO sounds like a tight bus factor
07:12<TrueBrain>for one, and don't take this the wrong way, what if something happens to orudge
07:13<@orudge>There can be other company directors, and they don't need to be UK resident, in terms of the Ltd
07:13<TrueBrain>but, on the other hand: we have been operating like that for 15 years, so yeah ..
07:13<@orudge>Of course, if I do get hit by a bus, you might need to change the registered office from my home address :P
07:13<LordAro>nothing's happened to him yet!
07:13<TrueBrain>so to be clear, and I appreciate you pushing for your solution orudge , it is not about doing the work
07:14<TrueBrain>it is more about, how professional do we want to become
07:14<TrueBrain>or do we just want to get it over with
07:14<TrueBrain>(with all the risks attached to that)
07:14<andythenorth>have we had lunch?
07:14<andythenorth>this sounds like thinking
07:14<andythenorth>thinking needs food
07:14<TrueBrain>and to be clear, I rather have we do what orudge says, as that means I don't have to do anything; I am lazy where I can :)
07:14<@orudge>Heh
07:14<TrueBrain>it is just about accepting the risks involved, doing something delibrately
07:14<TrueBrain>instead of by accident
07:15<@orudge>Plus, in terms of Apple, we aren't going to be uploading to the Mac App Store (I don't think we can, because GPL), this is just effectively for a code signing certificate
07:15<andythenorth>we could make a table of risks
07:15<andythenorth>and risk score them
07:15<TrueBrain>so, to voice my opinion: I am fully okay with putting the full load on orudge , IF he is willing to accept that
07:15<@orudge>So if anything does happen to me, you've not really lost anything.
07:15<@orudge>You just set up a new developer identity and sign with that
07:15<@orudge>If we move onto Steam, etc, then that might be something else to consider
07:15<TrueBrain>orudge: something something funds :P
07:15<andythenorth>and we can devise mitigations to prevent risks, and remedies if they manifest
07:15<andythenorth>or we can yolo :P
07:16<@orudge>TrueBrain: ah, yes, that's a separate matter really :)
07:16<TrueBrain>no, it is not :)
07:16<TrueBrain>if we go your route, we will never do a Stichting or what-ever
07:16<TrueBrain>as we are inherit lazy
07:16<TrueBrain>and again, I am totally fine with it
07:16<TrueBrain>just ... deliberate action vs accidental :)
07:17<andythenorth>TL;DR current 'authority' is based on who has possession of certain keys and passwords? So it's property based?
07:17<TrueBrain>so basically, we have 2 choices: either we solve OpenTTD LLC clean and correctly, or we continue to use orudge as our broker for the next 15 years :P
07:17<TrueBrain>I vote for the latter, simply because it is so much easier
07:17<@orudge>I wouldn't say never, but from my point of view, it's probably not something I have time for just now (if you need me to do anything, of course; I suspect there would be some work necessary). And at some point, yes, I would be happy to take that responsibility/liability off my shoulders. :)
07:18<TrueBrain>I can promise you, how OpenTTD operates .. once there is no more issue, nobody will put any effort in "doing it more correct" :)
07:18<TrueBrain>might sound harsh, but it is true :P
07:18<andythenorth>this way we sidestep having an OpenTTD legal entity
07:18<@orudge>I am happy to vote for the latter, with the intention that maybe in the next year or so we try to do something. There may be other options too, Software Freedom Conservancy, etc, that could be looked into.
07:18<TrueBrain>again, all nice ideas, but it really is not going to happen, unless you start to explicit lobby you no longer want to do it :P
07:18<andythenorth>I would rather we have a disorganised coop with no legal structure, and a broker providing some services
07:19<andythenorth>for now
07:19<TrueBrain>nobody really cares about where donations go, and how we pay AWS, basically :)
07:19<@orudge>TrueBrain: well, I need to move house first, that is likely to take up most of my time over the next 6 months or so. After that, perhaps I can lobby. Given I have all the funds, there would probably be some interest in that being sorted :D
07:19<andythenorth>if we make a legal entity, with a board, and some kind of process for getting on / off the board
07:19<andythenorth>we create politics
07:19<@orudge>True
07:19<TrueBrain>and to be clear orudge , I mostly do this for you; as you have to understand that it would mean you are stuck with us for another 10 years :D
07:19<andythenorth>and we create a thing for that one person who does care about donations etc
07:19<@orudge>Well
07:20<@orudge>I'm happy to keep doing what I'm doing
07:20<@orudge>but eventually we should probably do something more formal with the funds, or alternatively, spend them all :P
07:20<@orudge>Let's see how AWS does
07:20<TrueBrain>:D
07:20<andythenorth>defer the problem
07:20<TrueBrain>just so there is no illusion that if you start an UK company, that next year anyone would be interesting in doing it differently :)
07:21<TrueBrain>there will be even more crickets :P
07:21<@orudge>Well quite
07:21<@orudge>It sounds like nobody is particularly objecting to, whether in the short or long term, having an OpenTTD Distribution Ltd, which would help us at least solve our Mac (and/or Windows) problems.
07:21<@orudge>So I may well proceed with that.
07:21<TrueBrain>that said, I am very happy that you did this for the last 15 years, and I am pretty sure you do the Ltd well and correctly, so, yeah, I am all in for that :)
07:21<andythenorth>shall we vote?
07:21<TrueBrain>just as long as you understand the risks, I am all fine :)
07:22*andythenorth votes +1
07:22<@orudge>Once it's set up, perhaps I can persuade some of you to stick your name down as a company director if you so wish ;)
07:22<TrueBrain>+/- 0 on that .. if you like to, sure, if I don't have to, it is fine too :)
07:22<@orudge>but anyway
07:22<@orudge>lunch
07:22<@DorpsGek>[OpenTTD/OpenTTD] SamuXarick updated pull request #8517: Codechange: Make void tiles flood edge tiles, instead of edge tiles flooding themselves https://git.io/JLxCt
07:23<TrueBrain>so yeah, please do make an Ltd, create an Apple account, and .. let's pick one to sign Windows with too :)
07:23<TrueBrain>while at it, make a Steam account based on that Ltd
07:23<TrueBrain>please do this before you move :P (you move a lot, don't you?)
07:24-!-ekangmonyet_ [~ekangmony@202.151.229.112] has joined #openttd
07:24-!-ekangmonyet_ is "Ekang Monyet" on #openttd
07:24-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has joined #openttd
07:24-!-Samu is "realname" on #openttd
07:25-!-ekangmonyet [~ekangmony@202.151.229.112] has quit [Remote host closed the connection]
07:28<TrueBrain>owh, yeah, the other issue was OV or EV
07:28<andythenorth>thanks orudge also!
07:28<TrueBrain>I do not think we can automate EVs, as they mostly require hardware tokens
07:29-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has quit []
07:29<@orudge>TrueBrain: no, been here 9 years!
07:29<@orudge>and yes
07:29<@orudge>Can look into that separately
07:30<TrueBrain>9 years? Sorry, I lost context :)
07:30<TrueBrain>owh ,house
07:30<TrueBrain>haha :)
07:30<TrueBrain>sorry, slow :P
07:30<TrueBrain>anyway, so that means we can finally publish on Steam? That will be interesting :D
07:31<FLHerne>What we really need is build-on-slopes for airports https://cimg7.ibsrv.net/gimg/pprune.org-vbulletin/265x190/a_af467faf56b2590151045e0679df98fa5e78583e.jpg
07:33<TrueBrain>seems https://www.ksoftware.net/code-signing-certificates/ offers the cheapest OVs still
07:38<TrueBrain>insane how expensive it still is :P
07:38<TrueBrain>Comodo site itself is like ~150 dollar a year, but via a reseller it is 62 dollar a year
07:38<TrueBrain>like wtf?
07:40<Eddi|zuHause>is "cheapest" really the metric to go for with code signing?
07:40<TrueBrain>given they are otherwise identical, it is a metric for sure
07:40<TrueBrain>but the difference is ~70 dollar and ~350 dollar
07:41<TrueBrain>(Between suppliers and resellers)
07:42<Eddi|zuHause>well, maybe i'm being naive here, but i imagine "code signing" would involve someone actually checking what they're signing
07:42<twpol>In my experience the only difference of any consequence is how painful their validation process is, and that's pretty hard to judge before going through it :(
07:43<TrueBrain>Eddi|zuHause: you would be surprised :)
07:43<Eddi|zuHause>i'd rather not :p
07:43<TrueBrain>hmm, with the Apple Developers program, you get a code signing certificate
07:43<TrueBrain>I wonder if that also works on Windows binaries :D
07:43<twpol>For typical code signing, once they've validated your existence, and they hand over a certificate, they're no longer involved (except for a timestamping service)
07:44<twpol>No idea how it differs for Apple-specific stuff
07:44<TrueBrain>the thing I do not know, how easy it is to automate signing :D
07:44<Eddi|zuHause>TrueBrain: the other alternative is that "code signing" is effectively a money printing machine with no consequence on whatever
07:44<@orudge>For Apple we can store the certificate data in GitHub Secrets
07:45<twpol>Windows with an OV is trivial, `signtool` from the MS dev tools
07:45<TrueBrain>Eddi|zuHause: welcome to certificates! :)
07:45<TrueBrain>orudge: yeah, and GitHub does a very good job in keeping secrets a secret
07:45<Eddi|zuHause>TrueBrain: which in consequence creates a false sense of security
07:45<@orudge>Anyway, I will register the company this afternoon, will need to get a bank account set u
07:45<TrueBrain>Eddi|zuHause: have you read up on any CA lately? :P
07:45<TrueBrain>orudge: <3
07:45<Eddi|zuHause>... which makes everything worse for everyone
07:46<Eddi|zuHause>"i'd rather not :p"
07:46<TrueBrain>lets say I am happy we have Letsencrypt and ACM for https :)
07:47<milek7>I think officially you need to store cert on hardware smartcard
07:48<milek7>at least that was what certum wanted
07:49<milek7>(of course they cannot check where really you stored it)
07:49<TrueBrain>https://github.com/simonw/datasette/issues/1171 <- useful for MacOS signing
07:53<TrueBrain>milek7: EVs should be on hardware, OVs do not; this is why OVs are easier, but also less trust-worthy
07:55<milek7>hmm, curious why certum wanted smartcard
07:56<TrueBrain>EV is advised to use with Windows, but I have no clue how we would go about that
07:59-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has joined #openttd
07:59-!-Samu is "realname" on #openttd
08:04<LordAro>TrueBrain: manual step in release process!
08:04<TrueBrain>yeah ......... can I opt out? :D
08:04<Samu>hi
08:06<TrueBrain>hmm, gcc hasn't published a version 11 docker (yet)
08:07<@orudge>TrueBrain: yes, I found something similar, which I think uses the same library
08:07<milek7>sorry for the access __attribute__ saga
08:07<TrueBrain>milek7: isn't it just a GCC 11 bug, you ran into?
08:08<milek7>it's feature, look at first PR
08:08<TrueBrain>I am not talking about the noaccess macro, I mean the warning you get
08:09<TrueBrain>as the warning seems incorrect to me
08:09<milek7>well, it is passing uninitialized const pointer, so warning seems reasonable
08:10<TrueBrain>either my definition of uninitialized is wrong, or I don't understand the code :P
08:10<LordAro>seems reasonable to me
08:11<LordAro>the pointer could be explicitly initialised to null first i suppose, but it's not necessary
08:11<milek7>https://github.com/gcc-mirror/gcc/commit/b825a2289074
08:11<milek7>https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10138
08:12<TrueBrain>I guess the first question is: what pointer are we talking about :D
08:12<TrueBrain>I hate that I cannot run gcc11 easily myself :P
08:12<Heiki>GCC 11 doesn’t even have a release day yet
08:13<milek7>maybe we should revert it, and add it back when gcc11 is released with proper version check macro
08:14<TrueBrain>I am first trying to understand what the warning is trying to tell me :)
08:14<TrueBrain>as "last" is pretty much initialized
08:14<TrueBrain>does it mean that "url" is not?
08:15-!-Gustavo6046_ [~Gustavo60@189.6.235.203] has joined #openttd
08:15-!-Gustavo6046_ is "Gustavo Rehermann <rehermann6046@gmail.com>" on #openttd #llvm
08:15<@DorpsGek>[OpenTTD/OpenTTD] iTKerry opened issue #8525: Server on MacOS is not sending ADMIN_PACKET_SERVER_WELCOME packet https://git.io/JLpsj
08:17<milek7>last is pointer to uninitialized url
08:17<@orudge>Company registration submitted
08:17<milek7>"A pointer to const parameter is almost always an input parameter to a function, so -Wuninitialized could warn if it has not been initialized.
08:17<TrueBrain>orudge: nice
08:17<andythenorth>@orudge do you still have to pay in £1?
08:17<andythenorth>for the share?
08:17<TrueBrain>milek7: so the issue is not last, but url
08:17<TrueBrain>?
08:18<milek7>no
08:18<milek7>compiler assumes that const pointer is input, and function will be reading from it, therefore warning
08:18<milek7>but in fact pointer is never dereferenced, so it doesn't matter
08:18<milek7>attribute none tells compiler about it
08:19<TrueBrain>pretty sure that is not what I meant .. I am not debating whether it is used or not in the function, I am trying to make sense of the warning itself :)
08:19<@orudge>andythenorth: I will, yes, once there's a bank account
08:19<TrueBrain>to me, and that might be fully me, but ELI5, last is perfectly valid
08:19-!-Gustavo6046 [~Gustavo60@2804:14d:4cd8:855d::1] has quit [Ping timeout: 480 seconds]
08:19-!-Gustavo6046_ is now known as Gustavo6046
08:20<TrueBrain>I for example wonder, and we shouldn't do this, if "char url[1024] = {};" solves the issue?
08:20<andythenorth>@orudge I think I have a debt to my company somewhere of £1 for share cap :P
08:20<TrueBrain>just trying to understand what the compiler is seeing
08:21<TrueBrain>and that is the issue with not being able to try yourself, hard to understand what things are doing :)
08:22<milek7>all the code is perfectly valid, this is just to silence slightly overzealous warning
08:22<TrueBrain>I understand that, but it is not what I am asking about :)
08:22<andythenorth>sometimes a twitch stream would answer a lot :P
08:23<milek7>warning is just about that: "A pointer to const parameter is almost always an input parameter to a function, so -Wuninitialized could warn if it has not been initialized."
08:23<TrueBrain>you have said that 3 times now already
08:23<TrueBrain>I am not sure what you think helps by repeating the same thing :)
08:23<TrueBrain>clearly, I am not understanding something; so just repeating the same thing over and over, doesn't help
08:24<TrueBrain>I am simply asking: why does it think "last" is not initialized?
08:24<milek7>because.. it is not? I give up ;P
08:25-!-glx [glx@000128ec.user.oftc.net] has joined #openttd
08:25-!-glx is "Loïc GUILLOUX" on #openttd
08:25-!-mode/#openttd [+v glx] by ChanServ
08:27<milek7>https://godbolt.org/z/Txohv8
08:28<TrueBrain>so, what I have been asking in different forms now: the problem is that "url" is not initialized?
08:28<milek7>I wouldn't call that a problem
08:29<TrueBrain>....
08:29<TrueBrain>the compiler warns because url is not initialized
08:29<TrueBrain>that better?
08:30<milek7>no, because it skips fact that it warns about 'last', which don't have to be initialized :P
08:30<milek7>but sure, you can also fix it that way
08:31<TrueBrain>this seems really difficult for you, but in general people like to understand a problem before they can think about a fix .. so I am just trying to understand WHY the compiler warns, this allows me to think what we can do to fix this ..
08:31<TrueBrain>so, all I was asking, do I get this right that the problem is that last points into url, which is not initialized
08:31<TrueBrain>the answer appears to be: yes
08:33<milek7>or, the problem is that compiler wrongly assumes 'that' last is dereferenced
08:33<milek7>sorry, I'm stubborn :P
08:33<TrueBrain>and you are really not helping at all
08:33<TrueBrain>like, I am trying to show I don't know much about this stuff
08:33<TrueBrain>and all you do is bash me back over and over
08:34<TrueBrain>not sure what you think that does make me feel .. but it is not helping
08:34<milek7>that wasn't intended
08:34<TrueBrain>in that case I forgive you, but you frustrated the hell out of me :P
08:35<TrueBrain>GCC warnings are annoying as fuck, most of the time :)
08:39-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:4c99:2a10:9a3e:70ab] has joined #openttd
08:39-!-DasPoseidon is "DasPoseidon" on #openttd
08:42<andythenorth>hmm vehicle variants demanded
08:42*andythenorth drawing trains
08:42-!-jottyfan [~Thunderbi@x4dbfd142.dyn.telefonica.de] has joined #openttd
08:42-!-jottyfan is "jottyfan" on #openttd
08:47<andythenorth>discord is much more supportive about my train adventures TBH :P
08:48<Samu>:P
08:48<TrueBrain>you want to say something with that andythenorth ?
08:49<andythenorth>I said it
08:49<Samu>i read irc log
08:49<@DorpsGek>[OpenTTD/OpenTTD] glx22 commented on issue #8525: Server on MacOS is not sending ADMIN_PACKET_SERVER_WELCOME packet https://git.io/JLpsj
08:50<andythenorth>anyway vehicle variants or go home
08:54-!-rptr_ [~rptr@2a00:801:236:570e:b1f2:acf6:e570:218d] has joined #openttd
08:54-!-rptr_ is "rptr" on #openttd
08:55<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnT
08:55<TrueBrain>milek7: mind testing ^^
08:57-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:4c99:2a10:9a3e:70ab] has quit [Quit: DasPoseidon]
08:57<@DorpsGek>[OpenTTD/OpenTTD] SamuXarick commented on pull request #8517: Codechange: Make void tiles flood edge tiles, instead of edge tiles flooding themselves https://git.io/JLpns
08:57<supermop_Home>good morning
08:58<andythenorth>yo
08:58-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:ed86:2b81:a074:b12a] has joined #openttd
08:58-!-DasPoseidon is "DasPoseidon" on #openttd
08:59-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:ed86:2b81:a074:b12a] has quit [Remote host closed the connection]
08:59-!-DasPoseidon is "DasPoseidon" on #openttd
08:59-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:ed86:2b81:a074:b12a] has joined #openttd
09:00<milek7>TrueBrain: it works for me, but TBH I would revert NOACCESS and place it back when gcc11 is released and gate it with __GNUC__ >= 11 __GNUC_MINOR__ >= 1
09:00-!-jottyfan [~Thunderbi@x4dbfd142.dyn.telefonica.de] has quit [Quit: jottyfan]
09:00<@DorpsGek>[OpenTTD/OpenTTD] LordAro approved pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnl
09:01<TrueBrain>milek7: why? (honest question)
09:02<milek7>gcc11 was branched in april, but none attribute is present since june, so it will fail on compiler builds between those dates
09:03<FLHerne>milek7: But who uses outdated unreleased compiler versions?
09:03-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:ed86:2b81:a074:b12a] has quit [Remote host closed the connection]
09:03<FLHerne>Surely people are either using a release or a fairly recent dev build
09:04-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has joined #openttd
09:04-!-nielsm is "Niels Martin Hansen" on #openttd
09:05<@DorpsGek>[OpenTTD/OpenTTD] glx22 commented on pull request #8517: Codechange: Make void tiles flood edge tiles, instead of edge tiles flooding themselves https://git.io/JLpni
09:05-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:2525:1782:292d:cbe5] has joined #openttd
09:05-!-DasPoseidon is "DasPoseidon" on #openttd
09:06<andythenorth>so can we have filter modes for OpenTTD?
09:06<andythenorth>e.g. sepia
09:06<andythenorth>for all sprites except UI
09:06<+glx>oh indeed, just check with mingw (gcc10) and it errors
09:08<@DorpsGek>[OpenTTD/OpenTTD] glx22 approved pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnF
09:09<TrueBrain>milek7: good point; minor 1 or 2?
09:09<TrueBrain>I see godbolt is already on 2 :P
09:10<TrueBrain>so "#if __GNUC__ >= 11 && __GNUC_MINOR__ >= 1" would work too, not?
09:10<milek7>huh
09:10<TrueBrain>owh, nevermind
09:10<TrueBrain>I am an idiot
09:10<TrueBrain>haha
09:10<TrueBrain>righttt, revert it is
09:10<milek7>mine is __GNUC_MINOR__ 0
09:10<milek7>and minor 1 would be first tagged release
09:11<TrueBrain>feels a bit sad, but okay
09:12<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnF
09:12<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnl
09:12<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnT
09:13<TrueBrain>commit checker .. grr :P
09:13<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8526: Revert: access_mode "none" is only available on GCC 11.1 and later https://git.io/JLpnT
09:13<milek7>btw. the whole reason I have gcc11 installed because gcc10.2 miscompiles something in mesa with lto
09:13<TrueBrain>owh, too fed chars ...
09:14<LordAro>TrueBrain: how did you manage to dismiss that review twice? :p
09:14<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8526: Revert: access_mode "none" is only available on GCC 11.1 and later https://git.io/JLpnT
09:14<TrueBrain>LordAro: because 2 people approved it
09:14<LordAro>lol
09:16<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on issue #8525: Server on MacOS is not sending ADMIN_PACKET_SERVER_WELCOME packet https://git.io/JLpsj
09:16<TrueBrain>okay, writing that psuedo-code was a lot harder than I remembered
09:16<TrueBrain>reading TCP is annoying :P
09:19<milek7>https://gist.github.com/Milek7/3dd1f0d2bd6fd8422579055d7dbbd62f
09:20<@DorpsGek>[OpenTTD/OpenTTD] LordAro approved pull request #8524: Fix: [Actions] circumvent Windows tar warning about read-only files https://git.io/JLpcB
09:20<@DorpsGek>[OpenTTD/OpenTTD] LordAro approved pull request #8526: Revert: access_mode "none" is only available on GCC 11.1 and later https://git.io/JLpc0
09:20<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8524: Fix: [Actions] circumvent Windows tar warning about read-only files https://git.io/JLpIE
09:20*LordAro not merging anything
09:20<LordAro>have broken enough things today :p
09:20<TrueBrain>we all break shit constantly
09:20<milek7>sorry :P
09:20<TrueBrain>that is our job, not?
09:20-!-rptr_ [~rptr@2a00:801:236:570e:b1f2:acf6:e570:218d] has quit [Quit: Leaving]
09:22<@orudge>OPENTTD DISTRIBUTION LTD
09:22<@orudge>Company number SC685432
09:22<@orudge>Hurrah
09:23<TrueBrain>\o/
09:23<@DorpsGek>[OpenTTD/OpenTTD] SamuXarick commented on pull request #8517: Codechange: Make void tiles flood edge tiles, instead of edge tiles flooding themselves https://git.io/JLpcK
09:23<TrueBrain>that is rather quick ... UK has some nice IT
09:23<TrueBrain>that doesn't belong in the EU
09:24<TrueBrain>https://partner.steamgames.com/ <- just leaving that URL here ....... :D
09:24<milek7>yeah.. opening limited company there requires sending papers to court and waiting weeks
09:25<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8526: Revert: access_mode "none" is only available on GCC 11.1 and later https://git.io/JLpnT
09:25<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8526: Revert: access_mode "none" is only available on GCC 11.1 and later https://git.io/JLpc9
09:26<Samu>honestly that last check
09:26<Samu>would go undetected
09:27-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has joined #openttd
09:27-!-snail_UES_ is "Jacopo Coletto" on #openttd
09:30-!-ekangmonyet_ [~ekangmony@202.151.229.112] has quit [Read error: Connection reset by peer]
09:30-!-ekangmonyet [~ekangmony@202.151.229.112] has joined #openttd
09:30-!-ekangmonyet is "Ekang Monyet" on #openttd
09:30<Samu>it would require someone fiddling with the RunTileLoop, to expose it visually
09:30<Samu>pause it
09:31<Samu>don't run RunTileLoop to expose something nobody in a real game would ever notice
09:34<Samu>im just trying to be consistent
09:35<TrueBrain>ugh ... while trying to work on an open PR, I found an old PR, that is just a combination of wtf and huh and oef, this and that is forgotten ... down the rabbit hole we go!!!
09:37<Xaroth>bring a ladder, or a rope.
09:37<Xaroth>... or both.
09:39<Eddi|zuHause>a ladder on a rope?
09:39<Eddi|zuHause>or a rope-ladder?
09:45<Samu>funny! I just exposed an inconsisency in ConvertGroundTilesIntoWaterTiles()
09:45<Samu>but it requires to have RunTileLoop not to run to actually visualize it
09:46<Samu>or someone with a very big screen resolution and a very slow system at the same time
09:46<Samu>to see it happen before RunTileLoop takes action
09:49-!-frosch123 [~frosch@00013ce7.user.oftc.net] has joined #openttd
09:49-!-frosch123 is "frosch" on #openttd
09:49<Samu>This is what ConvertGroundTilesIntoWaterTiles do if RunTileLoop never happens: https://i.imgur.com/hcuvhBH.png
09:50<Samu>it already makes shores of those tiles adjacent to void tiles
09:50<Samu>and this is in master!
09:50<Samu>not related to my PR
09:53<@orudge>[14:23:54] <TrueBrain> https://partner.steamgames.com/ <- just leaving that URL here ....... :D <-- have applied for a bank account, so once that's in place...
09:53<@orudge>Also started the Apple application process
09:53<Samu>openttd is going to steam?
09:53<@orudge>Potentially
09:53<@orudge>If they'll have us :P
09:53<TrueBrain>orudge: guess we should see if the Apple cert works for Windows first, and otherwise pick an OV :D
09:53<Samu>that's gonna be mayhem
09:53<@orudge>TrueBrain: I don't think it will
09:53<@orudge>I think we'll need to do it separately
09:54<@orudge>Will wait and see
09:54<@orudge>but pretty sure it works differently :)
09:54<TrueBrain>it should be a real certificate etc
09:54<TrueBrain>you can do it the other way around
09:54<TrueBrain>use a third-party code signing certificate, manual says
09:54<TrueBrain>not sure for what
09:54<@orudge>Ah
09:54<TrueBrain>as that is .. unclear
09:54<@orudge>well, will see what happens!
09:54<TrueBrain>if that is for developers build only
09:55<TrueBrain>but indeed ... one step at the time :)
09:58<TrueBrain>so ... I load a game, I go to console, I type: newgame, I open console, I type: restart
09:58<TrueBrain>what do you expect that happens?
09:58<TrueBrain>:D
10:01<@DorpsGek>[OpenTTD/OpenTTD] hpiirai commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLpWw
10:02-!-_2TallTyler [~oftc-webi@151.203.115.35] has joined #openttd
10:02-!-_2TallTyler is "OFTC WebIRC Client" on #openttd
10:03<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLpWX
10:03<@DorpsGek>[OpenTTD/OpenTTD] LordAro approved pull request #8516: Fix #7972: show invalid orders to stations that don't accept your vehicle https://git.io/JLpWM
10:04<TrueBrain>"assuming no issues with PUSH/POP_COLOUR with eints/whatever" <- good question, we just blame frosch123 if there are :P
10:04<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed issue #7972: Impossible/invalid orders aren't marked as such in the order list https://git.io/JvGub
10:04<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8516: Fix #7972: show invalid orders to stations that don't accept your vehicle https://git.io/JLxcf
10:05<@DorpsGek>[OpenTTD/OpenTTD] LordAro approved pull request #8169: Fix #8153: Report autoreplace failure when new vehicle cannot carry the cargo https://git.io/JLpWQ
10:05<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed issue #8153: Autoreplace does not report failures due to refittability https://git.io/Jf0oB
10:05<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8169: Fix #8153: Report autoreplace failure when new vehicle cannot carry the cargo https://git.io/JfVAv
10:06<TrueBrain>LordAro: tnx for the reviews, much appreciated :)
10:08-!-tokai|noir [~tokai@00012860.user.oftc.net] has joined #openttd
10:08-!-tokai|noir is "Christian Rosentreter" on #openttd
10:08-!-mode/#openttd [+v tokai|noir] by ChanServ
10:11<TrueBrain>okay, the "restart" command is rather broken :) Time to fix it :P
10:11<@DorpsGek>[OpenTTD/OpenTTD] hpiirai commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLplv
10:11<TrueBrain>I honestly can live without people being able to abuse the game in that way for these edge-cases; but that is just me :)
10:15-!-tokai [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
10:16<@DorpsGek>[OpenTTD/OpenTTD] 2TallTyler commented on pull request #8473: Add: Towns can build tunnels https://git.io/JLpl3
10:18<@DorpsGek>[OpenTTD/OpenTTD] LordAro commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLplC
10:18<@DorpsGek>[OpenTTD/OpenTTD] LordAro commented on pull request #8473: Add: Towns can build tunnels https://git.io/JLpl8
10:19<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLpl4
10:19<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLplB
10:23<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLplr
10:24<TrueBrain>frosch123: it seems my copy/paste really is terrible .. aggghh :P
10:25<frosch123>copy/paste is always terrible, not just yours
10:25<TrueBrain>happy you are as sharp as you are in this review :)
10:25<frosch123>i deny your patent request on terrible copy&paste
10:26<TrueBrain>haha :D
10:26<TrueBrain>I can also just set the tooltip, and stay away from the widget_data
10:26<TrueBrain>I was using the wrapper functions, but SetupRoadToolbar is neither
10:27<frosch123>add another wrapper function?
10:27<frosch123>no idea
10:27<TrueBrain>sounds good to me
10:27<frosch123>but not reassigning the sprite when it does not change anyway, sounds smart :)
10:30<frosch123>did someone figure out that bananas complaint?
10:30<TrueBrain>owh, someone finally emailed?
10:30<TrueBrain>I already was told it should come :P
10:30<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLx6I
10:30<frosch123>yes, but i don't want to read up the drama, in case someone else already did :)
10:31<TrueBrain>yeah .. I know what is going on ... not sure yet what we should do .. it is all .. childish, at best
10:32<TrueBrain>basically, someone took GPLv2 and CC-BY graphics, repacked it, and published it on BaNaNaS
10:32<TrueBrain>under a single license
10:32<TrueBrain>so we can take this down, but he is just going to upload it as 2 packages
10:32<TrueBrain>not sure what we can really do about that, honestly ..
10:32<TrueBrain>I will make a short write-up soon, as I guess this is not just going away
10:33-!-rptr_ [~rptr@2a00:801:236:570e:b1f2:acf6:e570:218d] has joined #openttd
10:33-!-rptr_ is "rptr" on #openttd
10:34<@DorpsGek>[OpenTTD/OpenTTD] 2TallTyler commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLp8f
10:35-!-iSoSyS [~iSoSyS@ff2-84-90-95-208.netvisao.pt] has joined #openttd
10:35-!-iSoSyS is "realname" on #/r/openttd #openttd
10:36-!-rptr_ [~rptr@2a00:801:236:570e:b1f2:acf6:e570:218d] has quit []
10:41<@DorpsGek>[OpenTTD/OpenTTD] frosch123 approved pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLp82
10:43<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #8527: Fix a bug in "restart" and introduce "reload" console command https://git.io/JLp8M
10:43-!-jottyfan [~Thunderbi@x4dbfd142.dyn.telefonica.de] has joined #openttd
10:43-!-jottyfan is "jottyfan" on #openttd
10:43<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed issue #8055: Road Construction UI unavailable https://git.io/Jvbvc
10:43<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLx6I
10:44<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed pull request #8063: Fix #8055: Always allow building any available roadtypes, even if there are no road vehicles available https://git.io/JvNRF
10:44<TrueBrain>down to 11 open things in the milestone :D
10:44<Eddi|zuHause>that might be my fault
10:45<TrueBrain>I might have been a bit rant-ish in #8527, but boyyyy ...
10:45<TrueBrain>the argumentation in #7328 was just flawed
10:46<TrueBrain>Eddi|zuHause: what did you do? :)
10:46<Eddi|zuHause>i didn't finish #7000 :)
10:47<frosch123>i'll do that
10:47<frosch123>it's less work to do it myself
10:47<Eddi|zuHause>you sound mad when you say that
10:48<@DorpsGek>[OpenTTD/OpenTTD] James103 commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLp8h
10:48<frosch123>no, it's a dilbert reaction in this case, not an alice one
10:48<Eddi|zuHause>i'm not that familiar with those characters
10:50<andythenorth>dogbert ftw!
10:50*andythenorth coffee
10:53<@DorpsGek>[OpenTTD/OpenTTD] 2TallTyler updated pull request #8473: Add: Towns can build tunnels https://git.io/JL7cV
10:54<andythenorth>JGR should get an award for patience
10:54<andythenorth>in our annual awards
10:54<@DorpsGek>[OpenTTD/OpenTTD] 2TallTyler updated pull request #8473: Add: Towns can build tunnels https://git.io/JL7cV
10:54<andythenorth>also potentially JGR should be a sub-forum, not just a thread
10:55<_2TallTyler>Agreed, but JGR might want to make that decision as it could add more threads to monitor and reply to
10:57<@orudge>If he wants one, he can have one; I suspect it would be busy enough
10:58<TrueBrain>JGR: do you want one?
10:58<TrueBrain>(bah, the summoning powers are low today :P)
10:58<@DorpsGek>[OpenTTD/OpenTTD] orudge updated pull request #8340: Draft: Feature: Create Universal (x86_64 + Apple Silicon) build on macOS https://git.io/JkqLt
11:01-!-Progman [~progman@p548d93b8.dip0.t-ipconnect.de] has joined #openttd
11:01-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttd
11:07<@DorpsGek>[OpenTTD/OpenTTD] SamuXarick commented on pull request #8517: Codechange: Make void tiles flood edge tiles, instead of edge tiles flooding themselves https://git.io/JLp4F
11:09<Samu>i think i'm overexplaining
11:09<Samu>i derail my own PR's
11:10<@orudge>TrueBrain: btw, reading some of the documentation on Steam, I think publishing OpenTTD on Steam itself ought to be fine, but integrating it with SteamWorks (for things like friends lists, achievements, etc) might be more problematic with regards to the GPL. I suspect initially at least we wouldn't be wanting to do any of that anyway.
11:10<@orudge>We'd probably have to create some kind of dynamic interface on the OpenTTD side to load the Steam DLLs without directly linking to them, not quite sure.
11:11<TrueBrain>I did not plan on integrating with SteamWorks, personally :)
11:11<_2TallTyler>Steam achievements would be so fun to brainstorm though :P
11:11<TrueBrain>but the publishing was what I was hoping for :)
11:12<TrueBrain>from what I understand, we can even publish it via "OpenTTD", as long as there is a company behind it that is registered somewhere in the world
11:12<TrueBrain>and from what I understand, it is completely free to do so if your game is free too
11:12<@orudge>Yes
11:13<@orudge>The next fun thing (though I don't fancy it myself at this time) would be to trademark OpenTTD and get the imposter removed/renamed on the MS Store...
11:13<+glx>Samu: but RunTileLoop() should always run
11:13<@orudge>Could prove expensive though
11:13<TrueBrain>yeah ...
11:13<+glx>you're finding non issues I think Samu
11:13<TrueBrain>anyway, integrating with Steam is a different subject and problem, indeed :)
11:13<TrueBrain>but mostly, I am not sure that is a direction we want to go to, integrate with platforms
11:14<TrueBrain>sounds annoying to maintain :P
11:14<TrueBrain>(ignoring possible license issues)
11:15<+glx>Samu: but you may have found the real location for a fix :)
11:18-!-_dp_ [~dP@78.24.222.213] has quit [Remote host closed the connection]
11:18<Samu>maybe it's nothing, but it could affect town placement logic or industry placement logic, not really sure if it matters that much
11:19-!-Flygon [~Flygon@2001:44b8:411e:4e00:7c19:9cf4:ce5c:9d72] has quit [Quit: A toaster's basically a soldering iron designed to toast bread]
11:19<Samu>which happen still before the run tile loop
11:19<milek7>huh, steam publishing is free?
11:19<milek7>last time they charged 100$
11:20<@orudge>Yes, there's a $100 charge to sign up it seems
11:21<milek7>and you have to fill US tax forms even if you game is free
11:21<milek7>this is silly..
11:21<@orudge>Need to wait for the bank account to be set up anyway
11:23<@DorpsGek>[OpenTTD/OpenTTD] 2TallTyler commented on pull request #8473: Add: Towns can build tunnels https://git.io/JLpB6
11:23<+glx>Samu: I think you just confirmed the issue is in TileLoop_Clear() ;)
11:25<@DorpsGek>[OpenTTD/OpenTTD] orudge commented on pull request #8340: Feature: Add support for Apple Silicon (ARM64) build on macOS https://git.io/JLpBy
11:27<@DorpsGek>[OpenTTD/OpenTTD] orudge updated pull request #8340: Feature: Add support for Apple Silicon (ARM64) build on macOS https://git.io/JkqLt
11:33-!-Tirili [~Tirili@2a02:8108:96bf:8438:260:6eff:fe42:7728] has joined #openttd
11:33-!-Tirili is "realname" on #openttd
11:34<frosch123>TrueBrain: surprise. today content download fails for me
11:34<TrueBrain>hmm
11:35<LordAro>working here
11:35<LordAro>but you probably knew that
11:35<frosch123>-d net=7 says, it tries via ipv6
11:35<frosch123>dbg: [net] Connecting to [content.openttd.org]:3978 (IPv6)
11:35<frosch123>dbg: [net] [tcp] could not connect IPv6 socket: Connection timed out
11:36<TrueBrain>works over IPv6 for me
11:36<TrueBrain>dbg: [net] Connecting to [content.openttd.org]:3978 (IPv6)
11:36<TrueBrain>dbg: [net] [tcp] connected to [2a05:d014:870:d200:f298:e9f2:759:5cd4]:3978 (IPv6)
11:36<+glx>I can try here too
11:36<milek7>works for me too
11:37<TrueBrain>but .. IPv6 is still IPv6 :P
11:37<+glx>some days my ipv6 can't route outside ISP, but today should be good
11:38<frosch123>interesting. it tried ipv6 twice, both failed. then it tried ipv4. connection succeeded but it does not show a list either
11:39<TrueBrain>does https://content.openttd.org/ work?
11:39<TrueBrain>does it work from https://preview.openttd.org/pr8386/ ?
11:40<+glx>first link shows empty page
11:40<TrueBrain>yup
11:40-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:2525:1782:292d:cbe5] has quit [Ping timeout: 480 seconds]
11:41<frosch123>curl -4 gives 200, curl -6 times out
11:41<frosch123>so, i think the main bug is that ottd's fallback to ipv4 works only partially
11:42<TrueBrain>and your IPv6 to AWS is acting up, which is also not good
11:42<TrueBrain>can you reach https://www.openttd.org ?
11:42<TrueBrain>(hosted on a different segment within AWS)
11:42<TrueBrain>over IPv6, ofc
11:43<frosch123>yeah, also fails over ipv6, so my ipv6 is just broken :)
11:43<TrueBrain>k :)
11:43<TrueBrain>so a bug for OpenTTD client!
11:43<frosch123>and ottd's fallback
11:43-!-Tirili [~Tirili@2a02:8108:96bf:8438:260:6eff:fe42:7728] has quit [Quit: Leaving]
11:45<TrueBrain>hmm .. can you on the forum see what someone edited in his post?
11:47<andythenorth>let's have a digressions into fun :) https://en.wikipedia.org/wiki/Tech_Model_Railroad_Club
11:48<@orudge>I don't think so, TrueBrain
11:48<TrueBrain>owh, I just dno't have powers in this subforum
11:49<TrueBrain>even with powers, I cannot find that :P
11:49<andythenorth>http://henryjenkins.org/blog/2007/10/spacewars_and_beyond_how_the_t.html
11:49<TrueBrain>I want to know if someone ninja-edited something :)
11:50<frosch123>usually it says "edited last"
11:50<frosch123>so you have at least a date
11:53<@orudge>Right, hopefully the bank account will get set up on or by Monday, and Apple will have verified that the company exists, then we can look at moving forward
11:53<@orudge>Have a good weekend all :)
11:53<TrueBrain>you too!
11:54<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #8340: Feature: Add support for Apple Silicon (ARM64) build on macOS https://git.io/JLp0I
11:54<_2TallTyler>TrueBrain: I found a bug in the code I added in #8401 related to checking the direction of drive-through road stations. Would you prefer I fix it in #8473 or open a new PR?
11:55<LordAro>_2TallTyler: new PR please
11:58<@DorpsGek>[OpenTTD/OpenTTD] orudge merged pull request #8340: Feature: Add support for Apple Silicon (ARM64) build on macOS https://git.io/JkqLt
11:58<LordAro>\o/
11:59<_2TallTyler>OK, in that case #8473 is ready for review again.
12:01-!-Gustavo6046 [~Gustavo60@189.6.235.203] has quit [Quit: ZNC 1.7.5 - https://znc.in]
12:09<TrueBrain>cool; will give it a looksie soon :) Tnx!
12:09<TrueBrain>orudge: owh, we shouldn't forget "website" PR :P
12:10<TrueBrain>well, you said already bye, guess I can do that real quick :)
12:11<Samu>road tunnels
12:11<Samu>town road tunnels
12:12-!-Gustavo6046 [~Gustavo60@189.6.235.203] has joined #openttd
12:12-!-Gustavo6046 is "Gustavo Rehermann <rehermann6046@gmail.com>" on #openttd #llvm
12:13<Samu>so max and min have changed?
12:13<Samu>interesting
12:13<@DorpsGek>[OpenTTD/website] TrueBrain opened pull request #180: Add: description for MacOS arm64 binaries https://git.io/JLpEC
12:13<+glx>not a real change
12:13-!-Progman [~progman@p548d93b8.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
12:14<TrueBrain>if anyone has a better way of describing intel vs silicon, I am all ears :)
12:14<@DorpsGek>[OpenTTD/website] LordAro approved pull request #180: Add: description for MacOS arm64 binaries https://git.io/JLpE4
12:14<LordAro>seems good to me
12:14<TrueBrain>that was .. scary quick
12:14<LordAro>a whole 25s
12:17<TrueBrain>well, 1 drama dealt with .. hopefully
12:17<TrueBrain>we do need to setup a licensing-course or something :D
12:17<TrueBrain>we are the first students :P
12:18<@DorpsGek>[OpenTTD/website] TrueBrain merged pull request #180: Add: description for MacOS arm64 binaries https://git.io/JLpEC
12:18<@DorpsGek>[OpenTTD/website] TrueBrain created new tag: 1.4.9 https://git.io/JLpED
12:20<andythenorth>"please complete this 10 credit video learning course to get a bananas upload account" :P
12:20<andythenorth>oof
12:20<LordAro>:D
12:20<_2TallTyler>Need some Git help: my fix to #8401 is based on my new tunnel commits, since I renamed several things within the function. Should I rebase off master somehow? How does that work when two PRs rename the same thing? https://github.com/2TallTyler/OpenTTD/tree/road_station_direction_fix
12:21<andythenorth>anyway, shall we reply on behalf of JGR? :P https://www.tt-forums.net/viewtopic.php?p=1240265#p1240265
12:21<TrueBrain>_2TallTyler: I would just wait a few minutes if I were you :)
12:21<_2TallTyler>I think some basic education about licenses is a perfectly fair prerequisite to using Bananas
12:25<TrueBrain>like we really know what we are doing when it comes to licenses :P
12:25<frosch123>got content download to work
12:26<frosch123>it's a really stupid bug :p
12:26<andythenorth>hmm are we upstream or downstream of JGR now?
12:26*andythenorth is moderately confused :P
12:27<frosch123>ottd tries all ip-connection candidates sequentially, so if there are 3 and only the last one works, it takes 2 timeouts until the 3rd one is tried
12:27<TrueBrain>lol
12:27<frosch123>on successful connection ottd calls ClientNetworkContentSocketHandler::SendReceive() to actually send the packets
12:28<frosch123>however, the first thing it does, it checks for some inactivity timeout, and closes the connection
12:28<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #8473: Add: Towns can build tunnels https://git.io/JLpuO
12:28<TrueBrain>serious nice work _2TallTyler
12:28<LordAro>^
12:28<TrueBrain>also with the feedback; thank you
12:28<frosch123>so, if resolving the addresses takes longer than a minute, it never sends stuff
12:28<@orudge>TrueBrain: not at my PC now to submit a PR, but the macOS builds are for 10.9+. For arm64 it's 11+ though because that's the only macOS version available obviously on that platform.
12:29<TrueBrain>so I just added a lie :'(
12:29<_2TallTyler>Thank you! :)
12:29<TrueBrain>is it 11.0 orudge ? Or just 11?
12:29<@orudge>Just 11, I think next year's macOS will be 12
12:30<Samu>im looking at #7822, and... indeed it can get quite confusing what I'm talking about, coming from nowhere. Now that a year has passed, I can see where the confusion comes from
12:30<TrueBrain> description: MacOS 11+ (Apple Silicon, arm64)
12:30<TrueBrain>description: MacOS 10.9+ (Intel, x86_64)
12:30<@orudge>10.9 for x86_64 though
12:30<LordAro>OSXI
12:30<@orudge>Yep
12:30<Samu>i edited a bit to point to things
12:30<@orudge>Thanks
12:32<@DorpsGek>[OpenTTD/website] TrueBrain opened pull request #181: Fix: update the MacOS binary descriptions to reflect reality https://git.io/JLpul
12:32<TrueBrain>lets see how many seconds LordAro needs this time
12:32<@DorpsGek>[OpenTTD/website] LordAro approved pull request #181: Fix: update the MacOS binary descriptions to reflect reality https://git.io/JLpuR
12:32<LordAro>i wasn't ready!
12:32<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8473: Add: Towns can build tunnels https://git.io/JL7cV
12:33<LordAro>my fault for approving the first one, really
12:33<Samu>wow towns can build tunnels, which means... I need to update terraforming again
12:33<LordAro>i know that arm64 is MacOS 11 only :p
12:34<Samu>because tunnels terraform
12:34<TrueBrain>I know that too ... yet ... I wrote the nonsense :D
12:34<@DorpsGek>[OpenTTD/OpenTTD] SamuXarick updated pull request #7822: Fix #7670: Cache the origin tile to prevent recurring calls to the road pathfinder when a vehicle is blocked by another https://git.io/JegbJ
12:35<TrueBrain>LordAro: so now your scroll-PR needs some fixing :P
12:35<LordAro>yup
12:35<LordAro>half of the casts can be removed, for instance :p
12:35<TrueBrain>\o/
12:35<TrueBrain>I am really curious about that one statement
12:35<TrueBrain>took me a good 30 minutes to work out what the old code did
12:35<TrueBrain>what the new one did
12:35<TrueBrain>and why I think it is wrong :P
12:36<LordAro>(half of the trouble was GetPosition() returning an int, but it being compared against a size_type
12:36<TrueBrain>damn, that was difficult :D
12:36<LordAro>)
12:36<LordAro>hehe
12:36<@DorpsGek>[OpenTTD/website] TrueBrain merged pull request #181: Fix: update the MacOS binary descriptions to reflect reality https://git.io/JLpul
12:36<@DorpsGek>[OpenTTD/website] TrueBrain created new tag: 1.4.10 https://git.io/JLpuH
12:40<@DorpsGek>[OpenTTD/OpenTTD] 2TallTyler opened pull request #8528: Fix #8401: Drive-thru road stations can be connected at either end https://git.io/JLpze
12:40-!-Wormnest [~Wormnest@35.136.189.95] has joined #openttd
12:40-!-Wormnest is "Wormnest" on #openttd
12:40<frosch123>ottd needs asyncio :/
12:40<TrueBrain>_2TallTyler: are you now subtle pointing out we failed in reviewing your work? :P :P
12:40<TrueBrain>frosch123: yes
12:40<TrueBrain>does that exist for C++?
12:41<frosch123>it's in boost, and it's on the roadmap for c++23
12:41<TrueBrain>ugh, I cannot wait that long
12:41<frosch123>but it was already on the roadmap for c++20, so who knows
12:41<_2TallTyler>Maybe, but also that my test savegame should have checked all four orientations of road stations
12:41<frosch123>TrueBrain: if you are fine with boost. i have used that stuff before :)
12:42<LordAro>nooo
12:42<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #8528: Fix #8401: Drive-thru road stations can be connected at either end https://git.io/JLpzG
12:42<TrueBrain>well, I just know network code looks a lot better when using asyncio
12:42<TrueBrain>as in, you can almost make it somewhat readable with it
12:42<frosch123>downloading 5 things from bananas, waiting 5 times for a >1 minute timeout :p
12:43<frosch123>but at least it succeeds now
12:44<Samu>_2TallTyler, CommandFlagsToDCFlags(GetCommandFlags(CMD_BUILD_TUNNEL)) doesn't used DC_NO_WATER, let's see what could go wrong, brb
12:44<Samu>doesn't useP
12:44<Samu>use*
12:45-!-rptr_ [~rptr@2a00:801:236:570e:b1f2:acf6:e570:218d] has joined #openttd
12:45-!-rptr_ is "rptr" on #openttd
12:45<milek7>TrueBrain: I hope you aren't talking about asio?
12:45<milek7>that stuff is not readable at all imo :P
12:45<TrueBrain>_2TallTyler: just wait till he finds out neither do bridges :D :D
12:46<_2TallTyler>Samu: It's currently possible to build tunnels which end on a coast slope. This is a legitimate bug but it's possible for players to do, so it's out of scope of my PR
12:47<_2TallTyler>https://snipboard.io/5l4zwg.jpg
12:47<Samu>exactly that
12:48<_2TallTyler>I'll let you fix that :)
12:48<Samu>also if the thing needs to terraform
12:49<Samu>yes, i am working on it
12:49<Samu>but i can't make new PR's so, whatever
12:49-!-rptr_ [~rptr@2a00:801:236:570e:b1f2:acf6:e570:218d] has quit []
12:49<TrueBrain>boy, this PR couldn't possibly have worked as intended ... hmmmmm
12:50<TrueBrain>another one for the list: revamp console
12:50<frosch123>TrueBrain: what is the proper term for the addresses that resolve returns, and which you then try to connect to? connect-candidates?
12:51<TrueBrain>addresses :P
12:51<frosch123>meh
12:51<TrueBrain>isn't an address always a candidate, you can wonder :)
12:52<TrueBrain>possible-addresses and worked-last-time-addresses ? :)
12:52-!-jottyfan [~Thunderbi@x4dbfd142.dyn.telefonica.de] has quit [Quit: jottyfan]
12:52<TrueBrain>well, I guess you can call them "resolved addresses"
12:52<TrueBrain>as not every address can resolve
12:52<TrueBrain>and not every resolve address you can connect to
12:55<Samu>i got a crash, clicked build road in scenario editor
12:55<Samu>latest master
12:56<TrueBrain>_2TallTyler: one minor thing in your PR: we don't fix PRs, we fix commits. So I just changed your commit message ever so slightly :)
12:56<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8528: Fix #8401: Drive-thru road stations can be connected at either end https://git.io/JLpze
12:56<Samu>TrueBrain,
12:57<TrueBrain>Samu
12:57<_2TallTyler>Aha, thank you
12:58<TrueBrain>no, thank you!
12:58<+glx>oh scenario editor, always forgotten when touching build toolbars
12:58<TrueBrain>nah, I tested it, so now I am annoyed :P
12:59<TrueBrain>ugh, always that last minute addition
12:59<+glx>the not tested one ;)
12:59<_2TallTyler>Now to try my hand at fixing #8506...
13:01<TrueBrain>just a weird reuse of code, basically :)
13:02<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #8529: Fix af22a4f2: scenario editor doesn't have build station/depot/etc https://git.io/JLpg6
13:03<Samu>you work fast
13:04<+glx>knowing the cause it's easy to fix :)
13:04<TrueBrain>most time I spend on starting gdb
13:04<TrueBrain>it takes for ever to load symbols
13:05<+glx>oh same for water
13:05<+glx>(just tested)
13:05<TrueBrain>there is a reason that part is also in the PR, yes :)
13:06<TrueBrain>doubting my fixing skills, pfft :P
13:06<TrueBrain>glx: if you can add a comment explaining how slow-forward and fast-forward behaves in the hunderthtick PR, we can merge that too :D
13:06<+glx>where ? in OnHundredthTick() main comment ?
13:06<TrueBrain>dunno, find a nice place for it :)
13:07<TrueBrain>I agree with frosch123 's remark the other day that documenting what we expect it to do helps future-us :)
13:07<TrueBrain>otherwise in 2 years someone changes it back to a GUITimer again
13:07<TrueBrain>:D
13:07<TrueBrain>ping pong :P
13:08<TrueBrain>maybe even in the doxygen part of the callback
13:08<+glx>yeah that's where I was about to add it
13:08<TrueBrain>sounds good to me :)
13:10<@DorpsGek>[OpenTTD/OpenTTD] frosch123 opened pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpgA
13:10<frosch123>i hope someone squashes that, and enters a better commit message
13:10<TrueBrain>E_COMMIT_MESSAGE_TOO_LONG :P
13:10<TrueBrain>:D
13:11<frosch123>it's longer than the diff :)
13:12<LordAro>just split it into 2 lines and remove the "So "
13:13<@DorpsGek>[OpenTTD/OpenTTD] frosch123 updated pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpgA
13:13<TrueBrain>that comment confused me enough that I had to look in the code :D
13:14<TrueBrain>it has nothing to do with sending :P
13:14<frosch123>yeah, you would think so :p but it does
13:14<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLp2k
13:14<TrueBrain>well, if I understand the code: lastActivity keeps track when we last saw the other end doing anything
13:15<TrueBrain>and it closes the socket if that reaches a timeout
13:15<TrueBrain>so it is not only sending, also receiving :P
13:15<frosch123>the client has to send first
13:15<TrueBrain>the "now" was mostly what confused me btw :)
13:15<TrueBrain>like: is it otherwise going to wait?
13:16<TrueBrain>but it closes the connection :P
13:16<_2TallTyler>Question: Can a tile have more than one NRT roadtype? Or is the maximum one roadtype and one tramtype?
13:16<Samu>_2TallTyler, [img]https://i.imgur.com/IRef6j0.png[/img]
13:16<frosch123>the latter
13:16<Samu>tunnel issued a terraform command
13:18<Samu>let me test with DC_NO_WATER
13:18<_2TallTyler>Thanks frosch123
13:20<Samu>it was smarter! https://i.imgur.com/Q2ywb2Z.png
13:21<TrueBrain>frosch123: that lastActivity is a bit weird n general .. if I read this right, if you take more than 60 seconds to pick a download, it also resets the connection .. despite the connection still being valid and active
13:23<TrueBrain>anyway, I guess you can remove the assignment of lastActivity in Connect() with your patch, not?
13:23<TrueBrain>ugh, I should write in PRs
13:23<TrueBrain>how the hell do you add a comment in a line that is not changed ...
13:24<TrueBrain>you can't?! Lol
13:25<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpaT
13:26<@DorpsGek>[OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JLpaI
13:26<@DorpsGek> - Update: Translations from eints (by translators)
13:27<TrueBrain>this time of the schedule ... unbelievable :P It is getting worse and worse
13:30<frosch123>it's super weird. Connect() resets the timeout, even if it still connecting
13:30<frosch123>so by closing the gui at the right time
13:30<frosch123>you can elongate it indefinitely
13:32<frosch123>but yes, if i remove it from connect(), i am more confident in not adding a comment in OnConnect
13:32<frosch123>it looks more natural now
13:32<+glx>and git decided to do housekeeping while I was rebasing
13:33<@DorpsGek>[OpenTTD/OpenTTD] glx22 updated pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JvruE
13:33<+glx>I hope it's clear enough
13:35<milek7>I asked around on gcc irc
13:35<milek7>there is vague possibility that they will define __has_attribute(access) to 2 to indicate extra features
13:35<TrueBrain>frosch123: yeah, it seems the idea was to do it "on connected" not "on connect" :D
13:38-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has joined #openttd
13:38-!-Wolf01 is "Wolf01" on #openttd
13:40-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:2525:1782:292d:cbe5] has joined #openttd
13:40-!-DasPoseidon is "DasPoseidon" on #openttd
13:44<@DorpsGek>[OpenTTD/OpenTTD] frosch123 updated pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpgA
13:47<TrueBrain>https://github.com/OpenTTD/OpenTTD/pull/8529 <- can someone review this before 2000 pretty please? :D
13:48<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpVr
13:48<@DorpsGek>[OpenTTD/OpenTTD] glx22 approved pull request #8529: Fix af22a4f2: scenario editor doesn't have build station/depot/etc https://git.io/JLpVo
13:48<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8529: Fix af22a4f2: scenario editor doesn't have build station/depot/etc https://git.io/JLpg6
13:48<TrueBrain>tnx!
13:50<+glx>and now I reread previous commits and may have found an issue, need to check
13:51<TrueBrain>oh-oh :P
13:52<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JLpV7
13:53<@DorpsGek>[OpenTTD/OpenTTD] glx22 commented on pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JLpVA
13:53<+glx>dinner time
13:54<TrueBrain>enjoy!
13:54<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JLpwJ
13:55<Samu>dinner, afk
13:57<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JLpwt
13:57<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JLpwJ
13:58<TrueBrain>damn, you are sharp today frosch123 :)
13:58<frosch123>i stopped working early, it was too boring
13:59<TrueBrain>so you come to OpenTTD! :D
13:59<TrueBrain>sorry glx, it sounded like a good idea to move the code; I was wrong :)
14:02<frosch123>you can probably move the scheduledinvalidation stuff up
14:02<frosch123>it should be one of the first things to call. it's weird there is so much stuff in front of it
14:06<TrueBrain>hmm .. I can make functions 'static'
14:06<TrueBrain>I like doing that
14:08<milek7>so, did we discuss admin port?
14:09<milek7>whether it should be also migrated to pubkey auth?
14:09<TrueBrain>I believe we left it that you were going to see if we could find a library that also could be used by 3rd party?
14:10<milek7>hmm, yes
14:10<milek7>I'll check then
14:10<TrueBrain>if you wouldn't mind, that would be lovely :)
14:18-!-iSoSyS [~iSoSyS@ff2-84-90-95-208.netvisao.pt] has quit []
14:18<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #7286: Add #2155: newheightmapgame command https://git.io/JLprm
14:18<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed pull request #7286: Add #2155: newheightmapgame command https://git.io/fhNZl
14:18<TrueBrain>that took a long time to establish ... but okay, 2 years after creating the PR, at least I have an opinion :D
14:20<@DorpsGek>[OpenTTD/OpenTTD] michicc commented on pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JLprn
14:20<@DorpsGek>[OpenTTD/OpenTTD] frosch123 merged pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpgA
14:23<TrueBrain>yeah, tl;dr, console needs love :)
14:27<Heiki>“uudelleensovittaa” is the shortest Finnish translation of “refit” I can come up with for STR_ERROR_AUTOREPLACE_INCOMPATIBLE_REFIT, sometimes I wonder why this language can’t express some things more concisely
14:28<Heiki>real-life example, German vs. Finnish: http://vaunut.org/kuva/144773
14:28<TrueBrain>we used refit many more times; all instances are that long? :D
14:29<Heiki>no, in some context “sovittaa” is enough
14:29<Heiki>+s
14:29<TrueBrain>well, sucks to speak Finnish, I guess :P
14:29<TrueBrain>:D
14:30<Heiki>haha
14:30<TrueBrain>omg, someone uploaded a savegame in lzo format
14:30<TrueBrain>..... what in the world
14:30<milek7>where?
14:31<TrueBrain>more importantly, how am I going to compile support for that :D
14:31<Xaroth>Finnish has some fun words though
14:31<Xaroth>like Tietokone
14:32<TrueBrain>only funny to Dutch people, I guess? :P
14:32<Xaroth>well yes
14:32<TrueBrain>you are such a child :P
14:32<Xaroth>:D
14:34<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on issue #7619: Game crash from out-of-bounds helicopter, infinite circling with superfast aircraft https://git.io/fjz3Z
14:36<TrueBrain>okay, I cannot explain enough how cool that bug is
14:36<TrueBrain>I am not sure I can capture this on video even
14:38<@DorpsGek>[OpenTTD/OpenTTD] SamuXarick updated pull request #8492: Fix: Don't allow towns to terraform certain floodable tiles https://git.io/JLdA0
14:38<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on issue #7619: Game crash from out-of-bounds helicopter, infinite circling with superfast aircraft https://git.io/fjz3Z
14:42-!-gelignite [~gelignite@55d4d4cd.access.ecotel.net] has joined #openttd
14:42-!-gelignite is "realname" on #llvm #openttd
14:45<TrueBrain>so planes can go at such a fast speed, they miss their patterns or something ...
14:46<frosch123>don't they slow down in holding patterns?
14:46<TrueBrain>I think that movie gave you the answer :)
14:47<frosch123>SPEED_LIMIT_HOLD
14:47<frosch123>so either there is no holding position for that airport, or the speed limit does not work
14:47<TrueBrain>lets find out! :)
14:49<TrueBrain>no hold state reached
14:50<TrueBrain>seems the airport has no holding pattern
14:51<TrueBrain>now the question: should we still apply a speed limit when it goes in these circles?
14:51<@DorpsGek>[OpenTTD/OpenTTD] James103 commented on issue #7619: Game crash from out-of-bounds helicopter, infinite circling with superfast aircraft https://git.io/fjz3Z
14:52<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on issue #7619: Game crash from out-of-bounds helicopter, infinite circling with superfast aircraft https://git.io/fjz3Z
14:52<frosch123>only the original large airport has a holding pattern
14:53<frosch123>that's kind of funny
14:54<TrueBrain>lol, it was the one I tested to make sure my debugging was valid
14:54<TrueBrain>so what causes it to go in circles .. hmm
14:55<supermop_Home>really any aircraft going that fas should be recolored to the fire cycle colors
14:55<andythenorth>I love UIs designed by power users https://www.tt-forums.net/viewtopic.php?f=32&t=88329
14:56<frosch123>wow
14:56<TrueBrain>so when is that patch done? :D
14:57<TrueBrain>that content downloading window is 10 times better, but that isn't saying a lot :P
14:57<andythenorth>the ideas aren't awful
14:57<andythenorth>and the thought gone into it is high
14:57<andythenorth>it's not how I'd make a a simple interface
14:57<TrueBrain>damn, that Rich NewGRF window
14:58<TrueBrain>well, if he makes a design, I am pretty sure we can implement it, so .. there is that
14:58<andythenorth>pff, that's what we said last time :)
14:58<TrueBrain>we did? Hmm
14:59<andythenorth>nah I'm just moaning I drew multiple newgrf and game start windows
14:59<andythenorth>it was a long time ago
14:59<andythenorth>anyway, it's nice to have pictures instead of words
14:59<andythenorth>same for this also https://www.tt-forums.net/viewtopic.php?f=32&t=88255
15:00<TrueBrain>did he implement it already?!
15:00<TrueBrain>I assumed it was just art
15:00<TrueBrain>but that gif suggests it is ingame :P
15:00<andythenorth>it is extensive art
15:01<andythenorth>really detailed mockups
15:02*andythenorth still doesn't understand why authors don't just an extra vehicle ID for every variant
15:02<TrueBrain>it is amazing
15:03-!-J0anJosep [~J0anJosep@185.242.251.207-ip.operadors.cat] has quit [Quit: Konversation terminated!]
15:04<+michi_cc>TrueBrain: Laggin quite a bit in catching-up, but you know if we go back to Azure, we can get a cloud HSM: https://docs.microsoft.com/en-us/azure/key-vault/managed-hsm/overview
15:04<+michi_cc>Might not be free, tough :p
15:05<TrueBrain>michi_cc: I so read today yes :)
15:05<TrueBrain>it is pretty nice
15:05<TrueBrain>I even googled if GitHub has an interface with it
15:05<TrueBrain>couldn't find it :(
15:06<+michi_cc>TrueBrain: https://docs.microsoft.com/th-th/azure/key-vault/secrets/quick-create-github-secret
15:06<+michi_cc>Doesn't mention HSM though.
15:07<TrueBrain>owh, the other way around, did not check that :D
15:07<TrueBrain>well, over time, maybe worth a further look
15:07<TrueBrain>using HSM is .. better/easier? :D
15:11<TrueBrain>okay, the airplanes in the bug moves fast enough that it overshoots the point it changes in the state machine
15:12<TrueBrain>and that check is outside of the loop that moves the plane
15:12<TrueBrain>ghehe
15:13<frosch123>delete statemachines!
15:14<TrueBrain>the simple solution is a really expansive calculation ... :P
15:14<andythenorth>wat how does a state machine get out of state? :P
15:15<TrueBrain>at its peek, it does 72 moves
15:15<TrueBrain>how many pixels is a tile?
15:15<frosch123>16 world coordinates
15:15<TrueBrain>so it can move ..
15:15<TrueBrain>@calc 72 / 16
15:15<@DorpsGek>TrueBrain: 4.5
15:15<andythenorth>hmm can we just detect the condition, then increase the player's high score?
15:15<TrueBrain>tiles in 1 instant
15:15<andythenorth>like...this is rare no?
15:15<TrueBrain>happens with fast planes
15:16<TrueBrain>and if the distance is < 4, it is ... nudges, towards the airport, it seems
15:18<TrueBrain>so it depends on where the airport is located etc, how "unlucky" you get
15:18<TrueBrain>guess we need an universal speed cap :P
15:19<frosch123>if (!(amd.flag & AMED_EXACTPOS) && dist <= (amd.flag & AMED_SLOWTURN ? 8U : 4U)) return true; <- it can only warp so far
15:19<TrueBrain>that check is outside the while in that function
15:19<TrueBrain>that while does the real moving of the plane, and is called 70+ times
15:19<TrueBrain>instead of the normal 1 to 2 :P
15:20<frosch123>hmm, EXACTPOS is weird
15:20<frosch123>it is set for the airport entry
15:20<TrueBrain>there are already several safeguards to, in the end, make the plane go to the airport
15:20<TrueBrain>but .. it is not enough :D
15:22<TrueBrain>ah, and it circles as it tries to get to the entry point, overshoots, makes a turn, tries again
15:24<TrueBrain>I think I can force it into a holding state if it overshoot once
15:25<frosch123>can you do it by distance?
15:26<TrueBrain>normal planes, as in, not absurd planes done in NewGRF, never go fast enough for count > 1 :)
15:26<frosch123>slow down aircraft when near destination
15:27<TrueBrain>I see no reason why not
15:28<andythenorth>nerf newgrf
15:28<TrueBrain>well, I say that .. it does mean I overrule the airport layout
15:28<TrueBrain>as I force a holding pattern, basically
15:28<frosch123>none of them define one, except one
15:28<TrueBrain>okay
15:29<frosch123>and in utopia someone implemented modular airports, so no stupid statemachines
15:29<TrueBrain>so 6 tiles before an airport I make it slow to holding speed
15:30<frosch123>can it turn within 6 tiles? would be silly if it got further away again because it has to turn by 270° or so
15:31<TrueBrain>what do you mean, sorry?
15:31<TrueBrain>lol, 6 tiles isn't enough for this plane, omg .. eeuuhhhhhh
15:32<milek7>https://github.com/Xaroth/libottdadmin2/blob/master/libottdadmin2/packets/base.py#L220
15:32<milek7>wtf it does?
15:33<frosch123>TrueBrain: train approaches airport, gets within 6 tiles, slows down, state machine requiests to go in different direction, aircraft turns slowly, but while flying the arc it gets further away than 6 tiles again
15:33<TrueBrain>haha, yeah, that is possible
15:33<TrueBrain>I can set HOLD state on it
15:33<TrueBrain>that would prevent that
15:33<TrueBrain>but that means we are really overruling NewGRFs :)
15:34<Xaroth>milek7: it combines all data to be sent into one output buffer
15:34<frosch123>TrueBrain: those statemachines are not in newgrf
15:34<@DorpsGek>[OpenTTD/OpenTTD] SamuXarick updated pull request #8404: Feature: Snow line height can be autodetermined upon world generation https://git.io/JLa2N
15:34<TrueBrain>frosch123: NewGRFs cannot define holding patterns?
15:34<Xaroth>milek7: constantly constructing/packing/unpacking structs can get slow, so we build one big struct, construct it once, then pack/unpack with the current data that needs packing/unpacking.
15:34<frosch123>newgrf can define look&feel of airports. but there are only the fixed state machines from airport_movement.h
15:35<TrueBrain>ah .. did not know
15:35<TrueBrain>explains why someone was talking about NewGRF airports :P
15:35<TrueBrain>euh, yes, that changes things a bit
15:35<frosch123>newgrf airports were not finished. and then people noticed that they were the wrong idea anyway
15:36<frosch123>playing with airports is boring, because you can only choose from a fixed set. newgrf airports add a game "design an airport". which is fun, but it is added for newgrf authors, nor for players :p
15:36<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on issue #7619: Game crash from out-of-bounds helicopter, infinite circling with superfast aircraft https://git.io/fjz3Z
15:37<TrueBrain>design your own airport as player .. now that is an idea :P
15:37<+michi_cc>NewGRF statemachine airports don't really add that much. IMHO modular airports are the way to go (no, I'm not volunteering).
15:37<frosch123>there are like 3 partial implementations of that
15:38<TrueBrain>would be really fun, if you put down your own runways etc
15:38<TrueBrain>means I can make Schiphol :D
15:38<TrueBrain>(it has an insane layout)
15:38<frosch123>funnily modular airports also fix the broken airport catchment area and noise mechanics
15:38<frosch123>only terminals would have catchment, and only runways would have noise
15:38<TrueBrain>so, another thing that needs revamping
15:39<TrueBrain>my list is getting big :P
15:39<andythenorth>airport taxiways over bridges or go home
15:39<+michi_cc>But if I would do that, I think I would try mapping aircraft movement like trains, i.e. airport tiles have trackbits, "signals", and movement is PBS based.
15:39<frosch123>so, if your planes "drive" far enough ... you can use them as bus shuttle service
15:39<Xaroth>airport taxiways over roads or go home
15:39<Xaroth>otherwise TrueBrain can't make his Schiphol recreation.
15:39<andythenorth>same thing :P Xaroth
15:39<andythenorth>I was thinking of one of the Paris ones
15:39<andythenorth>Orly or CDG, can't remember
15:39<milek7>Xaroth: if "combines all data to be sent into one output" I would expect to be called at the end
15:39<TrueBrain>another type of "road" .. taxiways
15:39<milek7>but it's called in write_str
15:39<andythenorth>I flew London -> Paris once, more time taxiing in Paris than flying
15:40<frosch123>michi_cc: TrueBrain: https://www.tt-forums.net/viewtopic.php?t=38709 <- someone tested that aircraft pbs thingie by writing a prototype minigame in java
15:40<andythenorth>TrueBrain it's simple really, planes just reimplement as hovercraft
15:40<frosch123>can't remember how good it was
15:40<andythenorth>hovercraft need altitude
15:40<TrueBrain>it is a really fun idea, modular airports (for players)
15:40<Xaroth>milek7: write_str forces the data before the string to be packed, then appends the string
15:41<Xaroth>because python structs don't do strings the way ottd likes to receive it
15:41<Xaroth>so at that point the data before write_str becomes a struct/pack and the data after another one.
15:41<TrueBrain>okay, and planes are never in a holding state .. the state machine target can have that flag .. hmmm
15:42<milek7>Xaroth: so _write_process should be called before every _buffer modification?
15:43<Xaroth>pretty much, yes
15:43<Xaroth>it's a noop if nothing needs to be done
15:43<milek7>ok, thanks
15:43<Xaroth>What are you trying to do?
15:44<milek7>sending raw bytes
15:44-!-jottyfan [~Thunderbi@x4dbfd142.dyn.telefonica.de] has joined #openttd
15:44-!-jottyfan is "jottyfan" on #openttd
15:44<milek7>containing pubkey and signature
15:44-!-jottyfan [~Thunderbi@x4dbfd142.dyn.telefonica.de] has quit []
15:44<Xaroth>fun
15:45<Xaroth>let me know what you've made of it :)
15:45<frosch123>aw, it does not work. so much for java
15:46<milek7>oh
15:46<milek7>does write_byte can already accept many bytes?
15:47<Xaroth>yes, but it's not made for a gazillion bytes
15:47<Xaroth>https://docs.python.org/3/library/struct.html < that's what it uses internally
15:48<Xaroth>write_byte uses B
15:48<Xaroth>so you might want to add something that uses 's'
15:49<milek7>I guess appending bytearray to _buffer and increasing _index would work too?
15:50<Xaroth>if you preface\ it with _write_process, yes
15:50<TrueBrain>meh; making the plane slow down is easy .. to keep it slowed down till it landed, hard ..
15:53<TrueBrain>owh, I was thinking dist was in tiles, but it is in subtiles, or what-ever we call them
15:53<Samu>may I suggest a min snowline height of 3?
15:53<Samu>change MIN_SNOWLINE_HEIGHT to 3
15:54<Samu>then my PR can go to dust
15:55<Samu>but farms fail to generate at that height
15:55<Samu>fail at height 2
15:56<Samu>your PR handles forests
15:56<Samu>kinda
15:56<Samu>unless i'm stupid and set a snowline height higher than the max height
15:57<TrueBrain>https://www.youtube.com/watch?v=zpMZcQ1lGWU
15:57<TrueBrain>Replace Dancing with Talking, and that is what is my head atm
15:58<Samu>your commit, since now it's on master
15:59<Samu>https://github.com/OpenTTD/OpenTTD/commit/7463c46a54bed2d21ee8e8e2e8cfe9d67f5f45dc
16:00-!-ekangmonyet [~ekangmony@202.151.229.112] has quit [Ping timeout: 480 seconds]
16:00<Samu>nevermind, I fail at explaining
16:00-!-ekangmonyet [~ekangmony@202.151.229.112] has joined #openttd
16:00-!-ekangmonyet is "Ekang Monyet" on #openttd
16:00<frosch123>that's why we have no voice chat
16:01<TrueBrain>wait, you were explaining something? Sorry, I thought you were mumbling in yourself :) That we were just a rubber ducky
16:01<TrueBrain>it is how andythenorth and I get through the day
16:01<TrueBrain>pretty normal for this channel :)
16:01<andythenorth>sometimes people even reply
16:02<Samu>I think I rather close my PR. Doesn't seem useful anymore
16:06<TrueBrain>must .. not .. touch .. other .. parts of this code
16:06<TrueBrain>"speed" is signed
16:06<TrueBrain>like ... can a plane go backwards?! (it cannot)
16:06<_2TallTyler>That would be a problem, I think
16:06<andythenorth>wait wat?
16:06<andythenorth>helicopter backwards is needed
16:07*andythenorth cancels plane grf idea :(
16:12<@DorpsGek>[OpenTTD/OpenTTD] glx22 updated pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JvruE
16:14-!-rptr_ [~rptr@2a00:801:236:570e:b1f2:acf6:e570:218d] has joined #openttd
16:14-!-rptr_ is "rptr" on #openttd
16:16<+glx>andythenorth: CDG goes over the highway
16:17<andythenorth>airway bridges then
16:17<andythenorth>but only on French maps
16:21<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #8531: Fix #7619: nudge fast planes sooner towards their target https://git.io/JLp1e
16:21<TrueBrain>I think this is a clean solution :)
16:23<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #8532: Fix 85a49a0d: invalidate airport toolbar when new planes become available https://git.io/JLp1k
16:24<TrueBrain>https://github.com/OpenTTD/OpenTTD/issues/8121 <- tempted to close with: not-a-bug. Did I miss anything? :)
16:27<+glx>hmm yeah weird behaviour but intended
16:28<TrueBrain>the 3rd tile of a dock is just a really odd requirement ..
16:28<frosch123>yay, tb is removing c89 stuff
16:28<+glx>it's to make sure a boat can dock I think, but now we have more docking tiles
16:29<TrueBrain>frosch123: I knew that would make you happy :D
16:29<TrueBrain>I also made it into an unsigned int, but that was a world of hurt .. lot of that code is still signed, for no reason what-so-ever besides being signed
16:29<TrueBrain>+almost
16:30<TrueBrain>shit like: uint bla = <table value>; int other_bla = bla >> 8
16:30<TrueBrain>makes me nervous :P
16:30<TrueBrain>(well, uint8 vs int32, but okay)
16:30<TrueBrain>euh, uint16
16:30<TrueBrain>lol
16:30<TrueBrain>it is late okay, shut up :P
16:30<+glx>yeah uint8 >> 8 is 0 ;)
16:31<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on issue #8121: Cannot rebuild just buildozed dock https://git.io/JfnIF
16:31<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed issue #8121: Cannot rebuild just buildozed dock https://git.io/JfnIF
16:31<TrueBrain>doing psuedo-code is hard :P
16:32<@DorpsGek>[OpenTTD/OpenTTD] LordAro approved pull request #8532: Fix 85a49a0d: invalidate airport toolbar when new planes become available https://git.io/JLp1P
16:32<@DorpsGek>[OpenTTD/OpenTTD] SamuXarick commented on pull request #8404: Feature: Snow line height can be autodetermined upon world generation https://git.io/JLp11
16:32<_2TallTyler>Re: #8506, I think this is a legitimate thing to fix. If a town can't build a road type, it shouldn't be able to build junctions on that road.
16:33<TrueBrain>_2TallTyler: currently, towns are not really NewGRF aware :P But I like the way you think .. I wonder if that is easy to add
16:34<+glx>towns parly understand NRT
16:34<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8532: Fix 85a49a0d: invalidate airport toolbar when new planes become available https://git.io/JLp1k
16:34<TrueBrain>sorry, town-roads :P
16:34<_2TallTyler>I've been working on it for several hours. Still trying to figure out where to put the check.
16:35<_2TallTyler>There's a lot of duplication in town_cmd, partly due to the multiple road layouts
16:35<TrueBrain>yupppppp
16:35<+glx>there's at least a check for the flags, but it's not enough it seems
16:36<+glx>I think road type flag is checked only for empty tiles
16:36<_2TallTyler>There's a check for whether houses can grow along the road, but not whether the town can build it
16:37<_2TallTyler>I actually have it working, but I need to figure out how to let the growth algorithm continue along the road
16:38<_2TallTyler>I think we can ignore the flag about whether houses can grow. If a town can't build a road type, that should mean no junctions on said road either
16:41<+glx>GetTownRoadType() checks the can build road type flag, but it's the only place checking it I think
16:49-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
16:49-!-tokai is "Christian Rosentreter" on #openttd
16:49-!-mode/#openttd [+v tokai] by ChanServ
16:50<+glx>_2TallTyler: I think the main issue is to find where it's built and go back from there
16:51<_2TallTyler>I'm currently working inside GrowTownInTile()
16:52<+glx>but yeah the code is hard to read and follow
16:52<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpMo
16:52<TrueBrain>looking for opinions ^^
16:52<TrueBrain>looking at you LordAro :D
16:53<@DorpsGek>[OpenTTD/OpenTTD] SamuXarick updated pull request #8404: Feature: Snow line height can be autodetermined upon world generation https://git.io/JLa2N
16:54-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has quit [Quit: Leaving]
16:55<_2TallTyler>Does an excess-length train give an error as when dragging trains into one consist, or overflow into a new line as when you're buying trains?
16:55<TrueBrain>latter when buying
16:55<TrueBrain>first when dragging
16:55-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has joined #openttd
16:55-!-Samu is "realname" on #openttd
16:55<+glx>so multi free-wagon chains ?
16:55<TrueBrain>yes
16:56<TrueBrain>which was already the case for incompatible wagons
16:56<_2TallTyler>Makes sense to me
16:56-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
16:56<+glx>I think AI can already lose track of free wagons
16:56<TrueBrain>yeah .. Human vs AI :)
16:57<Samu>dear TrueBrain, you might want to add this to your arctic section https://github.com/OpenTTD/OpenTTD/pull/8404/files#diff-8463692a54e306b04c06accf493308970b084cc1a2d09c9d93160ba0dc283924
16:57<Samu>and now i gotta run
16:57<Samu>good night
16:57-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has quit []
16:57<TrueBrain>I ... don't even know ... wuth?
16:58<@DorpsGek>[OpenTTD/OpenTTD] J0anJosep commented on pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpM5
16:59<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpMo
16:59<TrueBrain>I have, once again, no clue what Samu was on about
16:59<TrueBrain>I have no open PRs about that stuff ... shrug
17:00<TrueBrain>spends time on things he does understand instead
17:00<frosch123>diff is out-dated, can't comment :/
17:00<+glx>oh TrueBrain, try pressing a shortcut key, like A for autorail, during the newgrf scan
17:01<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpDJ
17:01<TrueBrain>glx: my NewGRF scans don't take that long
17:01<TrueBrain>what am I to see or not to see?
17:01<+glx>a crash
17:02<TrueBrain>and why are you telling me? :)
17:02<+glx>it's related to toolbars
17:02<TrueBrain>so I now became the drain for all issues related to toolbars? :(
17:02<TrueBrain>:P
17:03<TrueBrain>but I don't believe I touched code related to that, did I?
17:04<frosch123>i think that modal thingie broke somewhen
17:04<frosch123>i don't think it should handle any hotkeys during modal state
17:05<+glx>it's not only the grf scan, it's the main menu
17:05<+glx>https://github.com/OpenTTD/OpenTTD/commit/85a49a0d3#diff-c3bd27ff69cf1279f08dce978b9675810679458efabacf2cefab2e9f81a218d0L784 <-- removed some checks
17:05<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpMo
17:05<TrueBrain>glx: LOL .. stupid reviewers :P
17:06<TrueBrain>I have no idea why I brainfarted on that
17:06<+glx>I'll fix it, I know what to look
17:06<TrueBrain>I want to fix it to, no problem?
17:06<+glx>it's your code, so feel free
17:07<TrueBrain>it is all our code :)
17:07<+glx>well your change ;)
17:07<+glx>but it was easy to overlook
17:08<+glx>so many special handlings everywhere
17:09-!-frosch123 [~frosch@00013ce7.user.oftc.net] has quit [Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn]
17:09<TrueBrain>yeah, but I cannot believe I threw out that whole line
17:10<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #8534: Fix 85a49a0d3: hotkeys were enabled outside of GM_NORMAL https://git.io/JLpD2
17:11<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpDV
17:13<TrueBrain>ugh, forgot how incredible difficult the "next" chain was in OpenTTD for trains
17:13<TrueBrain>sounds like it is very overcomplicated
17:15<TrueBrain>_2TallTyler: did you find where OpenTTD grows roads? (that was what you were after, right?)
17:16<_2TallTyler>Yes, I've mostly got it working
17:16<TrueBrain>good
17:16<TrueBrain>the code is very odd where it decides what to do next
17:16<TrueBrain>partially checking for road-growth
17:16<TrueBrain>partially for house-growth
17:16<TrueBrain>and on top of that 2 completely different layouts
17:16<TrueBrain>it is .. lovely code :D
17:16-!-sla_ro|master [slamaster@89.136.179.137] has quit []
17:17<andythenorth> goes it throw out?
17:17<_2TallTyler>I'm hoping I can work towards understanding it, then clean it up
17:17<+glx>I like your spirit :)
17:17<TrueBrain>I wouldn't bother too much _2TallTyler
17:18<andythenorth>we haven't had this for a while https://www.tt-forums.net/viewtopic.php?p=192300#p192300
17:18<TrueBrain>we plan to work towards making GS do town growth
17:18<TrueBrain>if that happens, this code would be mostly voided anyway
17:18<TrueBrain>so don't spend too much time on cleaning it up
17:18<_2TallTyler>GS or NewGRF?
17:18<TrueBrain>shrug
17:18<TrueBrain>GS most likely
17:18<_2TallTyler>Or does that go in parallel with allowing multiple GS if they don't conflict?
17:19<TrueBrain>one doesn't work without the other, so properly
17:19<TrueBrain>but it is early days
17:20<TrueBrain>anyway, cleaning up your own work == good
17:20<TrueBrain>cleaning up the town growth mess .... I am sure I can find something better for you to do :P
17:20<+glx>hmm there's a non working hotkey in road toolbar, but probably not related
17:21<_2TallTyler>I have some ideas but they're a bit beyond my abilities right now
17:21<TrueBrain>glx: which?
17:21<+glx>autoroad, default key is 3
17:22<TrueBrain>works for me
17:22<TrueBrain>both ingame as in SE
17:22<TrueBrain>did you remap any keys? :P
17:22<+glx>hmm unless I'm reading the wrong hotkey file
17:23<+glx>was reading the wrong file, I indeed remap
17:24<TrueBrain>pfew :)
17:24<TrueBrain>that would have been so selective :P
17:24<TrueBrain>https://github.com/OpenTTD/OpenTTD/issues/7869 <- seems that is the only thing I have left over for 1.11 .. well, besides the other PRs people are working on, ofc :)
17:25<andythenorth>woo
17:25<TrueBrain>and the issue-count is also slowly decreasing .. that aint bad
17:26<andythenorth>< 100 TBH is pretty healthy
17:26<+glx>indeed using the correct keys work, I forgot I changed them
17:26<andythenorth>I know it's just numbers, but eh
17:27<andythenorth>maybe we have a clean up after 1.11
17:28*andythenorth wants to close https://github.com/OpenTTD/OpenTTD/pull/8461
17:28<TrueBrain>I doubt any number is healthy .. the amount of closed vs opened says a bit more :D
17:28<@DorpsGek>[OpenTTD/OpenTTD] glx22 approved pull request #8534: Fix 85a49a0d3: hotkeys were enabled outside of GM_NORMAL https://git.io/JLpyv
17:28<TrueBrain>there was no consensus on #8461 yet
17:28<TrueBrain>closing for the fact of closing is also not a good idea :)
17:28<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #8534: Fix 85a49a0d3: hotkeys were enabled outside of GM_NORMAL https://git.io/JLpD2
17:28<TrueBrain>glx: I checked the other toolbars in the code too :D
17:29<TrueBrain>just to be sure :P
17:30<+glx>hehe
17:31<andythenorth>closing non-destroyable rivers I'd do because I think it's a bad idea in concept, but eh, just my view
17:31<andythenorth>hmm PR count has gone down, can't keep up :P
17:31<TrueBrain>andythenorth: so typie typie that, or give my comment a +1 via emoticon :)
17:31<TrueBrain>PR count is up :P I made too many PRs :D
17:32<TrueBrain>we keep bouncing around 50 :P
17:32<andythenorth>"how many is too many"
17:32<TrueBrain>well, if I drain the resources of other devs, it is too many
17:32<andythenorth>'bouncing around 50' is steady state if they move?
17:32<TrueBrain>but I am almost done, so just a little bit longer :D
17:32<TrueBrain>https://github.com/OpenTTD/OpenTTD/pulse :P
17:32<TrueBrain>merged 48 PRs in 1 week
17:33<andythenorth>pretty rad
17:34<_2TallTyler>I've got some more PRs on the way to keep the count up :P
17:35<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #8471: Fix #8462: Don't check whether to grow a town road on water https://git.io/JLpyW
17:37<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on issue #8419: Trains stuck at path through implicit destinations after fixing route towards real destination https://git.io/JLPDF
17:39<@DorpsGek>[OpenTTD/OpenTTD] 2TallTyler opened pull request #8535: Fix #8506: Towns don't add junctions to NewGRF roads they cannot build https://git.io/JLpyz
17:39<+glx>already ?
17:40<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on issue #8405: Trains not unloading load at station to later go to the depot for maintenance https://git.io/JLVPs
17:40<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed issue #8405: Trains not unloading load at station to later go to the depot for maintenance https://git.io/JLVPs
17:40<_2TallTyler>Think I figured it out, but I'd like help testing edge cases. Hoping James103 sees it. :P
17:40<+glx>huhu
17:41<TrueBrain>"As a quick-fix, you can set the order of a train to go to a depot after a station; it will not do automatic service at that point, and go when it is done with the station." <- this is true, right?
17:41<TrueBrain>lol @ commit message _2TallTyler .. so you fix that they don't add junctions? Or you fix that they do? :P
17:42<+glx>yes if there's a depot in the orders, it won't never decide to go to depot by itself
17:42<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on issue #7901: Train prefers service in depot over station https://git.io/Jeh7q
17:42<_2TallTyler>Uh, let me fix that
17:44<@DorpsGek>[OpenTTD/OpenTTD] 2TallTyler updated pull request #8535: Fix #8506: Towns don't add junctions to NewGRF roads they cannot build https://git.io/JLpyz
17:45<_2TallTyler>Dinnertime; be back later
17:45<TrueBrain>enjoy
17:45<andythenorth>hmm is it bedtime?
17:46*andythenorth needs magic 8 ball
17:46<andythenorth>nope, it's tidy the kitchen time
17:46<TrueBrain>highway is always build by the player in this case, right?
17:46<TrueBrain>there is 1 other place that can build roads in town growth
17:46<TrueBrain>but, only if it can clear the tile
17:46<TrueBrain>so that shouldn't be the case
17:47<TrueBrain>PR looks good to me; but I am scared shitless to approve it :P
17:49<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed issue #8290: Game Crashed while attempting to clone a train in one depot while train is in another depot https://git.io/JJMmI
17:49<+glx>yeah it seems correct to me, but maybe ask the #8506 author to test
17:49<TrueBrain>glx: merge and ask after? :P
17:49<+glx>preview and ask ?
17:50<TrueBrain>I was about to say: owh, we have previews!
17:50<TrueBrain>so yeah, add that preview label glx :D
17:50<TrueBrain>I am also still getting used to us having that :P
17:51<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed issue #8275: NRT uses "backwards" roadtype intercompatibility, at least in NML https://git.io/JJZ3X
17:52<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on issue #8272: Stopped vehicule destination should be red when mouse over https://git.io/JJ35w
17:53*andythenorth tinkers with an idea
17:54<TrueBrain>be careful with that
17:54-!-gelignite [~gelignite@55d4d4cd.access.ecotel.net] has quit [Quit: Stay safe!]
17:54<andythenorth>yeah, also it's an implementation idea not a use case, and it's half-assed
17:54<andythenorth>probably explodes in my face
17:54<andythenorth>much regret
17:55<@DorpsGek>[OpenTTD/OpenTTD] Milek7 updated pull request #8391: RFC: Feature: Public key company authorization https://git.io/JLnig
17:56<andythenorth>@Timberwolf would you have a use for extensible arbitrary vehicle properties (defined per grf)? E.g. livery, gear ratio, all that crap?
17:56<andythenorth>oops no @, not discord :P
17:59<TrueBrain>https://github.com/OpenTTD/OpenTTD/issues/8034 <- it is not wrong .. it is of course meant as a fun remark, but in this day and age, it is not okay anymore ..
18:00<andythenorth>I used to write silly things like that
18:00<andythenorth>now I don't so much
18:00<milek7>Xaroth: https://github.com/Milek7/libottdadmin2/commit/4590a8901a17d20ef93cc61d9047b1b64e142af3
18:01<TrueBrain>funny, I never read the text .. lolz
18:02<andythenorth>Whenever I read it now the words 'fuck you' silently play in my head
18:02<andythenorth>such a rebel
18:02<TrueBrain>OMG! I NOW HAVE milek7 's SECRET KEYS!
18:02<milek7>ugh, no :P
18:02<andythenorth>I mean, for newgrf testing I have to use cheat constantly
18:02<andythenorth>so maybe I see it more than most
18:02<milek7>password in cmdline argument is still used
18:03<@DorpsGek>[OpenTTD/OpenTTD] glx22 commented on issue #8506: Town builds unnecessary junctions on highway https://git.io/JLN40
18:04<Xaroth>milek7: https://github.com/Milek7/libottdadmin2/blob/4590a8901a17d20ef93cc61d9047b1b64e142af3/libottdadmin2/client/common.py#L54-L58 might as well move that to on_server_need_keyauth (basically what the lines below do)
18:05<Xaroth>that's what the callbacks are for, and allows people to override the functionality (if ever needed)
18:05<milek7>this isn't meant to be overriden
18:05<milek7>I need access to self._keypair there
18:05-!-Progman [~progman@p548d9150.dip0.t-ipconnect.de] has joined #openttd
18:05-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttd
18:06<Xaroth>all the on_* functions have access to self, and with that, self._keypair
18:06<milek7>ah
18:07<Xaroth>much like on_server_shutdown
18:07<@DorpsGek>[OpenTTD/OpenTTD] michicc opened pull request #8536: Feature: Choose a sensible window size on a fresh OTTD config file. https://git.io/JLpSy
18:07<@DorpsGek>[OpenTTD/OpenTTD] michicc opened pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JLpSS
18:07<@DorpsGek>[OpenTTD/OpenTTD] michicc updated pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JLxK4
18:08<milek7>it's only quick demo anyway, I didn't even bother with proper typing
18:08<Xaroth>technically this means you can create two classes, one that does password auth, and one that does keypair auth, without them interfering
18:08<Xaroth>fair enough
18:08<+michi_cc>andythenorth: #8537 makes a lot of sense together with #8519 (should apply/merge cleanly on top, too).
18:09<andythenorth>+1
18:09<andythenorth>I'll test tomorrow probs :)
18:10<andythenorth>I'm not sure 8519 is viable on most contemporary macs though for performance reasons
18:10<andythenorth>mine is a relatively high end 2020 i9 and performance was low so far
18:10<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #8538: Remove: warning in cheat window https://git.io/JLpSx
18:10<TrueBrain>let's see how many people I can tick off with 1 PR :)
18:11<andythenorth>maybe I should put xcode on my kids' m1
18:11<andythenorth>mac games tend to not run in HDPI for performance reasons, and generally macs have very poor UI and screen drawing performance these days
18:12<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8536: Feature: Choose a sensible window size on a fresh OTTD config file. https://git.io/JLp9f
18:13<@DorpsGek>[OpenTTD/OpenTTD] James103 commented on pull request #8538: Remove: warning in cheat window https://git.io/JLp9T
18:15<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8538: Remove: warning in cheat window https://git.io/JLp9t
18:16<Timberwolf>Aw :(
18:16<Timberwolf>GS joke injection API!
18:18<@DorpsGek>[OpenTTD/OpenTTD] michicc commented on pull request #8536: Feature: Choose a sensible window size on a fresh OTTD config file. https://git.io/JLp9Z
18:19<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #8536: Feature: Choose a sensible window size on a fresh OTTD config file. https://git.io/JLp9l
18:19<TrueBrain>michi_cc: good enough reason for me. Maybe we should write it in a comment or what-ever .. *shrug*
18:20<TrueBrain>Timberwolf: haha :)
18:22<TrueBrain>can't find other open bugs that I consider worth fixing for 1.11 .. few triages that might be worth doing
18:23<@DorpsGek>[OpenTTD/OpenTTD] michicc commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JLp9r
18:24-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has quit [Quit: Once again the world is quick to bury me.]
18:25<TrueBrain>glx: I added the direct link to the preview for his comfort; not sure yet everyone know where to find the deployment button :)
18:26-!-roadt__ [~roadt@117.64.249.139] has quit [Ping timeout: 480 seconds]
18:26<TrueBrain>still not sure about that part ..
18:26-!-roadt__ [~roadt@117.64.249.139] has joined #openttd
18:26-!-roadt__ is "roadt" on #openttd
18:35<+michi_cc>Emscripten could use an implentation of #8537. No idea at all though how (and if at all) you can get DPI on Emscripten.
18:36<TrueBrain>hopefully someone walk by that want to do that :D Would be nice :)
18:36<TrueBrain>I have been considering putting somewhere things in all kind of domains of the game people could help out with
18:36<TrueBrain>we now have a few "good first" issues
18:36<TrueBrain>but it is hard to find and read
18:37<TrueBrain>maybe a project to bind them together
18:37<TrueBrain>anyway, it might look we can do a 1.11 beta somewhere at the beginning of next week ..
18:38<TrueBrain>at least, if I have anything to say in it :P
18:39<TrueBrain>we might want to figure out signing first, I guess
18:39<TrueBrain>if there are open issues / PRs you consider should be in 1.11, please add them to the milestone (goes for everyone)
18:42<supermop_Home>andythenorth its past your bedtime
18:42<andythenorth>so is
18:42<TrueBrain>:D You guys are cute
18:42<supermop_Home>here it is beertime
18:46<supermop_Home>not sure what openttd thing i should be doing next
18:49<@DorpsGek>[OpenTTD/OpenTTD] LC-Zorg opened issue #8539: Graph Window - Colors of the mauve, dark green and purple companies are barely visible https://git.io/JLpHF
18:53<TrueBrain>Oeh, he found GitHub. Lovely ticket, clear and suggestions how to solve it :D
18:56<andythenorth>right, bedtime
18:56<andythenorth>I turn into a goblin if I stay up past midnight
18:56<andythenorth>or get wet
18:56-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has quit [Quit: andythenorth]
19:09-!-rptr_ [~rptr@2a00:801:236:570e:b1f2:acf6:e570:218d] has quit [Quit: Leaving]
19:22<@DorpsGek>[OpenTTD/OpenTTD] LordAro commented on pull request #8538: Remove: warning in cheat window https://git.io/JLp7t
19:23<TrueBrain>What value does it carry?
19:24<TrueBrain>I couldn't come up with a reason why we want to tell it that explicit :p
19:25<TrueBrain>And it is waaayyyy to big for the screen and what it does
19:25-!-tokai|noir [~tokai@00012860.user.oftc.net] has joined #openttd
19:25-!-tokai|noir is "Christian Rosentreter" on #openttd
19:25-!-mode/#openttd [+v tokai|noir] by ChanServ
19:25<TrueBrain>Dunno, feels like we giving it too much value
19:26<LordAro>maybe, but it is an action that "cannot be undone"
19:26<LordAro>users should be suitably warned about that
19:26<TrueBrain>I noticed I never read the sentence :l
19:26<LordAro>of course not, you probably wrote it originally :p
19:26<LordAro>or had a hand in it
19:26<TrueBrain>So if that is the goal, not sure we succeeded
19:27<TrueBrain>Nah, it is the UI pattern used
19:27<TrueBrain>Maybe a popup when you first use it, but also feels like too much
19:27<TrueBrain>I will toy a bit with it tomorrow, see if it can be a bit more useful and friendly
19:28<TrueBrain>I even considered removing the "we remember what you did"
19:28<TrueBrain>But for debugging it tends to be useful
19:31<TrueBrain>Now first, zzzzzzzz
19:32-!-tokai [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
19:37-!-Smedles [~quassel@61-245-148-167.3df594.adl.nbn.aussiebb.net] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
19:38<@DorpsGek>[OpenTTD/OpenTTD] Berbe commented on pull request #7286: Add #2155: newheightmapgame command https://git.io/JLp7n
19:38-!-Smedles [~quassel@61-245-148-167.3df594.adl.nbn.aussiebb.net] has joined #openttd
19:38-!-Smedles is "Paul Smedley" on #openttd
19:48-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
19:51-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:2525:1782:292d:cbe5] has quit [Quit: DasPoseidon]
20:21-!-Flygon [~Flygon@2001:44b8:411e:4e00:a502:82fb:e47c:9612] has joined #openttd
20:21-!-Flygon is "Flygon" on #openttd
20:30-!-_2TallTyler [~oftc-webi@151.203.115.35] has quit [Quit: Page closed]
20:34-!-Progman [~progman@p548d9150.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20:49<@DorpsGek>[OpenTTD/OpenTTD] mattkimber opened pull request #8540: Fix eeb88e8: Trains reversed while paused do not correctly update sprite bounds https://git.io/JLpdb
20:49<Timberwolf>oops, I broke it :(
21:31<@DorpsGek>[OpenTTD/OpenTTD] kiwitreekor commented on issue #8506: Town builds unnecessary junctions on highway https://git.io/JLN40
21:38<reldred>Okay, that multi tile depots patch is kinda cool
21:38<reldred>Building a four wide tram depot and unleashing a dozen trams at once and watching them all roll out side by side
21:49-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:2525:1782:292d:cbe5] has joined #openttd
21:49-!-DasPoseidon is "DasPoseidon" on #openttd
21:50-!-DasPoseidon [~Thunderbi@2001:9e8:2050:1d00:2525:1782:292d:cbe5] has quit []
22:07-!-jottyfan [~Thunderbi@x4dbfd142.dyn.telefonica.de] has joined #openttd
22:07-!-jottyfan is "jottyfan" on #openttd
22:08-!-jottyfan [~Thunderbi@x4dbfd142.dyn.telefonica.de] has quit []
22:14-!-debdog [~debdog@2a00:79c0:679:e400:7a24:afff:fe8a:d04d] has joined #openttd
22:14-!-debdog is "Wowbagger" on #openttd
22:15-!-Wormnest [~Wormnest@35.136.189.95] has quit [Quit: Leaving]
22:18-!-D-HUND [~debdog@2a00:79c0:625:9300:7a24:afff:fe8a:d04d] has quit [Ping timeout: 480 seconds]
23:14-!-glx [glx@000128ec.user.oftc.net] has quit []
23:33-!-WormnestAndroid [~WormnestA@35.136.189.95] has quit [Read error: Connection reset by peer]
23:35-!-WormnestAndroid [~WormnestA@35.136.189.95] has joined #openttd
23:35-!-WormnestAndroid is "WormnestAndroid" on #openttd
23:37-!-ekangmonyet_ [~ekangmony@202.151.229.66] has joined #openttd
23:37-!-ekangmonyet_ is "Ekang Monyet" on #openttd
23:41-!-ekangmonyet [~ekangmony@202.151.229.112] has quit [Ping timeout: 480 seconds]
23:54-!-roadt_ [~roadt@114.97.240.33] has joined #openttd
23:54-!-roadt_ is "roadt" on #openttd
---Logclosed Sat Jan 09 00:00:47 2021