Back to Home / #openttd / 2021 / 06 / Prev Day | Next Day
#openttd IRC Logs for 2021-06-03

---Logopened Thu Jun 03 00:00:12 2021
01:19-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has quit [Quit: snail_UES_]
01:35-!-Flygon [~Flygon@2001:44b8:411e:4e00:417d:3226:358a:328a] has joined #openttd
01:35-!-Flygon is "Flygon" on #openttd
02:15-!-HerzogDeXtEr [~farci@ip92345813.dynamic.kabel-deutschland.de] has joined #openttd
02:15-!-HerzogDeXtEr is "purple" on #openttd
02:30-!-sla_ro|master [~sla.ro@89.136.179.137] has joined #openttd
02:30-!-sla_ro|master is "slamaster" on #sla #openttd
03:10-!-gelignite [~gelignite@55d473db.access.ecotel.net] has joined #openttd
03:10-!-gelignite is "gelignite" on #debian #llvm #openttd
03:32-!-namad7 [~aaaaa@pool-100-6-182-52.pitbpa.fios.verizon.net] has quit [Ping timeout: 480 seconds]
03:32-!-namad7 [~aaaaa@pool-100-6-182-52.pitbpa.fios.verizon.net] has joined #openttd
03:32-!-namad7 is "namad2" on #openttd
03:33-!-Eddi|zuHause [~johekr@p4fcef710.dip0.t-ipconnect.de] has joined #openttd
03:33-!-Eddi|zuHause is "Johannes E. Krause" on #openttd
03:38-!-Eddi|zuHause2 [~johekr@p4fcefab6.dip0.t-ipconnect.de] has quit [Ping timeout: 480 seconds]
04:09-!-Progman [~progman@p4fd66a46.dip0.t-ipconnect.de] has joined #openttd
04:09-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttd
04:21-!-Beer [~Beerbelot@00028cd3.user.oftc.net] has joined #openttd
04:21-!-Beer is "realname" on #openttd
04:24-!-sla_ro|master [~sla.ro@89.136.179.137] has quit []
04:44-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has joined #openttd
04:44-!-andythenorth is "andythenorth" on #openttd
04:58<@DorpsGek>[OpenTTD/OpenTTD] PeterN commented on pull request #9330: Fix #9329: [CMake] FindVersion.cmake relied on internal cmake variable https://git.io/JGrnN
05:14-!-WormnestAndroid [~WormnestA@35.136.189.95] has quit [Remote host closed the connection]
05:15-!-WormnestAndroid [~WormnestA@35.136.189.95] has joined #openttd
05:15-!-WormnestAndroid is "WormnestAndroid" on #openttd
05:28-!-Smedles_ [~quassel@2403-5800-5100-f00-225-90ff-fe0e-3b40.ip6.aussiebb.net] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
05:30-!-Smedles [~quassel@2403-5800-5100-f00-225-90ff-fe0e-3b40.ip6.aussiebb.net] has joined #openttd
05:30-!-Smedles is "Paul Smedley" on #openttd
05:48-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has joined #openttd
05:48-!-Samu is "realname" on #openttd
05:57-!-tneo [~tneo@haleakala.openttdcoop.org] has quit [Ping timeout: 480 seconds]
05:57-!-tneo [~tneo@haleakala.openttdcoop.org] has joined #openttd
05:57-!-tneo is "tneo" on #openttdcoop.dev #openttd
05:58-!-ericnoan [~en@0002590d.user.oftc.net] has quit [Ping timeout: 480 seconds]
05:59-!-ericnoan [~en@0002590d.user.oftc.net] has joined #openttd
05:59-!-ericnoan is "ericnoan" on #oftc #alpine-linux #freedombox #redditprivacy #Qubes_OS #linode #ceph #openttd #debian
06:12-!-frosch123 [~frosch@00013ce7.user.oftc.net] has joined #openttd
06:12-!-frosch123 is "frosch" on #openttd
06:16-!-Xaroth2 [~Xaroth@022-139-128-083.dynamic.caiway.nl] has joined #openttd
06:16-!-Xaroth2 is "Xaroth Brook" on #openttd
06:21-!-Xaroth [~Xaroth@00017153.user.oftc.net] has quit [Ping timeout: 480 seconds]
07:03<@DorpsGek>[OpenTTD/OpenTTD] extrazi commented on discussion #9250: [Suggestion] Make console commands and outputs translatable strings https://git.io/JsUuI
07:04-!-iSoSyS [~iSoSyS@ff2-84-90-95-208.netvisao.pt] has joined #openttd
07:04-!-iSoSyS is "realname" on #/r/openttd #openttd
07:15-!-WormnestAndroid [~WormnestA@35.136.189.95] has quit [Remote host closed the connection]
07:15-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has joined #openttd
07:15-!-snail_UES_ is "Jacopo Coletto" on #openttd
07:18-!-WormnestAndroid [~WormnestA@35.136.189.95] has joined #openttd
07:18-!-WormnestAndroid is "WormnestAndroid" on #openttd
07:18-!-iSoSyS [~iSoSyS@ff2-84-90-95-208.netvisao.pt] has quit []
07:19-!-andythenorth_ [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has joined #openttd
07:19-!-andythenorth_ is "andythenorth" on #openttd
07:26-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has quit [Ping timeout: 480 seconds]
07:26-!-Xaroth2 is now known as Xaroth
07:53-!-WormnestAndroid [~WormnestA@35.136.189.95] has quit [Remote host closed the connection]
07:53-!-WormnestAndroid [~WormnestA@35.136.189.95] has joined #openttd
07:53-!-WormnestAndroid is "WormnestAndroid" on #openttd
08:11-!-k32n13 [~Miranda@5E1BE0B1.mobile.pool.telekom.hu] has joined #openttd
08:11-!-k32n13 is "k32n13@yahoo.com" on #openttd
08:13-!-k32n13 [~Miranda@5E1BE0B1.mobile.pool.telekom.hu] has left #openttd []
08:24-!-geli [~gelignite@55d473db.access.ecotel.net] has joined #openttd
08:24-!-geli is "gelignite" on #debian #llvm #openttd
08:24-!-gelignite [~gelignite@55d473db.access.ecotel.net] has quit [Read error: Connection reset by peer]
08:25<TrueBrain>so the delete savegame button doesn't ask for: are you sure?
08:25<TrueBrain>nice
08:28-!-jellyknight [~gelignite@55d4fb96.access.ecotel.net] has joined #openttd
08:28-!-jellyknight is "gelignite" on #openttd #llvm #debian
08:34-!-geli [~gelignite@55d473db.access.ecotel.net] has quit [Ping timeout: 480 seconds]
08:38<@peter1138>Yeah
08:38-!-jellyknight [~gelignite@55d4fb96.access.ecotel.net] has quit [Quit: Stay safe!]
08:39<andythenorth_>'type the name of this savegame to confirum'
08:40<andythenorth_>or confirm
08:40<TrueBrain>at least something would help
08:40<TrueBrain>Save and Delete buttons are next to each other
08:41<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9322: Add: store settings as key->value pair https://git.io/JGlmd
08:42<TrueBrain>okay, finally found a clean way to add headers to other chunks too
08:42<TrueBrain>haven't done them all, as we have 79 things to convert, and they are a lot of manual work each :P
08:42<TrueBrain>guess I could make it into another PR, but what-ever
08:49<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGrpy
08:49<TrueBrain>ping frosch123 ^^ :)
08:51-!-gelignite [~gelignite@55d4fb96.access.ecotel.net] has joined #openttd
08:51-!-gelignite is "gelignite" on #debian #llvm #openttd
09:03-!-andythenorth_ [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has quit [Quit: andythenorth_]
09:11<frosch123>separate chunk types is a good idea. that way external tools can detect whether there is a schema
09:13<TrueBrain>Wait, why are you already here? :p
09:14<TrueBrain>Unexpected :D
09:14<frosch123>another lazy-cathlic-day
09:14<TrueBrain>Nice :D
09:15<TrueBrain>But yeah, my biggest worry is those chunks that are really not a table
09:15<TrueBrain>Bit tempted to make those into a RIFF instead
09:15<frosch123>also, both savegame parsers that i wrote over the years, kind of survive the new chunk types
09:15<frosch123>(bananas_api scenario parser, and some desync decoder)
09:16-!-sla_ro|master [~sla.ro@89.136.179.137] has joined #openttd
09:16-!-sla_ro|master is "slamaster" on #sla #openttd
09:18<frosch123>meh, i still don't like that the variable names are used as keys in the savegame
09:18<frosch123>"_game_saveload_name" should really just be "name" in the savegame
09:18<frosch123>the rest is a weird implementation detail
09:20<TrueBrain>Yeah, that is easily fixed my changing that code
09:20<TrueBrain>It is very weird saveload code
09:20<TrueBrain>So that is mostly the exception .. a few more spots this happens in
09:21-!-Progman [~progman@p4fd66a46.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
09:21<TrueBrain>But otherwise we have to duplicate 90% of the keys for the 10% .. doesn't sound like a good idea either .. not sure if there is anything in between :)
09:24<TrueBrain>Why do we store translations of the GS in the save game btw?
09:24<frosch123>so that the clients get them
09:24<frosch123>clients do not have the gs
09:24<frosch123>but they need to show the strings
09:25<frosch123>i think only multiplayer store them
09:25<frosch123>isn't it skipped in singleplayer?
09:25<TrueBrain>Haven't seen code for it but also haven't been looking for it
09:25<TrueBrain>And that makes sense
09:25<TrueBrain>I will see if I cant rework that chunk
09:26<TrueBrain>So it is a proper table
09:27<TrueBrain>Owh, and I have an idea how to solve the global name issue
09:28-!-Progman [~progman@p4fd66a46.dip0.t-ipconnect.de] has joined #openttd
09:28-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttd
09:38<frosch123>oh, this also bakes the historic settings structures into the savegame :p lol, didn't notice this before
09:38<TrueBrain>what do you mean, sorry?
09:39<frosch123>"difficulty.terrain_type" that was a difficulty setting in ttd. but has been a mapgen setting in ottd for years
09:39<frosch123>also, various things moved between client settings, game settings and company settings over the years, it's just a mess :p
09:39<TrueBrain>yup
09:39<TrueBrain>and hopefully with this, we can clean that up a bit :)
09:41<frosch123>also, wtf is with "gui.autosave"? "from = SLV_23" and "flags = SLF_NOT_IN_SAVE | SLF_NO_NETWORK_SYNC"
09:41<frosch123>is it in the savegame, or is it not?
09:42<TrueBrain>those 2 flags mostly come hand in hand
09:42<TrueBrain>read: all SLF_NOT_IN_SAVE also have SLF_NO_NETWORK_SYNC :)
09:43<TrueBrain>"SLF_NOT_IN_SAVE | SLF_NOT_IN_CONFIG | SLF_NO_NETWORK_SYNC" <- we have that too
09:43<frosch123>i mean the "it's in the savegame starting with savegame version 23" and "it's not in the savegame"
09:43<TrueBrain>ah, like that, yes
09:43<TrueBrain>many odd things :)
09:43<frosch123>also, why would the autosave interval be in the savegame?
09:43<TrueBrain>because people wanted it to be stored per game
09:43<TrueBrain>in the old days, we made some weird choices
09:51<TrueBrain>(and with "we" in this case I guess CS or ludde :P)
09:52<TrueBrain>so tempted to remove the macros for saveload stuff
09:52<TrueBrain>it makes things more complex than needed
09:56<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9322: Add: store settings as key->value pair https://git.io/JGlmd
09:56<TrueBrain>frosch123: how about that? :)
09:57<TrueBrain>basically, I forced global variables to name the field :P
09:58<frosch123>off, does this now invalidate all my comments :p
09:58<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGomk
09:58<TrueBrain>only if they were all about the name :P
09:58<frosch123>let's see what survived
09:59<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGoml
09:59<frosch123>i am mostly confused about whether the schema contains SLF_NOT_IN_SAVE things, and wtf that autosave setting is doing
10:00<TrueBrain>euh, no, my comment is wrong ..
10:00<TrueBrain>I need to investigate autosave .. I think it doesn't do what it appears to do :P
10:00<frosch123>exactly my problem :p
10:01<@peter1138>Bootstrap is like "Hey you know the semantic part of HTML, and the cascasing part of CSS? LOL!"
10:02<frosch123>TrueBrain: btw. i love the first commit. it makes the code actually easier
10:02<TrueBrain>yeah ... took me a long time to figure out what it was doing ...
10:03<@peter1138>mpdrandom decided to play the album "Unknown"
10:03<@peter1138>I have 76 random tracks with "Unknown" as the album :/
10:03<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGoYI
10:04<TrueBrain>wait, [[maybe_unused]] exists? Lol .. well, I guess I can fix some other places in that case too :D
10:04<frosch123>https://en.cppreference.com/w/cpp/language/attributes/maybe_unused
10:04<frosch123>i checked first, whether it's also c++20 :p
10:04<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGoYZ
10:06<@peter1138>Time to redesign the page :/
10:07<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGoYN
10:08<TrueBrain>storing the type first is a good idea frosch123
10:08<TrueBrain>makes a lot more sense
10:08-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has joined #openttd
10:08-!-nielsm is "Niels Martin Hansen" on #openttd
10:10<TrueBrain>okay, the autosave indeed can be removed safely
10:10<TrueBrain>the field before that does 0 .. 22
10:12<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9322: Add: store settings as key->value pair https://git.io/JGlmd
10:12<TrueBrain>anyway, you think it is good to finish this PR this way frosch123 ? I wouldn't be able to do all chunks, but .. at least a good portion
10:14<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9180: Codechange: Remove FOR_ALL_CHUNK_HANDLERS https://git.io/JGoOA
10:14<TrueBrain>it will just take me a few .. days to finish it :P
10:15<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGo3O
10:16<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGo30
10:18<TrueBrain>okay, so we have NDEBUG, WITH_ASSERT and OTTD_ASSERT
10:18<TrueBrain>and we use them all!
10:18<TrueBrain>am I really surprised? Guess not
10:18<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGosv
10:24<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGosx
10:25<TrueBrain>good question; possibly the header is waaayyyy too long
10:25<TrueBrain>will work itself out while loading just fine, so you won't notice that
10:26<TrueBrain>clearly, I need to write some Python to look into savegames with this new header
10:26<TrueBrain>so we can validate it is doing what we expect :D
10:26<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGoGG
10:27<TrueBrain>I love how you complained like 5 times about that newline :P
10:27<TrueBrain>your OCD is consistent :D
10:27<TrueBrain>so is mine :P
10:28<frosch123>in chat? or did github duplicate my comment?
10:28<TrueBrain>frosch123: can I assume that with [[maybe_unused]], the compiler will optimize out the variable completely? So also if it is assigned something (not a function etc)
10:28<TrueBrain>frosch123: in chat :)
10:28<TrueBrain>you mentioned it a few times earlier when looking at it :P
10:29<TrueBrain>I could also just godbolt it, instead of asking you ..
10:29<TrueBrain>even functions are optimized out if possible
10:29<TrueBrain>nice
10:30<frosch123>do you want to short or the long answer? :p
10:30<TrueBrain>in general, I care about how it works, not if :P
10:30<frosch123>the optimiser removes unused storage and conditions (sometimes security relevant conditions)
10:30<frosch123>but in this case the storage is in the stackframe anyway
10:30<frosch123>or in a register
10:31<frosch123>bool result is in rax
10:31<TrueBrain>there are many more places :P
10:32<frosch123>so well, if the compiler inlines the function, it will remove the storage. if it calls the function, the function will store the result anywhere
10:32<TrueBrain>for ([[maybe_unused]] const Industry *i : Industry::Iterate()) assert(i->town != this);
10:32<TrueBrain>is that going to work as I expect, I wonder ..
10:32<frosch123>that looks dangerous in other ways...
10:32<TrueBrain>do tell?
10:32<frosch123>sometimes "assert" is a macro, so would it apply the for to the next insutrction?
10:32<frosch123>i would add { } to be safe :p
10:32<TrueBrain>we use cassert :)
10:33<TrueBrain>and it an existing line of code ;)
10:33<TrueBrain>but sure, I will add {} :)
10:33<TrueBrain>fun fact: some asserts() didn't work on RC-builds
10:33<TrueBrain>and some ONLY worked on RC-builds :P
10:34<frosch123>TrueBrain: if you want to do it the c89 way, you can use the variable and cast it to void :p "(void)i;" will also remove the "unused" warning, without adding real code
10:34<TrueBrain>that is what other places do, yes
10:35<frosch123>so, anyway, i like this PR. but all the historic settings names are annoying
10:36<TrueBrain>yeah .. I have some more plans to clean up that stuff
10:36<frosch123>it's the same mess as in openttd.cfg :)
10:36<TrueBrain>mostly: splitting up
10:36<TrueBrain>and for that I need a way to rename settings anyway
10:36<TrueBrain>so .. yeah ..
10:36<TrueBrain>lets fix this mess :D
10:36<V453000>HellO! I've been told air_drag_coefficient should be set to 1 if I want it to have no effect. NUTS has always had 0 though, that's correct, isn't it? I think it doesn't have any effect with 0
10:39<frosch123>zero is a special value
10:39<V453000>what does it mean?
10:39<frosch123>all the default vehicles have air_drag zero, and it sets a max-speed dependent air-drag value
10:40<frosch123>https://github.com/OpenTTD/OpenTTD/blob/master/src/ground_vehicle.cpp#L47 <- see there
10:41<frosch123>oh, and if you look 7 lines downwards, also "1" is a special value for "no airdrag" :p
10:41<TrueBrain>so 0 and 1 are special, and anything else isn't?
10:41<frosch123>typical ttdpatch assembler stuff :)
10:41<TrueBrain>"nobody wants an airdrag of 1, don't be silly"
10:42<V453000>interesting, I had a logic engine built with max speed 40 000, and with 1 it looks like it goes about 1900kmh at most, with 0 it seems to go 16 000 ... though when I added more engines it was getting faster with 0. Didn't try with 1
10:44<V453000>So what exactly is the air drag? It just means that if trains don't have enough power, they won't be able to go above some speed? is it the thing that also makes them slow down in tunnel entrances?
10:45<frosch123>V453000: see line 144 in that file
10:46<V453000>so fast trains with low power have a harder time reaching top speed?
10:46<frosch123>"area" is different in tunnels and outside
10:47<frosch123>but only for trains, not for rv
10:47<V453000>with 1 trains do seem to slow down in tunnels
10:48<frosch123>they shouldn't
10:48<frosch123>"1" would result in "tunnel_effect * 0"
10:48<frosch123>so, anyway, drag is a speed-dependant uphill-slope. it's doubled in tunnels
10:49<TrueBrain>maglev seriously have no friction? Haha, didn't expect things to go in that much detail :D
10:50<frosch123>hmm, the slope comparision is meh, ignore that :)
10:51<TrueBrain>damn, the game plays so much faster on release build
10:51<TrueBrain>lol
10:51<frosch123>but yes, it reduces power at higher speeds
10:51<frosch123>TrueBrain: newgrf scan is so much faster on release build
10:51<TrueBrain>mapgen too
10:52<TrueBrain>after weeks of testing newgame, that is noticeable :P
10:58<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #9331: Codechange: use "[[maybe_unused]]" instead of a wide variety of other ways we had https://git.io/JGo8f
10:58<TrueBrain>enjoy the variety of different ways developer can fix the same problem :D
10:58<frosch123>TrueBrain: https://dpaste.org/qVaD <- i was pondering about a syntax to define string-values for enum settings in the .ini files
10:59<frosch123>allowing to set multiple aliases for old configs and savegames
10:59<TrueBrain>sorry, I do not follow that paste at all :P
10:59-!-Wormnest [~Wormnest@35.136.189.95] has joined #openttd
10:59-!-Wormnest is "Wormnest" on #openttd
11:00<frosch123>terrain_type is currently stored as integer 0..3 in savegames, in openttd.cfg and in console's get/set setting
11:00<frosch123>i would like to use "temperate", "arctic", ... instead
11:01<TrueBrain>and you don't like the current solution for that? :D
11:01<frosch123>but i also want to support renaming those values in the future, so for each enum value there is a "primary string" that is used when saving, and multiple aliases which map the same when loading
11:01<frosch123>TrueBrain: no, the current solution defines the stuff in a different place
11:01<frosch123>and it does not support aliases
11:02<TrueBrain>it is funny how bad the current form is
11:02<TrueBrain>made sense when it was only used for gameopts
11:02<TrueBrain>but it got a bit out of hand :P
11:02<TrueBrain>"The rest is here for consistency." part made me giggle
11:02<TrueBrain>(comment in gameopts.ini)
11:02<frosch123>TrueBrain: btw. i do not regret telling you about maybe_unused :)
11:02<TrueBrain>:P
11:02<TrueBrain>frosch123: I can understand if we would do full.0 = ..
11:03<TrueBrain>full.1 = ..
11:03<TrueBrain>but with an enum there .. not sure how we would implement that
11:03<frosch123>i intended the stuff after the "." to be copied into the generated code by settingsgen
11:03<TrueBrain>and for example you now don't define all values .. how to deal with that?
11:04<TrueBrain>frosch123: settingsgen is really primitive .. so it doesn't know the value of those things .. it does need to generate a "std::string []" list from it
11:05<TrueBrain>well, std::map in your case, as aliases :P
11:05<TrueBrain>I just don't see how we could do that efficient
11:05<TrueBrain>but that is an implementation problem :)
11:05<frosch123>it does not have to. it would generate std::map<int, std::vector<std::string>> = {LT_TEMPERATE, {"temperate", "0"}} or so
11:05<frosch123>the compiler has to understand LT_TEMPERATE, settingsgen just copies it
11:06<TrueBrain>but that the min=0, max=5, and you define 4 values, does worry me .. as I wonder what other 2 terrain types we have :D
11:06<frosch123>maybe with some special magic for converting old integer values, like the "0" here
11:06<TrueBrain>I have been wondering several times now if we shouldn't switch to YAML for settings.ini
11:06<TrueBrain>as that allows easier syntax for many of these things
11:06<frosch123>oh lol... i copied the wrong setting
11:06<TrueBrain>(having dict and list support is kinda useful :P)
11:07<frosch123>i started with "terrain_type" and then added the strings for "landscape"
11:07<TrueBrain>owh, this is flat, very flat, etc
11:07<TrueBrain>gotcha
11:07<TrueBrain>that makes more sense :)
11:07<TrueBrain>anyway, we should at least validate that all full. entries are defined too
11:07<TrueBrain>but, to put it in Dutch, "ik zie beren op de weg", which is not what your snippet is about
11:07<TrueBrain>so yeah, I think that is good
11:08<TrueBrain>also means we can do stuff for zoom like "auto, 1x, 2x, 4x"
11:08<TrueBrain>instead of the current 0, 1, 2, 3
11:08<TrueBrain>which .. yeah, no :P
11:10<LordAro>"an internal compiler error has occurred"
11:10<LordAro>well done TrueBrain :)
11:10<TrueBrain>sweet!
11:11<TrueBrain>https://gist.github.com/TrueBrain/294690fa8c08f105bff6f74a318dbd2c <- just imagine
11:12<frosch123>isn't NDEBUG some msvc magic?
11:13<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9331: Codechange: use "[[maybe_unused]]" instead of a wide variety of other ways we had https://git.io/JGo8f
11:14<TrueBrain>NDEBUG is set by CMake
11:14<TrueBrain>and cassert is the one doing something with it
11:14<TrueBrain>but I think this problem is with the weird line I pasted earlier
11:14<TrueBrain>MSVC2016 has a lexer error :D
11:20<frosch123>i can't trigger it on godbolt with easier code
11:20<TrueBrain>see, now it is happy :)
11:25<frosch123>hmm, WITH_ASSERT is probably better there. not sure whether it would figure out it can skip the Iterate() :)
11:26<V453000>somehow
11:26<V453000>0.004 is the value with which it doesn't slow down in tunnels
11:26<V453000>it looks like it does with both 0 and 1
11:27<TrueBrain>frosch123: yeah, I wasn't either .. so yeah
11:27<@DorpsGek>[OpenTTD/OpenTTD] frosch123 approved pull request #9331: Codechange: use "[[maybe_unused]]" instead of a wide variety of other ways we had https://git.io/JGoue
11:28<frosch123>V453000: ah, sorry, yes, nml does unit coversion, so 1 is not 1 :)
11:28<V453000>XD
11:29<V453000>alright, so I'll just keep 0.004
11:29<V453000>the interesting part is the NUTS 0.8.4 was compiled with 0 and worked fine
11:29<frosch123>there probably should be NO_DRAG and DEFAULT_DRAG constants
11:29<V453000>would make sense
11:29<V453000>I guess updated NML converted the units?
11:29<frosch123>nope, no changes there
11:30<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #9331: Codechange: use "[[maybe_unused]]" instead of a wide variety of other ways we had https://git.io/JGo8f
11:30<TrueBrain>can I make OpenTTD CMake depend on Python? :P
11:30<TrueBrain>(I AM KIDDING)
11:30<TrueBrain>right, lets get out of this rabbit hole .. frosch123 : yes, I think your idea is a nice idea, now go make it :D
11:32-!-glx [~glx@000128ec.user.oftc.net] has joined #openttd
11:32-!-glx is "Loïc GUILLOUX" on #openttd
11:32-!-mode/#openttd [+v glx] by ChanServ
11:32<@DorpsGek>[OpenTTD/nml] frosch123 opened issue #219: Add DEFAULT_DRAG and NO_DRAG constants https://git.io/JGozA
11:33<frosch123>TrueBrain: i won't do yaml :)
11:33<TrueBrain>that's fine
11:33<TrueBrain>we can do that after :P
11:34<TrueBrain>personally, I would like if we don't have to do min/max if we have an enum, as that feels really useless
11:34<TrueBrain>(that is mainly what I removed in my YAML snippet :P)
11:34-!-tokai|noir [~tokai@00012860.user.oftc.net] has joined #openttd
11:34-!-mode/#openttd [+v tokai|noir] by ChanServ
11:34-!-tokai|noir is "Christian Rosentreter" on +#openttd
11:34<@DorpsGek>[OpenTTD/OpenTTD] glx22 commented on pull request #9330: Fix #9329: [CMake] FindVersion.cmake relied on internal cmake variable https://git.io/JGog2
11:35<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9322: Add: store settings as key->value pair https://git.io/JGlmd
11:35<frosch123>hmm, there are some settings where only "0" has a string
11:35<frosch123>at least in the gui
11:35<TrueBrain>the 0ISDISABLED (but not really disabled)
11:35<TrueBrain>right? :P
11:35<frosch123>yep :)
11:36<TrueBrain>many of the flags should be renamed
11:36<+glx>0ISSTRING
11:36<TrueBrain>but in general, why do I need to tell that 0 is special, if I have to define the string to start with?
11:36<TrueBrain>why can't it add the flag for me if I define one of those "str"
11:36<TrueBrain>lets call it str_if_zero:
11:36<TrueBrain>and .. magic!
11:36<frosch123>for newgrf setting we did: min/max defines the allowed integers. strings for specific values are added on top
11:37<TrueBrain>(now it does that sneaky thing of doing strval + 1 to find it)
11:37<frosch123>so you can have min=3, max=5, and still 0="magic"
11:37<TrueBrain>well, in your idea, "full." indicates sufficiently what the valid values are
11:37<TrueBrain>so min/max have no meaning
11:37<frosch123>to get "magic", 3, 4, 5 as options
11:37<TrueBrain>same as "interval=1" EVERYWHERE .. like .. wuth?
11:38<frosch123>"interval = 0" <- in [defaults] :p
11:38<TrueBrain>but from my understanding of settingsgen, it is really "dumb"
11:38<TrueBrain>it just combines information, and doesn't reason over it
11:38<frosch123>probably some magic meaning as well :)
11:38<TrueBrain>which I fully understand btw
11:39<TrueBrain>but .. it makes us do so much more work
11:39<+glx>was worse before it IIRC
11:39<TrueBrain>sure
11:39<TrueBrain>but this isn't "nice" either :)
11:40<+glx>yeah it's the same, but in a centralised location :)
11:40<TrueBrain>but yeah .. on my agenda, after this saveload stuff, is to split up settings.ini over multiple files
11:41<TrueBrain>as that is driving me nuts
11:41-!-tokai [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
11:41<TrueBrain>and after that, store it in more than one openttd.cfg, namely: "secrets.cfg" and "private.cfg"
11:41<TrueBrain>that is my goal :D
11:41<@DorpsGek>[OpenTTD/nml] FLHerne commented on issue #219: Add DEFAULT_DRAG and NO_DRAG constants https://git.io/JGozA
11:45<@DorpsGek>[OpenTTD/OpenTTD] glx22 commented on pull request #9180: Codechange: Remove FOR_ALL_CHUNK_HANDLERS https://git.io/JGoa2
11:55<V453000>BTW how could I change the railtype "icons" ?
11:55<V453000>are they just the 2nd piece of the gui?
11:55<V453000>(the icons in the dropdown when choosing which railtype to build)
12:05<@peter1138>Probably yes.
12:08<V453000>can I somehow set the default monorail and maglev GUIs?
12:08<V453000>ideally I should just create new ones but ugh
12:09<frosch123>yes, you can set the gui icons only
12:10<frosch123>though no idea why you would want to make the rails look different in the gui than on the map
12:13<V453000>but I can't just access default monorail icons, right?
12:13<V453000>like with stations for example
12:13<V453000>a railtype can have monorail stations/depots
12:13<V453000>can a railtype have monorail gui?
12:14<@peter1138>There's one set that includes the menu background colour in the icons. Except it's not exactly the right shade.
12:15<V453000>but that probably just copy pastes the images to define new gui sprites, right?
12:15<V453000>I'm just asking if there's a way to do it just via properties or flags
12:15<V453000>so in the code i could just set "this gui looks like base set monorail"
12:17<frosch123>no, you cannot access baseset monorail sprites
12:17<frosch123>it will fall-back to default normalrail sprites, if you set no gui sprites, but you cannot pick other baseset sprites
12:18<V453000>alright, that's what I needed, thank you :) yeah, it's been using rail for years
12:19<V453000>hm, I've got a parameter which has a value of 65535, I put it into logic engine's max speed, and the engine in game has 38170 max. speed
12:19<V453000>what did I fuck up?
12:19<V453000>units?
12:19<V453000>speed: param_logic_maglev_speed;
12:19<V453000>in properties, not callback
12:24<V453000>oh super wtf, with value 2222 in parameter, it goes 7999km/h
12:24<V453000>:d
12:24<V453000>ah
12:25<V453000>meters/second
12:28<V453000>this feels incredibly filthy to write speed: param_logic_maglev_speed km/h;
12:28<@peter1138>Already custom CSS-grid instead of bootstrap bullshit. Much nicer.
12:30-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
12:51-!-k32n13 [~Miranda@5E1BE0B1.mobile.pool.telekom.hu] has joined #openttd
12:51-!-k32n13 is "k32n13@yahoo.com" on #openttd
12:57-!-k32n13 [~Miranda@5E1BE0B1.mobile.pool.telekom.hu] has quit [Remote host closed the connection]
12:58-!-k3 [~Miranda@5E1BE0B1.mobile.pool.telekom.hu] has joined #openttd
12:58-!-k3 is "k32n13@yahoo.com" on #openttd
12:59-!-k3 [~Miranda@5E1BE0B1.mobile.pool.telekom.hu] has left #openttd []
13:21-!-Flygon [~Flygon@2001:44b8:411e:4e00:417d:3226:358a:328a] has quit [Quit: A toaster's basically a soldering iron designed to toast bread]
13:21<TrueBrain>frosch123: I think SLF_NOT_IN_SAVE is weird, now I take a second look at it .. it should be a settings flag, not a saveload flag :P
13:22<TrueBrain>same as SLF_NOT_IN_CONFIG
13:25<frosch123>nice, SLF_HEX appears to be unused :p
13:26<frosch123>what? that thing is from february 2020
13:26<frosch123>some eddi PR
13:26<TrueBrain>lol
13:26<TrueBrain>okay, that is it, I am going to do a mess rename of SLF_ flags
13:26<TrueBrain>SGF_
13:26<TrueBrain>sorry
13:26<TrueBrain>done with them ..
13:27<frosch123>https://github.com/OpenTTD/OpenTTD/pull/7396 <- i suggest to just trash it
13:27<LordAro>it was supposed to be used...
13:28<TrueBrain>the typical: I add a PR and I will use it later?
13:31<frosch123>so yeah, i was wondering whether SLF_HEX would be a setting or a saveload flag, in case we wanted to store vehiclesflags in hex in out new json save format. but well, if it is unused anyway :p
13:34<TrueBrain>burn it with fire!
13:43-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
13:43-!-mode/#openttd [+v tokai] by ChanServ
13:43-!-tokai is "Christian Rosentreter" on +#openttd
13:44<TrueBrain>https://www.youtube.com/watch?v=5lXmQE4xUjU <- #100th episode ..he has been busy :)
13:49<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGoA9
13:50<TrueBrain>I like to dedicated this PR to Rubidium :)
13:50-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has joined #openttd
13:50-!-andythenorth is "andythenorth" on #openttd
13:50-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
13:50<TrueBrain>mostly seds, no worries :)
13:56<@DorpsGek>[OpenTTD/OpenTTD] LordAro commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGopm
13:56<@peter1138>When one of your routers doesn't have enough flash to store the latest firmware image... :/
13:57<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGopl
13:57<TrueBrain>should I add an extra space for every row in #9332?
13:58<LordAro>it is a bit awkward :p
13:58<LordAro>just call it savflags
13:59<TrueBrain>I rather add the spaces :)
13:59<TrueBrain>any patch fails to apply anyway already
14:05<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGoA9
14:05<TrueBrain>let me know if you disagree on the last commit :)
14:10<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKeC
14:12<@Rubidium>is it me, or is a period after a question mark weird?
14:12<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #9333: Codechange: move SLF_NOT_IN_SAVE and SLF_NOT_IN_CONFIG to SettingFlag https://git.io/JGKeH
14:12<TrueBrain>Rubidium: that is not you
14:13<andythenorth>yo
14:13<TrueBrain>the question only is: where and what line? :D
14:13<TrueBrain>okay, I screwed myself over big-time with 9332 .. making changes to that is a pita :P Lol
14:13<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKvf
14:14<@Rubidium>75 of settings_internal.h
14:14<TrueBrain>frosch123: very solid point there, so indeed, we shouldn't .. but what do you mean with "sf"?
14:15<frosch123>the "settingsflags" enum uses "sf_" prefix, so the ini should also use "settingsflags" or "sf"
14:15<frosch123>name the ini key the same as the enum or the enum items :)
14:15<frosch123>possibly the same for the saveflags
14:15<TrueBrain>saveload is called slf
14:15<TrueBrain>so that would make "slf=" and "sf="
14:15<frosch123>yeah, no, meh :p
14:15<TrueBrain>my issue exactly :)
14:15<frosch123>is "saveload" and "settings" available?
14:15<TrueBrain>I was thinking not calling it SF_
14:16<TrueBrain>but ran out of ideas :P
14:16<TrueBrain>both words are not used, if that is what you are asking
14:16<TrueBrain>noting that it is a flag is pretty nice honestly
14:16<@Rubidium>maybe guiflags -> setflags?
14:16<TrueBrain>setflags and savflags? :D
14:17<frosch123>taking more letters for "flags" than for "set" and "sav" :p
14:17<TrueBrain>this happens when you do aligning
14:17<TrueBrain>it sucks balls
14:17<TrueBrain>flags:\n settings: ..\n saveload: .. :)
14:17<frosch123>haha :p
14:18<frosch123>i vote for "saveload" and "setting"
14:18<TrueBrain>after my other patch, the only "saveload" is SLF_NO_NETWORK_SYNC
14:18<TrueBrain>what if we make that ALSO a settingflag
14:19<TrueBrain>and just remove the saveloadflag
14:19<TrueBrain>makes the world simpler, I guess
14:19<frosch123>ah, just one flags, yeah, that's good :)
14:19<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKfu
14:20<TrueBrain>Rubidium: check the other PR! I happened to have fixed it there :D
14:21-!-Wormnest [~Wormnest@35.136.189.95] has quit [Ping timeout: 480 seconds]
14:21-!-OsteHovel_ [~OsteHovel@ti0056a400-6568.bb.online.no] has joined #openttd
14:21-!-OsteHovel_ is "realname" on #openttd #debian
14:22-!-WormnestAndroid [~WormnestA@35.136.189.95] has quit [Ping timeout: 480 seconds]
14:22<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKJm
14:24<TrueBrain>okay, lets not do everything at once in 1 PR .. lets first rename the settings only :D
14:24-!-WormnestAndroid [~WormnestA@2607:fb90:e411:41af:0:1d:89b3:5e01] has joined #openttd
14:24-!-WormnestAndroid is "WormnestAndroid" on #openttd
14:26<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 commented on pull request #9333: Codechange: move SLF_NOT_IN_SAVE and SLF_NOT_IN_CONFIG to SettingFlag https://git.io/JGKJh
14:27<frosch123>https://www.ruxan-muenchen-onlineshop.de/images/product_images/original_images/postkarte_0011_436x640.jpg <- our new PR template
14:28<TrueBrain>:D
14:28-!-OsteHovel [~OsteHovel@0002bf4f.user.oftc.net] has quit [Ping timeout: 480 seconds]
14:30<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGoA9
14:36<frosch123>good thing you want to merge the flags :) just noticed "SF_PER_COMPANY" is rather a saveload flag :p
14:36<TrueBrain>atm, it is fully a settings-only flag
14:37<@DorpsGek>[OpenTTD/OpenTTD] frosch123 approved pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKI0
14:37<TrueBrain>decides in what thing to store the settings .. _settings_company or _settings_client/_settings_game
14:41-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has joined #openttd
14:41-!-nielsm is "Niels Martin Hansen" on #openttd
14:45<TrueBrain>guiflags = SLF_NOT_IN_SAVE | SLF_NOT_IN_CONFIG | SLF_NO_NETWORK_SYNC | SF_NETWORK_ONLY
14:45<TrueBrain>ll
14:45<TrueBrain>lol even
14:45<TrueBrain>when is this used?! :P
14:48<TrueBrain>(hint: it is server-only :P)
14:50<TrueBrain>that moment you start the game and it is a blue ocean
14:50<TrueBrain>I broke something :D
14:53<frosch123>funny that those settings are NOT_IN_SAVE :) just to avoid that people mess with them
14:57<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKI0
14:57<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGoA9
14:58<TrueBrain>I made a change, I stashed it, pushed the branch
14:58<TrueBrain>something went wrong there :D
14:58-!-Wormnest [~Wormnest@35.136.189.95] has joined #openttd
14:58-!-Wormnest is "Wormnest" on #openttd
15:02-!-Gustavo6046 [~Gustavo60@189.6.232.247] has joined #openttd
15:02-!-Gustavo6046 is "Gustavo Rehermann <rehermann6046@gmail.com>" on #openttd #llvm
15:06<TrueBrain>btw, I love that SLF_HEX was sold as a feature :)
15:07-!-WormnestAndroid [~WormnestA@2607:fb90:e411:41af:0:1d:89b3:5e01] has quit [Remote host closed the connection]
15:07-!-WormnestAndroid [~WormnestA@2607:fb90:e411:41af:0:1d:89b3:5e01] has joined #openttd
15:07-!-WormnestAndroid is "WormnestAndroid" on #openttd
15:08<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKeH
15:10<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKeH
15:10<TrueBrain>right ... that is a lot cleaner now :)
15:11<frosch123>i assume nothing breaks when LoadSettings validates ranges of all int settings, also those which were not loaded :p
15:12<TrueBrain>honestly, I do not know
15:12<TrueBrain>I limited it to the ones in the savegame now
15:12<TrueBrain>but I am a bit annoyed version-check is not done
15:12<TrueBrain>might as well add that
15:13<TrueBrain>owh, yes, it used to do that
15:13<TrueBrain>so that is a bug in my PR :D
15:14<TrueBrain>hmm .. that is unexpected more difficult :D
15:14<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKOU
15:15<TrueBrain>owh, SLF_NO_NETWORK_SYNC is also only used for settings
15:15<TrueBrain>I expected others parts to also use it
15:15<TrueBrain>frosch123: regarding your comment, yes, yes there are. One proxies it into the other
15:16<TrueBrain>but I assumed it would be used by others to. It is not, so I can remove it from SaveLoad
15:16<TrueBrain>only this was is annoyingly hooked into the saveload system
15:16<frosch123>ah, i did not see the proxy thing, i just assumed you forgot to delete it :)
15:17<TrueBrain>meh; I need to look at that when the temperature in my room isn't above "able to think" temperature :)
15:17<TrueBrain>if you wouldn't mind reapproving #9332, I can at least merge that :D
15:18<@DorpsGek>[OpenTTD/OpenTTD] frosch123 approved pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKOR
15:18<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGoA9
15:18<frosch123>good thing that eints is still two hours away :p
15:20<frosch123>TrueBrain: just so i get this right: the numberic values of SLE_FILE_ values will matter in the future, when #9322 starts storing them in the schema?
15:20<frosch123>while all other SLE_ do not matter
15:21<TrueBrain>yes
15:21<TrueBrain>unintentional , but yes.
15:21<TrueBrain>ideally, we first split up that variable
15:22<TrueBrain>as it is so annoying that 1 variable contains 2 meanings
15:24<frosch123>maybe we can use template magic to remove some of the SLE_VAR
15:24<frosch123>but SLF_ALLOW_CONTROL, ... will remain
15:25<TrueBrain>okay, SF_NO_NETWORK_SYNC doesn't prevent the setting from being saved
15:25<TrueBrain>but only from being loaded
15:25<frosch123>oh, lol, SLF_ALLOW_NEWLINE is also unused :p
15:25<TrueBrain>.....
15:30<frosch123>looks like it was added together with ALLOW_CONTROL. just to pass all StringValidationSettings through
15:30<frosch123>https://github.com/OpenTTD/OpenTTD/commit/5cda1d7c90f7ac2a1d8a851edbe426f07a032946 <- oh, look, who added it :p
15:30<frosch123>so, gs stuff
15:30<TrueBrain>LIES
15:31<TrueBrain>I am happy there is another name in those ()
15:31<TrueBrain>:D
15:31<TrueBrain>shifting blame :D
15:32<frosch123>hmm, is SLE_STRINGQUOTE also a settings thing?
15:33<TrueBrain>seems so
15:33<TrueBrain>bit of a weird type
15:33<TrueBrain>no clue why a normal string isn't enough
15:33<frosch123>but where is it used?
15:33<TrueBrain>grep SLE_STRQ
15:34<frosch123>StringSettingDesc::FormatValue
15:34<TrueBrain>owh, that side of "used", sorry :)
15:34<TrueBrain>it adds "" around a string .. it is really odd :P
15:36<frosch123>so, it's only about openttd.cfg, not about console, right?
15:36<TrueBrain>I do not know
15:36<TrueBrain>I looked at it, was like: wtf? and moved on
15:36<TrueBrain>:D
15:37<frosch123>well, rb was working on removing all STRB
15:37<frosch123>so if STRQ could make it into the settingsflags :p
15:38<frosch123>otoh, maybe the config file should just quote all string settings
15:38<TrueBrain>or no settings
15:38<TrueBrain>I mean ... when it quoting useful?
15:38<@Rubidium>STRQ is basically "this string can start or end with a space, so it needs to be quoted otherwise it gets lost in the configuration"
15:39<TrueBrain>uuuggggghhhh ..
15:39<TrueBrain>can't we just use YAML? :P
15:39<TrueBrain>and leave that to the libyaml? :D
15:39<frosch123>oh, i assumed it applied to all strings with spaces, but small_font and friends disprove that :p
15:40<@Rubidium>practically it could probably even be removed and the code just checks for it starting/ending with a space, and if so add the quotes
15:40<frosch123>but yes, i agree. the iniwriter should figure out itself, whether quotes are needed
15:40<frosch123>add quotes when starting/ending with space or quotes
15:41<TrueBrain>the only "trick" in that case is to quote strings with quotes :)
15:41<TrueBrain>but yes, indeed
15:42<+glx>don't quote and encode spaces with %20 ?
15:43<TrueBrain>and escape % with .. :D
15:43<TrueBrain>before you know it we have urllib :P
15:43<TrueBrain>==19244==ERROR: AddressSanitizer: alloc-dealloc-mismatch (operator new vs free) on 0x6070002a4fc0
15:43<TrueBrain>in code I think I did not touch ..
15:43<frosch123>aw... we still store some strings as StringID in the saves. i thought that was all old stuff
15:44<TrueBrain>new vs free
15:45<TrueBrain>I am happy those traces show both ends (both the line of the "new" and the line of the "free")
15:46<frosch123>Rubidium: https://github.com/OpenTTD/OpenTTD/blob/master/src/script/script_instance.cpp#L385 <- do you already have that on your std::string agenda? :)
15:47<frosch123>(it's the only usage of SLE_CHAR)
15:47-!-iSoSyS [~iSoSyS@ff2-84-90-95-208.netvisao.pt] has joined #openttd
15:47-!-iSoSyS is "realname" on #/r/openttd #openttd
15:48<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #9334: Fix: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnt
15:50<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKeH
15:51<@DorpsGek>[OpenTTD/OpenTTD] glx22 commented on pull request #9334: Fix: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnP
15:53<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9334: Fix: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnt
15:53<@DorpsGek>[OpenTTD/OpenTTD] frosch123 commented on pull request #9334: Fix ef991b17: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnA
15:54<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9334: Fix ef991b17: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnt
15:54<TrueBrain>funny, I did search for "free(" :D But yes
15:54<TrueBrain>owh, other file
15:54<TrueBrain>nice
15:54<+glx>and in #ifdef code
15:54<frosch123>luckily there are not many free anymore
15:55<+glx>I searched for free(cp); (assuming variable names will be stable)
15:55<+glx>found only 2
15:55<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKeH
15:56<frosch123>there are only 14 "free(" in src/network/...
15:56<TrueBrain>we are getting there :)
15:56<TrueBrain>okay, #9333 should be done now too .. not the easiest to review
15:56<TrueBrain>I could split it up in several commits, if that is liked
15:58<TrueBrain>not super happy I had to make SlCalcConvMemLen visible ..
15:58<frosch123>haha, i bet you raged a bit when you noticed to had to reasslign the SF_ comments again :p
15:58<frosch123>*reallign
15:59<frosch123>*realign ?
16:00<frosch123>huh, what happened to the GetSettingsDesc?
16:00<TrueBrain>I fucking hate that we want things to be aligned :P
16:00<TrueBrain>I removed it .. it was buggy
16:00<TrueBrain>the temperature needs to drop before I can revisit that :)
16:03<@DorpsGek>[OpenTTD/OpenTTD] glx22 approved pull request #9334: Fix ef991b17: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKCW
16:06<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKeH
16:06<TrueBrain>right, a bit less ugly SF_NO_NETWORK_SYNC
16:06<TrueBrain>but still not what I want it to be
16:06<frosch123>i see, the entry to the rabbit hole collaped :p
16:06<frosch123>wasn't GetSettingsDesc the intial reason to start this? :p
16:06<TrueBrain>I cannot even remember why I was doing this :P
16:07<@Rubidium>because you wanted validation of the server name in your new network UI
16:07<TrueBrain>no, that is your rabbit hole :P
16:07<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #9334: Fix ef991b17: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnt
16:08<TrueBrain>I really cannot remember why I ended up doing this stuff :D Funny
16:08<@Rubidium>if I hadn't gone into that hole, you might not have done much of this
16:08<TrueBrain>no, my rabbit hole is having secrets in secrets.cfg :P
16:08<@Rubidium>frosch123: no, it's not on a list. Just occasionally I look for places with C-strings and change them
16:11<TrueBrain>funny, I really cannot remember what triggered me down this rabbit hole .. so, yes, it collapsed frosch123 :D
16:11<+glx>and with bad luck a simple C-string replacement ends up in a massive patch :)
16:13-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
16:17-!-WormnestAndroid [~WormnestA@2607:fb90:e411:41af:0:1d:89b3:5e01] has quit [Ping timeout: 480 seconds]
16:17-!-WormnestAndroid [~WormnestA@35.136.189.95] has joined #openttd
16:17-!-WormnestAndroid is "WormnestAndroid" on #openttd
16:18-!-glx_ [~glx@2a01:e0a:a54:7730:4dbf:f0b2:1757:7541] has joined #openttd
16:18-!-glx_ is "Loïc GUILLOUX" on #openttd.noai #openttd.notice #openttd
16:18-!-glx is now known as Guest769
16:18-!-glx_ is now known as glx
16:20<TrueBrain>hmm .. not sure if my lovely GetSettingsDesc can work ..
16:20<TrueBrain>skipping the NO_NETWORK_SYNC entries is difficult
16:22<frosch123>andythenorth: you seem to know about newgrf drama. why are there 4 egrvts on bananas now?
16:23<andythenorth>there are?
16:23<andythenorth>I don't know
16:23<andythenorth>I don't read forums
16:23<TrueBrain>unacceptable :P
16:23<frosch123>egrvts, egrvts2, rgrvts2 nrt, rgrvts 2.1
16:24<frosch123>i mean, i get firs 1,2,3,4 using different grfids. but egrvts 2 and 2.1 :p
16:24<@DorpsGek>[OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JGKlH
16:24<@DorpsGek> - Update: Translations from eints (by translators)
16:24-!-Guest769 [~glx@000128ec.user.oftc.net] has quit [Ping timeout: 480 seconds]
16:24<TrueBrain>poor GitHub schedule
16:24<TrueBrain>totally confused
16:25<michi_cc>They moved the runners to Mars?
16:25<michi_cc>Or hired somebody that spent years of running the rovers for NASA...
16:31<TrueBrain>it is just weird
16:34<TrueBrain>"Note: Due to load, the `schedule` event may be delayed"
16:34<TrueBrain>yeah, no shit
16:34<glx>luckily we only run it once a day
16:36<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #9335: Codechange: make [Save|Load]Settings() behave more like other Save/Load code https://git.io/JGKBm
16:36<TrueBrain>frosch123: okay, I managed to make it work .. I think :P
16:37-!-iSoSyS [~iSoSyS@ff2-84-90-95-208.netvisao.pt] has quit []
16:38<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKB4
16:38<TrueBrain>what an utter mess this saveload / settings integration has become, damn
16:43<TrueBrain>and I found back why I was doing this .. because I was done being confused by the flags being in saveload :P
16:43<TrueBrain>had nothing to do with any of the other work :P
16:43-!-tokai|noir [~tokai@00012860.user.oftc.net] has joined #openttd
16:43-!-mode/#openttd [+v tokai|noir] by ChanServ
16:43-!-tokai|noir is "Christian Rosentreter" on +#openttd
16:50-!-tokai [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
16:54-!-gelignite [~gelignite@55d4fb96.access.ecotel.net] has quit [Quit: Stay safe!]
16:55-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has quit [Read error: Connection reset by peer]
17:09<@peter1138>maybe someone wanted to use all versions of *grvts* together
17:09-!-sla_ro|master [~sla.ro@89.136.179.137] has quit []
17:14-!-k32n13 [~Miranda@5E1BE0B1.mobile.pool.telekom.hu] has joined #openttd
17:14-!-k32n13 is "k32n13@yahoo.com" on #openttd
17:16-!-k32n13 [~Miranda@5E1BE0B1.mobile.pool.telekom.hu] has left #openttd [I'm a happy Miranda NG user! Get it here: https://miranda-ng.org/]
17:16-!-k32n13 [~Miranda@5E1BE0B1.mobile.pool.telekom.hu] has joined #openttd
17:16-!-k32n13 is "k32n13@yahoo.com" on #openttd
17:16-!-Beer [~Beerbelot@00028cd3.user.oftc.net] has quit [Remote host closed the connection]
17:16-!-k32n13 [~Miranda@5E1BE0B1.mobile.pool.telekom.hu] has left #openttd [I'm a happy Miranda NG user! Get it here: https://miranda-ng.org/]
17:22<Timberwolf>A grf I persist in calling "eggverts" despite that not even being the correct order of 'r' and 'v'
17:24<FLHerne>Well, the actual order is unpronounceable
17:26<andythenorth>pronounce it like PNG
17:27<@peter1138>Allegedly "ping" but nobody does that. Right?
17:28-!-frosch123 [~frosch@00013ce7.user.oftc.net] has quit [Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn]
17:28<andythenorth>exactly
17:41<dwfreed>pee enn gee
17:46-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has quit [Quit: andythenorth]
17:46<Timberwolf>Pernug.
17:51-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has joined #openttd
17:51-!-andythenorth is "andythenorth" on #openttd
18:26-!-crem [~crem@2a02:169:160a:1:9b30:962e:76eb:4bb3] has quit [Ping timeout: 480 seconds]
18:30-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
18:30-!-tokai is "Christian Rosentreter" on #openttd
18:30-!-mode/#openttd [+v tokai] by ChanServ
18:31-!-crem [~crem@2a02:169:160a:1:9b30:962e:76eb:4bb3] has joined #openttd
18:31-!-crem is "crem" on #openttd
18:32-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has quit [Quit: andythenorth]
18:37-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
18:37-!-Strom [strom@strom.user.oftc.net] has quit []
18:38-!-Beer [~Beerbelot@00028cd3.user.oftc.net] has joined #openttd
18:38-!-Beer is "realname" on #openttd
18:39-!-Strom [strom@strom.user.oftc.net] has joined #openttd
18:39-!-Strom is "Strom" on #virt #tor-project #qemu #openttd #kernelnewbies #debian-next #debian #alpine-linux
18:58-!-Gustavo6046 [~Gustavo60@189.6.232.247] has quit [Quit: ZNC 1.8.2 - https://znc.in]
18:58-!-Gustavo6046 [~Gustavo60@2804:14d:4cd8:9367:dfa7:98f8:aa35:2eac] has joined #openttd
18:58-!-Gustavo6046 is "Gustavo Rehermann <rehermann6046@gmail.com>" on #openttd #llvm
19:00-!-Progman [~progman@p4fd66a46.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
19:22-!-HerzogDeXtEr [~farci@ip92345813.dynamic.kabel-deutschland.de] has quit [Read error: Connection reset by peer]
19:37-!-Gustavo6046 [~Gustavo60@2804:14d:4cd8:9367:dfa7:98f8:aa35:2eac] has quit [Quit: ZNC 1.8.2 - https://znc.in]
19:37-!-Gustavo6046 [~Gustavo60@189.6.232.247] has joined #openttd
19:37-!-Gustavo6046 is "Gustavo Rehermann <rehermann6046@gmail.com>" on #openttd #llvm
19:51-!-Gustavo6046 [~Gustavo60@189.6.232.247] has quit [Quit: ZNC 1.8.2 - https://znc.in]
19:52-!-Gustavo6046 [~Gustavo60@189.6.232.247] has joined #openttd
19:52-!-Gustavo6046 is "Gustavo Rehermann <rehermann6046@gmail.com>" on #openttd #llvm
22:08-!-Beer [~Beerbelot@00028cd3.user.oftc.net] has quit [Quit: Leaving]
22:31-!-Flygon [~Flygon@2001:44b8:411e:4e00:e446:8358:d777:e773] has joined #openttd
22:31-!-Flygon is "Flygon" on #openttd
22:38-!-Wormnest [~Wormnest@35.136.189.95] has quit [Quit: Leaving]
23:28-!-glx [~glx@000128ec.user.oftc.net] has quit []
---Logclosed Fri Jun 04 00:00:13 2021