Back to Home / #openttd / 2021 / 06 / Prev Day | Next Day
#openttd IRC Logs for 2021-06-10

---Logopened Thu Jun 10 00:00:22 2021
00:04-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
00:04-!-mode/#openttd [+v tokai] by ChanServ
00:04-!-tokai is "Christian Rosentreter" on +#openttd
00:11-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
01:10-!-Flygon [~Flygon@2001:44b8:411e:4e00:619b:fbde:f9c:9b80] has joined #openttd
01:10-!-Flygon is "Flygon" on #openttd
01:23-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has joined #openttd
01:23-!-nielsm is "Niels Martin Hansen" on #openttd
01:55-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
02:08-!-HerzogDeXtEr [~farci@ip9234250b.dynamic.kabel-deutschland.de] has joined #openttd
02:08-!-HerzogDeXtEr is "purple" on #openttd
02:13-!-Kitrana [~yoshi@24.146.38.28] has joined #openttd
02:13-!-Kitrana is "purple" on #openttd
02:15-!-sla_ro|master [~sla.ro@89.136.179.137] has joined #openttd
02:15-!-sla_ro|master is "slamaster" on #sla #openttd
02:19-!-Kitrana [~yoshi@24.146.38.28] has quit [Read error: Connection reset by peer]
02:42<@peter1138>Wonder if it's worth force-renewing my LE in case of issues...
02:43<@peter1138>LetsEncrypt certs, that is.
03:06<Xaroth>be careful, the new LE certs are 1 second shorter than the old ones.
03:09-!-tokai|noir [~tokai@00012860.user.oftc.net] has joined #openttd
03:09-!-mode/#openttd [+v tokai|noir] by ChanServ
03:09-!-tokai|noir is "Christian Rosentreter" on +#openttd
03:16-!-tokai [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
03:18-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
03:18-!-mode/#openttd [+v tokai] by ChanServ
03:18-!-tokai is "Christian Rosentreter" on +#openttd
03:19<@DorpsGek>[OpenTTD/website] TrueBrain opened pull request #214: Add: news about OpenTTD on GOG.com https://git.io/JZW75
03:19<TrueBrain>for some reason this completely fell off the radar yesterday .. and nobody reminded me :(
03:21<TrueBrain>now I need a quick review :D
03:24<TrueBrain>LordAro: if you can spare a few, would appreciate it :)
03:25-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
03:28<Elouin>Is there a git repo or something with the translations of the description text on gog?
03:29<TrueBrain>why you ask?
03:29<Elouin>The German Version has some mistakes in it.
03:29<TrueBrain>https://translator.openttd.org/
03:29<TrueBrain>be mindful, "mistakes" is often an opinion for German these days :)
03:30<TrueBrain>(there are 10+ people translating strings to German :P)
03:30<Elouin>i only see the steam store page in there.
03:30<Elouin>or is it the same?
03:30<TrueBrain>owh, it is not renamed yet
03:30<TrueBrain>it should be called "App Store Pages"
03:32<@DorpsGek>[OpenTTD/website] Xaroth approved pull request #214: Add: news about OpenTTD on GOG.com https://git.io/JZWp4
03:32<TrueBrain>tnx Xaroth , sadly that is not enough for me to merge :P
03:33<Xaroth>./shrug
03:34<Elouin>ok, thx TrueBrain
03:34<TrueBrain>np
03:48<@DorpsGek>[OpenTTD/website] PeterN approved pull request #214: Add: news about OpenTTD on GOG.com https://git.io/JZlUA
03:48<TrueBrain>cheers
03:48<@DorpsGek>[OpenTTD/website] TrueBrain merged pull request #214: Add: news about OpenTTD on GOG.com https://git.io/JZW75
03:48<@peter1138>Back to sleep.
03:48<TrueBrain>its warm enough for it ..
03:58<@peter1138>OMG. I've just noticed that gitea's wiki is backed by git already.
03:58<TrueBrain>and I just noticed I cannot even write news posts
03:58<TrueBrain>lol
03:59<@peter1138>Oh I did a crap review, oops.
03:59<@DorpsGek>[OpenTTD/website] TrueBrain opened pull request #215: Fix: forgot the file-extension with last commit https://git.io/JZlq4
03:59<TrueBrain>nothing you would really notice
03:59<@peter1138>(And the gitea wiki files are .md too :D)
04:00<@DorpsGek>[OpenTTD/website] PeterN approved pull request #215: Fix: forgot the file-extension with last commit https://git.io/JZlq7
04:00<TrueBrain>I approve of their approach :)
04:00<TrueBrain>sadly, our files are still mediatext
04:00<TrueBrain>but converting mediatext to markdown .. yeah, not it
04:01<@peter1138>Yes, I was hesitant to use the wiki as I thought it might be locked away in a weird format, but now I know it's just git, it's perfect.
04:01<TrueBrain>it is nice if products do the sane thing :D
04:02<@peter1138>I don't think I can clone issues though :)
04:03<TrueBrain>why would you want to?
04:04<@DorpsGek>[OpenTTD/website] TrueBrain merged pull request #215: Fix: forgot the file-extension with last commit https://git.io/JZlq4
04:04<@peter1138>Unlikely, just nice when things are open.
04:05<TrueBrain>that moment you move some code, and the game no longer works
04:05<TrueBrain>I hate that
04:05<TrueBrain>means you have to stare at the code for a while to find a weird typo
04:09<@peter1138>Urgh, one of my colleagues never puts an email subject on.
04:09<LordAro>"oh i'm sorry, i just assumed it was spam"
04:10<TrueBrain>one of "those" people :D
04:13<TrueBrain>meh, URL is over 2 lines on the frontpage now
04:13<TrueBrain>well, not "the worst"
04:13<@DorpsGek>[OpenTTD/website] TrueBrain created new tag: 1.4.30 https://git.io/JZlZA
04:14<V453000>how many days does an average month have?
04:15<@Rubidium>median is 31, isn't it?
04:15<TrueBrain>@calc (31 + 28.25 + 31 + 30 + 31 + 30 + 30 + 31 + 30 + 31 + 30 + 31) / 12
04:15<@DorpsGek>TrueBrain: 30.354166666666668
04:15<V453000>hm
04:15<TrueBrain>he asked average, not median :P
04:16<V453000>so if I have a date(1990, 6, 29) for example
04:16<V453000>and want to convert it to some days value
04:16<V453000>hm
04:16<V453000>it's not so simple, is it
04:17<V453000>because it's not the average, it's just dependent on the current position in the month
04:17<TrueBrain>you talking in general, or in OpenTTD?
04:17<TrueBrain>as OpenTTD internally uses "days since 1-1-0"
04:17<TrueBrain>and a lot of code to get from that to YYYY-MM-DD :)
04:17<V453000>in openttd
04:18<V453000>yeah
04:18<TrueBrain>so doesn't NML etc already have something for this?
04:18<TrueBrain>(I honestly don't know, but I would assume so :P)
04:18<V453000>NML has a literally date(1990, 6, 29)
04:18<V453000>now I wonder if I can do date() + date()
04:19<V453000>or only date() + days
04:19<@Rubidium>if it were to work, it would probably first convert the date to days from epoch and then add those days together
04:20<@Rubidium>so 1-1-2004 + 1-1-1 would become 31-12-2004
04:21<V453000>not 2005?
04:21<V453000>uh
04:21<V453000>I don't think I understand that XD
04:22<Timberwolf>Ouch, the epoch is non-zero so the calculations will be a year "off".
04:22<@Rubidium>year 0 is not a leap year, 2004 is a leap year
04:22<Timberwolf>If I read that correctly.
04:22<Timberwolf>Oh wait - the leap year thing.
04:22<@Rubidium>so 1-1-0 to 1-1-1 is 365 days, 1-1-2004 to 1-1-2005 is 366 days
04:23<V453000>well this did result in 3066, idk about the days date(2066, 1, 1) + date(1000,1,1);
04:24<TrueBrain>adding two dates together doesn't really mean anything honestly .. I would hope NML supports date(Y, M, D) + D
04:24<TrueBrain>okay, posted GOG news on Socials, except tt-forums
04:24<TrueBrain>I guess I should be nice and do that too ..
04:24<Eddi|zuHause>since date() is a macro that returns an integer, that should work
04:25-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has joined #openttd
04:25-!-andythenorth is "andythenorth" on #openttd
04:25-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has quit []
04:26<Timberwolf>Heh. I'm so used to dealing with ISO style dates I read "1-1-0" as "0th January, 1"
04:26<V453000>yeah, I imagine under the hood both are just converted into integers, however I also guess that I'm always adding 1 month and 1 day extra? :)
04:27<TrueBrain>and I have the first remark how we should have done GOG before Steam :P
04:27<TrueBrain>people gatekeep the weirdest shit
04:27<Eddi|zuHause>honestly, that's the point where you just softban people
04:28<Eddi|zuHause>let them think they posted something, but nobody can read it
04:28<Timberwolf>Discord/Reddit has some weird hangups.
04:29<Timberwolf>I've been finding that most of the time when someone puts up a station design and someone else "corrects" it, the corrected version is somewhere between 20%-50% worse for throughput.
04:29<TrueBrain>okay, posted on tt-forums too now
04:31<@peter1138>Game features: Cloud saves, mmm
04:31<TrueBrain>GOG is funny, in a lot of things you do not get a choice :)
04:32<TrueBrain>I still hope someone looks at how/what to enable for Steam Cloud save :) But so far, crickets
04:32<@peter1138>Me: use path signals, they much easier
04:33<Eddi|zuHause>cloud saves weird me out... but i do think for many people they are a benefit
04:33<@peter1138>Reddit: but you need block/pre signals for prio or logic! absolutely impossible to play without!
04:33<Timberwolf>AFAICT, it's because most of the popular station designs date back to the block signals era, where they were often massively better, and people have ported them to PBS over the years without revisiting what that does to the throughput.
04:34<Eddi|zuHause>no, that's because they make assumptions on how "most people" play the game that just aren't based on reality
04:34<Timberwolf>Hey, I got a clocked exit roro with acceleration tracks to give me the same throughput as a compact balanced PBS roro, it only took about 100 additional tiles and an hour of balancing! It's not that bad a station! :p
04:36<Eddi|zuHause>that's also what always weirded me out about openttdcoop. they all talked like their way is the only way to play the game
04:36<@peter1138>I'm not even sure what prios achieve. They seem to specifically designed to delay trains from one path.
04:38<Eddi|zuHause>well, yes. i do get their idea. once a train (on the "main line") is at full speed, it should never ever stop on a red signal
04:38<Timberwolf>These people, with their "identifiable" "main" line.
04:39<Eddi|zuHause>... is exactly why i never have a use for "priority signals"
04:39*Timberwolf is of the, "oh everything appears to be going via there, not sure why but I guess I'll make it 6 tracks"
04:40<@peter1138>Alright, time to find some convincing uses of presignals on the reddit server.
04:40<Eddi|zuHause>i'd rather build more 2-track lines
04:41<@peter1138>Rau's Labs. Good candidate, I assume that is the guy that replied to me.
04:42<Eddi|zuHause>in an ideal world, you could achieve the "no stopping on red" with timetables
04:42<V453000>priorities are basically just detections, if you're trying to join 1 line onto 4, you need to somehow detect if the other line is full. Using too long priorities isn't a great idea, but many people do it htat way
04:43<Eddi|zuHause>V453000: i'm pretty sure most people that use them are just cargoculting, without really understanding them
04:43<V453000>as with most things
04:44<@peter1138>JGR's braking patch would sort of achieve priority. I think a fast train would reserve farther ahead, beyond one signal.
04:45<Eddi|zuHause>that's an "almost, but not quite" solution
04:48<@DorpsGek>[OpenTTD/team] ritwikraghav14 opened issue #227: [hi_IN] Translator access request https://git.io/JZl70
04:48<Eddi|zuHause>what timetables need, in my eyes, is: 1) a complete GUI overhaul, 2) a better way to set synchronisation points between separate lines, and 3) a conditional speed limit (e.g. 80km/h when on time, 100km/h when delayed more than 2 days)
04:49<@peter1138>Registered : Jan 10 11:44:29 2010 (11y 21w 6d ago)
04:49<@peter1138>Finally remembered to drop my freenode nickserv account...
04:50<V453000>How are timetables related to merging tracks? Are you trying to let a delayed train go first, or hope to time them so precisely that they just avoid each other?
04:50<Eddi|zuHause>i never had a freenode account. made it pretty unusable after that wave of spam attacks, where every channel and their mom set "registered users only". never really recovered from that
04:50<Eddi|zuHause>V453000: i did the "so precisely that they avoid each other" successfully on a maglev track
04:51<Eddi|zuHause>but it was a complete pain to set up
04:51<TrueBrain>how is freenode doing .. :P
04:51<Eddi|zuHause>and that was a "simple" A-B, A-C merge
04:51<TrueBrain>not good, not bad either: https://netsplit.de/networks/top10.php :P
04:51<V453000>yes, that sounds close to impossible to expand, autoreplace, or anything
04:52<Eddi|zuHause>that was at a point where no autoreplace would ever occur
04:52<@peter1138>TrueBrain, so many idle accounts from bouncers or matrix etc, I bet :-)
04:55<V453000>sure, so what would you do in a more general case?
04:56<@peter1138>Build point to point tracks :)
04:56<FLHerne>TrueBrain: Yeah, I don't think that graph accurately represents user activity -- anecdotally all but one of the channels I was in has moved wholesale
04:56<V453000>that's probably the n1 most efficient solution, yes
04:56<TrueBrain>FLHerne: we might just operate in a world that is biased towards these things :P
04:57<FLHerne>100% of Libera users have been active in the last few weeks; that's clearly not true of freenode
05:02<_dp_>peter1138, there's literally just that single weird guy on reddit who cares about presignals xD
05:05<V453000>haha
05:12<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9339: Codechange: add and use the ability to store (lists of) structs in savegames https://git.io/JZLZC
05:13<TrueBrain>there, stations also converted ... now I need to do a pass off: store length-byte beforre list, instead of in a random other place
05:14<TrueBrain>time to run this against 550 savegames :)
05:16<@peter1138>I apologise for the weird bit about stationspecs that I added back in the day...
05:16<TrueBrain>the speclist?
05:17<@peter1138>Yeah
05:17-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has joined #openttd
05:17-!-Samu is "realname" on #openttd
05:17<TrueBrain>that was the only thing in the whole station_sl.cpp that wasn't weird :P
05:17<@peter1138>Oh
05:17<TrueBrain>its a simple list with a simple structure :)
05:17<TrueBrain> for (StationCargoPacketMap::ConstMapIterator it = ge->cargo.Packets()->begin(); it != ge->cargo.Packets()->end(); ++it) {
05:17<TrueBrain> SlObject(const_cast<StationCargoPair *>(&(*it)), this->GetDescription());
05:17<TrueBrain>who ever wrote that
05:17<TrueBrain>now THAT is some seriously unreadable lines ..
05:18<TrueBrain>and SwapPackets .. like wtf ..
05:18<TrueBrain>no, those parts are completely unclear in why/what they do
05:18<TrueBrain>"Don't run when savegame version is higher than or equal to 123"
05:18<TrueBrain>as a comment
05:19<TrueBrain>like .. I had to go in the history to figure out WHY that is the case
05:19<TrueBrain>I can read the line of code that it was doing exactly as the comment said
05:19<milek7>what's wrong with that for loop?
05:19<TrueBrain>but 0 motivation
05:19<@peter1138>Could be improved with a range iterator? :D
05:19<TrueBrain>so yeah peter1138 , I was happy when I arrived at SpecList :)
05:19<@peter1138>Oof. Simpler times :)
05:20<@peter1138>That may predate the C++ change, I guess.
05:20<TrueBrain>some parts are, yes
05:20<TrueBrain>and never got converted :)
05:20<TrueBrain>other parts predated C++11
05:20<Timberwolf>TrueBrain: on savegames, I have some old ones which were generated in a patchpack which added a couple of settings and bumped the savegame version, which now have a weird property that they load in a current version, but all the newgrf settings are missing. Is there any way to rescue them?
05:20<Timberwolf>It's weird they load at all, I'd have thought something would be invalid.
05:21<TrueBrain>Timberwolf: strongly depends on the changes :)
05:21<@peter1138>What truebrain is doing now should prevent that "sort of works" thing, I think.
05:21<@peter1138>Well, going forwards.
05:21<TrueBrain>peter1138: absolutely
05:22<TrueBrain>adding/removing of "things" in structs becomes "free" and compatible
05:22<TrueBrain>modifying remains the hard part :)
05:22<@peter1138>Doing this should've been step 1 of changing from TTD's file format :D
05:22<TrueBrain>the world has changed a lot in 17 years :P
05:22<TrueBrain>non-self-describing formats are a bit .. meh, these days :)
05:23<TrueBrain>but, after my works, except for the MAP chunks, they should all be self-describing :D
05:23<Timberwolf>This of course is the classic preservation problem, you don't just need the media but also the player.
05:24<Timberwolf>I vaguely recall thinking this at the time, "oh dear, if I want to play these games again I'll need the exact patched version which created them"
05:24<TrueBrain>Timberwolf: either way, to recover such savegame, if it is only settings, I would modify the source to have those extra settings for that savegame range, so they are loaded, just not saved
05:24<TrueBrain>meaning that loading should "just work" fine again
05:24<TrueBrain>and after saving, those settings are gone
05:25<TrueBrain>but it is not trivial, and needs knowledge of the changes of that savegame version
05:25<@peter1138>Grr, why do my rudder pedals always shift left. And why do I care when I'm not using them.
05:25<@peter1138>Self-describing map chunks... that'll be a task.
05:25<TrueBrain>and the fact that they load, can have everything to do with pure luck :)
05:25<TrueBrain>we read a lot of strings, which read to the next \0
05:25<TrueBrain>which tends to reset "broken" stuff
05:26<TrueBrain>no, wait, that is not true for savegames
05:26<TrueBrain>only on the network
05:26<Timberwolf>Quite. Interestingly OpenTTD handles the lack of newgrf config by applying whatever happens to be the current new-game profile.
05:26<Timberwolf>So I might be better off guessing the original newgrf set, which is probably going to be predictable (and possibly even documented somewhere)
05:26<TrueBrain>to me, NewGRF config just in general feels completely over complicated and not understood by any developer :P
05:28<@peter1138>NewGRF config was originally just numeric parameters after the newgrf filename in the config file.
05:28<TrueBrain>Timberwolf: I have no clue why that savegame would load correctly .. only by pure luck, I can imagine
05:28<@peter1138>Then it got beefed out to be described by NewGRF.
05:29<Timberwolf>Yeah, at first I thought, "ooh, I've found something which doesn't load properly" then realised it would have been from the days when I was combining hertogjan's old physics patch and a few of my own things.
05:30<Timberwolf>So that it loads at all is quite spectacular.
05:30<@peter1138>Ah yes, old games could use newgrfs but nothing was stored about them, so it used the new-game newgrf config because that's how it worked.
05:30<TrueBrain>oops, I have 9 open PRs, I have to be careful not to become "one of those" people :D
05:30<V453000>ooh
05:31<@peter1138>Not sure if there's a version cut off for that behaviour. I think I saw one for not-before but don't know about not-after. (LetsEncrypt lol)
05:31<V453000>:)
05:31<@peter1138>TrueBrain, it's the *other* people's fault for not reviewing and approving, right...
05:31<TrueBrain>yeah, as it is totally realistic for someone with an actual job to keep up with the SaveLoad changes I have been making :P
05:31<TrueBrain>:D
05:33<Timberwolf>peter1138: That's another possibility, these are *old* games. They're definitely from a patched version, but I do recall making one which was save-compatible with trunk by just hardcoding all the parameters in the patches.
05:35<Eddi|zuHause>i've made a special modified version once that converted a game from some old patched version to be trunk-loadable
05:36<@peter1138>I found a nice issue with my actul job system last night :(
05:37<@peter1138>... involving database transaction locks, and files being removed from /tmp.
05:39<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9314: Codechange: let the setting name be std::string https://git.io/JZ82W
05:39<Eddi|zuHause>i once learned the only time when it's safe to remove files from /tmp is during a reboot
05:40<@peter1138>That was why the file was removed :-)
05:41<@peter1138>It's a nice plan. Multiple instances, all running fairly independently except backed by one database. Instances can be stopped and started as needed. Except if this file is missing it causes a transaction lock to occur, and that fucks up all the other instances. Not completely, but just enough to cause things to not work right...
05:42<@peter1138>I am, of course, reworking it so it no longer happens.
05:44<TrueBrain>we expected nothing less from you :)
05:46-!-Smedles [~quassel@2403-5800-5100-f00-aaa1-59ff-fe53-1a69.ip6.aussiebb.net] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
05:47<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9315: Codechange: use std::string with network's ContentInfo https://git.io/JZ8rI
05:47<TrueBrain>okay, savegame-regression-test-suite-thingy says my PR has no regressions \o/
05:47<TrueBrain>that is nice
05:47<_dp_>hm... there is an overflow because line height is more than font height... should I fix the line, the overflow or both...
05:48<LordAro>everyone else looking at the clouds where the eclipse should be?
05:48<TrueBrain>clear skies here
05:48<TrueBrain>like ... completely blue
05:48<_dp_>*less
05:48<@peter1138>_dp_, there's quite a lot of places I found that assume one thing is always bigger than the other. I've fixed them in my mammoth scaling PR, but need to split that up a bit, when I have brain power.
05:50<_dp_>so... should i fix the line, the overflow or wait for peter to do it xDD
05:50<TrueBrain>LordAro: it is especially fun to see this on my solar panels .. it is already going down, the power produces, while it is not even midday :)
05:58<V453000>Floating-point operations are only possible when both operands are compile-time constants. Hm
05:58<V453000>I guess NML doesn't have a round() or something?
06:00<LordAro>TrueBrain: neat
06:01<V453000>I have shit like this introduction_date: date(0,1,1) + (param_date_start * 365.25) + (((1982 - 1900)/199)*(param_date_end-param_date_start) * 365.25);
06:05-!-tokai|noir [~tokai@00012860.user.oftc.net] has joined #openttd
06:05-!-mode/#openttd [+v tokai|noir] by ChanServ
06:05-!-tokai|noir is "Christian Rosentreter" on +#openttd
06:09-!-Smedles [~quassel@2403-5800-5100-f00-aaa1-59ff-fe53-1a69.ip6.aussiebb.net] has joined #openttd
06:09-!-Smedles is "Paul Smedley" on #openttd
06:11<V453000>guess I need to convert it into a "start date" and a "length multiplier", multiplying the dys
06:11<V453000>days
06:11<V453000>that will be good enough
06:12-!-tokai [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
06:12-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
06:12-!-mode/#openttd [+v tokai] by ChanServ
06:12-!-tokai is "Christian Rosentreter" on +#openttd
06:19-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
06:19<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9339: Codechange: add and use the ability to store (lists of) structs in savegames https://git.io/JZLZC
06:56<TrueBrain>LordAro: https://user-images.githubusercontent.com/1663690/121513545-3f370500-c9eb-11eb-8d64-48c714464331.png <- it goes wwwhhhhhiiiiieeeeeeeee
06:56<TrueBrain>(the green line are my solar panels .. the blue dip is me cooking)
06:58<LordAro>neat
07:04<TrueBrain>well, "cooking" .. I made a tosti :P
07:11*Timberwolf flashbacks to staring at Factorio solar output vs. charge graphs.
07:17-!-WormnestAndroid [~WormnestA@35.136.189.95] has quit [Remote host closed the connection]
07:18-!-WormnestAndroid [~WormnestA@35.136.189.95] has joined #openttd
07:18-!-WormnestAndroid is "WormnestAndroid" on #openttd
07:43<FLHerne>V453000: `date()` can take non-constant parameters
07:45<FLHerne>so `(param_date_start * 365.25)` can be `date(param_date_start, 1, 1)` or so
07:45<FLHerne>Why is there a 199?
07:46<FLHerne>[only the year can be non-constant in `date()`]
08:07-!-jez [~user@51.148.163.160] has joined #openttd
08:07-!-jez is "Jez" on #openttd
08:07<jez>is anyone here a moderator at tt-forums.net?
08:08<jez>i'm working with an oldish patch pack that uses a patch from another patch pack. that other patch pack has a post that'd been updated a bunch of times with newer versions of the .diff for his patch pack. at one point, he fixed a crash bug that's still in the version of that patch pack that the one i'm using uses. i need to get a diff of the two revisions before and after he applied the fix for the bug.
08:08<FLHerne>orudge owns it
08:09<jez>to do that, i need to get access to the history of the edits for that post so i can get the diffs for r51 and r52 (sadly he didn't just give access to his hg repo)
08:09<jez>the post in question is here: https://www.tt-forums.net/viewtopic.php?f=33&t=53394
08:09<jez>as i can only see the latest edit, i can only get r53. was hoping admins might be able to access historical versions
08:11<LordAro>pretty sure phpbb doesn't store edit history
08:13<FLHerne>orudge should have backups though :p
08:13<FLHerne>Maybe not that old
08:13<LordAro>the file will probably still be there, but good luck finding the id
08:13<jez>darn
08:14<jez>the guy hasnt been active for 6 years either so he probably isnt contactable :-(
08:14<jez>i sent a PM just in case
08:21<_dp_>web archive has r51 id but it's no longer downloadable http://web.archive.org/web/20140804162348/https://www.tt-forums.net/viewtopic.php?f=33&t=53394
08:22<_dp_>may be jgrpp has something on it but that's a lot of stuff there to filter through
08:24<milek7>probably easier to just fix the bug ;p
08:24<milek7>than hunting old attachments
08:25<_dp_>yeah, that would be my thinking too xD
08:26<_dp_>you may need some good C++ knowledge to fix a crash though
08:37-!-glx [~glx@000128ec.user.oftc.net] has joined #openttd
08:37-!-mode/#openttd [+v glx] by ChanServ
08:37-!-glx is "Loïc GUILLOUX" on +#openttd
08:42-!-iSoSyS [~iSoSyS@ff2-84-90-95-208.netvisao.pt] has joined #openttd
08:42-!-iSoSyS is "realname" on #/r/openttd #openttd
08:44-!-iSoSyS [~iSoSyS@ff2-84-90-95-208.netvisao.pt] has quit []
08:44<jez>ok, looks like i managed to fix it. a line needed moving.
08:45<jez>surprised it hadn't been causing more crashes than it did actually
08:49<@peter1138>"How did that ever work" is fairly common :D
08:51<FLHerne>The really annoying thing is when it couldn't have possibly worked, and then you fix it, and the new version that's obviously correct doesn't
09:07<jez>i've successfully patched OpenTTD to allow the jukebox to play WAV files
09:07<jez>it's not all that difficult. dunno why it isn't in trunk. i have nice versions of the tracks playing now :-)
09:07<jez>im also using the original's opening theme instead of TTD's, which i prefer
09:08<jez>introduce a new .obm for wavs, remove MD5s, disable MD5 check for WAV music files
09:08<_dp_>what's even the point of playing wav?
09:08<@peter1138>What's the point?
09:08<_dp_>mp3 would make some sense but there're better programs for it
09:09<jez>so you can play custom jokebox music (in my case, a nicer-sounding MT-32 version than than windows MIDI rendering)
09:09<jez>MP3 is harder because directmusic doesn't support it. wav was easy because it was already supported.
09:09<jez>there aren't "better programs for it" because there's nothing better than having the in-game music experience of the right music being played at the right time :-P
09:10<jez>also, i patched it to mute sounds on the opening screen. no idea why that isn't in trunk either. sound fx on the opening screen are annoying
09:10<_dp_>except openttd doesn't do any dynamic music and just does playlists like any other program :p
09:12<jez>it plays the title screen music on the title screen
09:12-!-jez [~user@51.148.163.160] has quit []
09:25<V453000>FLHerne: that does make it 1 step less stupid, thanks! I still changed the system to multiply only, I just have something wrong in my conversion for now
09:26-!-WormnestAndroid [~WormnestA@35.136.189.95] has quit [Remote host closed the connection]
09:26-!-WormnestAndroid [~WormnestA@35.136.189.95] has joined #openttd
09:26-!-WormnestAndroid is "WormnestAndroid" on #openttd
09:26<V453000>the 199 was the default range length, so it was getting a "position in range of progression"
09:27<TrueBrain>can someone turn down the thermostat outside? I am not enjoying this
09:29<FLHerne>V453000: What do you have now?
09:29<dwfreed>TrueBrain: heat advisory here today; anticipated heat indexes of 106 F
09:29<dwfreed>or 41 C
09:29<TrueBrain>pffff
09:30<V453000>introduction_date: date( param_date_start, 1, 1) + ( 18 * param_date_multiplier);
09:30<V453000>the 18 is just somehow gotten wrong by the python that ... gets it
09:31<FLHerne>Why 18?
09:31<V453000>wrong? :D
09:31<TrueBrain>or is it? :)
09:31<V453000>it's supposed to be conversion from original introduction dates to this parameter based sistem
09:31<FLHerne>Well, 18 days doesn't seem like an obviously-meaningful time period
09:32<V453000>so it's something like "number of days since the game start / 10"
09:32<V453000>but as I'm saying, the 18 is not supposed to be this number. :)
09:32<TrueBrain>make it 42, and all is well :D
09:33<FLHerne>What's param_data_multiplier?
09:33<FLHerne>*date
09:33<V453000>a parameter that can extend the period in which engines are introduced
09:34<FLHerne>With what value range?
09:34<V453000>10 is default, which means 199 year total range
09:34<V453000>so you can shorten it to 19.9 years, or make it longer to some wtf number
09:34<TrueBrain>over 9000?
09:35<V453000>I think 666 is currently the max but that's quite arbitrary
09:35<FLHerne>...so you have more code somewhere? I don't see how that's connected to what you copied just now
09:35<V453000>well, yeah
09:35<FLHerne><V453000> introduction_date: date( param_date_start, 1, 1) + ( 18 * param_date_multiplier);
09:35<V453000>yes that's the intro date property of one of the vehicles
09:35<FLHerne>So if param_date_multiplier is 10, you're adding about half a year
09:36*_dp_ was quite surprised to find out that some openttd games overflow postgres date type
09:36<V453000>yes, which is incorrrect, as 18 is wrong
09:36<_dp_>coz over 9999
09:36<V453000>what is your point?
09:36<FLHerne>That 18 is wrong, I suppose, which was why I asked in the first place
09:36<V453000>I am saying that from the start
09:36<V453000>._.
09:36<FLHerne>Oh, "somehow gotten wrong by the python that ... gets it" is your code
09:37<V453000>pretty much
09:37<FLHerne>Ok, somehow I misread that as saying nmlc was broken :p
09:37<FLHerne>(which tbf it usually seems to be with units)
09:38<V453000>XD
09:38<FLHerne>But yeah, that looks sane except that the numbers should be bigger than 18 :D
09:39<V453000>ye
09:42<V453000>yeah I was keeping a /199 in my python formula while it shouldn't have been there anymore
09:46<V453000>it's working now I think :)
09:49<@DorpsGek>[OpenTTD/OpenTTD] glx22 merged pull request #9345: Fix: Crash when CTRL-clicking on a sign https://git.io/JZceM
09:50-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has joined #openttd
09:50-!-nielsm is "Niels Martin Hansen" on #openttd
10:48-!-Kitrana [~yoshi@d24-146-38-28.commercial.cgocable.net] has joined #openttd
10:48-!-Kitrana is "purple" on #openttd
10:53<@peter1138>_dp_, stupid database designers!
10:54-!-Kitrana1 [~yoshi@45.148.7.7] has joined #openttd
10:54-!-Kitrana1 is "purple" on #openttd
10:55-!-Kitrana2 [~yoshi@d24-146-38-28.commercial.cgocable.net] has joined #openttd
10:55-!-Kitrana2 is "purple" on #openttd
11:01-!-Kitrana [~yoshi@d24-146-38-28.commercial.cgocable.net] has quit [Ping timeout: 480 seconds]
11:02-!-Kitrana1 [~yoshi@45.148.7.7] has quit [Ping timeout: 480 seconds]
11:30-!-Wormnest [~Wormnest@35.136.189.95] has joined #openttd
11:30-!-Wormnest is "Wormnest" on #openttd
11:34-!-Progman [~progman@p57a2bbdb.dip0.t-ipconnect.de] has joined #openttd
11:34-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttd
11:43<@DorpsGek>[OpenTTD/OpenTTD] glx22 commented on issue #9337: Pressing a station name in the station list doesn't move you to the correct station https://git.io/JGDBu
11:58<@DorpsGek>[OpenTTD/OpenTTD] ldpl commented on issue #9337: Pressing a station name in the station list doesn't move you to the correct station https://git.io/JGDBu
12:04<@DorpsGek>[OpenTTD/OpenTTD] ldpl commented on issue #9337: Pressing a station name in the station list doesn't move you to the correct station https://git.io/JGDBu
12:31<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 commented on pull request #9314: Codechange: let the setting name be std::string https://git.io/JZR2z
12:39<@DorpsGek>[OpenTTD/OpenTTD] ldpl commented on issue #9337: Pressing a station name in the station list doesn't move you to the correct station https://git.io/JGDBu
12:41<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9314: Codechange: let the setting name be std::string https://git.io/JZRrp
12:42<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9314: Codechange: let the setting name be std::string https://git.io/JZRoa
12:43-!-Flygon [~Flygon@2001:44b8:411e:4e00:619b:fbde:f9c:9b80] has quit [Quit: A toaster's basically a soldering iron designed to toast bread]
12:45<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 commented on pull request #9315: Codechange: use std::string with network's ContentInfo https://git.io/JZR6U
12:50<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9315: Codechange: use std::string with network's ContentInfo https://git.io/JZRij
12:54<@DorpsGek>[OpenTTD/OpenTTD] V453000 commented on pull request #9346: Feature: [NewGRF] Maximum curve speed modifier for rail vehicles https://git.io/JZRXG
12:59-!-gelignite [~gelignite@55d4f5e7.access.ecotel.net] has joined #openttd
12:59-!-gelignite is "gelignite" on #debian #llvm #openttd
13:02<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 approved pull request #9338: Several code refactors of the SaveLoad code https://git.io/JZRD1
13:02<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 updated pull request #9314: Codechange: let the setting name be std::string https://git.io/JGCaz
13:17<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9314: Codechange: let the setting name be std::string https://git.io/JZR7G
13:18<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #9338: Several code refactors of the SaveLoad code https://git.io/JGhXd
13:18<TrueBrain>w00p, tnx for that review Rubidium :)
13:20<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 commented on pull request #9342: Change: allow pause/unpause console command in single player too https://git.io/JZR5z
13:20<TrueBrain>can we switch to Rust? I like variable-lifetime to be more explicit :D
13:23<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 approved pull request #9343: Add: adhere the autosave_on_exit setting for Null videodriver https://git.io/JZRdV
13:23<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9342: Change: allow pause/unpause console command in single player too https://git.io/JZGDH
13:24<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9342: Change: allow pause/unpause console command in single player too https://git.io/JZGDH
13:26-!-tokai|noir [~tokai@00012860.user.oftc.net] has joined #openttd
13:26-!-mode/#openttd [+v tokai|noir] by ChanServ
13:26-!-tokai|noir is "Christian Rosentreter" on +#openttd
13:29<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9342: Change: allow pause/unpause console command in single player too https://git.io/JZGDH
13:30<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9342: Change: allow pause/unpause console command in single player too https://git.io/JZGDH
13:30<TrueBrain>ugh, okay, enough bikeshedding .. :P Sorry for the spam :)
13:30-!-frosch123 [~frosch@00013ce7.user.oftc.net] has joined #openttd
13:30-!-frosch123 is "frosch" on #openttd
13:31<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9342: Change: allow pause/unpause console command in single player too https://git.io/JZRA7
13:31<TrueBrain>ffs, and now the English is ugly :P
13:33-!-tokai [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
13:34<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9342: Change: allow pause/unpause console command in single player too https://git.io/JZGDH
13:34-!-grag[m] [~gragkdeor@2001:470:1af1:101::4516] has quit []
13:34<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9342: Change: allow pause/unpause console command in single player too https://git.io/JZRpO
13:34<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #9343: Add: adhere the autosave_on_exit setting for Null videodriver https://git.io/JZG9y
13:38<TrueBrain>frosch123: why don't containers extend the lifetime of what they contain? (talking about std::span and std::string_view here) .. I don't like lifetimes in C++, they are annoying :P
13:40<+glx>hmm I guess I'll have some conflicts to fix
13:43<+glx>oh a nice one in cheat_sl, almost all the file is in conflict
13:43<@DorpsGek>[OpenTTD/website] frosch123 opened pull request #216: Fix: typos in news post https://git.io/JZ0ej
13:44<@DorpsGek>[OpenTTD/team] frosch123 commented on issue #227: [hi_IN] Translator access request https://git.io/JZl70
13:44<TrueBrain>"getting here" isn't fine frosch123 ? Hmm
13:45<frosch123>TrueBrain: they are not containers, they are views
13:45<TrueBrain>it is Dutch .. :P
13:45<TrueBrain>frosch123: yeah, that is what I meant
13:45<@DorpsGek>[OpenTTD/website] TrueBrain approved pull request #216: Fix: typos in news post https://git.io/JZ0v1
13:45<frosch123>TrueBrain: i guess depends on the meaning?
13:45<TrueBrain>in this context, I was sure "getting here" was fine :)
13:45<TrueBrain>as that is how you say it in Dutch :P
13:46<frosch123>"getting to this situtation" or "getting onto gog"
13:46-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has joined #openttd
13:46-!-Wolf01 is "Wolf01" on #openttd
13:46<TrueBrain>I meant the first
13:46<TrueBrain>not sure if it is "here" or "there" :P
13:46<TrueBrain>but I understand, it points to something unclear
13:46<TrueBrain>so that is confusing anyway :D
13:46<+glx>I think it's "there"
13:47<TrueBrain>anyway, more importantly: just surprised views don't extend the lifetime honestly .. sometimes is a bit weird
13:47<TrueBrain>as things that have infinite lifetime is fine
13:47<TrueBrain>like a c-string
13:48<TrueBrain>but things that do not, like a std-string, need more care
13:48<TrueBrain>confusing, for a person like me :P
13:48<frosch123>c-strings have no infinite lifespan. or do you mean string literals?
13:48<TrueBrain>"abc" <- that, over "abc"s, as example given by cppreference
13:48<@Rubidium>frosch123: c-string literals ;)
13:48<TrueBrain>call them how ever you want :)
13:49<TrueBrain>the thing ending up in the .data :P
13:49<frosch123>there is also "abc"sv :)
13:49<+glx>https://github.com/OpenTTD/OpenTTD/compare/master...glx22:saveload <-- not fully done I think, but it's a start
13:50<TrueBrain>frosch123: wtf does the "v" do?
13:50<frosch123>stringview
13:50<TrueBrain>ah
13:50<frosch123>computes the length at compile time, and then stores data+length in .data
13:51<frosch123>though i would not be surprised, if optimisers figured that out themself
13:51<TrueBrain>I would hope so ...
13:51<frosch123>but you discovered that std::vector consturctor is not yet constexpr :)
13:51<TrueBrain>yes .... painfully ... we found that out the other day :P
13:52<TrueBrain>as you said it was, but it really wasn't :P
13:52<TrueBrain>I TRUSTED YOU! :P :D
13:52<+glx>isn't it constexpr in c++20 ?
13:52<@DorpsGek>[OpenTTD/website] TrueBrain merged pull request #216: Fix: typos in news post https://git.io/JZ0ej
13:52<TrueBrain>glx: it is; just in no compiler :P
13:53<@DorpsGek>[OpenTTD/website] TrueBrain created new tag: 1.4.31 https://git.io/JZ0Uo
13:53-!-WormnestAndroid [~WormnestA@35.136.189.95] has quit [Ping timeout: 480 seconds]
13:53<TrueBrain>glx: starting to look like something solid :D (your branch)
13:54<+glx>I still don't like fix_pointers variable
13:54<+glx>but I managed to remove the need for save variable :)
13:55<TrueBrain>converting all chunks did that for you? :)
13:55<TrueBrain>what FixPointers soon (tm) can do, is just run over all chunks
13:56<TrueBrain>as there is no real reason not to, as it only works on a few types anyway
13:56<TrueBrain>just a bit pedantic atm it is selective
13:56<+glx>for now the variable is just for the DEBUG
13:56<TrueBrain>even better :)
13:57<TrueBrain>btw, it is likely CH_READONLY will have to become a pointer
13:57-!-WormnestAndroid [~WormnestA@2607:fb90:e418:eefe:0:19:1375:2301] has joined #openttd
13:57-!-WormnestAndroid is "WormnestAndroid" on #openttd
13:57<TrueBrain>as I still might need to know if the load code is CH_RIFF or CH_ARRAY
13:57<TrueBrain>but that is a bit further away on my TODO list, so who knows if that is still true by then :)
13:59<TrueBrain>pointer?
13:59<TrueBrain>did I write that?
13:59<TrueBrain>lol
13:59<TrueBrain>"become a flag"
13:59<TrueBrain>holy crap ... it really is too warm
14:01<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 updated pull request #9315: Codechange: use std::string with network's ContentInfo https://git.io/JGCyL
14:02<TrueBrain>btw, frosch123 , {} or "" .. did we settle on either one?
14:05<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #9315: Codechange: use std::string with network's ContentInfo https://git.io/JZ0tg
14:08<frosch123>TrueBrain: i would choose "" because it is more verbose, and you can easier find the string in a long list of values, like in the SLE_ macros.
14:09<TrueBrain>k, will do :)
14:09<frosch123>but i agree that you may save one cpu cycle in unoptimised builds by using {} :p
14:09<LordAro>there's quite a lot of {} scattered around now
14:09<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 merged pull request #9315: Codechange: use std::string with network's ContentInfo https://git.io/JGCyL
14:10<TrueBrain>LordAro: yup. But, I agree, "" is a lot more verbose
14:10<LordAro>indeed
14:11<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 approved pull request #9342: Change: allow pause/unpause console command in single player too https://git.io/JZ0m9
14:11<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #9342: Change: allow pause/unpause console command in single player too https://git.io/JZGDH
14:25<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 opened pull request #9347: [Codechange] Remove C-string Packet::Recv_string https://git.io/JZ0Zs
14:27-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
14:27-!-mode/#openttd [+v tokai] by ChanServ
14:27-!-tokai is "Christian Rosentreter" on +#openttd
14:29<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #9347: Codechange: [Network] Remove C-string Packet::Recv_string https://git.io/JZ0nK
14:29<TrueBrain>seems Rb is buying us cake :P
14:34-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
14:43<frosch123>what's the occassion? it's way beyond 25k commits, and way below #10000 ?
14:43<TrueBrain>removing c-string function deep in the network layer :)
14:43<LordAro>and probably not breaking anything in the process!
14:44<frosch123>savegame version 300 is coming up, but that's nothing to party :p
14:44<frosch123>too bad some patchpack used up version 255
14:44<frosch123>would have been a nice fool's news: we are out of savegame versions, no more features can be accepted
14:45<TrueBrain>hahaha
14:45<TrueBrain>:D
14:45<TrueBrain>sorry I took that from you :P
14:51-!-Kitrana2 [~yoshi@d24-146-38-28.commercial.cgocable.net] has quit [Ping timeout: 480 seconds]
15:01-!-crem [~crem@2a02:169:160a:1:9b30:962e:76eb:4bb3] has quit [Quit: WeeChat 3.0]
15:01-!-crem [~crem@2a02:169:160a:1:9b30:962e:76eb:4bb3] has joined #openttd
15:01-!-crem is "crem" on #openttd
15:02-!-crem [~crem@2a02:169:160a:1:9b30:962e:76eb:4bb3] has quit []
15:04<frosch123>hmm, black cannot wrap long f strings
15:04<TrueBrain>he doesn't force breaks on long sequential things, no
15:04<TrueBrain>similar for long integers, etc
15:04<TrueBrain>you have to help him :)
15:04-!-crem [~crem@2a02:169:160a:1:9b30:962e:76eb:4bb3] has joined #openttd
15:04-!-crem is "crem" on #openttd
15:04<frosch123>"him" :p
15:05<TrueBrain>I want to make a very racist joke now, but I will leave that be :P
15:07<+glx>[19:57:47] <TrueBrain> as I still might need to know if the load code is CH_RIFF or CH_ARRAY <-- but chunk type as specified in the struct doesn't mean anything at load time, it relies on what the save says
15:07<TrueBrain>glx: absolutely! But I intend to change that drasticly
15:07<TrueBrain>there is a lot of freedom atm
15:08<TrueBrain>a CH_ARRAY can store what-ever-the-fuck-it-wants-even-not-an-array
15:08<TrueBrain>I kinda want to .. nudge things in the right direction, but making that a bit more abstracted away :)
15:09<frosch123>i replaced it with str.format(), way shorter string :p
15:10<TrueBrain>youi and str.format :P
15:13<+glx>https://github.com/glx22/OpenTTD/blob/96b02934493e053e98e8a4287483391e658810de/src/saveload/saveload.cpp#L315 and https://github.com/glx22/OpenTTD/blob/96b02934493e053e98e8a4287483391e658810de/src/saveload/saveload.cpp#L1802 are why fix_pointers is "needed"
15:14<TrueBrain>glx: the first one, after my changes, it can just call FixPointer always
15:14<+glx>and debug levels are weird, save and load are level 2, pointers are level 3
15:14<TrueBrain>so that at least makes it a debug-only
15:15<TrueBrain>owh, and the debugs also move up ofc
15:15<TrueBrain>so yeah .. after my changes, that shouldn't be an issue anymore :)
15:15-!-WormnestAndroid [~WormnestA@2607:fb90:e418:eefe:0:19:1375:2301] has quit [Ping timeout: 480 seconds]
15:15-!-WormnestAndroid [~WormnestA@35.136.189.95] has joined #openttd
15:15-!-WormnestAndroid is "WormnestAndroid" on #openttd
15:24-!-Kitrana [~yoshi@d24-146-38-28.commercial.cgocable.net] has joined #openttd
15:24-!-Kitrana is "purple" on #openttd
15:35-!-Kitrana [~yoshi@d24-146-38-28.commercial.cgocable.net] has quit [Read error: Connection reset by peer]
15:43<TrueBrain>glx: what I really like about your work, as that means we can move the _desc tables inside those classes too :)
15:43<TrueBrain>that makes things a lot more .. contained :D
15:44<+glx>but it's not done yet :)
15:44<TrueBrain>there is also no rush :)
15:53<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 merged pull request #9347: Codechange: [Network] Remove C-string Packet::Recv_string https://git.io/JZ0Zs
15:55<@Rubidium>but I'll buy some cake and you can get it if you can find it ;)
15:59<@DorpsGek>[OpenTTD/OpenTTD] michicc approved pull request #9341: Add: '-X' option to ignore global folders in the search path https://git.io/JZ0Nc
15:59<@DorpsGek>[OpenTTD/OpenTTD] michicc approved pull request #9336: Fix: [Script] Ensure the saved script strings are properly validated and terminated when being read from the save game https://git.io/JZ0NW
16:00<@DorpsGek>[OpenTTD/OpenTTD] michicc approved pull request #9330: Fix #9329: [CMake] FindVersion.cmake relied on internal cmake variable https://git.io/JZ0N8
16:00<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 commented on pull request #9341: Add: '-X' option to ignore global folders in the search path https://git.io/JZ0Nw
16:01<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 commented on pull request #9341: Add: '-X' option to ignore global folders in the search path https://git.io/JZ0Av
16:03<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 merged pull request #9336: Fix: [Script] Ensure the saved script strings are properly validated and terminated when being read from the save game https://git.io/JGDIR
16:04<michi_cc>More settings, yes or no? https://github.com/OpenTTD/OpenTTD/pull/9081
16:04<frosch123>cargodist disables subsidies, right?
16:06<frosch123>https://github.com/frosch123/TrivialEconomyGame <- unrelated: if someone wants to play a little game for 15 minutes. i wrote this yesterday
16:06<TrueBrain>lol :D
16:06<TrueBrain>nice
16:10<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #9341: Add: '-X' option to ignore global folders in the search path https://git.io/JZ0Nc
16:10<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9341: Add: '-X' option to ignore global folders in the search path https://git.io/JZG1r
16:11<michi_cc>glx: You've got one open comment on https://github.com/OpenTTD/OpenTTD/pull/9268
16:12<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9341: Add: '-X' option to ignore global folders in the search path https://git.io/JZ0jZ
16:13-!-gelignite [~gelignite@55d4f5e7.access.ecotel.net] has quit [Quit: Stay safe!]
16:14<@DorpsGek>[OpenTTD/OpenTTD] glx22 merged pull request #9330: Fix #9329: [CMake] FindVersion.cmake relied on internal cmake variable https://git.io/JGV2l
16:14<@DorpsGek>[OpenTTD/OpenTTD] glx22 closed issue #9329: No rule to make target 'generated/ottdres.rc' when Cross-compiling with CMake + MINGW https://git.io/JGVvY
16:17-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has joined #openttd
16:17-!-andythenorth is "andythenorth" on #openttd
16:19<TrueBrain>michi_cc: personally, I think it makes sense to have subsidy configurable in length, as that allows for certain types of gameplay; and yes, that is one more setting .. but ... yeah, I also can't think of another way :P
16:25<@DorpsGek>[OpenTTD/OpenTTD] michicc updated pull request #9081: Feature: Configurable subsidy duration https://git.io/JOXcg
16:26<michi_cc>TrueBrain: Can you have a tiny look, even if I could technically still approve it :)
16:27<TrueBrain>sure
16:28<TrueBrain>"attract a {NUM} year subsidy" <- doesn't need plural?
16:28<michi_cc>The one permission loop-hole: just pick some random PR not by you, force-push stuff and approve and merge because you aren't the PR author :)
16:28<TrueBrain>(it stands out)
16:28<TrueBrain>michi_cc: a few of us can also just hit "merge"
16:28<TrueBrain>I mean .. the system is not meant to avoid abuse like that :P
16:28<michi_cc>IMHO (not English etc), I would indeed say "a 3 year subsidy"
16:28<+glx>TrueBrain: the red button ?
16:28<michi_cc>Could be wrong English, though :)
16:29<TrueBrain>"the next {NUM} year{P "" s}!" <- reads fine for 2+, but for 1 reads weird :P
16:29<TrueBrain>"the next 1 year!"
16:29<_dp_>TrueBrain, throw out subsidies into gamescript :p
16:30<michi_cc>Make plural system even more powerful by allowing {P "year" "{NUM} years"} :)
16:34<TrueBrain>the DParam thing is very weird :P
16:37<@DorpsGek>[OpenTTD/OpenTTD] michicc commented on pull request #9344: Change: Reduce real sprite groups if possible. https://git.io/JZEty
16:38<TrueBrain>sorry michi_cc :)
16:38<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9081: Feature: Configurable subsidy duration https://git.io/JZEqG
16:39<TrueBrain>1 comment of every type: rebase-error, coding style, missing-feature-usage, wrong doxygen and nitpick :D
16:39<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9081: Feature: Configurable subsidy duration https://git.io/JZEq7
16:40<@DorpsGek>[OpenTTD/OpenTTD] michicc commented on pull request #9081: Feature: Configurable subsidy duration https://git.io/JZEqN
16:40<TrueBrain>good point michi_cc .. so lets just ignore that comment of mine :)
16:41<TrueBrain>owh, and STR_JUST_INT is "wrong" , I think .. shouldn't the setting read: "1 year" instead of "1"?
16:42<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9081: Feature: Configurable subsidy duration https://git.io/JZEmd
16:48<@DorpsGek>[OpenTTD/OpenTTD] glx22 updated pull request #9268: [MinGW] Fix MinGW32 build failure and almost all MinGW32/MinGW64 warnings https://git.io/JsGOr
16:55-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has quit [Quit: Leaving]
17:04<michi_cc>TrueBrain: The subsidy PR changes the number of params for the strings (leading to strgen warnings). Will eints sort that our or is there some manual work needed?
17:05<TrueBrain>I would like to say the first
17:05<TrueBrain>but I sneaky look at frosch123 to get confirmation
17:05<frosch123>eints will mark all translations "invalid"
17:05<frosch123>it will remove them from git on next commit
17:05<frosch123>but keep them visible for the translators to fix
17:08<@DorpsGek>[OpenTTD/OpenTTD] michicc updated pull request #9081: Feature: Configurable subsidy duration https://git.io/JOXcg
17:09-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
17:10<TrueBrain>peter1138: michi_cc used a class enum !! :D
17:11<@peter1138>u
17:11<@peter1138>wot
17:11<TrueBrain>it is PRETTY!
17:11<@peter1138>m8
17:11<TrueBrain>michi_cc: I can nitpick about a dot at the end of a tooltip
17:11<TrueBrain>not sure I can muster that
17:12<@DorpsGek>[OpenTTD/OpenTTD] michicc updated pull request #9081: Feature: Configurable subsidy duration https://git.io/JOXcg
17:12<michi_cc>Just for you
17:12<TrueBrain>awwwwhh <3
17:12<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #9081: Feature: Configurable subsidy duration https://git.io/JZE8C
17:13<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 approved pull request #9341: Add: '-X' option to ignore global folders in the search path https://git.io/JZE8E
17:13<@DorpsGek>[OpenTTD/OpenTTD] michicc approved pull request #9268: [MinGW] Fix MinGW32 build failure and almost all MinGW32/MinGW64 warnings https://git.io/JZE8X
17:13<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #9341: Add: '-X' option to ignore global folders in the search path https://git.io/JZG1r
17:17<@DorpsGek>[OpenTTD/OpenTTD] glx22 merged pull request #9268: [MinGW] Fix MinGW32 build failure and almost all MinGW32/MinGW64 warnings https://git.io/JsGOr
17:26<@DorpsGek>[OpenTTD/OpenTTD] michicc merged pull request #9081: Feature: Configurable subsidy duration https://git.io/JOXcg
17:29-!-frosch123 [~frosch@00013ce7.user.oftc.net] has quit [Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn]
17:31<@DorpsGek>[OpenTTD/OpenTTD] glx22 updated pull request #8698: Add: [Actions] msys2/MinGW CI https://git.io/Jtyp5
17:32<+glx>I want to see what it does now :)
17:32<TrueBrain>big bala boom? :D
17:33<TrueBrain>another incredibly slow target ... well, after MacOS, we can handle that :D
17:35-!-sla_ro|master [~sla.ro@89.136.179.137] has quit []
17:36<TrueBrain>https://blog.mozilla.org/en/mozilla/privacy-analysis-of-floc/
17:38-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has quit [Quit: Once again the world is quick to bury me.]
17:40<andythenorth>lol surprises
17:43<+glx>linking is so slow
17:44<andythenorth>I blame Apple
17:44<+glx>"No annotations found"
17:45<+glx>finally a no warning mingw
17:45<TrueBrain>nice work glx :D
17:45<TrueBrain>you have to buy us cake too!
17:45<TrueBrain>two cakes in 1 day :)
17:50<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #8698: Add: [Actions] msys2/MinGW CI https://git.io/JZEKP
17:54<@DorpsGek>[OpenTTD/OpenTTD] glx22 merged pull request #8698: Add: [Actions] msys2/MinGW CI https://git.io/Jtyp5
17:56<@DorpsGek>[OpenTTD/OpenTTD] JGRennison opened issue #9348: Assertion failure when removing company https://git.io/JZEiy
17:56-!-HerzogDeXtEr [~farci@ip9234250b.dynamic.kabel-deutschland.de] has quit [Read error: Connection reset by peer]
18:01<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #9349: Fix #9348, 4d74e5: don't try to sell shares of spectators https://git.io/JZEX3
18:01<+glx>oh nice one, but I don't really understand this code :)
18:03<@DorpsGek>[OpenTTD/OpenTTD] michicc approved pull request #9349: Fix #9348, 4d74e5: don't try to sell shares of spectators https://git.io/JZEXj
18:05<@DorpsGek>[OpenTTD/OpenTTD] James103 commented on pull request #9349: Fix #9348, 4d74e5: don't try to sell shares of spectators https://git.io/JZE1y
18:05<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #9349: Fix #9348, 4d74e5: don't try to sell shares of spectators https://git.io/JZEXj
18:05<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9349: Fix #9348, 4d74e5: don't try to sell shares of spectators https://git.io/JZEX3
18:06<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9349: Fix #9348, 4d74e5: don't try to sell shares of spectators https://git.io/JZE1A
18:06<@DorpsGek>[OpenTTD/OpenTTD] michicc approved pull request #9349: Fix #9348, 4d74e5: don't try to sell shares of spectators https://git.io/JZEMf
18:06<+glx>ah 7 is enough, I usually use 8
18:11-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has quit [Quit: andythenorth]
18:12-!-namad7 [~aaaaa@pool-100-6-184-56.pitbpa.fios.verizon.net] has joined #openttd
18:12-!-namad7 is "namad2" on #openttd
18:12-!-namad7 [~aaaaa@pool-100-6-184-56.pitbpa.fios.verizon.net] has quit []
18:14<TrueBrain>glx: now the question, does MacOS finish before or after MSYS?
18:15<TrueBrain>they get 90s slack, as the cache was cold
18:16<+glx>mingw32 finished first
18:16<TrueBrain>omg, with the 90s they even won
18:16<TrueBrain>haha
18:16<TrueBrain>that is just sad
18:17<TrueBrain>wow, annotation check is .. slow
18:17<TrueBrain>wth
18:17<+glx>weird
18:18<+glx>ah no 1s as usual
18:18<+glx>it was a refresh issue
18:18<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain closed issue #9348: Assertion failure when removing company https://git.io/JZEiy
18:18<TrueBrain>runner was slow with reporting, it seems
18:18<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #9349: Fix #9348, 4d74e5: don't try to sell shares of spectators https://git.io/JZEX3
18:18<TrueBrain>right, record for quickest bug-fix?
18:18<TrueBrain>:D
18:19<+glx>definitely in top 10
18:32-!-Smedles [~quassel@2403-5800-5100-f00-aaa1-59ff-fe53-1a69.ip6.aussiebb.net] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
18:32-!-Smedles [~quassel@2403-5800-5100-f00-aaa1-59ff-fe53-1a69.ip6.aussiebb.net] has joined #openttd
18:32-!-Smedles is "Paul Smedley" on #openttd
18:53-!-Progman [~progman@p57a2bbdb.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
19:36-!-WormnestAndroid [~WormnestA@35.136.189.95] has quit [Remote host closed the connection]
19:49-!-WormnestAndroid [~WormnestA@35.136.189.95] has joined #openttd
19:49-!-WormnestAndroid is "WormnestAndroid" on #openttd
20:13-!-iarp[m] [~iarpavare@2001:470:1af1:101::4512] has quit []
20:45-!-tokai|noir [~tokai@00012860.user.oftc.net] has joined #openttd
20:45-!-mode/#openttd [+v tokai|noir] by ChanServ
20:45-!-tokai|noir is "Christian Rosentreter" on +#openttd
20:52-!-tokai [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
21:11-!-ircer[m] [~ircernerd@2001:470:1af1:101::4515] has quit []
22:39-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Quit: c('~' )o]
22:48-!-Wormnest [~Wormnest@35.136.189.95] has quit [Quit: Leaving]
22:50-!-glx [~glx@000128ec.user.oftc.net] has quit []
22:55-!-debdog [~debdog@2a00:79c0:610:d500:7a24:afff:fe8a:d04d] has joined #openttd
22:55-!-debdog is "Wowbagger" on #openttd #devuan
22:58-!-D-HUND [~debdog@2a00:79c0:67f:3100:7a24:afff:fe8a:d04d] has quit [Ping timeout: 480 seconds]
---Logclosed Fri Jun 11 00:00:23 2021