Back to Home / #openttd / 2021 / 06 / Prev Day | Next Day
#openttd IRC Logs for 2021-06-29

---Logopened Tue Jun 29 00:00:48 2021
00:06-!-roadt_ [~roadt@114.102.180.125] has quit [Ping timeout: 480 seconds]
00:15-!-Flygon [~Flygon@2001:44b8:411e:4e00:f86c:da4e:8d6c:4b7b] has joined #openttd
00:15-!-Flygon is "Flygon" on #openttd
00:48-!-Gustavo6046 [~Gustavo60@189.6.235.82] has quit [Quit: ZNC 1.8.2 - https://znc.in]
00:50-!-Gustavo6046 [~Gustavo60@189.6.235.82] has joined #openttd
00:50-!-Gustavo6046 is "Gustavo Rehermann <rehermann6046@gmail.com>" on #openttd #llvm
01:54-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has joined #openttd
01:54-!-andythenorth is "andythenorth" on #openttd
01:55-!-sla_ro|master [slamaster@89.136.179.137] has joined #openttd
01:55-!-sla_ro|master is "slamaster" on @#sla #openttd
02:11-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has quit [Quit: andythenorth]
02:44-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has joined #openttd
02:44-!-andythenorth is "andythenorth" on #openttd
02:59-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has left #openttd []
03:20-!-gelignite [~gelignite@55d43d25.access.ecotel.net] has joined #openttd
03:20-!-gelignite is "gelignite" on #debian #llvm #openttd
03:21-!-kgarza_ [~kgarza@2601:800:4000:ca30:9d3a:b32c:856b:d211] has joined #openttd
03:21-!-kgarza_ is "realname" on #openttd
03:28-!-kgarza [~kgarza@2601:800:4000:ca30:ac5b:4410:8312:917c] has quit [Ping timeout: 480 seconds]
04:03<TrueBrain>that moment you rebase a patch from before fmt, and it errors out on fmt .. for no apparent reason other than to say: fuck youuuuuuuu
04:03<TrueBrain>lol
04:25-!-grossing [~grossing@dysnomia.uberspace.de] has quit [Ping timeout: 480 seconds]
04:25-!-Elouin [~Elouin@gibbs.uberspace.de] has quit [Ping timeout: 480 seconds]
04:41-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
04:45<TrueBrain>so I did the rebase patch by patch, compiling each one fixing issues .. and the fmt error I got, I no longer get .. wth .. weird compilers being weird
04:48-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
04:48-!-tokai is "Christian Rosentreter" on #openttd
04:48-!-mode/#openttd [+v tokai] by ChanServ
04:52<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JOk7C
04:53<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JOk7C
05:04<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain opened pull request #9404: Fix f7e390bd: freeaddrinfo() is not guaranteed to handle a nullptr graceful https://git.io/Jcmup
05:05<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcmzJ
05:06-!-Gustavo6046 [~Gustavo60@189.6.235.82] has quit [Quit: ZNC 1.8.2 - https://znc.in]
05:08-!-Gustavo6046 [~Gustavo60@2804:14d:4cd8:96b6:5cca:9041:ea3e:7195] has joined #openttd
05:08-!-Gustavo6046 is "Gustavo Rehermann <rehermann6046@gmail.com>" on #openttd #llvm
05:08<TrueBrain>milek7: if you can confirm #9404 to fix the issue, that would be appreciated :D
05:09<@DorpsGek>[OpenTTD/OpenTTD] LordAro approved pull request #9404: Fix f7e390bd: freeaddrinfo() is not guaranteed to handle a nullptr graceful https://git.io/JcmzA
05:09<TrueBrain>wow, quick review :o
05:11<TrueBrain>"_network_game_info.join_key = _network_game_info.join_key;" <- that moment you know you did some C++-ification, but did it in an automated way ..
05:11<TrueBrain>I love having useless statements in my code, don't you?
05:11<LordAro>eh, compiler will get rid of it for you
05:11<TrueBrain>exactly!
05:11<TrueBrain>I was testing deepsource.io on some Python repos of mine .. it made some .. wrong assumptions
05:12<TrueBrain>I had a line of code: "mydict[key]"
05:12<TrueBrain>it says: that is a useless statement
05:12<TrueBrain>I say: you are dead-wrong
05:12<TrueBrain>in Python the act of accessing a key can have a result .. especially as this was a defaultdict
05:12<TrueBrain>so "if key in mydict" is True after that statement
05:13<LordAro>mm
05:13<LordAro>though i would start to question the quality of the code :p
05:13<LordAro>bit of a code smell
05:13<TrueBrain>you got to love the nuances of different programming languages :D
05:13<TrueBrain>owh, it does have a comment in front of it explaining why it is needed, don't worry :D
05:13<TrueBrain>as for sure it is unusual
05:13<LordAro>:D
05:13-!-gelignite [~gelignite@55d43d25.access.ecotel.net] has quit [Quit: Stay safe!]
05:13<TrueBrain>but for a linter to say: "useless statement" ... you better be sure that is a correct claim :)
05:13<TrueBrain>if it would have said: "please don't do this crap", I agree :D
05:14<TrueBrain>euhm ... my PR now fails on something brilliant ... "Check Annotations" fails ...
05:14<TrueBrain>warning: String name 'STR_NETWORK_SERVER_LIST_ENTER_IP' does not exist in master file
05:15<TrueBrain>since when do we pick up strgen warnings :D
05:15<TrueBrain>I want to let eints fix this problem ;)
05:19<@peter1138>Hmm, do I change my UUIDs to match another system, or add another reference field...
05:19<TrueBrain>the first sounds bad :P
05:20<@peter1138>I think you're right.
05:20<TrueBrain>\o/
05:20<@peter1138>Imagine if someone comes along and adds a third system...
05:21<TrueBrain>omg
05:21<TrueBrain>no
05:21<TrueBrain>no
05:21<TrueBrain>please god no
05:21<TrueBrain>(I hope you are imagining the right The Office meme now)
05:21<@peter1138>I've never watched The Office, so... no.
05:21<TrueBrain>peter1138: I do have to ask .. do you make it a point to write proper english on IRC these days? Or did you always do that? :P
05:22<TrueBrain>as in, full sentences, starting with a capital, ending with a dot, etc :P
05:23<@peter1138>It's not a concious effort right now, although I do remember years ago a guy getting totally wound up by me doing so.
05:24<TrueBrain>I noticed it a few weeks ago, and I am surprised how consistent you are with it :D
05:24<TrueBrain>once you notice, it is hard not to notice :)
05:36<TrueBrain>yippie ... you can now reuse your join-key over and over and over and over again, as long as you know the secret that belongs to it :D
05:36<TrueBrain>sweet
05:39-!-Gustavo6046 [~Gustavo60@2804:14d:4cd8:96b6:5cca:9041:ea3e:7195] has quit [Quit: ZNC 1.8.2 - https://znc.in]
05:47-!-Gustavo6046 [~Gustavo60@2804:14d:4cd8:96b6:5cca:9041:ea3e:7195] has joined #openttd
05:47-!-Gustavo6046 is "Gustavo Rehermann <rehermann6046@gmail.com>" on #openttd #llvm
05:50<LordAro>TrueBrain: dependabot alerts have got longer
05:50<TrueBrain>few more days :P
05:50<TrueBrain>been testing dependabot to open PRs as they come
05:50<TrueBrain>it is not as bad as I imagined
05:50<TrueBrain>might want to try it on a few OpenTTD repos too
05:50<TrueBrain>but I think it would be good to mute it reporting on IRC, as it is noisy
05:51<TrueBrain>either way, why I mention this .. those PRs are often easier to merge
05:51<TrueBrain>as it is not "everything at once" concept
05:51<LordAro>feel like they'll get forgotten if they're not announced here :p
05:54<TrueBrain>as if they aren't forgotten if they are ;)
05:54<TrueBrain>I mean, there has been .. how many up for a whole month now :D
05:54<LordAro>oh no
05:54-!-tokai|noir [~tokai@00012860.user.oftc.net] has joined #openttd
05:54-!-tokai|noir is "Christian Rosentreter" on #openttd
05:54-!-mode/#openttd [+v tokai|noir] by ChanServ
05:55<TrueBrain>but we can try with announcing, I am fine with that
05:55<TrueBrain>more people can judge a lot easier if a single one can be merged I am sure :) Just some need more attention
06:00<FLHerne>TrueBrain: Eh, just make it auto-merge them :p
06:00<TrueBrain>FLHerne: yeah ... no :P
06:00<TrueBrain>GitHub also made that nearly impossible, which is a good thing :D
06:00<FLHerne>People can always complain if it breaks
06:01-!-tokai [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
06:01<TrueBrain>breaking is not what worries me :D But too often these days a project gets hijacked and someone uploads a .. weird new version :)
06:01<TrueBrain>GitHub now made it that dependabot PRs cannot access ANY secrets
06:02<TrueBrain>as people were exfiltrating them by updating things like NodeJS deps with code to do that :D
06:02<LordAro>isn't security fun?
06:03<TrueBrain>the years of neglect is finally catching up with us :D
06:03<TrueBrain>for Python it is not that bad, as we have rather few dependencies
06:03<TrueBrain>but if you check a NodeJS project
06:03<TrueBrain>how .. ever .... has that gone well for so long
06:04-!-Gustavo6046 [~Gustavo60@2804:14d:4cd8:96b6:5cca:9041:ea3e:7195] has quit [Quit: ZNC 1.8.2 - https://znc.in]
06:06<TrueBrain>GitHub is reporting a security alert to upgrade to aiohttp 3.7.4 or higher .. where we run 3.7.4.post0
06:06<TrueBrain>I think some parsing goes wrong at GitHub's side there :P
06:10-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has joined #openttd
06:10-!-Samu is "realname" on #openttd
06:29<@DorpsGek>[OpenTTD/OpenTTD] fsimonis opened pull request #9405: Reduce allocations in string handling https://git.io/Jcmd2
06:31-!-Gustavo6046 [~Gustavo60@2804:14d:4cd8:96b6:5cca:9041:ea3e:7195] has joined #openttd
06:31-!-Gustavo6046 is "Gustavo Rehermann <rehermann6046@gmail.com>" on #openttd #llvm
06:32<@DorpsGek>[OpenTTD/OpenTTD] LordAro commented on pull request #9405: Reduce allocations in string handling https://git.io/JcmdN
06:32<TrueBrain>you are quick today LordAro :D
06:34<TrueBrain>really cool way to analyze OpenTTD, that is nice
06:35<@peter1138>I don't those "allocations" need to be avoided. And the string stack change seems odd.
06:36<@peter1138>Maybe fine, I don't really know what that is doing.
06:36<@peter1138>I don't THINK those...
06:38<@peter1138>They will be fixed "stack" allocations so I'm not sure there's any performance hit with them.
06:40<@peter1138>Or is it heap? I dunno. I guess I can shut up :D
06:40<TrueBrain>it is a local variable, so I would guess they are on the stack too
06:40<TrueBrain>but .. it is 2048 bytes long
06:40<TrueBrain>so I would guess that it is not that great for performance, to trash your stack with 2048 every freaking time :P
06:40<TrueBrain>maybe compilers put it on the heap exactly because of that, dunno :D
06:40<@peter1138>Trash?
06:41<TrueBrain>sorry, cache-line trashing :D
06:41<TrueBrain>well, it is within a page .. who knows
06:42<TrueBrain>godbolt says it stays on the stack
06:42<TrueBrain>for what-ever that is worth :D
06:42<TrueBrain>"sub rsp, 1928"
06:42<TrueBrain>lol
06:43<@peter1138>As it becomes non-threadsafe that could be more of an issue than a few stack "allocations".
06:44<TrueBrain>I am surprised that a heapallocator would pick this up
06:44<TrueBrain>I wonder what is going on there exactly
06:44<TrueBrain>but yeah, I think LordAro correctly nudge the author to that part .. thread safety is a thing :D
06:45<TrueBrain>it most likely "is fine" in the current design, as these functions are "most likely" only called from the draw-thread :P
06:45<LordAro>you'd hope so, really
06:45<@peter1138>It's not impossible that all of these calls are only done in a GUI context, so not an issue.
06:45<LordAro>but...
06:45<@peter1138>Hah.
06:46<TrueBrain>this doesn't happen often that we are all 3 in agreement like this :P
06:46<TrueBrain>I got to frame this now :D
06:46<TrueBrain>anyway, I have been wondering before, why GetString works like this
06:47<TrueBrain>I am just waiting for Rb to C++-ify it :P
06:47<@peter1138>Well building a string in a preallocated space is easier for memory management, I guess.
06:48<TrueBrain>shit, lunchtime has come and gone .. lets try to catch up
06:50<@peter1138>"The Marketplace has extensions that can help with '.cs~stashed changes' files"
06:50<@peter1138>That seems... no thanks.
06:50<@Rubidium>GetString is also in the network code
06:54-!-Gustavo6046 [~Gustavo60@2804:14d:4cd8:96b6:5cca:9041:ea3e:7195] has quit [Ping timeout: 483 seconds]
07:17<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9405: Reduce allocations in string handling https://git.io/JcYeB
07:17<TrueBrain>lets ask the author if he can enlighten us :)
07:26-!-whatsthetime [~whatsthet@8VQAABX57.tor-irc.dnsbl.oftc.net] has quit [Ping timeout: 480 seconds]
07:35-!-Gustavo6046 [~Gustavo60@189.6.235.82] has joined #openttd
07:35-!-Gustavo6046 is "Gustavo Rehermann <rehermann6046@gmail.com>" on #openttd #llvm
08:20<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JOk7C
08:20<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9234: UDP query of game script https://git.io/JcYqU
08:21-!-glx [~glx@000128ec.user.oftc.net] has joined #openttd
08:21-!-glx is "Loïc GUILLOUX" on #openttd.noai #openttd.notice #openttd
08:21-!-mode/#openttd [+v glx] by ChanServ
08:23<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcYqg
08:24<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JOk7C
08:24<TrueBrain>stupid MSVC with its rightful complaints
08:25<+glx>it's weird how compiler complain differently :)
08:27<TrueBrain>yup
08:27<TrueBrain>glx: I have an issue with the Check Annotation you might know what to do with .. it fails on strgen stuff that will be fixed by eints after the PR is merged
08:28<+glx>but strgen warnings should not be picked
08:28<TrueBrain>they are now ...
08:28<TrueBrain>I also thought they weren't, but .. :D
08:29<+glx>they don't match the problem matcher
08:29<+glx>unless matcher changed
08:30<TrueBrain>or GitHub added their own?
08:30<TrueBrain>dunno :P
08:33<+glx>only gcc/clang it seems
08:33<TrueBrain>indeed
08:34<TrueBrain>well, Check Annotation doesn't prevent merging, so I guess it is okay
08:34<+glx>https://github.com/ammaraskar/gcc-problem-matcher/commit/a141586609e2a558729b99a8c574c048f7f56204 <-- recent change
08:34<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JOk7C
08:34<TrueBrain>:D
08:36<+glx>guess we can make a small change to strgen so it doesn't match :)
08:36<TrueBrain>feels silly
08:36<TrueBrain>I think it is okay that it tells us something is worth checking out
08:37<TrueBrain>but it is also fine to ignore these warnings :P
08:37<+glx>main issue is it only reports 10 first warnings for each run
08:40<+glx>so expected strgen warnings will hide unexpected compile warnings if not checking build logs manually
08:40<TrueBrain>true
08:41<TrueBrain>either way, STUN patch is done \o/ Fixed every bug people reported to me .. pretty sure there are more bugs hiding, but only one way to find those :D :D
08:50<TrueBrain>glx: maybe a good solution is to change "Warning" into "Hint" or something
08:50<TrueBrain>as clearly it is not that big of a deal if it is for the non-english
08:51<TrueBrain>or "Info"
08:52<TrueBrain>would also means that warnings triggered by the base language are reported
08:52<+glx>I can look at it
08:52<TrueBrain>\o/
08:53<+glx>and --warning switch should still warn (as it's explicit)
08:58-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has joined #openttd
08:58-!-snail_UES_ is "Jacopo Coletto" on #openttd
09:00-!-Kitrana [~yoshi@d24-146-38-28.commercial.cgocable.net] has quit [Read error: Connection reset by peer]
09:08<@DorpsGek>[OpenTTD/OpenTTD] James103 commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcYnl
09:09<+glx>https://github.com/OpenTTD/OpenTTD/blob/c539343ba914d68a9ab560bf09ed1854ab6d43f6/src/strgen/strgen_base.cpp#L652-L656 but https://github.com/OpenTTD/OpenTTD/blob/c539343ba914d68a9ab560bf09ed1854ab6d43f6/src/strgen/strgen_base.cpp#L821
09:09<+glx>so basically the check is useless
09:12-!-Kitrana [~yoshi@d24-146-38-28.commercial.cgocable.net] has joined #openttd
09:12-!-Kitrana is "purple" on #openttd
09:14-!-Kitrana [~yoshi@d24-146-38-28.commercial.cgocable.net] has quit [Read error: Connection reset by peer]
09:15<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcYcy
09:26<Samu>im using AIGroup.GetCurrentUsage for the first time
09:27<Samu>it's helping me manage the number of ships on a route so far
09:33<Samu>hmm, if ships end up stacking, there will be periods of current usage being ~ 100%
09:35-!-WormnestAndroid [~WormnestA@047-225-169-103.res.spectrum.com] has quit [Ping timeout: 480 seconds]
09:35<Samu>i think that's still okay, it means there may be more passengers waiting at a dock
09:35<Samu>so it's okay to add an extra ship
09:36-!-WormnestAndroid [~WormnestA@2607:fb90:88d0:8b95:0:5:be70:d01] has joined #openttd
09:36-!-WormnestAndroid is "WormnestAndroid" on #openttd
09:42-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has joined #openttd
09:42-!-nielsm is "Niels Martin Hansen" on #openttd
10:00<Samu>hmm not doing good in the long run
10:00<Samu>who would have thought ship stacking would ruin management
10:02<Samu>if one dock provides tons of passengers and the other doesn't, i get a bouncing usage of > 90% and < 10%
10:02<Samu>ship stacking ruins the usage of AIGroup.GetCurrentUsage
10:03<Samu>must think of another method
10:13<Samu>> 66% doing better than > 50%
10:15<+glx>TrueBrain: oh in theory msvc matcher should also pick strgen warnings, but output format is wrong ;)
10:17<+glx>matcher expects "file(line)" but strg outputs "file (line)"
10:17<+glx>msvc itself understands "file (line)" btw
10:33-!-WormnestAndroid [~WormnestA@2607:fb90:88d0:8b95:0:5:be70:d01] has quit [Ping timeout: 480 seconds]
10:51-!-sla_ro|master [slamaster@89.136.179.137] has quit []
11:16<+glx>ah no it's not matched because there's no code, the space before '(' doesn't matter
11:39-!-WormnestAndroid [~WormnestA@2607:fb90:88fe:f6ae:0:10:78df:2c01] has joined #openttd
11:39-!-WormnestAndroid is "WormnestAndroid" on #openttd
12:22-!-HerzogDeXtEr [~farci@ip92340c22.dynamic.kabel-deutschland.de] has joined #openttd
12:22-!-HerzogDeXtEr is "purple" on #openttd
12:32-!-Taschi [~Taschi@2001:16b8:2dd4:f200:e110:f3ca:bce4:70c0] has joined #openttd
12:32-!-Taschi is "realname" on #openttd
12:41-!-gelignite [~gelignite@55d43d25.access.ecotel.net] has joined #openttd
12:41-!-gelignite is "gelignite" on #debian #llvm #openttd
12:44-!-grossing [~grossing@dysnomia.uberspace.de] has joined #openttd
12:44-!-grossing is "Florian Gross" on #openttd #centos #oftc #kaschemme #osm-de-ot
12:45<@peter1138>Hmm, well...
13:10-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has joined #openttd
13:10-!-andythenorth is "andythenorth" on #openttd
13:11<andythenorth>TrueBrain if STUN is done, goes it ship 2.0
13:11<andythenorth>out-of-cycle release
13:15<TrueBrain>why not just 1.11.3 :P
13:15<andythenorth>where is the glamour
13:16<+glx>ok I think I have a working hack
13:20<+glx>test running on https://github.com/glx22/OpenTTD/actions/runs/983544863
13:22<@DorpsGek>[OpenTTD/OpenTTD] spnda commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOLu
13:24<Taschi>everybody knows that transferring information between two computers is an unsolved problem in computer sciences
13:24<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOL6
13:27<Taschi>sheesh, i make ONE joke about how computer networking is complicated and kind of annoying and my soccer livestream chooses that exact moment to fall apart
13:27<@DorpsGek>[OpenTTD/OpenTTD] spnda commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOLx
13:29<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOtm
13:31<@DorpsGek>[OpenTTD/OpenTTD] glx22 commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOtW
13:32-!-Progman [~progman@p4fd667f9.dip0.t-ipconnect.de] has joined #openttd
13:32-!-Progman is "Peter Henschel" on #openttdcoop.dev #openttd
13:32<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOt0
13:33<+glx>so yeah, there's magic involved
13:36<TrueBrain>also I just copy/pasted existing entries :P
13:37<+glx>no annotations on my 9017 copy
13:39<Taschi>what exactly does the "annotation" checker do?
13:39<Taschi>check for compiler warnings?
13:40<+glx>yes it "fails" the CI if there's any warning (else they are forgotten)
13:40<Taschi>it fails if there's a warning from *any* compiler?
13:41<+glx>exactly
13:41<+glx>we don't want any warning in master
13:42<Taschi>this is one of those moments where i'm very happy to work in Java and with just one compiler, but to be fair, we just ignore warnings anyway
13:42<+glx>without using Werror because that's stops compilation early
13:45-!-Flygon [~Flygon@2001:44b8:411e:4e00:f86c:da4e:8d6c:4b7b] has quit [Quit: A toaster's basically a soldering iron designed to toast bread]
13:49<@DorpsGek>[OpenTTD/OpenTTD] glx22 opened pull request #9406: Change: [strgen] 'warnings' for translations are now 'infos' unless invoked with -w or -t https://git.io/JcOq5
13:52-!-Taschi [~Taschi@2001:16b8:2dd4:f200:e110:f3ca:bce4:70c0] has quit [Quit: Leaving]
14:10<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9406: Change: [strgen] 'warnings' for translations are now 'infos' unless invoked with -w or -t https://git.io/JcOYD
14:14<@DorpsGek>[OpenTTD/OpenMSX] ConiKost opened issue #22: No tests (make check) is possible https://git.io/JcOOG
14:22-!-sla_ro|master [~sla.ro@89.136.179.137] has joined #openttd
14:22-!-sla_ro|master is "slamaster" on @#sla #openttd
14:28-!-Elouin [~Elouin@gibbs.uberspace.de] has joined #openttd
14:28-!-Elouin is "Elo Ouin" on #openttd
14:41-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has joined #openttd
14:41-!-Wolf01 is "Wolf01" on #openttd
14:49<LordAro>https://arstechnica.com/gadgets/2021/06/hackers-exploited-0-day-not-2018-bug-to-mass-wipe-my-book-live-devices/
14:49<TrueBrain>owh boy
14:50<TrueBrain>that is just ...
14:50<TrueBrain>wth
14:51<LordAro>"oops"
14:51<TrueBrain>owh, lines of code with a // are NOT working?
14:51<TrueBrain>I was thinking it was for higher privileges
14:52<@DorpsGek>[OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JcOn3
14:52<@DorpsGek> - Update: Translations from eints (by translators)
14:57<@DorpsGek>[OpenTTD/OpenMSX] glx22 commented on issue #22: No tests (make check) is possible https://git.io/JcOOG
15:02<@DorpsGek>[OpenTTD/OpenTTD] fsimonis commented on pull request #9405: Reduce allocations in string handling https://git.io/JcOCk
15:03<TrueBrain>so now the real issue pops up :D
15:03<LordAro>uh
15:04<LordAro>pretty sure that still counts as a compiletime constant
15:04<TrueBrain>godbolt agrees with you
15:05<@DorpsGek>[OpenTTD/OpenMSX] ConiKost commented on issue #22: No tests (make check) is possible https://git.io/JcOOG
15:26<@DorpsGek>[OpenTTD/OpenTTD] glx22 updated pull request #9406: Change: [strgen] 'warnings' for translations are now 'infos' unless invoked with -w or -t https://git.io/JcOq5
15:37-!-gelignite [~gelignite@55d43d25.access.ecotel.net] has quit [Quit: Stay safe!]
15:38-!-gelignite [~gelignite@55d43d25.access.ecotel.net] has joined #openttd
15:38-!-gelignite is "gelignite" on #debian #llvm #openttd
15:44<@DorpsGek>[OpenTTD/website] dadadom opened pull request #217: Fix link to COPYING.md https://git.io/JcO0s
15:45<@DorpsGek>[OpenTTD/website] TrueBrain approved pull request #217: Fix link to COPYING.md https://git.io/JcO0w
15:51<@DorpsGek>[OpenTTD/website] TrueBrain merged pull request #217: Fix link to COPYING.md https://git.io/JcO0s
15:51<@DorpsGek>[OpenTTD/website] TrueBrain created new tag: 1.4.32 https://git.io/JcOEA
15:53<@DorpsGek>[OpenTTD/OpenTTD] glx22 commented on pull request #9406: Change: [strgen] 'warnings' for translations are now 'infos' unless invoked with -w or -t https://git.io/JcOuq
15:54<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9406: Change: [strgen] 'warnings' for translations are now 'infos' unless invoked with -w or -t https://git.io/JcOuE
15:56-!-nielsm [~nielsm@188-181-82-243-cable.dk.customer.tdc.net] has quit [Ping timeout: 480 seconds]
16:00<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9406: Change: [strgen] 'warnings' for translations are now 'infos' unless invoked with -w or -t https://git.io/JcOzX
16:01<TrueBrain>sorry glx, I could have looked before writing a comment, would have been easier .. sorry :)
16:01<+glx>oh strgen is not easy to follow
16:04<+glx>I think only 4 strgen_warning calls are only for translation (not counting the ones for -w)
16:08<TrueBrain>I noticed also stuff like utf-8
16:08<TrueBrain>but that might need to become an error :D
16:09<TrueBrain>anyway, maybe good to find a better name for that function not to confuse future-us
16:10<TrueBrain>the more I look at it
16:10<TrueBrain>the more I just realise it is already a mess
16:10<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain approved pull request #9406: Change: [strgen] 'warnings' for translations are now 'infos' unless invoked with -w or -t https://git.io/JcO2X
16:11<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9406: Change: [strgen] 'warnings' for translations are now 'infos' unless invoked with -w or -t https://git.io/JcO2D
16:12<+glx>yeah and utf-8 thing is not related to lang files (I think it can't come from them), it's from explicit calls with SCC_, or via the EmitSingleChar table, so really an strgen bug if it happens
16:14<+glx>so the 2 important warnings should indeed be errors
16:14<TrueBrain>not for this PR :P
16:14<andythenorth>yo
16:15<+glx>but yeah strgen is already a mess (like the macro so MSVC reports error without stopping build)
16:15<andythenorth>so newgrf flag to disable the desert / above snowline town growth behaviour?
16:17<+glx>oh and of course strgen_warning (and similar) are different when building openttd :)
16:19<@DorpsGek>[OpenTTD/OpenTTD] glx22 merged pull request #9406: Change: [strgen] 'warnings' for translations are now 'infos' unless invoked with -w or -t https://git.io/JcOq5
16:19<+glx>let's hide the mess under the carpet now :)
16:20<TrueBrain>:D
16:20<+glx>it works, don't fix
16:20<TrueBrain>sometimes words to live by
16:21<andythenorth>so can I build my fork on the official infra?
16:23<+glx>oh that's probably why the "should be errors" are warnings, because it's in code shared by squirrel
16:24<TrueBrain>andythenorth: yup
16:24<+glx>s/by/with/
16:25<andythenorth>'assuming my fork builds at all' :P
16:25<+glx>should work, you just need to set the appropriate secrets I think
16:25<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9298: Change: move sensitive information to secrets.cfg and private information to private.cfg https://git.io/JGLne
16:27<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOwt
16:30-!-virtualrandomnumber [~Thunderbi@p4ffe3291.dip0.t-ipconnect.de] has joined #openttd
16:30-!-virtualrandomnumber is "virtualrandomnumber" on #openttd #/r/openttd
16:31-!-virtualrandomnumber [~Thunderbi@p4ffe3291.dip0.t-ipconnect.de] has quit []
16:35-!-Tirili [~Tirili@dslc-082-083-142-252.pools.arcor-ip.net] has joined #openttd
16:35-!-Tirili is "realname" on #openttd
16:37<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOr1
16:39-!-HerzogDeXtEr [~farci@ip92340c22.dynamic.kabel-deutschland.de] has quit [Read error: Connection reset by peer]
16:42<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOoC
16:42<TrueBrain>std::map vs std::unordered_map .. I read up on it the other day .. I ran away
16:42<TrueBrain>I need frosch for guidance :P
16:43<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain updated pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JOk7C
16:43<TrueBrain>I could replace it for a std::vector<std::pair<>> and just ignore the problem, I guess :D
16:44<TrueBrain>but a rb-tree vs bucket-linked-list .. that is a weird discussion to read up on on the Internet :D
16:48<@DorpsGek>[OpenTTD/OpenTTD] embeddedt commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOod
16:49<Tirili>hey
16:49<@Rubidium>how big is the map generally going to be?
16:49<milek7>std::map should be named std::sorted_map, imo :P
16:50<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOKJ
16:50<TrueBrain>Rubidium: 2 items
16:50<TrueBrain>:P
16:51<TrueBrain>and another one closeby is one for every connection attempt .. so 1, possibly 2, if you are really weird: 3 :P
16:51<@DorpsGek>[OpenTTD/OpenTTD] embeddedt commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOKt
16:52<TrueBrain>milek7: it is not so much the name, it is also that they are two completely different beasts
16:52<TrueBrain>and on the internet ... that triggers a lot of opinions
16:52<TrueBrain>A LOT OF THEM
16:52<TrueBrain>in my use-case, performance-wise it will not be something we can measure
16:53<TrueBrain>it becomes close to the pedantic side of it all .. "strictly seen" .. :D
16:53<TrueBrain>milek7: would you have a chance to check https://github.com/OpenTTD/OpenTTD/pull/9404 on Haiku?
16:53<@Rubidium>TrueBrain: conceptually unordered_map might be better, but due to the small size the rb-tree will probably win out on both performance and size. So I'd keep it as is
16:54<TrueBrain>Rubidium: k, tnx
16:54<TrueBrain>would you mind adding that as a comment to the PR, so I can resolve the comment? :D
16:57-!-Samu [~Ricardo@po1-84-91-251-215.netvisao.pt] has quit [Quit: Leaving]
16:58-!-gelignite [~gelignite@55d43d25.access.ecotel.net] has quit [Quit: Stay safe!]
17:00<Tirili>Has anyone ever had the problem that some websites / ip-addresses are reachable (by ping for example) but others aren't?
17:01<Tirili>Sorry for abusing this channel for offtopic!
17:01<milek7>TrueBrain: maybe tomorrow
17:01<milek7>but it did work before with this fix
17:01<TrueBrain>haha, like we are always ontopic :D
17:01<TrueBrain>k, tnx milek7
17:02<TrueBrain>Tirili: IPv4 / IPv6 is most of the reason for me :P
17:02<TrueBrain>and crappy ISPs in the past
17:02<@DorpsGek>[OpenTTD/OpenTTD] TrueBrain merged pull request #9404: Fix f7e390bd: freeaddrinfo() is not guaranteed to handle a nullptr graceful https://git.io/Jcmup
17:02<Tirili>ok
17:02-!-Wolf01 [~wolf01@0001288e.user.oftc.net] has quit [Quit: Once again the world is quick to bury me.]
17:05<Tirili>There have been a lot of thunderstorms the last days, could that be related?
17:05<TrueBrain>if you live in remote Alaska, sure
17:05<Tirili>No Central Europe
17:05<TrueBrain>but if you can reach some sites, and not others, it can have so many reasons
17:06<TrueBrain>for example, if you are using the Tor network
17:06<TrueBrain>that is fully expected to happen
17:06<TrueBrain>if your ISP is being a bad boy, and Cloudflare / AWS / Azure / GCP / ... blacklisted you
17:06<TrueBrain>sure, that happens to
17:06<+glx>broken peering too
17:06<TrueBrain>a peering can be down
17:06<TrueBrain>transit can be conguested
17:06<TrueBrain>even satellites that are in the wrong orbit can be a cause
17:07<Tirili>Maybe a thunderbolt has caused some infrastructure to break.
17:07<TrueBrain>rather unlikely that to be the cause, honestly
17:07<TrueBrain>most internet exchanges are connected via fibre
17:07<TrueBrain>and most sane ISPs have several peerings and transits
17:08<TrueBrain>a lot has to go wrong before things become unreachable for a longer period
17:08<Tirili>Cannot a lightning cause highly increased voltages for short times in the power network that finally destroys hardware?
17:08<TrueBrain>sure, but that would mean you have NO internet :P
17:09<+glx>always possible, but yeah it's more like all or nothing in this case, not just some
17:09<Tirili>Maybe just a few specific routes where affected.
17:09<Tirili>ok
17:09<TrueBrain>Internet is build to be redundant
17:09<TrueBrain>if a route from A to B fails
17:09<TrueBrain>it uses A -> C -> B to get to B
17:09<TrueBrain>giving your ISP has the peerings or is willing to pay the transit to make that happen ofc
17:10<Tirili>hm
17:10<Tirili>Duckduckgo.org works, google.com doesn't.
17:11<+glx>google not reachable almost never happens :)
17:11<+glx>unless it's a DNS issue
17:11<TrueBrain>you cannot ping a lot of domains in the world, if that is what you are trying
17:12<+glx>google is pingable
17:12<Tirili>ping 8.8.8.8 does not work
17:12<Tirili>here
17:12<+glx>works fine for me :)
17:13<Tirili>Maybe I should give my ISP a call tomorrow.
17:15<Tirili>Router restart doesn't help either.
17:15<+glx>traceroute may give a hint
17:15<TrueBrain>http://weathermap.ovh.net/ <- just to give you an idea how for example OVH is interconnected
17:16<TrueBrain>peering status of large exchanges used to be public, but these days that is no longer the case .. which is a bit sad
17:16<TrueBrain>was fun to see how ISPs were doing
17:17<+glx>TrueBrain: still doesn't help when a datacenter is burnt ;)
17:17<TrueBrain>glx: you could even see that on the weathermap
17:17<@DorpsGek>[OpenTTD/OpenTTD] rubidium42 commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOPR
17:18<+glx>my isp used to have a similar map, but they removed it a long time ago
17:18<TrueBrain>tnx Rubidium !
17:18<@DorpsGek>[OpenTTD/OpenTTD] spnda commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JcOPw
17:18<TrueBrain>glx: yeah ... and it used to be public but unpublished for a while too
17:18<TrueBrain>so if you knew the address, you could still see it
17:18<TrueBrain>but even that ... is no longer the case
17:19<TrueBrain>did he just add a graph without telling what the axis are? :D
17:20<Tirili>TrueBrain, is that weathermap link a map of all the most important online routers?
17:20<Tirili>in the world?
17:20<TrueBrain>Tirili: that is OVH, and only OVH
17:20<+glx>now when I have an issue I just start by checking https://www.free-reseau.fr/ but it's not provided by my isp, it's a tool made by users
17:21<Tirili>Do both of you live in France?
17:21<TrueBrain>http://www.level3.com/~/media/files/maps/en-network-services-level-3-network-map.ashx <- this is one of the biggest backbones of the Internet (the one that supplies connectivity to the company your ISP buys it from)
17:21<TrueBrain>but it is missing fancy realtime stats
17:21<TrueBrain>just shows what is connected to what
17:22<TrueBrain>it does show how crazy many redundant ways there are to get from A to B
17:22<Tirili>Well I'd like to view it, but the god won't let me.
17:22<Tirili>So thanks for the link..
17:22<TrueBrain>sounds like your ISP didn't pay his bill :P
17:23<TrueBrain>(I am joking)
17:23<+glx>IIRC they were touched by a destroyed submarine cable, but the result was just highly increased ping
17:25<Tirili>It all started yesterday in the evening (early morning). First I could still check my e-mails, but now even that is impossible.
17:26-!-andythenorth [~andytheno@cpc87165-aztw31-2-0-cust40.18-1.cable.virginm.net] has quit [Quit: andythenorth]
17:27<Tirili>Could someone send a copy of the text-article behind this links to me via pm?:
17:27<Tirili>https://www.ln-online.de/Lokales/Ostholstein/Sierksdorf-Vodafone-Kunden-ohne-Internet-Telefon-und-Fernsehen
17:28<+glx>there's a paywall :)
17:28<Tirili>oh well
17:28<Tirili>thx though
17:38<TrueBrain>in case you missed the news of the day: https://github.blog/2021-06-29-introducing-github-copilot-ai-pair-programmer/
17:38<TrueBrain>no clue what to think about this ... really curious if it really works
17:38<TrueBrain>sounds like stackoverflow integrated in your editor :P
17:39-!-spnda [~oftc-webi@dynamic-2a01-0c23-81e3-c700-a03a-2d35-7a10-9b09.c23.pool.telefo] has joined #openttd
17:39-!-spnda is "OFTC WebIRC Client" on #openttd
17:40<spnda>btw to the irc: ive edited my comment regarding the unordered_map thing. turns out that std::hash makes it a heck of a lot slower so yeah, stay with std::map.
17:40<+glx>hehe
17:42-!-spnda [~oftc-webi@dynamic-2a01-0c23-81e3-c700-a03a-2d35-7a10-9b09.c23.pool.telefo] has quit []
17:58-!-iSoSyS [~iSoSyS@ff2-84-90-95-208.netvisao.pt] has joined #openttd
17:58-!-iSoSyS is "realname" on #/r/openttd #openttd
18:00-!-WormnestAndroid [~WormnestA@2607:fb90:88fe:f6ae:0:10:78df:2c01] has quit [Ping timeout: 480 seconds]
18:06-!-WormnestAndroid [~WormnestA@047-225-169-103.res.spectrum.com] has joined #openttd
18:06-!-WormnestAndroid is "WormnestAndroid" on #openttd
18:09-!-WormnestAndroid [~WormnestA@047-225-169-103.res.spectrum.com] has quit [Read error: Connection reset by peer]
18:09-!-WormnestAndroid [~WormnestA@047-225-169-103.res.spectrum.com] has joined #openttd
18:09-!-WormnestAndroid is "WormnestAndroid" on #openttd
18:11<Tirili>ha actually some websites work, if you give them a little time.
18:11<Tirili>The link with the paywall is an example.
18:11<Tirili>And it's a paywall where you can read the text, when you open the sites's sourcecode.
18:13-!-iSoSyS [~iSoSyS@ff2-84-90-95-208.netvisao.pt] has quit []
18:22-!-sla_ro|master [~sla.ro@89.136.179.137] has quit []
18:33-!-Progman [~progman@p4fd667f9.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
18:33-!-Tirili [~Tirili@dslc-082-083-142-252.pools.arcor-ip.net] has quit [Ping timeout: 480 seconds]
18:49-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has quit [Ping timeout: 480 seconds]
18:57-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has joined #openttd
18:57-!-snail_UES_ is "Jacopo Coletto" on #openttd
19:15-!-WormnestAndroid [~WormnestA@047-225-169-103.res.spectrum.com] has quit [Ping timeout: 480 seconds]
19:16-!-WormnestAndroid [~WormnestA@2607:fb90:8900:2305:0:e:16b6:a01] has joined #openttd
19:16-!-WormnestAndroid is "WormnestAndroid" on #openttd
19:28-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
19:28-!-tokai is "Christian Rosentreter" on #openttd
19:28-!-mode/#openttd [+v tokai] by ChanServ
19:35-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
20:23-!-tokai|noir [~tokai@00012860.user.oftc.net] has joined #openttd
20:23-!-tokai|noir is "Christian Rosentreter" on #openttd
20:23-!-mode/#openttd [+v tokai|noir] by ChanServ
20:30-!-tokai [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
20:35-!-tokai|noir [~tokai@00012860.user.oftc.net] has quit [Ping timeout: 480 seconds]
20:56<@DorpsGek>[OpenTTD/OpenTTD] vituscze commented on pull request #9405: Reduce allocations in string handling https://git.io/Jc3f2
21:06-!-WormnestAndroid [~WormnestA@2607:fb90:8900:2305:0:e:16b6:a01] has quit [Ping timeout: 480 seconds]
21:06-!-WormnestAndroid [~WormnestA@047-225-169-103.res.spectrum.com] has joined #openttd
21:06-!-WormnestAndroid is "WormnestAndroid" on #openttd
22:00-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has quit [Read error: Connection reset by peer]
22:01-!-snail_UES_ [~snail_UES@cpe-98-14-137-148.nyc.res.rr.com] has joined #openttd
22:01-!-snail_UES_ is "Jacopo Coletto" on #openttd
22:35-!-roadt__ [~roadt@117.64.146.144] has quit [Ping timeout: 480 seconds]
22:37-!-roadt__ [~roadt@117.64.146.144] has joined #openttd
22:37-!-roadt__ is "roadt" on #openttd
22:52-!-debdog [~debdog@2a00:79c0:62d:4900:7a24:afff:fe8a:d04d] has joined #openttd
22:52-!-debdog is "Wowbagger" on #openttd
22:55-!-D-HUND [~debdog@2a00:79c0:671:d300:7a24:afff:fe8a:d04d] has quit [Ping timeout: 481 seconds]
23:02-!-glx [~glx@000128ec.user.oftc.net] has quit []
23:10-!-roadt__ [~roadt@117.64.146.144] has quit [Ping timeout: 480 seconds]
23:16-!-roadt__ [~roadt@117.64.146.144] has joined #openttd
23:16-!-roadt__ is "roadt" on #openttd
23:18-!-Ttech [ttech@00014919.user.oftc.net] has quit [Remote host closed the connection]
23:20-!-Ttech [ttech@00014919.user.oftc.net] has joined #openttd
23:20-!-Ttech is "Thomas Techinus" on #moocows #mobian #linux #help #fdroid #debian #ceph #alpine-linux #alpine-devel #virt @#transcendence @#swift #openttd #oftc
23:36-!-Flygon [~Flygon@2001:44b8:411e:4e00:bd1f:167f:ed89:1256] has joined #openttd
23:36-!-Flygon is "Flygon" on #openttd
23:36-!-yeoldetoast [~billy@25.72.233.220.static.exetel.com.au] has joined #openttd
23:36-!-yeoldetoast is "Textual User" on #openttd
23:37-!-tokai [~tokai@00012860.user.oftc.net] has joined #openttd
23:37-!-tokai is "Christian Rosentreter" on #openttd
23:37-!-mode/#openttd [+v tokai] by ChanServ
---Logclosed Wed Jun 30 00:00:50 2021